Commit Graph

3219 Commits

Author SHA1 Message Date
sigurdm@google.com f218f0797f Remove non-existing tests from co19-dart2js.status.
These lines are not referring to existing tests

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1116133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45523 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 11:02:36 +00:00
paulberry@google.com 964bb448cc Fix status file after r45489.
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//1121283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45498 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 18:07:06 +00:00
karlklose@google.com 6abb79a95b cps-ir: Implement type tests for interface types without type arguments.
R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1110813005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45484 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-04 07:58:38 +00:00
karlklose@google.com dd7d140bc3 Adjust test expectations for dart2js-cps-ir.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1116863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45457 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-30 09:48:09 +00:00
karlklose@google.com e8fa15c30a Update dart2js-cps_ir test expectations.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1091143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45371 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 08:40:49 +00:00
johnniwinther@google.com 19c838f3eb Fix dart2dart new backend status.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1083093005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45346 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 13:20:48 +00:00
kmillikin@google.com ed699ec05d Mark a dart2js test that fails in --use-cps-ir mode.
R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//1085913004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45337 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:08:39 +00:00
kmillikin@google.com 4f7c1d3d54 Clean up handling of constants in the CPS backend.
Before: constant-valued expressions were usually compiled by the JS constant
compiler task, which surprisingly produces a Dart (not JS) constant.

After: use the already computed constant value of a constant-valued
expression.  This is looked up in one of two ways depending on whether the
expression is an identifier or not.  For primitive constants (Booleans,
doubles, integers, strings, and null) simply construct them as they have not
had a value computed.

Also, fix a variety of small bugs.  In some case the fix is disabling an
incorrect code path and bailing out of the compiler.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1057483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45335 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:59:03 +00:00
sra@google.com 1b2296c2be getElementsByName returns HtmlCollection on IE
Review URL: https://codereview.chromium.org//1093243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45299 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 22:23:08 +00:00
kmillikin@google.com 00e4ba52ea CPS implementation of throw and rethrow.
Throw and rethrow are implemented as CPS expressions in tail position.

The CPS translation assumes that all expressions translate to a primitive
that is the value of the expression, and throw is an expression in Dart.
For simplicity of the translation, a non-tail throw Primitive is sometimes
used as a placeholder during the translation and removed immediately
afterward.

Both throw and rethrow are represented in the Tree IR.  In the Dart backend,
throw translates to throw and rethrow translates to rethrow.  In the JS
backend, throw translates to JS throw of a wrapped value.  Rethrow is not
currently implemented for the JS backend, it bails out of the compiler.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1092023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45235 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 11:15:45 +00:00
whesse@google.com 07a4bb6df5 Update android dartium status for timing-out test.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1061753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45208 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 13:52:03 +00:00
whesse@google.com 616a12b976 Update status for Chrome 42 dart2js
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45200 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 09:31:25 +00:00
sigmund@google.com 5d6b64dc49 Do not use erroneouselement unless the member is static
R=het@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//1089463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45187 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 23:10:06 +00:00
zra@google.com 86bfd7cb30 Adds a simarmv5te build and test target.
Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45181 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 20:44:43 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend.
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 11:44:02 +00:00
karlklose@google.com 9c86dda699 Update dart2dart test expectations after r45114.
R=johnniwinther@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org//1057003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45131 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-14 10:50:07 +00:00
lrn@google.com 70e04edd86 Update test expectations due to unexpected consequences of r45096.
Review URL: https://codereview.chromium.org//1083523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45130 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-14 09:35:21 +00:00
sigmund@google.com 968fcdc8c7 Make invalid to override method names for local nested functions
BUG= http://dartbug.com/19129
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1073983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45123 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 23:49:55 +00:00
alanknight@google.com 9bcd15c0cf Adjustments to SVG test suppressions
BUG=

Review URL: https://codereview.chromium.org//1088623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45116 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 18:13:50 +00:00
sigmund@google.com b2c067a754 Report compile-time error if using this implicitly in initializers
BUG= http://dartbug.com/21210
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1078873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45114 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 17:56:32 +00:00
alanknight@google.com 7c8351df36 Remove SVG constructor suppressions around foreignobject and altGlyph
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1078853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45112 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:53:35 +00:00
alanknight@google.com e1cf15849d Associate bug number with spawnUri suppressions
BUG=

Review URL: https://codereview.chromium.org//984133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45078 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 19:55:14 +00:00
johnniwinther@google.com 16bfae7b27 Handle setter without getter for compounds in SemanticSendVisitor
+ fix status of dart2dart new_backend.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1077103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45065 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 14:00:15 +00:00
whesse@google.com 462fd69d5a Update IE status for co19 and html tests.
BUG=dartbug.com/23146
R=ricow@google.com

Review URL: https://codereview.chromium.org//1073753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44994 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 09:05:23 +00:00
whesse@google.com ce5e1f62d5 Update Firefox status on Windows for version 37, on co19 tests.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1069403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44967 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 13:26:01 +00:00
paulberry@google.com e0ee1cb68f Rework type assignability, subtype, and "more specific than" checking.
The key change in this CL is to change the technique for avoiding
infinite recursion in the presence of illegal code.  Rather than track
type pairs, we track (a) the function typedef elements that have been
expanded while examining the LHS and RHS, and (b) the class and type
parameter elements that have been visited while exploring the class
hierarchy.  If a function typedef is encountered while expanding
itself, or a class or type parameter element is encountered while
searching its own class hierarchy, then it is skipped.  Since both
class hierarchy loops and self-referential function typedefs are
prohibited by the spec, this ensures that the checks to avoid
recursion will only trigger in the presence of compile errors, so
analyzer will produce correct warnings in the absence of compile
errors.

As a consequence of the new technique, bugs 21912 and 22976 are fixed.

In addition, there are a few other improvements:

- Optional arguments are used to keep track of elements already
  visited, so it's not necessary to have separate functions
  isAssignableTo2, isSubtypeOf2, and isMoreSpecificThan2, nor do we
  need "internal" versions of those functions.

- InterfaceTypeImpl no longer needs a special implementation of
  isSubtypeOf.  It's now implemented in the same way it's defined (in
  terms of isMoreSpecificThan).

- Some flaws were discovered in the co19 tests.  I've filed a co19 bug
  for these, and updated the co19-analyzer2 status file.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1070443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44965 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 13:00:57 +00:00
alanknight@google.com d5125b52f6 Temporarily suppress tests that do svg/innerHTML, consistency over treatment of foreignobject tag
BUG=

Review URL: https://codereview.chromium.org//1062383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44954 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 23:14:53 +00:00
sra@google.com 9b2d7cae44 CssStyleDeclaration performance work
Cache browser prefix detection to avoid repeated camelCasing.
Remove IE9 compatibility code.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1064783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44951 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 21:34:20 +00:00
paulberry@google.com 9efc540b0e Fix tests broken by r44880.
Revision 44880 added an assertion to accompany the internal error
message emitted if Parser._computeStringValue computes nonsensical
string start and end positions, so that those internal errors would be
noticed by the buildbots.  It fixed most of the circumstances in which
the internal error might occur, but it missed a few: if the analyzer
encounters an unterminated string at the end of a line, or an
unterminated multiline string at the end of a file, or a string ending
with an invalid interpolation expression (e.g. "${var x}" or
"$class"), then a token might be generated which the parser thinks is
a complete string, but which consists solely of 1, 3, 4, or 5
consecutive quotes (and thus is an unterminated string), causing
Parser._computeStringValue to get confused and fire the assertion.

This CL addresses those problems by modifying
Parser._computeStringValue to handle those ill-formed tokens.

In a future CL I plan to modify the parser so that invalid
interpolation expressions like "${var x}" and "$class" are recovered
from more gracefully.  But that is a low priority fix, since this CL
is sufficent to prevent the assertion from firing.

BUG=dartbug.com/23100
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1061883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44914 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 16:22:54 +00:00
paulberry@google.com 9e1055502f Update status files to reflect bug 23100.
These status file updates reflect breakages I introduced in r44880.

BUG=dartbug.com/23100
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1056253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44904 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-04 01:03:17 +00:00
paulberry@google.com 85846dde46 Fix co19 tests after r44774.
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44775 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 02:37:52 +00:00
karlklose@google.com 05fcf8ad3f Update test expectations for new dart2dart backend.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1035093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44729 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 09:23:40 +00:00
alanknight@google.com fc92478567 Fix status file for FontFace tests that now pass
BUG=

Review URL: https://codereview.chromium.org//1012193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44693 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 20:04:01 +00:00
whesse@google.com 745b6809e9 Update test status for flaky tests.
BUG=dartbug.com/22695, dartbug.com/22896
R=ricow@google.com

Review URL: https://codereview.chromium.org//1019463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44557 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 12:45:50 +00:00
whesse@google.com 47cf2ba160 Update co19 status for Chrome 41, now that no bots are on Chrome 40.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1002473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44435 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 18:00:26 +00:00
karlklose@google.com 24dd17f1f6 Mark test as 'Fail, Pass'.
It only fails on Windows 7's IE10.

R=ricow@google.com

Review URL: https://codereview.chromium.org//999293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44425 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 10:19:57 +00:00
karlklose@google.com 6f92570a8d Update test expectations for dart2js-ie10.
TBR=sigurdm@google.com

Review URL: https://codereview.chromium.org//1004463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44422 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 07:46:47 +00:00
herhut@google.com 43e36555f8 Fix test expectations on ie.
BUG=
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//1001543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44404 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 15:25:36 +00:00
karlklose@google.com 8f667bff4d Mark test as failing on IE10.
R=ricow@google.com

Review URL: https://codereview.chromium.org//997023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44392 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 08:57:33 +00:00
floitsch@google.com 458f7ad6fc Mark test as failing for IE.
Review URL: https://codereview.chromium.org//992983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44370 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 14:12:27 +00:00
rmacnak@google.com 0ee0f654e0 Revert r44217 for switch back to Dartium development branches.
BUG=

Review URL: https://codereview.chromium.org//990093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44331 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 16:58:28 +00:00
whesse@google.com 07750d9a42 Update test status for Chrome 41 on Windows and Mac OS X.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//983173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44291 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 14:19:58 +00:00
herhut@google.com f19447b972 Fix status files after jsshell update.
BUG=
R=floitsch@google.com
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//983163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44289 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 13:40:51 +00:00
rmacnak@google.com 694bd9741a Mark fragment-activation-focuses-target_t01 as failing on Dartium (Chromium 39 beta patches).
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//982433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44217 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 02:11:10 +00:00
ricow@google.com dc6e1a9d1a Status file updates after update to chrome 40 on mac
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//965413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44127 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 12:41:07 +00:00
terry@google.com d302844d03 Test now passes
Reviewers=asiva@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//963233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44103 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 20:25:46 +00:00
whesse@google.com 1cd644a5e1 Fix status for ContentShellOnAndroid, for some copy-paste tests.
BUG=dartbug.com/22532
R=kustermann@google.com

Review URL: https://codereview.chromium.org//962183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44090 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 13:03:28 +00:00
rmacnak@google.com cd5f2a6cb8 Update co19 status for clipboard access change.
BUG=http://dartbug.com/22532
R=asiva@google.com

Review URL: https://codereview.chromium.org//964633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44078 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 22:23:16 +00:00
karlklose@google.com f50c1e0de5 Update dart2js-ff-windows test expectations.
R=whesse@google.com

Review URL: https://codereview.chromium.org//956783004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44024 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 14:37:49 +00:00
herhut@google.com e3efcb499a Fix co19 status file.
BUG=
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//938703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43839 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 13:35:00 +00:00