Commit Graph

3219 Commits

Author SHA1 Message Date
Jacob Richman 1be2db9a05 Add back one test that still fails and remove a bunch of tests that now pass with the refactor.
BUG=

Review URL: https://codereview.chromium.org/1591843003 .
2016-01-15 14:42:07 -08:00
Ivan Posva b2a186c2dd - Readjust Dartium status files.
BUG=

Review URL: https://codereview.chromium.org/1591063002 .
2016-01-15 11:22:24 -08:00
Asger Feldthaus fb0330df46 dart2js cps: Improve constant folding of equality operators.
Previously we would only fold comparisons between primitive constants, missing out on e.g. the list sentinel comparisons.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1583993005 .
2016-01-14 14:01:20 -08:00
William Hesse ecd3129c25 Update status for co19 test that times out.
BUG=

Review URL: https://codereview.chromium.org/1582073002 .
2016-01-13 20:12:58 +01:00
Ivan Posva b508064e9e - Further updates of status files for Dartium.
BUG=

Review URL: https://codereview.chromium.org/1582913002 .
2016-01-13 09:17:17 -08:00
Ivan Posva 8741a8dcda - Update status files.
BUG=

Review URL: https://codereview.chromium.org/1579213003 .
2016-01-13 01:39:40 -08:00
Zachary Anderson cbc4f025d7 Update status file for timing-out tests on windows.
R=asiva@google.com

Review URL: https://codereview.chromium.org/1575233002 .
2016-01-11 15:41:40 -08:00
Matthias Hausner 37ab1a9c7c Exclude faulty co19 tests
BUG=https://github.com/dart-lang/co19/issues/18
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1570453003 .
2016-01-07 13:41:41 -08:00
Sigmund Cherem e2623f1aea cpsir: add support for deferred code
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1558353002 .
2016-01-06 10:24:52 -08:00
Stephen Adams 6602644bb3 Language/Types/Interface_Types/subtype_t28 also fails by 'Crash'ing.
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/1553453003 .
2015-12-28 18:20:56 -08:00
William Hesse b0246edac5 Update status for windows firefox version 43.
BUG=

Review URL: https://codereview.chromium.org/1549783002 .
2015-12-23 17:11:40 +01:00
Matthias Hausner f51f96816d Move super initializer to end of list.
Introduce --warn_super flag to print a warning when a super call is found that is not at the end of the initializer list.

Mark failing tests as Fail, OK.

In a later step, we can eliminate the implicit 'phase' parameter in constructors.

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1540673002 .
2015-12-18 15:37:07 -08:00
Ryan Macnak 6b964b83ac Add ./tools/test.py -c precompiler -r dart_precompiled.
- Make --gen/run-precompiled-snapshot take a directory to use for the snapshot pieces.
 - Throw on Platform.executeable to prevent tests from becoming fork-bombs.
 - Update status files so 'dart_precompiled' is generally expected to behave the same as 'vm'.

Currently multitests will fail unless run with --jobs=1 because the test harness assigns them the same temporary directory.

Running this also requires a great deal of space. My out directory is 380G.

BUG=http://dartbug.com/24975
R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org/1507943002 .
2015-12-18 12:08:10 -08:00
William Hesse 6485590527 Remove old java-based analyzer from test scripts and status files
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1537653002 .
2015-12-17 14:44:57 +01:00
Sigmund Cherem 2e90021cfb fix redness: it fails on some configurations and not others, still need to
investigate. For now marking as pass/fail.

BUG=

Review URL: https://codereview.chromium.org/1531203002 .
2015-12-16 21:10:37 -08:00
Sigmund Cherem 25e33b4a21 Suppress test that yields a stack overflow in the compiler
TBR=sra@google.com

Review URL: https://codereview.chromium.org/1537473004 .
2015-12-16 18:37:03 -08:00
Johnni Winther c5235fde7f Add token invariant to DiagnosticReporter
Closes #3675

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1520293002.
2015-12-15 11:35:55 +01:00
Kevin Millikin ff12f5ddd0 Remove a couple of unnecessary lines from test status files.
The test runner will generate a filename from the test name in the status
file.  If the status file contains a filename, it does not match any test.

R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1510943005 .
2015-12-11 14:19:58 +01:00
Alan Knight 44d82ebc43 Fix Chrome 47 test suppressions and invalid @DontInline directive
BUG=

Review URL: https://codereview.chromium.org/1509323003 .
2015-12-09 10:32:26 -08:00
Kevin Millikin 42809b52b1 dart2js: Fix an issue with erroneous for-in.
In the CPS backend, when a for-in loop has an erroneous variable (interpreted
as an unresolved static setter), then we should call NoSuchMethod and not try
to call the setter.  This is what the SSA backend does.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1518473002 .
2015-12-09 18:33:27 +01:00
Kevin Millikin deba5aaf7a Remove an unnecessary line in a test status file.
The syntax of the test status file expects the name of the test which will
be used to derive the filename.  If the filename is instead given, it
matches no test.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1508413002 .
2015-12-09 16:28:46 +01:00
Kevin Millikin 12d79f91a3 dart2js: Process arguments to direct invocations as if the target is known.
When a method is invoked directly the target is known.  Normalize the
arguments based on the known target at CPS-translation time.  If this is not
done, then the call may go indirectly through a stub which is not actually
generated.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org/1510193003 .
2015-12-09 16:27:13 +01:00
Johnni Winther 77b2f078af Make new of an ambiguous a warning.
Closes #21171

R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1508383002.
2015-12-09 15:54:41 +01:00
Florian Loitsch 5b4e5a90fe Update status file.
Review URL: https://codereview.chromium.org/1507383003 .
2015-12-09 01:30:52 +01:00
Kevin Millikin 5c9a554187 dart2js CPS: Evaluate the arguments to abstract class constructors.
Constructing an abstract class is a runtime error, but that error should be
thrown after the arguments are evaluated.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org/1506143002 .
2015-12-08 12:53:01 +01:00
Alan Knight 7f9dcb66a5 One more suppression and fix incorrect test names in previous CL
BUG=

Review URL: https://codereview.chromium.org/1508963002 .
2015-12-07 15:14:52 -08:00
Alan Knight e4f1784690 Update more Chrome 47 test statuses
BUG=

Review URL: https://codereview.chromium.org/1509703003 .
2015-12-07 14:05:35 -08:00
Alan Knight 39e69b1898 Suppress tests around issue 25155 (object tags in Chrome 47)
BUG=

Review URL: https://codereview.chromium.org/1507013002 .
2015-12-07 12:39:37 -08:00
Sigmund Cherem bb2c3a9350 Fix #25111: evaluate arguments before throwing errors about invoking invalid constructors
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1492823007 .
2015-12-04 13:33:28 -08:00
Alan Knight 9a6725566c Remove co19 suppressions fixed in Chrome roll, add new suppressions for co19 issue 14
BUG=

Review URL: https://codereview.chromium.org/1497283003 .
2015-12-04 13:00:21 -08:00
Alan Knight ae2e3dff66 Remove suppression that seems to be now fixed in Firefox
BUG=

Review URL: https://codereview.chromium.org/1496383002 .
2015-12-04 11:19:56 -08:00
Sigmund Cherem 346e0da5db Fix status files: this marks a new test with the correct expectations for
analyzer, and it adds a temporary suppression for a co19 test (tracked in issue
25111).

Review URL: https://codereview.chromium.org/1494383002 .
2015-12-03 18:19:50 -08:00
Alan Knight bfd0efa955 Suppress more flaky co19 tests due to spawn semantics changes
BUG=

Review URL: https://codereview.chromium.org/1490863002 .
2015-12-01 11:10:23 -08:00
Alan Knight 50b1ea35e9 Fix a couple more tests related to Isolate.spawn semantics change
BUG=

Review URL: https://codereview.chromium.org/1481693002 .
2015-11-25 16:28:59 -08:00
Alan Knight c480c7beec Fix tests that don't catch asynchronous errors from isolate spawning. Update co19 status.
BUG=

Review URL: https://codereview.chromium.org/1477043002 .
2015-11-25 14:33:09 -08:00
Todd Turnidge bd2b840be0 Revert my recent changes to the Dartium test status files.
We have restored blocking isolate spawning under a flag.

--------

Revert "Update test status files.  Issue #24990."

This reverts commit 05bf1d6bb6.

Revert "Skip isolate spawning tests on Dartium."

This reverts commit c6c6f121ed.

BUG=

Review URL: https://codereview.chromium.org/1472783004 .
2015-11-23 15:15:55 -08:00
Todd Turnidge c6c6f121ed Skip isolate spawning tests on Dartium.
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1455233007 .
2015-11-20 11:10:17 -08:00
Todd Turnidge 05bf1d6bb6 Update test status files. Issue #24990.
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/1454143005 .
2015-11-19 12:42:58 -08:00
Ryan Macnak 71f7688c91 Update co19 status for noopt.
R=srdjan@google.com

Review URL: https://codereview.chromium.org/1457733003 .
2015-11-18 13:24:47 -08:00
Alan Knight aeceee15ef Suppress flaky co19 test on Dartium
BUG=

Review URL: https://codereview.chromium.org/1436933004 .
2015-11-12 17:48:53 -08:00
William Hesse 5c2102fbac Fix format error in co19 status file.
BUG=
R=mit@google.com

Review URL: https://codereview.chromium.org/1433873003 .
2015-11-11 18:58:13 +01:00
William Hesse 7e2efcbb2a Update browser status for co19 roll.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1440663002 .
2015-11-11 16:09:03 +01:00
William Hesse 13b2d4463c Update dart2js/check_members_test for co19 renaming.
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1440573002 .
2015-11-11 14:23:20 +01:00
Johnni Winther 9cfba28da1 Compute NewStructure in resolution.
Closes #21134

R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1437463005.
2015-11-11 11:46:08 +01:00
William Hesse d524cf4076 Update co19 test suite to commit Oct 1 2015 1d96fbbf94c534c9076f90bd4ebce6226169da48
Update co19-co19.status

Update co19 to tot.

Rename co19 language tests in status files, and roll co19 version.

BUG=
R=ricow@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org/1390533003 .
2015-11-11 10:47:46 +01:00
Lasse R.H. Nielsen 580d8601d0 Fix co19 expectation after fixing compile-time constant interpolation bug.
Review URL: https://codereview.chromium.org/1417553012 .
2015-11-06 12:28:34 +01:00
Asger Feldthaus a32a12f900 dart2js: Change how super tear-offs are registered.
Previously, torn off super methods would be registered by emulating a
dynamic getter call using an exact TypeMask for the super class as the
receiver.

If the super class was abstract (or just not instantiated), using an
exact TypeMask is absurd since there are no objects with that exact
class.

Now, methods that have been registered as "needing super getter" are
always considered to have their getter invoked, removing the need to
emulate the dynamic getter call.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1418573011 .
2015-11-06 11:49:05 +01:00
William Hesse abcb3a4d4d Update status for Firefox 42.
BUG=https://github.com/dart-lang/sdk/issues/24838
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1415473006 .
2015-11-05 16:14:46 +01:00
William Hesse 8ef142ef72 Update co19 status for Firefox 41 on linux.
BUG=

Review URL: https://codereview.chromium.org/1418603003 .
2015-11-03 18:21:50 +01:00
Asger Feldthaus 0c25cd27ac dart2js cps: Remove unneeded bailout on captured loop variables.
The analysis of try-boxed variables reused some code from the old
dart2dart CPS backend, which had bailouts for code that is handled just
fine in the dart2js CPS backend.

R=karlklose@google.com, kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/695bdf4fa365fc84ef4dda9e0fde84b58772ca9b

Review URL: https://codereview.chromium.org/1410123005 .
2015-10-27 13:01:10 +01:00