Commit Graph

3219 Commits

Author SHA1 Message Date
Asger Feldthaus 8701dbf147 Revert "added Range.toString() to dart:html (#28376)" +1 more
Revert "dart2js status updates after Range.toString was added to dart:html"

This reverts commit 226a7e7177.
This reverts commit c279a951f4.

The test

  co19/LayoutTests/fast/filesystem/file-writer-abort-continue_t01

broke after the inital commit. The second commit being reverted
is one that updated the status files for tests that now pass.

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2635033004 .
2017-01-17 17:21:46 +01:00
Asger Feldthaus c279a951f4 dart2js status updates after Range.toString was added to dart:html
This updates only tests that failed but now pass.

Test groups:
co19/LayoutTests/fast/dom/Range
co19/LayoutTests/fast/text/international

Runtimes:
chrome, ff, drt, jsshell, safari, ie10, ie11

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2632363002 .
2017-01-17 13:31:27 +01:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots."
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
2017-01-13 15:52:36 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots.
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
2017-01-13 15:18:27 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots."
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots.
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
2017-01-13 10:37:51 -08:00
Kevin Millikin f32ef84dc5 Mark a now-passing test
This test started passing, apparently because we stopped running heap
verification code at shutdown when testing.  The underlying issue or
false positive is still there.  It now appears with the VM flag
--verify-on-transition.

BUG=https://github.com/dart-lang/sdk/issues/28379
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2627713011 .
2017-01-13 11:00:38 +01:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM.
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
2017-01-11 16:55:55 -08:00
Florian Schneider 45c3ecdf9c Re-enable now passing tests and remove redundant status file entry.
Because the tests were marked "Skip" there is no way to find out when
they started passing again.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2625833004 .
2017-01-11 16:35:24 -08:00
Martin Kustermann 1c7c3408bf VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624273002 .
2017-01-11 20:24:06 +01:00
Florian Schneider df2ef7fd4b Speed up AOT compilation of is-tests.
* In subtype-tests in the compiler, allocate temporary objects in new-space.
* Add local StackZone to avoid accumulating zone memory.
* Exlude "Function" type from this optimization.

Fixes #28318.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2622283004 .
2017-01-11 11:13:17 -08:00
Martin Kustermann bce0be4540 VM: [Kernel] Add kernel::ConstantEvaluator support for string.length
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621343002 .
2017-01-11 19:53:57 +01:00
Martin Kustermann 2f21c261c9 VM: [Kernel] Make type literals which refer to type parameters work
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2623143003 .
2017-01-11 19:51:42 +01:00
Martin Kustermann 23cc9cca41 VM: [Kernel] Add toString() support for generated enum classes
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2625053003 .
2017-01-11 19:50:21 +01:00
Martin Kustermann 673eb56471 VM: [Kernel] Fix remaining issues with kernel-based async/await implementation
This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2627873002 .
2017-01-11 19:35:02 +01:00
Erik Corry 61eba61153 Gardening: Mark slow subtype_28 and subtype_27 tests in different compilers.
R=kustermann@google.com
BUG=28318

Review-Url: https://codereview.chromium.org/2625123002 .
2017-01-11 17:22:47 +01:00
Erik Corry d2dfc35575 Gardening: mark subtype_t28 as timeout on the vm-kernel config
TBR=fschneider@google.com
BUG=28318

Review-Url: https://codereview.chromium.org/2624133002 .
2017-01-11 11:32:55 +01:00
Dmitry Olshansky 6a6ea68f88 Gardening: mark tests that are timing out as slow
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2624733003 .
2017-01-10 17:59:16 +01:00
Regis Crelier 7b68f5a2ee Status update: 3 previously failing kernel tests are now passing, most probably
fixed by https://codereview.chromium.org/2624543002/

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2621733003 .
2017-01-09 16:21:41 -08:00
Ryan Macnak 6840abebd6 Unmark 3 tests in precomp debug as slow following change to debug from -O1 to -O2.
This reverts commit 8222b4deda.

Review-Url: https://codereview.chromium.org/2622483004 .
2017-01-09 11:11:36 -08:00
Vyacheslav Egorov aa39062c0a VM: [Kernel] Remove custom expectations for generic closurization tests.
This feature is removed from the VM and now these tests fail with compile error on VM's source front-end too.

BUG=http://dartbug.com/28263
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2619323002 .
2017-01-09 16:31:27 +01:00
Martin Kustermann 98e3037f41 Share common failures between kernel and non-kernel in language_kernel.status -> language.status
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621623002 .
2017-01-09 13:53:23 +01:00
Jens Johansen 8222b4deda Gardening: Marked 3 tests in precomp debug as slow.
BUG=

Review-Url: https://codereview.chromium.org/2620613004 .
2017-01-09 09:38:32 +01:00
Vyacheslav Egorov 0d4d5221d3 Gardening: Mark LibTest/isolate/Isolate/spawn_A04_t01 Pass, Fail
See issue #28269.

R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2613953002 .
2017-01-05 16:11:53 +01:00
Asger Feldthaus 0546f6b4b7 Support generic method syntax in kernel pipeline.
Closes https://github.com/dart-lang/sdk/issues/28231
Closes https://github.com/dart-lang/sdk/issues/28238

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2613683003 .
2017-01-04 14:25:36 +01:00
Lasse R.H. Nielsen 821eeb1aac Update expectations for dartk-vm crashes.
Review-Url: https://codereview.chromium.org/2606343002 .
2017-01-03 13:38:30 +01:00
Siva Annamalai c78cb290df Adjust co19 status files for dartium.
Review-Url: https://codereview.chromium.org/2607223002 .
2016-12-29 15:12:22 -08:00
Siva Annamalai c69cbb586f - report tear offs using the x#y syntax as a compilation error
(fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
R=regis@google.com

Review-Url: https://codereview.chromium.org/2607173002 .
2016-12-29 13:01:12 -08:00
Kasper Lund b85f0906a4 Mark isContentEditable_A01_t01 as flaky on Safari.
TBR'ed.

R=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2599743004 .
2016-12-22 14:01:20 +01:00
Matthias Hausner 13908fa105 Adjust co19 test status
Test Language/Statements/Assert/syntax_t04 is no longer
correct.

Filed co19 bug 85 (https://github.com/dart-lang/co19/issues/85)
to have test removed.

BUG=

Review-Url: https://codereview.chromium.org/2590573003 .
2016-12-19 15:57:08 -08:00
Harry Terkelsen 74c92d5c5f fix assert message tests in dart2js
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2579843002 .
2016-12-15 10:29:46 -08:00
Martin Kustermann 6a30db5997 Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missing CTEs from dartk and from dart_bootstrap
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2563983002 .
2016-12-09 10:55:03 +01:00
Brian Wilkerson f61ffe3e07 Fix the kernel status files to fix the bots (TBR)
Review-Url: https://codereview.chromium.org/2562703004 .
2016-12-08 15:40:08 -08:00
Brian Wilkerson e22a2b4626 Enable messages in asserts by default
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2557513008 .
2016-12-07 12:23:00 -08:00
Sigmund Cherem 2da72a832c fix status of jsshell tests
R=het@google.com

Review URL: https://codereview.chromium.org/2562483002 .
2016-12-07 10:32:20 -08:00
Sigmund Cherem 0cb170488c Update failing chrome tests after chrome 55 roll (issue #27991), also update a
status comment.

Review URL: https://codereview.chromium.org/2557533002 .
2016-12-05 14:38:01 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
Martin Kustermann 117924ed15 Update kernel status files for precompilation after refactoring
The tests for which dartk is missing a compile-time error will run the precompiler on the result and will therefore have a different status entry (even though it is caused by dartk).

Review URL: https://codereview.chromium.org/2547523002 .
2016-12-01 14:48:24 +01:00
Martin Kustermann ff8951a515 VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate
If we generate too much surviving objects in Heap::kNew during program reading
time or flow graph construction time we trigger (very aggressive) growth of new
space.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2539173002 .
2016-12-01 13:51:29 +01:00
Martin Kustermann abd77cab64 Refactor kernel-related status files
To make it clear in the status file whether a crash (or other issues) are coming
from the dartk compiler or from the vm, this CL introduces new status file
markers which are the normal markers prefixed with Dartk (e.g. DartkCrash).

Furthermore this CL groups common failures
  * compiler: dartk & dartkp
  * runtime: vm & dart_precompiled
into shared status file blocks, thereby deduplicating failures (which removes around 500 lines).

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2543973002 .
2016-12-01 13:48:35 +01:00
William Hesse 10e535a5ee Update status for dart_style package and dom/shadowroot co19 windows.
BUG=https://github.com/dart-lang/dart_style/issues/562
TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/2543463003 .
2016-11-30 16:52:17 +01:00
William Hesse de0c7acfd7 Update status for flaky Windows tests
BUG=https://github.com/dart-lang/sdk/issues/27935
R=eernst@google.com

Review URL: https://codereview.chromium.org/2539033002 .
2016-11-30 11:41:17 +01:00
William Hesse e2a48dbf38 Update status for failing tests
BUG=https://github.com/dart-lang/sdk/issues/27925
R=eernst@google.com

Review URL: https://codereview.chromium.org/2536183002 .
2016-11-29 14:26:27 +01:00
Martin Kustermann 8698589dee VM: [Kernel] Update status file for precompiled (debug) builders
Review URL: https://codereview.chromium.org/2538713002 .
2016-11-29 10:32:53 +01:00
Martin Kustermann f81bcb660a VM: [Kernel] Update status file for precompiled (release) builders
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2537543002 .
2016-11-28 19:23:23 +01:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
2016-11-28 16:32:41 +01:00
Vyacheslav Egorov 8eceda053f VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary.
Tree shaker can't cope with this and produces incorrect snapshots that contains tree shaken classes.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2536683002 .
2016-11-28 15:50:24 +01:00
William Hesse c3333f9c40 Update dartium status for issue 26644
BUG=https://github.com/dart-lang/sdk/issues/26644

Review URL: https://codereview.chromium.org/2526283005 .
2016-11-25 14:49:12 +01:00
William Hesse 52cb4500b5 Update co19 status for issue 26644
BUG=https://github.com/dart-lang/sdk/issues/26644

Review URL: https://codereview.chromium.org/2528103003 .
2016-11-25 14:32:01 +01:00
William Hesse 177f9c690f Update MacOS dartium status for co19 tests
BUG=
R=sortie@google.com

Review URL: https://codereview.chromium.org/2534583002 .
2016-11-25 13:51:47 +01:00