dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

3219 Commits

Author SHA1 Message Date
Peter von der Ahé 470127ae46 Setup correct scope for initializers and complain about fields initialized more than once. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2916333002 .
 2017-06-06 19:35:35 +02:00
Peter von der Ahé cbcb7d4885 Clean up handling of types. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2915933004 .
 2017-06-02 14:53:20 +02:00
Peter von der Ahé 696f00d96b Implement library access restrictions and privacy. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2916863003 .
 2017-06-02 13:13:38 +02:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files. 
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
 2017-06-02 10:38:14 +02:00
Peter von der Ahé c0bf4eddbe Various checks for constant expressions. 
Fixes https://github.com/dart-lang/sdk/issues/29379

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2911023002 .
 2017-05-31 15:57:03 +02:00
Peter von der Ahé 8ea78cbc3f Avoid using Invalid{Statement,Expression,Initializer}. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2906253004 .
 2017-05-31 14:53:44 +02:00
Peter von der Ahé 4cd8e437f6 Various constant checks. 
R=johnniwinther@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2908113002 .
 2017-05-30 12:44:57 +02:00
Johnni Winther 3098f71cee Mark date-interactive-validation-required_t01 as flaky on Dartium 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2908133002 .
 2017-05-29 12:51:38 +02:00
Peter von der Ahé 0eae9218f4 Complain about duplicated names. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2902113005 .
 2017-05-29 09:45:05 +02:00
Peter von der Ahé bcb2ea962b Complain about function literals not being constant expressions. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2899343002 .
 2017-05-25 16:02:30 +02:00
Peter von der Ahé fb8c445e92 Update status files. 
Review-Url: https://codereview.chromium.org/2897483004 .
 2017-05-19 13:40:46 +02:00
Peter von der Ahé 547b2cdcce Implement generalized function types. 
Fixes https://github.com/dart-lang/sdk/issues/6972

Fixes https://github.com/dart-lang/sdk/issues/26581

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2876813002 .
 2017-05-19 11:03:24 +02:00
Bob Nystrom 92267afc66 Refactor and clean up the status file parsing code. - Make the parser less error tolerant. The expression parser used to ignore any unrecognized tokens, which means a status like "RuntimeError CompileError" (not the missing comma) was parsed as simply "RuntimeError", which seems bad. Now it reports an error. Fixed a couple of status files that thought they were setting statuses that they weren't (!). 
- Separate out parsing a status file from applying the environment to
  determine which sections are active. This makes it possible to, for
  example, generate expectation sets for multiple environments without
  having to reparse each time.

- Simplify expression parsing. Remove set expressions since they weren't
  used for anything useful. A test's expectations are a simple
  comma-separated list and don't need anything beyond that. Merge
  Scanner and Tokenizer since the latter was a glorified function.

- Make more names private so that it's clearer what's used outside of
  various libraries.

- Generally modernize the style.

- Add *lots* of documentation.

Again, there should be no behavioral changes. I ran:

  ./tools/test.py -m release,debug -c none,dart2js,dart2analyzer -r none,vm,d8 corelib

Before and after the change and verified that the output was the same
(aside from timing).

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2891753003 .
 2017-05-18 12:42:52 -07:00
Bob Nystrom c269ef53a5 Revert "Re-apply status file parser changes from 0b7728da1bef08c1c1e092005d9fd8c8bff5fa6c." 
This reverts commit a881aed354.

TBR.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2888213002 .
 2017-05-17 13:45:40 -07:00
Bob Nystrom a881aed354 Re-apply status file parser changes from 0b7728da1b. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2880203004 .
 2017-05-17 13:04:35 -07:00
Alan Knight 6b525831f6 Fix typo in status file 
BUG=

Review-Url: https://codereview.chromium.org/2891593002 .
 2017-05-16 15:38:15 -07:00
Alan Knight 0ea9e4402d Suppressions for dart2js-drt roll 50. Issue 29632 
BUG=

Review URL: https://codereview.chromium.org/2886003002 .
 2017-05-16 15:16:57 -07:00
Alan Knight cf9d7a872e Supress Safari Roll 50 errors - Issue 29632 
BUG=

Review-Url: https://codereview.chromium.org/2883423002 .
 2017-05-16 13:01:07 -07:00
Terry Lucas 3160698fb7 Revert "Test that all bots successes" 
This reverts commit a9a4f84549.

Revert "Test that all bots successes"

This reverts commit dc7ee5d872.

BUG=

Review-Url: https://codereview.chromium.org/2881353002 .
 2017-05-16 05:40:27 -07:00
Terry Lucas dc7ee5d872 Test that all bots successes 
TBR=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/a9a4f84549146f86233fb619c17f2acf688cb522
Review-Url: https://codereview.chromium.org/2881093002 .
 2017-05-15 19:15:55 -07:00
Bob Nystrom 01e5b1b40c Revert "Refactor and clean up the status file parsing code." 
This reverts commit 0b7728da1b.

R=nbosch@google.com

Review-Url: https://codereview.chromium.org/2885623002 .
 2017-05-15 15:58:05 -07:00
Bob Nystrom 0b7728da1b Refactor and clean up the status file parsing code. 
- Make the parser less error tolerant. The expression parser used to
  ignore any unrecognized tokens, which means a status like
  "RuntimeError CompileError" (not the missing comma) was parsed as
  simply "RuntimeError", which seems bad. Now it reports an error.
  Fixed a couple of status files that thought they were setting statuses
  that they weren't (!).

- Separate out parsing a status file from applying the environment to
  determine which sections are active. This makes it possible to, for
  example, generate expectation sets for multiple environments without
  having to reparse each time.

- Simplify expression parsing. Remove set expressions since they weren't
  used for anything useful. A test's expectations are a simple
  comma-separated list and don't need anything beyond that. Merge
  Scanner and Tokenizer since the latter was a glorified function.

- Make more names private so that it's clearer what's used outside of
  various libraries.

- Generally modernize the style.

- Add *lots* of documentation.

Again, there should be no behavioral changes. I ran:

  ./tools/test.py -m release,debug -c none,dart2js,dart2analyzer -r none,vm,d8 corelib

Before and after the change and verified that the output was the same
(aside from timing).

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2875203005 .
 2017-05-15 15:42:15 -07:00
Terry Lucas a9a4f84549 Test that all bots successes 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2881093002 .
 2017-05-15 07:45:52 -07:00
Paul Berry 28e742a31c Infer return types of closures (basic support). 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2878173002 .
 2017-05-13 06:13:31 -07:00
Stephen Adams 7e8fc74337 A few co19 html tests now passing on Chrome 
TBR=terry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2876473006 .
 2017-05-11 14:29:47 -07:00
William Hesse c03715e589 Update dart2js browser failures with passing tests 
BUG=https://github.com/dart-lang/sdk/issues/26714

Review-Url: https://codereview.chromium.org/2879593002 .
 2017-05-11 16:17:09 +02:00
Terry Lucas f27144d7b5 Roll 50: Updated for push to origin/master. 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
 2017-05-10 18:16:51 -07:00
Terry Lucas 4d6fa74118 Temporary to make bots green with Chrome 50 IDLs 
R=whesse@google.com
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2873323002 .
 2017-05-10 07:51:08 -07:00
Terry Lucas 88a226b58b New sdk/lib generated from Chrome 50 IDLs 
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2871193002 .
 2017-05-10 05:26:37 -07:00
Erik Corry 6a1560b541 Fix dart2js co19 tests to fix unexpected DRT passes 
R=whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2870773004 .
 2017-05-09 10:24:16 +02:00
Peter von der Ahé 4880a2876e Rewrite mixin application handling in Fasta. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2862223002 .
 2017-05-09 09:22:57 +02:00
Florian Loitsch 8e01f69305 Void is not required to be null anymore. 
In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, kmillikin@google.com, lrn@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Committed: https://github.com/dart-lang/sdk/commit/4e52c457a9ac412b6b0a3a350020998c7e2f7d9a
Reverted: https://github.com/dart-lang/sdk/commit/4b35d3995b2b273728751c19976ece0edca0eddc
Committed: https://github.com/dart-lang/sdk/commit/6caf9ef4439e20ea726d8a5383ed34d42b02c84b
Reverted: https://github.com/dart-lang/sdk/commit/30d9bf2ed3225f04c52d999a1a5c61e63a90578d
Review-Url: https://codereview.chromium.org/2718513002 .
 2017-05-08 11:31:37 +02:00
William Hesse 5ffb0b2c21 Revert "Update status files: these co19 tests seemed to have invalid code that got" 
This reverts commit dadb76a197.
This revert is part of reverting "Void is not required to be 'null' anymore.

R=jensj@google.com
BUG=

Review-Url: https://codereview.chromium.org/2870583002 .
 2017-05-08 11:14:31 +02:00
Jens Johansen d9e93a1067 Revert "Remove status entries for now-passing checked-mode co19 tests that were returning a value from a void function" 
This reverts commit 47ba2bd413.

Reverting this because the commit causing these tests to pass was reverted.

BUG=

Review-Url: https://codereview.chromium.org/2868433002 .
 2017-05-05 09:31:59 +02:00
Jens Johansen 30d9bf2ed3 Revert "Void is not required to be null anymore." 
This reverts commit 6caf9ef443.

Commit breaks vm-kernel-linux-debug-x64-be.

Triggers asserts like
../../runtime/vm/flow_graph_compiler_x64.cc: 658: error: expected: dst_type.IsMalformedOrMalbounded() || (!dst_type.IsDynamicType() && !dst_type.IsObjectType() && !dst_type.IsVoidType())

Quick-check with python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options --no-enable-malloc-hooks isolate

BUG=

Review-Url: https://codereview.chromium.org/2865603003 .
 2017-05-05 08:56:26 +02:00
Sigmund Cherem dadb76a197 Update status files: these co19 tests seemed to have invalid code that got 
"fixed" by the changes to void. For example, they return a value on a void
function, and then read it.

Probably the tests need to be fixed. For now I'm updating the status files to
make the bots green.

BUG= https://github.com/dart-lang/sdk/issues/29565

Review-Url: https://codereview.chromium.org/2866553002 .
 2017-05-04 15:12:29 -07:00
Alan Knight 47ba2bd413 Remove status entries for now-passing checked-mode co19 tests that were returning a value from a void function 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2856863009 .
 2017-05-04 12:59:50 -07:00
Florian Loitsch 6caf9ef443 Void is not required to be null anymore. 
In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Committed: https://github.com/dart-lang/sdk/commit/4e52c457a9ac412b6b0a3a350020998c7e2f7d9a
Reverted: https://github.com/dart-lang/sdk/commit/4b35d3995b2b273728751c19976ece0edca0eddc
Review-Url: https://codereview.chromium.org/2718513002 .
 2017-05-04 16:27:52 +02:00
Stephen Adams 9ae8b0df25 Some co19 tests pass now that getMatchedCssRules is nullable 
TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2860933002 .
 2017-05-03 20:40:32 -07:00
Stephen Adams 51118ab0b9 Some co19 tests pass now that getMatchedCssRules is nullable 
TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2863563002 .
 2017-05-03 20:27:28 -07:00
Florian Loitsch 4b35d3995b Revert "Void is not required to be null anymore." 
This reverts commit 4e52c457a9.

BUG=

Review-Url: https://codereview.chromium.org/2863463002 .
 2017-05-03 19:22:22 +02:00
Florian Loitsch 4e52c457a9 Void is not required to be null anymore. 
In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/521dc6620fd2c4591aa975745c14b304428f17eb
Reverted: https://github.com/dart-lang/sdk/commit/a3c0cb65af4bbbdde756208dcccdcdf896902b5b
Review-Url: https://codereview.chromium.org/2718513002 .
 2017-05-03 17:43:23 +02:00
Florian Loitsch a3c0cb65af Revert "Void is not required to be null anymore." 
This reverts commit 521dc6620f.

BUG=

Review-Url: https://codereview.chromium.org/2855173002 .
 2017-05-03 17:36:39 +02:00
Florian Loitsch 521dc6620f Void is not required to be null anymore. 
In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
R=johnniwinther@google.com, lrn@google.com, regis@google.com

Review-Url: https://codereview.chromium.org/2718513002 .
 2017-05-03 17:31:21 +02:00
Florian Loitsch 953ce8c9fb Mark tests as flaky. 
Review-Url: https://codereview.chromium.org/2859473002 .
 2017-05-02 15:57:18 +02:00
Martin Kustermann e2524712ed [Gardening] Broaden scope of test failure to non-checked mode 
Review-Url: https://codereview.chromium.org/2853793002 .
 2017-05-01 09:28:01 +02:00
Kevin Millikin 385f8fb054 Read platform.dill in the VM. 
1. A --platform flag is added to dart to give a path to a Kernel
   binary for the platform libraries (as produced by building the
   runtime_kernel target).

2. This binary is used for bootstrapping.  Since it contains libraries
   other then the VM's bootstrap libraries, they are also loaded.

3. The frontend does not send any library with a dart: import URI
   scheme.  Note that it does not (yet) prune the canonical name
   table, which will contain a lot of unnecessary names used for
   internal linkages in the platform libraries.

4. There is a single dependency in the platform libraries on the
   script: _getMainClosure in dart:_builtin.  This is patched after
   the script is loaded.

BUG=
R=ahe@google.com, kustermann@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2786083002 .
 2017-04-25 20:04:25 +02:00
Florian Loitsch 7f3ed24918 delete-contents is failing on IE11 
Review-Url: https://codereview.chromium.org/2839963002 .
 2017-04-25 15:30:40 +02:00
Florian Loitsch 83491f2f9f delete-contents_t01 test started passing. 
Review-Url: https://codereview.chromium.org/2835123006 .
 2017-04-25 15:24:50 +02:00
Jennifer Messerly 613881a433 fix #29426, class type alias was missing checks 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2837173002 .
 2017-04-24 15:02:29 -07:00