dart-lang/sdk - sdk - Tonycloud git server

dart-lang/sdk

Fork 0

Commit Graph

Author	SHA1	Message	Date
Alexander Aprelev	e70690e415	[native_extensions] Convert uri to path so that on Windows native extension loading works. Lookup of native extension library on Windows works when the library is next to Platform.executable, this CL fixes lookup when it's next to the script. Fixes https://github.com/dart-lang/sdk/issues/45370 TEST=updated sample_extension test Change-Id: I91226be19ceec05e45cf90fd85428a62d95769c2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193741 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>	2021-04-01 03:22:35 +00:00
Daco Harkes	1245a196ce	[samples] Duplicate samples prior to NNBD migration We want to migrate the samples to NNBD. In order for the old samples to keep running on the legacy bots, this duplicates all samples, and changes the legacy bots to run the copies. Note this will cause the legacy bots to report that all the samples tests are skipped and that there are now new tests in the samples_2 suite. Existing failures may re-appear. These will be be re-approved or alternatively Skipped. The follow up CL migrates samples/ffi to NNBD. Issue: https://github.com/dart-lang/sdk/issues/43600. TEST=samples TEST=samples_2 Change-Id: Ib40f8fb71f81c091973aa0f860b1a49bac120d6c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173523 Reviewed-by: Alexander Thomas <athom@google.com>	2020-11-24 18:50:28 +00:00

Author

SHA1

Message

Date

Alexander Aprelev

e70690e415

[native_extensions] Convert uri to path so that on Windows native extension loading works.

Lookup of native extension library on Windows works when the library is next
to Platform.executable, this CL fixes lookup when it's next to the script.

Fixes https://github.com/dart-lang/sdk/issues/45370

TEST=updated sample_extension test

Change-Id: I91226be19ceec05e45cf90fd85428a62d95769c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193741
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

2021-04-01 03:22:35 +00:00

Daco Harkes

1245a196ce

[samples] Duplicate samples prior to NNBD migration

We want to migrate the samples to NNBD. In order for the old samples
to keep running on the legacy bots, this duplicates all samples, and
changes the legacy bots to run the copies.

Note this will cause the legacy bots to report that all the samples
tests are skipped and that there are now new tests in the samples_2
suite. Existing failures may re-appear. These will be be re-approved
or alternatively Skipped.

The follow up CL migrates samples/ffi to NNBD.

Issue: https://github.com/dart-lang/sdk/issues/43600.

TEST=samples
TEST=samples_2

Change-Id: Ib40f8fb71f81c091973aa0f860b1a49bac120d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173523
Reviewed-by: Alexander Thomas <athom@google.com>

2020-11-24 18:50:28 +00:00

2 Commits