e70690e415
[native_extensions] Convert uri to path so that on Windows native extension loading works.
...
Lookup of native extension library on Windows works when the library is next
to Platform.executable, this CL fixes lookup when it's next to the script.
Fixes https://github.com/dart-lang/sdk/issues/45370
TEST=updated sample_extension test
Change-Id: I91226be19ceec05e45cf90fd85428a62d95769c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193741
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2021-04-01 03:22:35 +00:00
91b0f16663
Migrate samples/sample_extension to null safety
...
Closes https://github.com/dart-lang/sdk/issues/43711
Change-Id: I7628e4a6192efb26a12f8051b4fa87dfafabab9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180960
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2021-01-25 20:06:43 +00:00
745f112ef6
Opt out some files from null safety.
...
Opt an initial batch of files under samples, samples-dev,
utils, and runtime/tools/dartfuzz out of null safety in preparation
for switching the flag on by default.
Change-Id: Icdfd52a5a969e678a7205903332f73fe3841c223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166960
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
2020-10-12 22:15:42 +00:00
49142b49e7
Revert "[gardening] mark sample_extension_test as error"
...
This reverts commit 679108ea7bfba5a58b47TBR=asiva@google.com ,kathyw@google.com
Change-Id: I690694ec974fa316b25934a1f0f62b5e665a28ba
Reviewed-on: https://dart-review.googlesource.com/c/86800
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-12-10 19:37:33 +00:00
fba5a58b47
Update 'samples/sample_extension' to Dart 2
...
- Ran `dartfmt --fix`
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)
Contributes to https://github.com/dart-lang/site-www/issues/980
cc @a-siva @kwalrath @kevmoo
Closes #33711
https://github.com/dart-lang/sdk/pull/33711
GitOrigin-RevId: a832220272fe50a8bd96c6bc71692d54dcbf9465
Change-Id: Ia542ce073d2f9a4c78934a74ee17b60156a49d25
Reviewed-on: https://dart-review.googlesource.com/c/63260
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-12-09 03:34:04 +00:00
cc1a7b35d0
Update SDK wrt to void and invalid returns
...
Change-Id: Ia1a6b056351beb9faddc2c6e86280983a2395d45
Reviewed-on: https://dart-review.googlesource.com/65140
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-07-17 13:37:47 +00:00
bc7220a4fd
[VM] Turn dart2 on by default on the command line VM
...
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations
Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-18 22:31:32 +00:00
4f5ad1918c
Make strong mode the default under --preview-dart-2.
...
Change-Id: Ic1637d65a34f6b0310439293f7d83cb351f2c89c
Reviewed-on: https://dart-review.googlesource.com/43200
Commit-Queue: Siva Chandra <sivachandra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-02-27 22:16:07 +00:00
b33097b9b4
Format samples and samples-dev directories.
...
BUG=
R=sra@google.com
Review-Url: https://codereview.chromium.org/2828603002 .
2017-04-19 07:30:17 -07:00
e8e7b2c832
Reenable some sample tests and fix how they find their data files
...
R=kustermann@google.com
BUG=
Review-Url: https://codereview.chromium.org/2709713002 .
2017-02-21 13:08:55 +01:00
987165f022
Reload native extensions when starting from a snapshot.
...
Fixes #21180
Fixes #27574
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2475523002 .
2016-11-07 16:17:47 -08:00
Alexander Aprelev