f4f0831c69
[vm] Fix TSAN failures related to object headers and GC task phases.
...
Change-Id: I15078e845712e8e712e2cb0a044fc7550127ea36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120629
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-10-09 21:48:20 +00:00
8866cdb8be
[vm] throw exception if directory buffer overflows on Windows
...
According to https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-readdirectorychangesw ,
When using ReadDirectoryChangesW, buffer overflows will still return true. It ends up closing the stream without any notification.
Throw an exception to notify users.
Bug: https://github.com/dart-lang/sdk/issues/37233
Change-Id: I9aebed8b1f30b5e843ad37a51b87d234aa1d8ce6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119524
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-10-09 19:59:52 +00:00
55d1c95e08
[vm] Fix instruction deduplication for bare-AOT mode
...
Though we disable deduplication for instance methods because switchable
calls rely on a unique PC -> Code mapping atm.
Change-Id: I80915e97f5e06c3f1251ea3176d5c4f8413a81ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120041
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-10-09 19:45:42 +00:00
f5ce3a6e7f
[ VM / Compiler ] Fixed issue where TMP was being used as source for store with large offset on ARM
...
While emitting code for a ParallelMove on ARM32, the TMP register was
being used as a dest/src. When the stack slot offset is large,
StoreToOffset creates a new base in TMP in order to use a smaller
offset. Since the ParallelMove implementation was hardcoding TMP as the
dest/src register, the assert that the register != TMP failed with large
offsets. Now we instead perform a check to see if the offset will fit to
determine whether or not we can use TMP or if we need to fall back and
use LR as our temporary (we can do this since we're in the middle of a
ParallelMove).
Fixes https://github.com/dart-lang/sdk/issues/38654
Change-Id: I4d8cc8b54f6090d86992aabb8ff44d088bc02d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119584
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2019-10-09 17:06:00 +00:00
ff23f546db
[vm/ffi] Work around dartdoc crash to fix API doc generation
...
Issue: https://github.com/dart-lang/sdk/issues/38786
Change-Id: Ida4bb78da1aabdf6da259e0d66840d9db4b1428d
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120788
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-09 12:37:52 +00:00
b12bed36a8
[VM] Implement isExtensionMember in MethodMirror and VariableMirror
...
Added ability to recognize a MethodMirror to be a mirror of an extension member
Added ability to recognize a VariableMirror to be a mirror of a static
extension field.
Change-Id: I56715a491bba0d8cafb2796ebb755bd339e147c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120760
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2019-10-09 00:27:30 +00:00
735d8b7c64
[VM/nnbd] Propagate nnbd flag on Library from kernel to VM and bytecode.
...
Also fix a few obsolete comments.
Change-Id: Ice4d36abb950575316db02c3dad2b94a505d7e0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120743
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-10-08 22:25:20 +00:00
8bf424ea89
Revert "[vm/bytecode] Enable bytecode compiler by default in Dart SDK"
...
This reverts commit 31996aa24fhttps://dart-review.googlesource.com/c/sdk/+/110551 .
>
> Change-Id: I85fcfadfd20fdba752fa8225650a1cb6c32fff31
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117931
> Reviewed-by: Régis Crelier <regis@google.com >
> Commit-Queue: Alexander Markov <alexmarkov@google.com >
TBR=rmacnak@google.com ,alexmarkov@google.com ,asiva@google.com ,regis@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I941eff705b599c59251e5ba2337c307cc84f373b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120720
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-10-08 20:40:59 +00:00
597cd06aec
[vm/ffi] Pointer load and store as extension methods
...
Issue: https://github.com/dart-lang/sdk/issues/37773
Change-Id: I836d6305b613cf05590d872874f4517831be3e08
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118992
Reviewed-by: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-08 16:49:41 +00:00
d23c824435
Reland "[vm/ffi] Optimize Pointer operations for statically known types"
...
Original CL in patchset 1.
Fix for simdbc in patchset 4.
Fix for arm32 precompiled in: https://dart-review.googlesource.com/c/sdk/+/120660/
This CL optimizes Pointer operations in hot loops for Pointer<NativeInteger/NativeDouble/Pointer> (not for structs).
Design: go/dart-ffi-pointers-il
It provides roughly a 100x speedup for the FfiMemory benchmark. The next 5x speedup is to get rid of allocations due to `load` and `store` not being inlined.
FFI API is changed to enable optimizations:
* Disable dynamic invocations of Pointer.load / Pointer.store.
* Disallow implicit downcast of argument passed to Pointer.store.
* Stop zeroing out Pointer.address on Pointer.free().
Issue: https://github.com/dart-lang/sdk/issues/38172
Related issues:
Closes: https://github.com/dart-lang/sdk/issues/35902 (Disallowing dynamic invocations of Pointer ops.)
Closes: https://github.com/dart-lang/sdk/issues/37385 (Function variance checking)
Change-Id: I3921a595fd05026d6ca565ace496771d7c1d877b
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120661
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2019-10-08 13:04:39 +00:00
15e8c12bc2
[vm] Do not inline force-optimized functions
...
Change-Id: I11b5e799f46be7631b148c479ccc19fc507cf56a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120660
Reviewed-by: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-08 13:04:39 +00:00
9276d50fdc
[cfe] Remove Severity.errorLegacyWarning
...
Change-Id: I1cc7a34af307b9edee4c92e43e8607a450cf471d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120585
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-10-08 09:16:47 +00:00
01ebf92dde
[VM] Consume extension member/is late flag setting when reading kernel file.
...
Consume the extension flag setting for functions and the extension flag and is late
flags for fields when reading kernel file and set bit in Function/Field objects.
Change-Id: I661d30d53e817d968151d2b95474a6daf918de13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118000
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2019-10-07 22:43:19 +00:00
4539536b34
[eventhandler] generalize socket initialization
...
Change-Id: Iac2ef051a822223a20b2a440756de18f9b2bf11e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120601
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2019-10-07 22:10:59 +00:00
c38e19cbbe
[vm/compiler] bit utilities
...
Rationale:
Useful in the future when compiler wants to constant fold
operations related to leading/trailing/counting (non)zeros.
https://github.com/dart-lang/sdk/issues/38346
Change-Id: I158aca125d3a15019af20ca7c2a516b74e4d84c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119920
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-10-07 18:13:06 +00:00
d5feab0c53
[vm] Create builds for LeakSanitizer, MemorySanitizer and ThreadSanitizer.
...
Change-Id: I65905ec76fcde8b7f4063cb5b80a3d034b453153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120323
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Chinmay Garde <chinmaygarde@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-10-07 16:24:22 +00:00
8c5236f55e
[vm/ffi] Fix host-target word mismatch breaking AOT callbacks in ARM_X64.
...
Addresses https://github.com/dart-lang/sdk/issues/38718
Change-Id: If416feb182da1d3a13d4a78770c9e240a0fe17cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120584
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-10-07 14:49:31 +00:00
0eff6b38a9
Revert "[vm/ffi] Optimize Pointer operations for statically known types"
...
This reverts commit 3712ed27efhttps://github.com/dart-lang/sdk/issues/38737
Original change's description:
> [vm/ffi] Optimize Pointer operations for statically known types
>
> This CL optimizes Pointer operations in hot loops for Pointer<NativeInteger/NativeDouble/Pointer> (not for structs).
>
> Design: go/dart-ffi-pointers-il
>
> It provides roughly a 100x speedup for the FfiMemory benchmark. The next 5x speedup is to get rid of allocations due to `load` and `store` not being inlined.
>
> FFI API is changed to enable optimizations:
>
> * Disable dynamic invocations of Pointer.load / Pointer.store.
> * Disallow implicit downcast of argument passed to Pointer.store.
> * Stop zeroing out Pointer.address on Pointer.free().
>
> Issue: https://github.com/dart-lang/sdk/issues/38172
>
> Related issues:
> Closes: https://github.com/dart-lang/sdk/issues/35902 (Disallowing dynamic invocations of Pointer ops.)
> Closes: https://github.com/dart-lang/sdk/issues/37385 (Function variance checking.)
>
> Change-Id: I96058d8b5b49052eb6999f084372e6f08b4f6f17
> Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117547
> Commit-Queue: Daco Harkes <dacoharkes@google.com >
> Reviewed-by: Martin Kustermann <kustermann@google.com >
TBR=kustermann@google.com ,sjindel@google.com ,dacoharkes@google.com
Change-Id: I3b7923ace45beaa9f99119e9ea20c1e52b429ad8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Issue: https://github.com/dart-lang/sdk/issues/38172
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try, vm-ffi-android-debug-arm64-try, app-kernel-linux-debug-x64-try, vm-kernel-linux-debug-ia32-try, vm-dartkb-linux-debug-simarm64-try, vm-kernel-win-debug-x64-try, vm-kernel-win-debug-ia32-try, vm-dartkb-linux-debug-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-dartkb-linux-release-x64-abi-try, vm-kernel-precomp-android-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120582
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2019-10-07 11:50:43 +00:00
3712ed27ef
[vm/ffi] Optimize Pointer operations for statically known types
...
This CL optimizes Pointer operations in hot loops for Pointer<NativeInteger/NativeDouble/Pointer> (not for structs).
Design: go/dart-ffi-pointers-il
It provides roughly a 100x speedup for the FfiMemory benchmark. The next 5x speedup is to get rid of allocations due to `load` and `store` not being inlined.
FFI API is changed to enable optimizations:
* Disable dynamic invocations of Pointer.load / Pointer.store.
* Disallow implicit downcast of argument passed to Pointer.store.
* Stop zeroing out Pointer.address on Pointer.free().
Issue: https://github.com/dart-lang/sdk/issues/38172
Related issues:
Closes: https://github.com/dart-lang/sdk/issues/35902 (Disallowing dynamic invocations of Pointer ops.)
Closes: https://github.com/dart-lang/sdk/issues/37385 (Function variance checking.)
Change-Id: I96058d8b5b49052eb6999f084372e6f08b4f6f17
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117547
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-07 09:23:54 +00:00
9d55bb6ba7
[vm/ffi] Fix incorrect use of host word size in FFI instructions.
...
Addresses https://github.com/dart-lang/sdk/issues/38718
Will be tested by https://dart-review.googlesource.com/c/sdk/+/120121
Change-Id: Id1a877c254afd029efab57199d5bd6b65fe380f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120260
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-10-06 20:15:43 +00:00
c77c2728dd
[vm,aot,bytecode] Handle inferred-type metadata when generating bytecode
...
Change-Id: Ifadb25c782db5c95025e7275daf0676abd73cf49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120341
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-10-06 16:51:43 +00:00
418b646749
[vm/debugger] not pausing exceptions on implicit throw
...
Ignoring exceptions that coming from implicit throw. For example, try finally block will generate an implicit throw inside finally block to rethrow the exception.
Bug: https://github.com/dart-lang/sdk/issues/37645
Change-Id: I5c4f90ec3c9aa92bb670d4bb9a8edb332f7b32fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118911
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2019-10-05 00:33:32 +00:00
38f78c01f3
[ dart:developer ] Updated parentId argument for timeline events to use base64 to be consistent with async ID formatting
...
Change-Id: I96314f5712b722da5188c0a447a12c9c5fe6064b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120322
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2019-10-04 23:27:22 +00:00
143aa4bdb4
[vm/fuzzer] don't print oom on oom
...
Rationale:
exit code suffices, don't make it more likely
that the oom handler itself goes oom
https://github.com/dart-lang/sdk/issues/38657
Change-Id: I3037c8e781da06d05b74eddd8b1d57ff9fb00f29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120301
Reviewed-by: Felicitas Hetzelt <felih@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-10-04 20:38:57 +00:00
65b9109255
[vm/fuzzer] avoid codedup in fuzzer
...
Change-Id: Ie49819b0d7b83c1050be61c385b4668141d099a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120300
Reviewed-by: Felicitas Hetzelt <felih@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-10-04 20:30:47 +00:00
836d9bf168
Reapply "[vm, bytecode] Fix missing dependencies in --snapshot-deps output."
...
Avoid Windows path differences. Skip for simulators (i.e., running from kernel file instead of source).
Change-Id: I7045591f026c392d92f2ec3247ed5b6e1b5e25df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120023
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-04 19:30:06 +00:00
28f21d4e99
[vm/bytecode] correct source position of clearAsyncThreadStackTrace
...
source position of clearAsyncThreadStackTrace should not have a valid source position.
This fixes code coverage regression.
Bug: https://github.com/dart-lang/sdk/issues/38628
Change-Id: I41b1822a07b9d4becdda58bb810f03733289cd2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120002
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-10-04 03:12:53 +00:00
7a7dcd1ed9
[vm/fuzzer] Several tweaks to reduce timeouts
...
Rationale:
Disable non-flat types, reduce number of iterations,
decrease limit for emitsmallpositiveint.
[vm/fuzzer] Disable *= in loops for string types
Change-Id: I9b406a1e3d34fce0cec65083aa7b24dfc80967cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119980
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Felicitas Hetzelt <felih@google.com >
2019-10-04 00:49:43 +00:00
d2738bf9f0
[vm, gc] Reserve ForwardingPages up front.
...
Allocate space for ForwardingPages when allocating a new HeapPages that is subject to compaction, instead of allocating it at compaction time, which is when we're already low on memory.
This has a 4KB/256KB = 1.5% overhead for ordinary pages, no overhead for large and code pages.
Bug: https://github.com/dart-lang/sdk/issues/37772
Change-Id: I9ce4d0791093df8ee98d9bda17f0a1cc33788e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114020
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-10-04 00:29:34 +00:00
1d5bdb2cee
Revert "[vm, bytecode] Fix missing dependencies in --snapshot-deps output."
...
This reverts commit f2e32b5e65https://dart-review.googlesource.com/c/sdk/+/120004
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
> Reviewed-by: Alexander Markov <alexmarkov@google.com >
TBR=rmacnak@google.com
Change-Id: I0848e2fc5dd4623b2e9d2913ed211cc1da5b73e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120022
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-04 00:21:17 +00:00
f2e32b5e65
[vm, bytecode] Fix missing dependencies in --snapshot-deps output.
...
Change-Id: Ib0bcb43f52e0a086174f508222d60b894a5855f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120004
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-10-03 22:59:02 +00:00
56a28260fd
[ Observatory ] Fixed issue where timeline save functionality was consistently failing
...
Timeline save functionality was broken after a recent redesign of how
CPU samples are pushed over the service protocol. When the save button
on the timeline page was clicked, the "traceObject" variable was
undefined, causing the save to fail.
Fixes https://github.com/flutter/flutter/issues/41746
Change-Id: Icd3e9c841431c790dd7f49107f0c5d39f0088cd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120000
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2019-10-03 21:28:12 +00:00
7376167b2a
Revert "[vm/compiler] Fix Code equality comparison in DedupInstructions."
...
This reverts commit 4cd5d773dehttps://dart-review.googlesource.com/c/sdk/+/119844
> Auto-Submit: Teagan Strickland <sstrickl@google.com >
> Reviewed-by: Martin Kustermann <kustermann@google.com >
> Commit-Queue: Teagan Strickland <sstrickl@google.com >
TBR=kustermann@google.com ,sstrickl@google.com
Change-Id: I5ab180ddd40fecf769d544184dfffeb034bc2eeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119941
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-10-03 19:43:15 +00:00
b2bf860e56
[vm/ffi] Fix FfiCall on ARM_X64.
...
Fixes https://github.com/dart-lang/sdk/issues/38690
Change-Id: I597361ed611885bcf93584a76f8baaf1108e7026
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119940
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-03 18:51:33 +00:00
4c614c7c44
[vm, bytecode] Don't suppress the interpreter on IA32 or ARM.
...
Interpreter support was added in 975cc65c1724df9cc588https://dart-review.googlesource.com/c/sdk/+/119763
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-03 17:26:45 +00:00
c1f691c797
[vm, bytecode] Saturate context ids instead of issuing a compile-time error.
...
The bytecode encoding allows for 8-bits of context id, but this limit is exceeded in Flutter test code. Context ids are as yet unused, but will be used to disambiguate variables at the same position in different contexts.
Change-Id: I64130c11ddf04495b2719aa6f4809fa64ff135c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119728
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-03 16:57:33 +00:00
4cd5d773de
[vm/compiler] Fix Code equality comparison in DedupInstructions.
...
Change-Id: Ide07e8dd174cec407b2f19346330985b612f098e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119844
Auto-Submit: Teagan Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Teagan Strickland <sstrickl@google.com >
2019-10-03 16:49:13 +00:00
e87f3407c8
[ dart:developer ] Added optional parent parameter to TimelineTask constructors.
...
Specifying a parent will result in an argument being added to 'start'
events for that TimelineTask named 'parentId', which contains the task
ID of the parent. This is to be used by DevTools to show relationships
between asynchronous tasks that are not currently supported in the trace
event format used by Catapult.
Change-Id: Id0a030f018f5a6ac1e3b0ef2e89c1cd732790f02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119520
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-10-03 16:33:38 +00:00
07a63a17a4
[vm,aot,bytecode] Handle procedure-attributes metadata when generating bytecode
...
Change-Id: I26e1a15d979ce13ca60298de28ced49b6882cf52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119765
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2019-10-03 16:27:33 +00:00
afac6a3714
Re-land "[vm] Use ELF loader in dart2native."
...
Fixes symbol resolution on Darwin.
The original commit is in patchset 1.
Change-Id: If71e9a72b8a2f45db2591bfa45ec4018745ee2c4
Cq-Include-Trybots:luci.dart.try:dart-sdk-mac-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119646
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-03 13:40:12 +00:00
5c106e3098
[vm, fuchsia] Add timezone support in Fuchsia SDK builds
...
Previously Fuchsia did not expose a timezone API in their public API.
Support for the existing private APIs was added in:
https://fuchsia-review.googlesource.com/c/fuchsia/+/284531
https://fuchsia-review.googlesource.com/c/fuchsia/+/284654
as fuchsia::deprecatedtimezone. A replacement API has not yet been added
to the public SDK.
This resolves b/141224241.
Change-Id: I50d3cb61f869508a6cf90e918c5af001a27192f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119820
Auto-Submit: Chris Bracken <cbracken@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2019-10-03 04:33:59 +00:00
375c4a9657
[vm/fuzzer] Disable CC for most types
...
Change-Id: I7ab01cd7ca2d5f9ec23f5be9dfbe7c4dfc7b46a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119768
Commit-Queue: Felicitas Hetzelt <felih@google.com >
Reviewed-by: Aart Bik <ajcbik@google.com >
2019-10-03 00:12:02 +00:00
22479a17ff
[vm/fuzzer] Sort generated tables.
...
Change-Id: I5f8cac14ffeb05f12889a42706de02a40b72cd75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119727
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Felicitas Hetzelt <felih@google.com >
2019-10-02 23:27:41 +00:00
9050e28bf0
[vm/fuzzer] Avoid STRING *= large number in loops
...
Change-Id: I2048b1c888a9656107bcee6a966f4658c9bab4a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119740
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Felicitas Hetzelt <felih@google.com >
2019-10-02 23:25:01 +00:00
1ed707703d
[vm/bytecode] Mark try blocks generated for try/finally as synthetic
...
This matches behavior of AST-based flow graph builder. Debugger ignores
synthetic (is_generated) try blocks when it figures out if thrown
exception is unhandled, so in order to ignore all try/finally blocks
they should be marked as synthetic.
Fixes https://github.com/dart-lang/sdk/issues/38697
Change-Id: I06840362a255b500e1e9317af90a61bbdea2a310
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119726
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-10-02 23:15:11 +00:00
97bb624cfe
[vm] Rebuild type testing stubs if their fast path starts failing
...
When type testing stub is generated it captures whatever subclasses are
present at this moment. As program continues running, new classes could be
loaded and finalized. This is especially true in bytecode mode with
its more lazy class loading. So type testing stubs could get outdated and
will fall back to slow path. This could cause performance regressions as
slow path is (1) slower :) and (2) it populates and uses SubtypeTestCache,
which has a limited capcity (controlled by max_subtype_cache_entries flag).
Once SubtypeTestCache overflows type checks are not longer cached which
makes type checks at particular location significantly slower.
The solution is to rebuild specialized type testing stub in TypeCheck
runtime entry after fast path failed but check succeeded.
Change-Id: Ied166e19be2870acef7a066b83bb73931bd1073d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119184
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-02 21:09:33 +00:00
f46e5ee44e
[vm/fuzzer] Make num type non instantiable
...
Change-Id: I7ea37b58f1a3464ff4565219268f1a8bf3b04672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119720
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Felicitas Hetzelt <felih@google.com >
2019-10-02 21:04:04 +00:00
7e99f49629
[vm/compiler] general rbit utilities
...
Rationale:
Useful to implement the simulator, but also useful
in the future when compiler wants to constant fold
operations related to bit reversal.
https://github.com/dart-lang/sdk/issues/38346
Change-Id: I2f09ba6b1897202b5c07a2cff771afd7bbc99495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119703
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-10-02 20:37:10 +00:00
9e738b94b4
[vm] Remove #include from elf_loader.h so it can be used imported in Flutter.
...
Change-Id: I72ff785709ee1f5f5fbbd57d2433ca96e9866470
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118986
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-10-02 20:11:20 +00:00
2c3f0fc359
[vm/assembler] Add rbit to ARM32
...
Rationale:
We are adding library support for bit operations:
lowZeroBitCount/highZeroBitCount/nonZeroBitCount
The rbit on AM32 will enable very efficient direct
native implementations of these operations in the
DartVM codegen.
https://github.com/dart-lang/sdk/issues/38346
Change-Id: Icedf4af301b5c8011922fccb1530a9c28e5c0964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119600
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-10-02 17:34:10 +00:00
Ryan Macnak