Commit Graph

18 Commits

Author SHA1 Message Date
Zach Anderson 56f87f409e [dart:io,fuchsia] Pass Isolate namespace to child process. Fix double free.
Before this change, the child process inherits the namespace of the
process. After this change the child process inherits the namespace of
the calling isolate.

Related: DX-710

Change-Id: Idbc72e30f5796f8034cedae776d4572ad0b0360f
Reviewed-on: https://dart-review.googlesource.com/c/89460
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2019-01-15 22:07:51 +00:00
Ryan Macnak fa6a1684ef [vm] Introduce a separate VMTag for the interpreter.
Makes time spent in interpreted versus compiled Dart code visible in Observatory's pie chart. Will allow the profiler to know whether to start a stack walk from the machine code FP or the interpreter's FP.

Remove dead Dart 1 frontend tags. Add tag for loading bytecode.

Change-Id: I2c5a580e1581f8ccd5a93bb293899c81f900ef13
Reviewed-on: https://dart-review.googlesource.com/c/83564
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-11-09 01:58:54 +00:00
Brett Wilson d99aeb3e13 [kernel] Update Fuchsia suspend to use new API.
The old zx_task_suspend is being replaced with zx_task_suspend_token
which eliminates the possibility that suspends can get leaked due to
crashes.

Change-Id: Ib7df2494a013b899c98d03d9ceeb0cc9de2ea6b4
Reviewed-on: https://dart-review.googlesource.com/60204
Reviewed-by: Zach Anderson <zra@google.com>
2018-06-14 16:08:31 +00:00
Doug Evans cc1a817faa Use ZX_THREAD_STATE_BASIC on state output of ZX_INFO_THREAD.
Change-Id: I0429ad208cddb0cb21db293fd798cb872f71b305
Reviewed-on: https://dart-review.googlesource.com/58560
Reviewed-by: Zach Anderson <zra@google.com>
2018-06-05 19:53:21 +00:00
Brett Wilson 84b3e8923a [system api] Update thread state API usage.
The out param has been removed from Zircon and the structs and defines
renamed.

Change-Id: I9d6eaed2119b2c232f77b86f9b0d4a311be531c6
Reviewed-on: https://dart-review.googlesource.com/38782
Reviewed-by: Zach Anderson <zra@google.com>
2018-02-05 22:19:37 +00:00
P.Y. Laligand 1356fa56e5 Fix one more Fuchsia syscall.
Change-Id: I5d64e5b642b8ced71b1c7003bf8565372774c076
Reviewed-on: https://dart-review.googlesource.com/38481
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-02-04 07:11:03 +00:00
P.Y. Laligand c854daf611 Update a type for a Fuchsia syscall.
Change-Id: I92993e5e7bc60fee02b9301b8069ac2b94995020
Reviewed-on: https://dart-review.googlesource.com/38440
Reviewed-by: Zach Anderson <zra@google.com>
2018-02-03 23:34:39 +00:00
Ryan Macnak 3609522166 printf format checking is a compiler feature, not a platform feature.
Change-Id: Ib3e0beb814b5cae6f2b4be13f055069f682674f5
Reviewed-on: https://dart-review.googlesource.com/11645
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-09 22:26:01 +00:00
George Kulakowski 7800d2a995 Rename Magenta to Zircon, along with related abbreviations
Change-Id: Ic4215ceb00f5a60d21ec1398fd398a9f78a9eb94
Reviewed-on: https://dart-review.googlesource.com/6100
Reviewed-by: Zach Anderson <zra@google.com>
2017-09-15 14:54:18 +00:00
Zachary Anderson 15ba173993 [Fuchsia] Rename MG-nnn -> ZX-nnn
Change-Id: Ia84cd53ef3dcfd13a7feb22178583e00705a4e4b
Reviewed-on: https://dart-review.googlesource.com/5290
Reviewed-by: Zach Anderson <zra@google.com>
2017-09-12 20:28:12 +00:00
Zachary Anderson 6cd8a79078 VM: Re-format to use at most one newline between functions
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2974233002 .
2017-07-13 08:08:37 -07:00
Zachary Anderson a834e6dcf3 Update Fuchsia-specific code to use the new MX_ error names
R=zra@google.com

Review-Url: https://codereview.chromium.org/2935483002 .
2017-06-09 13:19:54 -07:00
Zachary Anderson 5e8799ce81 [Fuchsia] Enable CPU profiling for the standalone VM
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2916313003 .
2017-06-05 14:45:41 -07:00
Zachary Anderson f6ca2fc63a [Fuchsia] Fix arm64 build
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2897173006 .
2017-05-24 12:12:49 -07:00
Zachary Anderson 904aefe6e3 [Fuchsia] Implements the thread interrupter for CPU profiling.
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2796143002 .
2017-05-23 10:22:07 -07:00
Ryan Macnak 877284947b Rename TARGET_OS_* to HOST_OS_*.
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.

Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2750843003 .
2017-03-15 13:11:05 -07:00
John McCutchan 95a8166523 Disable the profiler when a debugger is attached
Fixes #28702

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2682343002 .
2017-02-09 10:11:52 -08:00
Zachary Anderson a503570e3a Fuchsia: Initial check-in.
Instructions to build and run are in README.fuchsia.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2117593002 .
2016-07-01 12:42:05 -07:00