de2ef79d56
Revert "More allocation tracing unit tests"
...
This reverts commit d14e50b9c7https://codereview.chromium.org//1293383010 .
2015-08-20 11:47:55 -07:00
d14e50b9c7
More allocation tracing unit tests
...
- Context allocation unit test.
- Class allocation unit test.
- Adjust behaviour of RecordAllocation when we haven't exited Dart code and we aren't profiling the VM to match the sampler.
R=iposva@google.com
Review URL: https://codereview.chromium.org//1297693003 .
2015-08-20 11:10:37 -07:00
935e11be24
Fix VM profiler for simulator builds.
...
BUG=
Review URL: https://codereview.chromium.org//1280023003 .
2015-08-10 13:13:33 +02:00
a1798f7e45
Enable native stack walking for allocation profiling
...
- Use native stack walker for allocation profiling when --profile-vm is passed
- Helpers for retrieving SP, FP, and PC registers
- Refactor sampler code to share more code between allocation sampling / interrupt sampling
- Export all symbols into the dynamic symbol table for run_vm_tests (already doing this for Dart executable)
R=regis@google.com
Review URL: https://codereview.chromium.org//1274663004 .
2015-08-06 13:31:56 -07:00
4665285ac2
VM: Remove unused private field to fix build.
...
TBR=rmacnak
BUG=
Review URL: https://codereview.chromium.org//1247453005 .
2015-07-23 13:05:25 +02:00
8d38a58c18
Make array allocation stub shared between isolates.
...
This allows to make the last explicitly named stubs shared between isolates.
When sharing code stubs, we can't do patching at their entry anymore.
Therefore, I had to remove patching support of the array allocation stub.
Is this a functionality we want to keep?
The change is mostly performance-neutral because optimized code has an inlined fast
path for array allocation and only uses the stub for the slow-case.
The only isolate-specific stubs left are object allocation stubs which are
associated with their Class are per-isolate.
Since this CL removes any isolate-specific stubs from StubCode, it becomes AllStatic.
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//1247783002 .
2015-07-23 12:56:16 +02:00
26b5b2e95b
Introduce mechanism to record an allocation of a class
...
- Use a bit in RawClass to remember if we are tracing allocation for this class.
- Add Profiler::RecordAllocation
- Add a simple heartbeat test for Profiler::RecordAllocation
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1211633002 .
2015-06-24 13:41:12 -07:00
7f7fcf03ee
Begin transition to ProcessedSample in Profiler
...
- Introduce ProcessedSample and ProcessedSampleBuffer
- Visit SampleBuffer *once* and build ProcessedSampleBuffer
- Stop altering the SampleBuffer when processing samples
- Beginning of support for chained samples
- Use ProcessedSampleBuffer instead of SampleBuffer for all passes in the ProfilerService. More cleanups here will follow.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1202943002 .
2015-06-24 06:54:39 -07:00
50842cd27a
Add storage of class id and state bit to the profiler's Sample
...
- Stop storing sp and fp in Sample. Both are not used after the stack walk
- Add AllocationSample bit to Sample's state_
- Add a metadata_ field to Sample
- Use metadata_ to store a class id when AllocationSample bit is set
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1199473003 .
2015-06-23 06:47:39 -07:00
baa34257fc
Track prologue offset of Code and use for more precise return addresses
...
- Remember the prologue offset in the Code object.
- Size of Code object does not change.
- Use the prologue offset to assist in locating the return address of the current frame.
- Prologue offset + instruction pattern matching will be accurate for all Dart code, most intrinsic prefixed Dart code, and some stub code.
- By default only collect Dart frames (normal Dart developers only care about Dart frames)
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1150633002
2015-05-21 18:35:19 -07:00
3f694c96ba
Attempt to fix Windows Dartium #2
...
BUG=
Review URL: https://codereview.chromium.org//1129903007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45802 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 22:47:21 +00:00
282fab7f41
Move stack walker construction outside of SEH try block
...
- Attempt to fix Dartium Windows build.
Review URL: https://codereview.chromium.org//1146433005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45798 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 22:22:59 +00:00
84b615d4fc
Use Structured Exception Handler on Windows to gracefully handle guard page faults
...
- set profile_vm flag to be true by default to make sure crashes on bots are taken care of.
R=koda@google.com
Review URL: https://codereview.chromium.org//1131233005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45771 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 19:36:53 +00:00
2c4dfb60c8
Don't attempt to walk the native stack by default.
...
This was unintentially enabled by default as a consequence of
https://codereview.chromium.org/1104323003/
BUG=23368
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1130253005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45666 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 22:34:17 +00:00
44bb8bf95f
Enable profiler by default on Android, and reduce profiler sampling rate for Android, ARM and MIPS.
...
Raspberry Pi 1 B+ (700MHz single-core ARMv6)
--profile_period=1000 DeltaBlue(RunTime): 231748.1111111111 us.
--profile_period=10000 DeltaBlue(RunTime): 117826.64705882352 us.
--profile_period=20000 DeltaBlue(RunTime): 111494.05555555555 us.
--profile_period=50000 DeltaBlue(RunTime): 101028.45000000001 us.
--profile=false DeltaBlue(RunTime): 100488.70000000001 us.
Raspberry Pi 2 B (900MHz quad-core ARMv7)
--profile_period=1000 DeltaBlue(RunTime): 19612.676470588238 us.
--profile_period=10000 DeltaBlue(RunTime): 18774.51401869159 us.
--profile_period=20000 DeltaBlue(RunTime): 18611.314814814818 us.
--profile_period=50000 DeltaBlue(RunTime): 18940.10377358491 us.
--profile=false DeltaBlue(RunTime): 18242.463636363635 us.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1108123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45432 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 21:45:51 +00:00
d5bace63ad
Support profiling of simulated Dart code on mips, arm, and arm64.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1107753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45430 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 19:55:53 +00:00
b69bab6a6f
Fix memory leak in CPU Profile page
...
- Programmatically clear all onClick listeners.
- Use an iterative call tree loader.
- Load call trees on demand.
- When a sample was filled before exhausting the call stack, mark that the sample's call stack is truncated.
- Insert '[Truncated]' tag nodes into call trees.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//973553005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44190 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 19:00:20 +00:00
78ad7f347b
Improved profiler view and inclusive profile tree
...
TableTree improvements:
- Row's have flex-box divs in each table cell.
- To represent depth in tree a colored vertical bar for each depth level is shown
- Expanding tree nodes is now asynchronous and animates.
- Change cursor during tree expansion.
Observatory Profiler improvements:
- Improved appearance.
- Support for inclusive (main first) call trees.
- Replace tooltip hover with info toggle.
- Visual icon attributes for code, functions and call tree nodes.
- Fetching / Load status display.
- Cleaned up Code and Function kinds.
Profiler improvements:
- When not profiling the VM (--profile-vm) only walk the stack when we are in Dart code or have exited Dart code. This removes some native stack walker noise.
- Build inclusive (main first) call trees and send across service.
Notes for analyzer team:
Analyzer command line:
./out/ReleaseIA32/dart --keep-code --trace-profiler --profile-depth=128 --observe out/ReleaseIA32/dart-sdk/bin/snapshots/dartanalyzer.dart.snapshot --dart-sdk=out/ReleaseIA32/dart-sdk pkg/compiler/lib/src/dart2js.dart
Profiler settings:
- Tags: None or VM
- Mode: Function
- Direction: Bottom up
R=asiva@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//965593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44152 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 23:01:43 +00:00
4c03dad8e6
Fix Win64 flakey crash related to reading from stack guard page.
...
Avoid reading from stack if we aren't executing Dart code.
BUG=
Review URL: https://codereview.chromium.org//958183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44074 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 20:41:40 +00:00
f2333f63a5
Add Function based profile tree
...
Profiler improvements:
- Track Functions in profile and build Function based trie
- Associate code objects with functions
- Created cpu_profile.dart library
- Major speed improvements for disassembly view
- Fix truncation of disassembly comments
- Ability to get code object ticks from disassembly view
- Inlining mini-map in disassembly view.
- Remove a bunch of unused data from profile service response
- In some cases a caller PC that is better than the PC marker is inserted into the stack trace
- Inlined functions are expanded
- Ability to clear profile
- New flag '--keep_code' which keeps deoptimized code around for use by the profiler.
General fixes:
- Fix caching in service library
- Remove pubspec.yaml before running pub get
R=asiva@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//928833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44067 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 18:48:55 +00:00
c2da2d9830
Make ASAN/MSAN ignore Dart frames.
...
Frames initialized by generated code are unknown to ASAN/MSAN, so we must explicitly mark it as initialized.
For some (unknown) reason, this only caused failures on the build bot.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//915723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43661 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 18:43:27 +00:00
420aa94c56
Split profiler.cc into profiler.cc and profiler_service.cc
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//864173008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43623 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 23:22:19 +00:00
e65e6fab9d
Begin migrating the vm service from a rest-style interface to a json-rpc style interface.
...
BUG=
Review URL: https://codereview.chromium.org//823403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43370 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:15:40 +00:00
bedcc03afb
Remove unsupported --profile-dir flag and related code
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//877143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43198 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 18:31:41 +00:00
81ce3ffef4
Speedup profile generation for stress test benchmark by 176x
...
Processed 779753 frames
CodeTables: live=9604 dead=5345 tag=51
FixTopFrame took 158092 millis.
CodeRegionTableBuilder took 13616 millis.
CodeRegionExclusiveTrieBuilder took 283 millis.
CodeRegionTableCallersBuilder took 57 millis.
CodeTableStream took 5637 millis.
~176 seconds
--- Fix PageSpace::FindObject to fast path executable pages
Processed 648584 frames
CodeTables: live=9398 dead=4655 tag=45
FixTopFrame took 68401 millis.
CodeRegionTableBuilder took 6401 millis.
CodeRegionExclusiveTrieBuilder took 222 millis.
CodeRegionTableCallersBuilder took 45 millis.
CodeTableStream took 267 millis.
~74 seconds
--- Fix PageSpace::Contains to fast path executable pages
Processed 690756 frames
CodeTables: live=9329 dead=5310 tag=49
FixTopFrame took 234 millis.
CodeRegionTableBuilder took 173 millis.
CodeRegionExclusiveTrieBuilder took 265 millis.
CodeRegionTableCallersBuilder took 60 millis.
CodeTableStream took 331 millis.
~1 second
R=iposva@google.com
Review URL: https://codereview.chromium.org//839833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42672 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 21:39:49 +00:00
a1faa84c2a
Make all tests pass ASAN.
...
Unpoison additional locations touched by profiler's stack walking.
Use return value of Isolate::GetProfilerStackBounds.
Commands to build and test:
export CXX="third_party/clang/linux/bin/clang++ -fsanitize=address -fPIC"
gclient runhooks
./tools/build.py -m debug -a x64 runtime
ASAN_OPTIONS=handle_segv=0 python tools/test.py --report --time --mode=debug --arch=x64 --compiler=none --runtime=vm --failure-summary --write-debug-log --write-test-outcome-log --copy-coredumps --exclude-suite=pkg --checked
R=iposva@google.com
Review URL: https://codereview.chromium.org//813163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42635 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 15:44:26 +00:00
08edbbd6b4
MemorySanitizer support.
...
Enables building (including generating snapshot) and running simple scripts under MemorySanitizer.
Not all tests pass yet.
R=asiva@google.com
Review URL: https://codereview.chromium.org//816123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42561 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-23 01:07:58 +00:00
456bdc4ea3
Enable the profiler on the simulator
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//718393005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41752 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-14 23:15:00 +00:00
816bf5af2e
Fixes for the profiler on arm64.
...
On arm64, in Dart code, R18(SP) is the stack pointer.
In C++ code, R31(CSP) is the stack pointer.
The profiler must choose the right one when performing
its bounds checks.
This change also fixes a bug in the InvokeDartCode stub
on arm64 so that CSP is set to the Isolate's stack
limit immediately, rather than a bit later. When it was
set a bit later, if a profiler interrupt came in in the
interim, the stack would be smashed.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//583683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40502 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 16:25:16 +00:00
3c6822fde3
- Keep track of stack base whenever Dart code is invoked.
...
- Update stack limit based on stack base.
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//506933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39613 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 18:28:47 +00:00
4d5f3ba638
vmservice protocol cleanup
...
user_name -> name
name -> vmName
Also, vmName is now only provided when it differs from name.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//487023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39525 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 18:53:43 +00:00
14ecdbd66a
- Separate the thread implementation used in bin/ and vm/
...
to allow us to make VM specific changes.
R=asiva@google.com
Review URL: https://codereview.chromium.org//463993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39172 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 23:19:53 +00:00
207752927d
Disable ProfilerNativeStackWalker on Win64
...
BUG=
Review URL: https://codereview.chromium.org//455873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39041 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 16:50:04 +00:00
26376a1e58
Don't try to read return address from the stack of another thread on Win64.
...
This is not safe unless we are inside the Dart code.
Remove incorrect code that was trying to guard against STATUS_GUARD_PAGE_VIOLATION by checking FP.
BUG=http://dartbug.com/20421
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//451033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39035 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 13:43:08 +00:00
ae9b2a9dd5
Add build configuration variable 'c_frame_pointers' to control whether or not frame pointers are included and which stack walker the profiler uses.
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//414303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38711 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 22:48:57 +00:00
6f0b2bb2a9
Profiler tweaks
...
* Rename Script tag to Dart tag.
* Respect ignore bit on samples.
* Mark samples collected with an exit frame.
* Don't give exclusive CPU ticks to top frame on samples collected from an exit frame (because CPU usage is in the native code we've called out to not the function waiting to return).
R=asiva@google.com
Review URL: https://codereview.chromium.org//418433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38522 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 21:09:25 +00:00
28c8553cb6
- Fix a lot of warnings generated by -Wshorten-64-to-32
...
when compiling for ia32 on Mac.
R=vegorov@google.com
Review URL: https://codereview.chromium.org//415513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38499 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 14:10:13 +00:00
2abbaca938
Add Dart stack walker that relies on frame pointers.
...
* It is used only when we don't have a top exit frame and we have the script tag set.
* Steps across exit frames and only collects Dart frames.
R=asiva@google.com
Review URL: https://codereview.chromium.org//408663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38475 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-22 21:08:22 +00:00
98a959ff35
Really fix the build
...
BUG=
Review URL: https://codereview.chromium.org//408493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38412 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-18 21:11:45 +00:00
597caa1754
Fix build breakage introduced in r38409
...
BUG=
Review URL: https://codereview.chromium.org//403003003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38411 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-18 21:04:36 +00:00
86bf7bb898
Profiler cleanup
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//397163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38409 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-18 20:55:24 +00:00
e7ddd5d047
Move some isolate state setup from C++ code to JumpToExceptionHandler stub (take 3).
...
- CL is the same as take 2, but, I now prohibit the profiler from walking the call stack when the isolate is executing the jump to exception handler.
R=asiva@google.com
Review URL: https://codereview.chromium.org//395233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38300 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-16 18:03:17 +00:00
7366afd86e
Revert r38240
...
BUG=
Review URL: https://codereview.chromium.org//393103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38257 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 20:48:20 +00:00
efc684e4a8
Move some isolate state setup from C++ code to JumpToExceptionHandler stub
...
This change means that the isolate's top exit frame info and vm tag will only be updated after setting the frame pointer.
This is step one in a series of changes to allow the profiler to walk the stack when there is no frame pointer.
R=asiva@google.com
Review URL: https://codereview.chromium.org//393693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38240 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 16:39:19 +00:00
9812f8a581
- Enable top exit frame profiler mode by default
...
- Final Windows fixes for using StackFrameIterator from different thread.
R=asiva@google.com
Review URL: https://codereview.chromium.org//360373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37918 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 22:21:43 +00:00
ef2adfc5c6
Allow StackFrameIterator to be used on a different thread than the isolate whose stack frames are being iterated over.
...
This is necessary to be able to use this in the profiler.
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//354063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37886 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 17:38:13 +00:00
59a859c2e8
Switch to old stackwalker until Windows crashes are fixed
...
BUG=
Review URL: https://codereview.chromium.org//351363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37769 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 22:47:47 +00:00
70e89dc996
Use Dart stack walker when we have an exit frame.
...
This makes the profiler more Dart developer friendly (but less VM developer friendly).
Also, fixes a bug where the top exit frame info would be invalid after an exception occurs.
The flag: --profile-vm allows for profiling of VM internals.
R=asiva@google.com
Review URL: https://codereview.chromium.org//341083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37767 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 22:06:34 +00:00
c897df4e7b
Make size of sample variable based on the profile depth flag.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//345713006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37553 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 14:46:54 +00:00
e3f564fb6c
Changes for running tests on arm64 hardware.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//311413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37046 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 18:43:55 +00:00
John McCutchan