cb522bfcd2
[vm] Update Windows synchronization code to CONDITION_VARIABLEs and SRWLOCKs.
...
Use CRITICAL_SECTIONs for dart::bin::Monitor as the event handler requires a recursive monitor.
Requires Vista or later.
Bug: https://github.com/dart-lang/sdk/issues/35029
Bug: https://github.com/dart-lang/sdk/issues/35118
Change-Id: I1e96c5b428257649a45d26a979fba53a10f02151
Reviewed-on: https://dart-review.googlesource.com/c/20901
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-11-09 18:44:49 +00:00
07852532e3
[ VM ] Additional cleanup in Dart_Initialize and Dart_Cleanup
...
Change-Id: I6dc02b3d9de16cc176eb97613bc0c7f0bb9b16eb
Reviewed-on: https://dart-review.googlesource.com/77013
Commit-Queue: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2018-09-28 23:18:59 +00:00
6cd8a79078
VM: Re-format to use at most one newline between functions
...
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2974233002 .
2017-07-13 08:08:37 -07:00
a1bcf051d8
clang-format runtime/vm
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2481873005 .
2016-11-08 13:54:47 -08:00
103881d01c
Make header include guards great again
...
i.e. #ifndef VM_WHATEVER -> #ifndef RUNTIME_VM_WHATEVER
This lets us remove a hack from the PRESUBMIT.py script that existed
for reasons that are no longer valid, and sets us up to add some
presubmit checks for the GN build.
R=asiva@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2450713004 .
2016-10-26 00:26:03 -07:00
5f59a954f8
Uses an open thread handle as the ThreadJoinId on Windows.
...
Also:
- Reaps exited threads in the thread pool before putting
a thread on the idle list so that a new arriving task
isn't blocked on a supposedly idle thread in the middle
of a join.
- Stops trying to join eventhandler threads on
Windows. Now that we're using the correct exit() call,
we probably don't have to worry about exit code pollution,
so joining the threads is unnecessary.
related #26400
R=asiva@google.com , iposva@google.com
Review URL: https://codereview.chromium.org/1978153002 .
2016-05-17 13:18:13 -07:00
59fd6c8397
VM: Small clean up and const-ness fix for Thread/OSThread constants.
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org/1482243006 .
2015-12-02 12:30:12 +01:00
a0c50a1836
Fix Windows take 3
...
BUG=
Review URL: https://codereview.chromium.org/1408743007 .
2015-10-16 13:11:46 -07:00
5cc6d83127
Fix windows take 2
...
BUG=
Review URL: https://codereview.chromium.org/1410103002 .
2015-10-16 12:49:22 -07:00
d3f71ec939
Fix windows build
...
BUG=
Review URL: https://codereview.chromium.org/1411813002 .
2015-10-16 10:21:04 -07:00
e36b9fa3bf
Complete support for Windows TLS destructors
...
- Maintain a list of TLS destructors that should be run when a thread exits.
- Walk that list on thread exit and invoke destructors.
R=asiva@google.com
Review URL: https://codereview.chromium.org/1410493002 .
2015-10-16 10:00:44 -07:00
7093f2996b
VM thread shutdown.
...
BUG=
R=iposva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//1275353005 .
2015-09-15 12:49:52 -07:00
24f227d38e
Rename more friend declarations.
...
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//844763007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42896 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:45:51 +00:00
c7e9e048ed
Rename Thread -> OSThread.
...
It's a collection of static utility methods for primitive operations on OS threads.
Make room in the namespace for upcoming class that will represent all the complex state of a VM thread.
Review URL: https://codereview.chromium.org//796063006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42895 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:30:07 +00:00
Ryan Macnak