1e72c0f6c4
Disable applyAuthorStyles
...
This allows us to remove the dependency on bootstrap.css (removal of bootstrap.css from third_party will happen in follow up CL).
As a side effect of this, the following changes have occurred:
- Removed Google Charts Table from allocation profile pane.
- Add a SortedTable view-model (used in allocation profile).
- Changes to CPU profile tree view.
- Consolidate string formatting utility functions.
There is some UI regression (font size is one size too small) that will have to be addressed in follow up CLs.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//237683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35266 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 16:01:14 +00:00
7840906011
Revert "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)."
...
Review URL: https://codereview.chromium.org//246173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35238 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 00:08:52 +00:00
69d82c334b
Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation).
...
Ensure invocation_fuzz_test doesn't exit prematurely.
Also visit instance methods defined in superclasses.
Complete blacklist so invocation_fuzz_test passes on the VM.
B=http://dartbug.com/15274
R=iposva@google.com
Review URL: https://codereview.chromium.org//241993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35234 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 23:24:17 +00:00
fdaf1b59bf
Undo r35207
...
Review URL: https://codereview.chromium.org//243583008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35208 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 16:03:52 +00:00
1606fce42f
Add TraceBuffer log to all Functions (plus small tweaks to function-view)
...
BUG=
R=srdjan@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//227423005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35207 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-21 15:57:09 +00:00
110570e9fe
Fixes a problem with the recovery of contexts in the debugger at closure calls.
...
When we call a closure, the caller saves the context before the call.
So when walking the stack, we used to check the callee activation to
see if it was a closure call, and then recover our caller-saved
context.
This breaks down in the following case:
1. Caller calls function F.
2. Function F is compiled.
3. The compiler needs to run code to evaluate a constant (e.g. a
static final getter).
4. We hit a breakpoint *while* evaluating the constant.
In this case, there is no callee frame for the closure call yet.
I fix this by using the the pc descriptors to see if the current pc in
the caller is a closure call. This avoids needing to have a callee
frame available.
---
ALSO:
New flags:
--verify-incoming-contexts: in development - verify assumptions about
contexts in stub code. (currently ia32 only)
--trace-debugger-stacktrace: this helps debug these kinds of
stacktrace issues.
Miscellaneous improvements to frame and context printing.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//240213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35130 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-16 20:03:30 +00:00
a561e2bd17
1. Provide a framework to traverse persistent prolog weak handles.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//231053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35066 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-15 16:32:55 +00:00
8f0056371d
Initial UserTag and dart:profiler library
...
R=asiva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//230863005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34949 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 22:32:45 +00:00
ef666553a1
Add runtime and native entry tags
...
- Split runtime and native entry tags.
- Set runtime / native entry address as vm tag in stubs.
- Add reverse native entry resolver (pc to name) to public API (breaking change).
- Hookup reverse resolver for standalone VM (io + bootstrap + builtin natives).
- Runtime entries are registered with tags.
- Profiler queries for tag names via the reverse native entry resolver.
- Profiler outputs named entry tags as children under parent tag (runtime or native).
R=asiva@google.com
Review URL: https://codereview.chromium.org//227433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34941 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 20:26:45 +00:00
79a5307d5b
VM: Implement closure calls as instance calls.
...
Conceptually f() becomes f.call() where the .call method performs the actual
closure call. The closure call itself is implemented without a stub.
The check if the object called is a closure becomes a class-id check
which can be hoisted out of loops.
R=iposva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//227723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34917 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 10:56:00 +00:00
91388a5f79
Simplify and fix instantiation of recursive types.
...
Add tests for non-contractive types.
Cleanup language tests status file.
Enhance tracing of type finalization.
R=hausner@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//224793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34739 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-04 18:27:53 +00:00
2fe51715e5
Begins work on ARM64, first assembler test.
...
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}
The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.
R=regis@google.com
Review URL: https://codereview.chromium.org//221133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
cc9e3b8068
Introduce a lazy-compile stub for functions.
...
The function's code pointer is either a lazy-compile stub
or the compiled code. The function is compiled on invocation.
There is no need to check for null when invoking a function. This means
one check less when invoking functions via a stub. For this I added a LazyCompile
stub.
Additional cleanup in Stackmap and PcDescriptors (remove unused code pointer,
and changed smi-lengh into a raw integer).
R=zra@google.com
Review URL: https://codereview.chromium.org//203523011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34643 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 12:37:48 +00:00
b373e6c423
Change how we provide value previews in the vm service.
...
Rename the 'preview' property to 'valueAsString'.
Rework printing so that we only add 'valueAsString' when we need it
(num, String, etc.).
Change ToUserCString to be a String-only method. Drop ToUserCString
for lists -- it was hokey and unused. Max string length is now 1024
instead of 40.
Update tests.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//219333011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34612 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 19:45:57 +00:00
bb6003d9b7
Fix line number table generation for multiline strings with interpolation.
...
Share the line number table generation code between debugger and vm service.
R=hausner@google.com
Review URL: https://codereview.chromium.org//219993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34606 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 18:16:27 +00:00
6daac5a3e2
Fix code invalidation for deferred code
...
Review URL: https://codereview.chromium.org//217483008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34545 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-29 00:25:16 +00:00
f0626388f5
VM: Evaluate metadata on a class in the scope of its library not the scope of the class.
...
BUG=http://dartbug.com/17795
R=gbracha@google.com , hausner@google.com
Review URL: https://codereview.chromium.org//217543004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34537 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:38:32 +00:00
3e86631f02
Use tokenPos instead of line/col in the vm service.
...
Add line number information to the Script response.
Parse line number information in the observatory.
Update <script-ref> to take a pos argument
Add a new <script-inset> element which shows a code snippet.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//216883008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34528 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 21:24:24 +00:00
3adcbe1071
Rework the <field-view> page.
...
Give fields/functions a consistent notion of ownership.
Add field's script to the JSON.
Make page reload work again.
Fixup closure printing a bit.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//215213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34520 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 20:21:09 +00:00
9c105f7c9c
Handle creating ParameterMirrors for the parameters of forwarding constructors.
...
BUG=http://dartbug.com/17823
R=hausner@google.com , regis@google.com
Review URL: https://codereview.chromium.org//212883009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34494 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 01:22:03 +00:00
ed24226376
Support deferred library prefix syntax
...
First step towards deferred library support:
- Parse the “deferred as” import clause.
- Implement p.loadLibrary() which returns a future that
completes when the library is loaded.
- Treat type annotations of deferred types as malformed.
- Throw NoSuchMethodError when calling functions from
unloaded libraries.
- Libraries are still read synchronously, but items in the
library won’t be visible through the deferred prefix until
the future returned by loadLibrary() completes.
Review URL: https://codereview.chromium.org//208323015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34481 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 21:20:47 +00:00
f60ab4dd11
Detect and reject illegal recursive types (non-contractive types).
...
Fixed instantiation and equality of recursive types.
Added many asserts to detect issues with recursive types.
Disabled bad tests. They declare illegal types and will be fixed in a later cl.
R=hausner@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//211963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34460 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:38:18 +00:00
99fca31c02
Support Types in instance-ref/instance-view.
...
Refactor JSON printing for all instances to share more code. This allows Types to act like Instances in Observatory.
Update the look and feel for the function-view page.
Add script info for functions.
Update tests.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//211283004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34435 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:13:03 +00:00
ffdca5647a
Fix PrintToJSONStream for oddball functions
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//196173022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34338 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:58:45 +00:00
23d06d9db0
Rework how ServiceObjects are created and cached in Observatory.
...
We now use a single cache, rather than per-type caches which simplifies the get() logic and makes it easier to add more model-types in the future.
Rework how isolates are created/stored/retrieved. IsolateList is gone.
Add canCache and immutable to ServiceObjects and use them to inform when an object should be cached or reloaded.
Remove cache.dart, service.dart.
Add a notion of a ServiceObjectOwner.
Cleanups.
Etc.
Etc.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//204983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34333 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:42:26 +00:00
38bfed114d
Fix memory-issue String::fromCharCodes, where a GC could invalidate an address.
...
The constructions is now reordered, so the address is not extracted
until after allocation of the new string.
BUG=https://code.google.com/p/dart/issues/detail?id=17602
R=iposva@google.com
Review URL: https://codereview.chromium.org//209003009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34320 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:56:36 +00:00
565a554b02
Make all objects print at least their type in PrintToJSONStream.
...
Also check this in the unit test.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//209093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34315 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 16:57:53 +00:00
d17423903d
Ensure PrintToJSONStream can be called on all heap objects without crashing.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//206003005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34271 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 21:12:38 +00:00
95894fc2e5
Assert that FreeListElement is never wrapped in a handle.
...
Previously, this just crashed with a segfault (since its vtable entry is 0).
R=asiva@google.com
Review URL: https://codereview.chromium.org//207153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34257 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 16:31:32 +00:00
c8ec766bf0
Print inlined tree using --print_inline_tree. Also added Function::ToQualifiedCString which prints only the class and function name.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//206503007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34216 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 23:53:58 +00:00
d302dc431a
Auto delete persistent weak handles during finalization after invoking the callback associated with the weak handle.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//205153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34208 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 21:45:43 +00:00
fe667b6d9a
Support displaying of types in the observatory (back-end only for now):
...
- canonical type arguments cached in the global hash table
- subset of the above, but with cached instantiations
- canonical types cached by the type class
And of course, it should now be possible to display any type, e.g.
field types, function signature types, classes super types, interface types,
etc...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//184653003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34181 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 16:41:59 +00:00
ed690f97b6
Fix canonicalization of types.
...
Add functions retrieving canonical types by their index or vice versa (used by
a future cl supporting types in vm service).
Add getters for type argument instantiations (used by future cl).
R=hausner@google.com
Review URL: https://codereview.chromium.org//203443012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34128 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 18:48:57 +00:00
6952f5ddfe
Use VM tag in profile and add stack trace trie
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//201213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34064 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 21:20:41 +00:00
a2ca78bc3e
Fix http://dartbug.com/17555
...
- Do not try to finalize VM internal classes.
- Do not try to print the script of VM internal class.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//202853007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34035 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 17:55:10 +00:00
7fbb7cd5dc
Rework library and class view pages.
...
Add expression evaluation support for libraries and classes.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//199363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33755 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:43:07 +00:00
37b30ab2ac
Alternative fix for .call invocation of closures.
...
This also covers "closurization" of the .call method.
This relies on the fact that f.call === f if f is a closure.
This means that adding a simple getter to _FunctionImpl that
returns this is enough. No need for a separate dispatch.
This CL reverts the previous fix for issue 12602 (modulo the
additional tests).
BUG=dartbug.com/17473, dartbug.com/12602
R=iposva@google.com
Review URL: https://codereview.chromium.org//200193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33736 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 10:31:33 +00:00
f99c83e54a
Show object pool on code page
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//197853005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33702 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 17:03:38 +00:00
6ea46abd34
Create a shadow table to track CodeRegions of reused code address space.
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//197803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33665 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 21:00:44 +00:00
021fca847c
- Implement a PauseTimerScope so that we can properly exclude
...
times when a TimerScope is active.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//196413011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33662 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 20:38:24 +00:00
e99b7269e7
Stop/restart compilation timer when running Dart code from within the parser. SMall perfromance fix.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//197923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33616 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 21:28:50 +00:00
a73703b08a
Improve the instance-view page in observatory.
...
Add an eval-box element which is used to evaluate expressions.
Support expression evaluation for instances in the vm service.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//194623006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33592 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 17:18:14 +00:00
f75ef2e6ab
Fix invocation of closures via .call in the VM.
...
Calling closures via .call does now work in the VM - it was working in
dart2js already. Calling .call on a closure is implemented to go through
a dispatcher method. These dispatcher methods are automatically created and
cached in the same way as NoSuchMethod- or field-invocation dispatchers.
This CL does not change the way regular closure invocation works in
the VM. It is therefore performance-neutral for normal closure calls.
BUG=dartbug.com/12602
TEST=language/call_test
R=iposva@google.com
Review URL: https://codereview.chromium.org//188703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33576 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 14:02:27 +00:00
25678c7d86
- Fix formatting of generated sources.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//196653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33570 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 09:16:21 +00:00
3f048502d4
Use CHECK_ISOLATE instead of DARTSCOPE for Dart_GetNativeInstanceField after
...
fixing Instance::IsValidFieldOffset to use a reusable handle instead of
creating a new one (this was the issue last time which caused assertions).
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//196243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33566 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 00:14:03 +00:00
01c3d1adcb
Add compile timestamp to Code
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//194813008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33555 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 21:14:24 +00:00
801c26beb4
Unboxed Float64x2 fields and some misc fixes
...
R=srdjan@google.com , zra@google.com
Review URL: https://codereview.chromium.org//195333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33542 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 17:59:45 +00:00
6edd276df8
Switch Observatory to use only ServiceObject instances.
...
All fetched objects are upgraded to a ServiceObject.
ServiceObjectCache.
Uniform updating / refreshing.
Fix UTF8 string escaping in TextBuffer (should fix invalid character bug https://code.google.com/p/dart/issues/detail?id=16590 )
R=turnidge@google.com
Review URL: https://codereview.chromium.org//192443004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33541 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 17:48:09 +00:00
3af18cc4c0
1. Restructure reusable handles to make individual Scopes for each handle type
...
2. Add a convenience macro to make use of reusable handle scopes easier
R=iposva@google.com
Review URL: https://codereview.chromium.org//187503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33471 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-08 00:26:29 +00:00
57dd1321d1
Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
...
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.
BUG=http://dartbug.com/10360
Review URL: https://codereview.chromium.org//189843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
johnmccutchan@google.com