Ben Konyi
9c95624a63
Temporary revert to fix issue #35009 for 2.1. package:rpc relies on mirrors behaviour that is not valid for Dart 2, so these type checks cause the package to crash.
...
Revert "[ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors"
This reverts commit 9f00eec55b .
Change-Id: I82ce07d388ba9402f20caf700815b39c9bc418f6
Reviewed-on: https://dart-review.googlesource.com/c/83225
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2018-11-06 23:59:11 +00:00
Ryan Macnak
e89aeb0352
[vm] Fix profiler tests.
...
Bug: https://github.com/dart-lang/sdk/issues/31137
Bug: https://github.com/dart-lang/sdk/issues/33224
Bug: https://github.com/dart-lang/sdk/issues/33337
Bug: https://github.com/dart-lang/sdk/issues/34493
Change-Id: Iedf6eb71416e50129803f7f9ebd7e2036c7583ef
Reviewed-on: https://dart-review.googlesource.com/c/82528
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-11-05 18:26:02 +00:00
Martin Kustermann
ffbf6b9e61
[Gardening] Mark vm/dart/appjit_cha_deopt_test as slow in debug mode
...
Change-Id: I169ac1a39512f1050819270146d27ec92c95b9f1
Reviewed-on: https://dart-review.googlesource.com/c/82443
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
Auto-Submit: Martin Kustermann <kustermann@google.com >
2018-11-01 13:34:49 +00:00
Samir Jindel
e23acaaf90
[vm/aot] Fix obfuscation.
...
Test Plan:
Make vm-kernel-precomp-obfuscate-linux-release-x64-try green, ensuring status file changes
reflect design gaps and not bugs.
Tested locally that obfuscated Flutter Gallery runs.
Change-Id: Ifcdc334de58f43c310e15b58dbcf6fe1597206f2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/81009
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-26 13:00:33 +00:00
Vyacheslav Egorov
ad60d37dff
[vm] Handle null receiver at call sites that track type exactness
...
Fixes https://github.com/dart-lang/sdk/issues/34755
Bug: 34755
Change-Id: Ic7a32c8628d8c90fe10b6ca92fb2016f41b29c1d
Reviewed-on: https://dart-review.googlesource.com/c/81417
Auto-Submit: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2018-10-25 17:38:44 +00:00
Samir Jindel
d11b74d1f3
[vm] Use unchecked entry-point for super calls.
...
Change-Id: Ie1abd050203f2d9806ebeedbec47292892fc9b0e
Reviewed-on: https://dart-review.googlesource.com/c/79960
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-25 12:48:09 +00:00
Martin Kustermann
8300248edb
[VM] Ensure inferred types are set on parameters
...
Now parameter instructions are part of FunctionEntry/OsrEntry/CatchEntry
instead of GraphEntry.
Change-Id: I27338aaf1d2a9cc3ca61a3817bbb929d0ea6627c
Reviewed-on: https://dart-review.googlesource.com/c/80201
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-16 16:09:48 +00:00
Vyacheslav Egorov
2495e2e951
[vm] Silence output from kernel::Program::ReadFromFile.
...
It is used by hot-reload to check if a file is a kernel binary - so it makes
no sense to output failures to the stderr.
Change-Id: Ie2ebd5ff47990eec950550e333a41aaf5f8d7973
Reviewed-on: https://dart-review.googlesource.com/c/80224
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
Auto-Submit: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-10-16 14:49:01 +00:00
Zach Anderson
dea6c97a08
[vm] A couple more benchmark for kernel loading
...
One that measures the two existing benchmarks together, and one that
measures max RSS.
Change-Id: I2c8e383c1e7f38ea8010f3bd6a4bcbcacb999069
Reviewed-on: https://dart-review.googlesource.com/c/79822
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-10-15 18:57:27 +00:00
Martin Kustermann
06f9a9e354
[VM] Introduce function and osr entrypoints to the VM's IR
...
Similar to how we treat catch entry instructions, this cl adds new
function and osr entry instructions. The [FunctionEntry] and
[OsrEntry] - just like [CatchBlockEntry] - have now their own initial
definitions. The [GraphEntry] has only initial definitions for
constants.
Explicit phis are inserted for all parameter / special parameter
instructions if necessary.
Future work is:
a) Minimize parallel moves due to the phis on parameters
b) Cleanup frame setup: Move it entirely into FunctionEntry/CatchEntry
(instead of the split version we have now)
Fixes https://github.com/dart-lang/sdk/issues/34435
Fixes https://github.com/dart-lang/sdk/issues/34287
Change-Id: Iefa0280a709716f748d6fb0523b8d0f4d8de1fec
Reviewed-on: https://dart-review.googlesource.com/c/74782
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-15 13:02:51 +00:00
Ben Konyi
9f00eec55b
[ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors
...
Fixes issue #32232
Change-Id: Id6c9ea8e72bb66c77a2817f20c33bb405cb4c310
Reviewed-on: https://dart-review.googlesource.com/c/79081
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2018-10-13 16:27:40 +00:00
Alexander Markov
97ffcd9a3d
[vm] Disable incorrect widening of smis to int32
...
The optimization of widening smi operations to int32 does not account
for uses which depend on the range of operation (e.g. BinarySmiOp
which uses the result of widened operation becomes incorrect).
Closes https://github.com/dart-lang/sdk/issues/32619
Change-Id: Ia419c7bbec93679a5cdd1d16ffa3f51824fc08bb
Reviewed-on: https://dart-review.googlesource.com/c/47661
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-11 18:13:42 +00:00
Ryan Macnak
235a918233
[vm] Remove Dart_LoadScript, Dart_LoadLibrary, Dart_LoadSource, etc.
...
Change-Id: I9c19625702f1df48c03de2eb3a0f7bb581d2e0b3
Reviewed-on: https://dart-review.googlesource.com/c/79140
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-10-11 00:38:37 +00:00
Ryan Macnak
b8760fed67
[vm, compiler] Remove ASTs and AST flow graph builder.
...
Change-Id: I4d3c6500577d5285ced327954040dab42ba92341
Reviewed-on: https://dart-review.googlesource.com/c/78823
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-10-10 18:00:21 +00:00
Martin Kustermann
ecd13de9da
[Gardening] Mark slow_path_shared_stub_test as slow (reaches 1 minute on windows)
...
Change-Id: Ibcfa6869f22d546055dcafee6fccd67758ce754b
Reviewed-on: https://dart-review.googlesource.com/c/78980
Reviewed-by: Martin Kustermann <kustermann@google.com >
Auto-Submit: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-10-10 09:55:07 +00:00
Alexander Markov
34651d204e
[gardening] Update status
...
Change-Id: I50470052bd646684d36c793424485a88f1b84ee6
Reviewed-on: https://dart-review.googlesource.com/c/78869
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-10-09 21:24:36 +00:00
asiva
32c484bb71
[VM] Fix typo in BitTestImmediate unit test.
...
Change-Id: Id2dc17e0df20a17c3f37dbf7640f21250b72c88a
Reviewed-on: https://dart-review.googlesource.com/c/78861
Reviewed-by: Aart Bik <ajcbik@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-10-09 18:22:40 +00:00
asiva
de18295924
Adjust some status files for the new build configurations added to the buildbots.
...
Change-Id: I5b80e45780078e5613a7934751173b091e93628f
Reviewed-on: https://dart-review.googlesource.com/c/78707
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-10-09 00:49:41 +00:00
Zach Anderson
b4b02a6bde
[vm] Include bytecode in core-jit and app-jit snapshots
...
when the --enable_interpreter flag is passed to gen_snapshot/dart.
Change-Id: I6e9481e1793e4c97fd6b14b56e55aafcb044fc23
Reviewed-on: https://dart-review.googlesource.com/c/78150
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-10-08 19:51:10 +00:00
Alexander Aprelev
20e57c1bcc
[gardening] Differentiate windows bot test failures on ia32 vs x64
...
Change-Id: I9e7751acb3d68d4916a17eb79f86014a428ba1bf
Reviewed-on: https://dart-review.googlesource.com/c/78401
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-10-06 05:20:49 +00:00
Alexander Aprelev
eddfdd00a4
[gardening] Further windows test status tweaks.
...
Change-Id: I0a438fc8aaa84a648debe0c1832b228b5ec83f5b
Reviewed-on: https://dart-review.googlesource.com/c/78381
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-10-05 22:55:56 +00:00
Alexander Aprelev
ea45756a7b
[gardening] Windows dartk test status update.
...
Change-Id: I30694678354943edeb2effc108bb922ee6fcb093
Reviewed-on: https://dart-review.googlesource.com/c/78342
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-10-05 21:46:58 +00:00
Ryan Macnak
d2e08e4952
[vm] Disable concurrent sweeping when --deterministic is set.
...
Concurrent sweeping introduces non-determinism in heap iteration order, which can affect the result of (e.g.) Symbols::Compact.
Bug: https://github.com/dart-lang/sdk/issues/34638
Change-Id: If5afa41d23b0eabdcd67d0f30d0f8ab1acb3bbd6
Reviewed-on: https://dart-review.googlesource.com/c/77677
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-10-02 23:36:45 +00:00
Vyacheslav Egorov
0b48c4a6ad
[gardening] Mark appjit_determinism_test flaky on IA32
...
https://github.com/dart-lang/sdk/issues/34638
TBR=rmacnak@google.com
Change-Id: I28bd11ec2509385bbed781d53002c737d848adcc
Reviewed-on: https://dart-review.googlesource.com/77580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-10-02 16:02:55 +00:00
William Hesse
6361d9e1c3
Update status for flaky product-mode vm test
...
Bug: https://github.com/dart-lang/sdk/issues/34627
Change-Id: I4cdefdae032b74dd522fd669bb27b076c75b41c5
Reviewed-on: https://dart-review.googlesource.com/77340
Reviewed-by: William Hesse <whesse@google.com >
2018-10-01 09:38:59 +00:00
Samir Jindel
30333c508f
[vm] Fix bug with generic invocation of fields.
...
Change-Id: I644f6a66891cf87853b2e7de784c73292bcb2955
Reviewed-on: https://dart-review.googlesource.com/76661
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2018-09-28 09:50:21 +00:00
asiva
c9f5c3a79e
[VM] Delete access to Dart 1 parser.
...
- delete access to Dart 1 parser
- Skip codegen unit tests as they use the Dart 1 parser
Change-Id: I24f3986fac9c496e231c723c6eaa0704e6a616f5
Reviewed-on: https://dart-review.googlesource.com/77009
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-09-27 23:08:20 +00:00
Ben Konyi
6f3de544ed
[ VM / Hot Reload ] Fixed tests which were crashing periodically. Fixes issue #34599
...
Change-Id: I053701122f4a95ae3d9f27b91134433201bfe8aa
Reviewed-on: https://dart-review.googlesource.com/77004
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2018-09-27 21:47:39 +00:00
Alexander Markov
2742a5d558
[Gardening] Update test status
...
Issue: https://github.com/dart-lang/sdk/issues/34599
Issue: https://github.com/dart-lang/sdk/issues/34606
Change-Id: Ieba1080a23d72b5c05086ece2c1cb5ea2e0ad5be
Reviewed-on: https://dart-review.googlesource.com/77003
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-09-27 18:20:37 +00:00
asiva
7c54fab8a5
Adjust status files.
...
Change-Id: If9432c0b441b06df0873fa2cd7740b95fb1103bd
Reviewed-on: https://dart-review.googlesource.com/76783
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-09-27 02:13:36 +00:00
Ryan Macnak
2f25dcda16
[vm] Remove script snapshots.
...
Change-Id: I5bc692b754c0909de4aa5f05af81b074578b16f4
Reviewed-on: https://dart-review.googlesource.com/76706
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-09-26 22:49:27 +00:00
Ben Konyi
3c4c62d79a
Reland "[VM] Dart_Initialize no longer crashes after Dart_Cleanup"
...
This is a reland of 519ee905f9
Original change's description:
> [VM] Dart_Initialize no longer crashes after Dart_Cleanup
>
> Change-Id: I3cfdab9553aad045f024b6f9aec0b40b08234007
> Reviewed-on: https://dart-review.googlesource.com/75786
> Reviewed-by: Ryan Macnak <rmacnak@google.com >
> Commit-Queue: Ben Konyi <bkonyi@google.com >
Change-Id: Icdd901bf1ab0b675cc5f1497061a2b7b8a05d956
Reviewed-on: https://dart-review.googlesource.com/76561
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-09-26 17:54:45 +00:00
Alexander Aprelev
efe76b272d
[gardening] Update product dartk test status.
...
Change-Id: I2eac965fe2daa982d21f3818694ad490b729e86c
Reviewed-on: https://dart-review.googlesource.com/76587
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-09-26 04:57:01 +00:00
Ben Konyi
b6284b41e3
Revert "[VM] Dart_Initialize no longer crashes after Dart_Cleanup"
...
This reverts commit 519ee905f9 .
Reason for revert: Seeing multiple crashes on Windows
Original change's description:
> [VM] Dart_Initialize no longer crashes after Dart_Cleanup
>
> Change-Id: I3cfdab9553aad045f024b6f9aec0b40b08234007
> Reviewed-on: https://dart-review.googlesource.com/75786
> Reviewed-by: Ryan Macnak <rmacnak@google.com >
> Commit-Queue: Ben Konyi <bkonyi@google.com >
TBR=bkonyi@google.com ,rmacnak@google.com ,zra@google.com
Change-Id: I33ad79dbc3fcf44f93612ff63bd2d8431f6067c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/76342
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2018-09-25 02:17:37 +00:00
Ben Konyi
519ee905f9
[VM] Dart_Initialize no longer crashes after Dart_Cleanup
...
Change-Id: I3cfdab9553aad045f024b6f9aec0b40b08234007
Reviewed-on: https://dart-review.googlesource.com/75786
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2018-09-25 01:20:24 +00:00
asiva
355c73d4ee
[VM] Remove support for option --no-preview-dart-2
...
- option --no-preview-dart-2 will now result in an error
- change aot-assembly build rule to generate AOT snapshot using Dart 2
- generate coresnapshot using Dart 2 (this snapshot is not used yet, next CL which switch the isolate create code to use this snapshot)
- by pass all Dart1 test runs in the status file
- change the default compiler setting in test.py to use dartk
- have test.py not pick up any configuration for --no-preview-dart-2
Change-Id: Ia136943ebfd0fed0c52683b330745b3e2c7a7ce6
Reviewed-on: https://dart-review.googlesource.com/75820
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-09-24 20:38:08 +00:00
Zach Anderson
dba8b37d38
[vm] Benchmark for reading kernel bytecode
...
Change-Id: I07617a553193495fcc4fc0ce4a6382996ee7dc51
Reviewed-on: https://dart-review.googlesource.com/75821
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-09-24 15:54:49 +00:00
Aske Simon Christensen
8385c36d97
Move all int literal parsing and checking code together.
...
Report error for negated hex literals > 2^63.
Optimized common case of web int literal exactness check.
Fixes https://github.com/dart-lang/sdk/issues/33311
Change-Id: Ib72b2dbb21e42489ee2d06b17302daf83d560df1
Reviewed-on: https://dart-review.googlesource.com/72802
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-09-24 11:17:36 +00:00
Zach Anderson
51f2dac483
Reland: [vm] Adds a benchmark for Dart_LoadLibraryFromKernel
...
Adds missing free(), and skips on Windows.
Change-Id: Ie187172b1b9b276477e10d10f2b7f492f009ebfd
Reviewed-on: https://dart-review.googlesource.com/75920
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-09-21 15:48:17 +00:00
asiva
929b2fbc55
Adjust status file to account for CustomIsolates test passing now.
...
Change-Id: Idbcc6456154f01698783890afca068af07782317
Reviewed-on: https://dart-review.googlesource.com/75630
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-09-20 02:26:49 +00:00
Daniel Hillerström
de984e58cb
Type checking for redirecting factories.
...
Implements static semantics for redirecting factories (c.f. §10.6.2 of
the specification). This CL does not include inference of actual type
arguments on redirectees, that is it does not handle the case where
type arguments have been omitted on the redirectee as in this
following example program:
class A<T> {
factory A() = B;
}
class B<T> implements A<T> {
B();
}
Closes https://github.com/dart-lang/sdk/issues/32988 .
Also resolves the second part of
https://github.com/dart-lang/sdk/issues/30579 .
Can possibly also close https://github.com/dart-lang/sdk/issues/11578 .
Change-Id: I5f1fb60510ba6cdc917321239819c1f817b5b85d
Reviewed-on: https://dart-review.googlesource.com/74580
Commit-Queue: Daniel Hillerström <hillerstrom@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-09-19 06:20:20 +00:00
Vyacheslav Egorov
f8a3d802d0
Revert "[vm/kernel] Preserve strong mode types in async transformation"
...
This reverts commit eec96f9076 .
Revert "[vm/kernel] In async transformation check if strongMode is on."
This reverts commit 348ed30efd .
Reason for revert: getStaticType is unreliable in Kernel
R=alexmarkov@google.com
Change-Id: I08b914f947a00923491bb610ed74d6348882554f
Reviewed-on: https://dart-review.googlesource.com/75220
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2018-09-17 22:58:55 +00:00
Ryan Macnak
1741448392
[vm] Skip Profiler_FunctionInline on Mac.
...
Bug: https://github.com/dart-lang/sdk/issues/34493
Change-Id: If06ef55201e57f1e5d19de15a94e260b7f09a075
Reviewed-on: https://dart-review.googlesource.com/75202
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-09-17 18:09:04 +00:00
Vyacheslav Egorov
229d793602
[vm/compiler] Support materializing unboxed variables when entering catch.
...
Previously we tried to rely on the assumption that all variables would be
boxed - so the machinery for setting correct catch-entry state only
supported tagged values and constants. However this both leads to worse code
and is not entirely correct assumption.
This also:
- renames various confusingly named classes: we move away from talking
about "catch entry state" to "catch entry moves" - because we only
record a subset of moves that needs to be performed and that does
not describe the whole state;
- refactors a bunch of associated code to be more readable and maintainable;
- adds documentation about catch implementation in optimized code
to runtime/docs/compiler;
Fixes https://github.com/flutter/flutter/issues/21685 .
Change-Id: I03ae361a1bb7710acbd9f661ae014e663a163c59
Reviewed-on: https://dart-review.googlesource.com/74860
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-09-14 17:39:12 +00:00
Vyacheslav Egorov
eec96f9076
[vm/kernel] Preserve strong mode types in async transformation
...
Async transformation uses dynamic variables in few places (e.g.
for temporaries and for incomming arguments) - which creates
not strongly typed AST with method invocations having dynamic
receivers and non-null interface targets at the same time.
To maintain strong typedness of the AST we insert unsafeCast
when accessing the temporaries.
Bug: https://github.com/dart-lang/sdk/issues/34463
Change-Id: I11e38c128645ebc8acb0c982a80fe4c5c4036673
Reviewed-on: https://dart-review.googlesource.com/75000
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-09-14 17:19:29 +00:00
Vyacheslav Egorov
89fa4739de
[vm/compiler] Disable multiple entry-points
...
Implementation is missing few bits in the register allocator
and causing GC crashes.
Bug: https://github.com/dart-lang/sdk/issues/34435
Change-Id: I4779797351c6853b87a5fef663324973e8a64c99
Reviewed-on: https://dart-review.googlesource.com/74641
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-09-12 17:12:10 +00:00
Martin Kustermann
1cd9cae45e
[gardening] Mark vm/cc/CustomIsolates as Crashing
...
Issue https://github.com/dart-lang/sdk/issues/34424
Change-Id: Ib75ac91ea7a956ca274e23f1d5bfa63f49b80734
Reviewed-on: https://dart-review.googlesource.com/74180
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-09-10 14:11:26 +00:00
Devon Carew
87bbceb3f1
More cleanup of analyzer status file predicates.
...
Change-Id: I047be4db04227d406ade3f206478d382e810cdd4
Reviewed-on: https://dart-review.googlesource.com/72063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-29 22:48:29 +00:00
Samir Jindel
a11e079d4c
[vm] Fix oversight in status file.
...
Change-Id: Icf9631799058ad4c6f1fd465f454950bcc11c8c5
Reviewed-on: https://dart-review.googlesource.com/71406
Reviewed-by: Samir Jindel <sjindel@google.com >
2018-08-24 17:41:41 +00:00
Samir Jindel
cf6c57de40
[vm] Update status file for BitTestImmediate on Windows 32-bit.
...
Change-Id: I0269fe14090515eb77ba18af1932c8c31d2f663f
Reviewed-on: https://dart-review.googlesource.com/71405
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-08-24 17:11:12 +00:00