Commit Graph

1248 Commits

Author SHA1 Message Date
rmacnak@google.com bfd342fd8a Remove MirroredCompilationError from the VM.
Regenerate snapshot test due to removed symbol.

BUG=http://dartbug.com/16562
R=regis@google.com

Review URL: https://codereview.chromium.org//389573007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38202 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 18:00:04 +00:00
mlippautz@google.com 85ce6bffb9 Coverage data for single entities can be obtained by querying:
* script: isolate/id/script/name/coverage
 * class: isolate/id/class/id/coverage
 * library: isolate/id/library/id/coverage

Some numbers (curl on vm service):
 * old base line (full coverage of dart:core + script computing faculty): ~1.2s
 * generation for just the script file: ~12ms
 * generation of dart:core (after executing fac script): ~150ms
 * generation of dart:core-patch/array.dart: ~12ms

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//346003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37676 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 00:06:53 +00:00
mlippautz@google.com e404ee32cf Update tests/vm/vm.status to exclude Coverage_MainWithClass.
BUG=

Review URL: https://codereview.chromium.org//356463007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37671 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 21:35:18 +00:00
mlippautz@google.com 93feacec1b Exclude coverage test from mips.
TBR

BUG=

Review URL: https://codereview.chromium.org//353743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37667 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 19:39:25 +00:00
whesse@google.com a9fcd11101 Update mips status for crashing test
Test vm/cc/JSON_JSONStream_Options is crashing in debug mode on mips hardware.

BUG=dartbug.com/19328
R=ricow@google.com

Review URL: https://codereview.chromium.org//324053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37167 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 08:24:20 +00:00
zra@google.com cc07656a94 Skips snapshot reading benchmark in debug mode for timeout.
Review URL: https://codereview.chromium.org//319173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37080 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 14:48:44 +00:00
zra@google.com ea99b1e6f8 Adds debugger patching to arm64.
Also other small fixes.

R=regis@google.com

Review URL: https://codereview.chromium.org//274043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36003 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-09 23:20:14 +00:00
zra@google.com 5d94e8900f Adds single-precision and SIMD load/store to arm64.
Also adds conversion between double an single-precision floats.

R=regis@google.com

Review URL: https://codereview.chromium.org//269343010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35933 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 19:06:04 +00:00
rmacnak@google.com f4f4713eb8 Put metadata fields in their owner class to maintain the class-field bidirectional relationship asserted Field::PrintJSON.
Extended metadata scope test based on suspicions regarding the ordering of adding type parameters metadata fields versus ordinary fields of a class.

BUG=http://dartbug.com/18652
R=iposva@google.com, regis@google.com

Review URL: https://codereview.chromium.org//269253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35926 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 18:15:33 +00:00
ajohnsen@google.com c98c3cd65b Mark PrintJSON as crashing.
BUG=

Review URL: https://codereview.chromium.org//271453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35797 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 12:09:00 +00:00
hausner@google.com d7524ee0ba Generate escape sequence for non-printable ascii characters
Fix issue 17857.

R=iposva@google.com

Review URL: https://codereview.chromium.org//254553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35411 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 22:55:52 +00:00
lrn@google.com 49853292aa Add crash expectation for test in debug mode due to Issue 17857.
Review URL: https://codereview.chromium.org//225023037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34815 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 09:19:13 +00:00
lrn@google.com 88ba8efed9 Optimize one-byte string's toUpperCase.
R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//213293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34812 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 07:19:33 +00:00
zra@google.com 2fe51715e5 Begins work on ARM64, first assembler test.
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}

The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.

R=regis@google.com

Review URL: https://codereview.chromium.org//221133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
zra@google.com 3eba8b8f77 Avoids MIPS32r2 instructions on MIPS32.
Adds necessary feature detection to tell the difference.

R=regis@google.com

Review URL: https://codereview.chromium.org//211363007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34391 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 21:30:51 +00:00
whesse@google.com e1511e8392 Add more ContentShellOnAndroid entries to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//204103007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34111 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 12:52:21 +00:00
johnmccutchan@google.com 76ef3034d1 Fix VM status
TBR

Review URL: https://codereview.chromium.org//195893039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34072 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:14:42 +00:00
johnmccutchan@google.com 6952f5ddfe Use VM tag in profile and add stack trace trie
R=asiva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//201213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34064 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 21:20:41 +00:00
whesse@google.com 9b1a6aa809 Add mips failures to status files.
BUG=dartbug.com/17440
R=kustermann@google.com

Review URL: https://codereview.chromium.org//203313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33811 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 16:20:36 +00:00
whesse@google.com 04fc336f32 Update mips test status files for new mips build slaves.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//196133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33585 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:21:15 +00:00
fschneider@google.com d6178535b2 Landing: Write protect executable pages in the VM.
Change executable pages to be read/execute but not writable by default.

All pages are made temporarily writable just before a full GC, because both
the mark and sweep phases write to the pages. When allocating in a page and
when patching code, the pages are made temporarily writable.

The order of allocation of Code and Instructions objects is changed so that
a GC will not occur after Instructions is allocated. (A full GC would
render the Instructions unwritable.) A scoped object is used to make memory
protection simpler.

Original CL: https://codereview.chromium.org/106593002/

I added a cc test that is expected to crash.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//136563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32493 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 12:18:06 +00:00
johnmccutchan@google.com 7f75b32faa Mark Service_Coverage as Skip on SIMMIPS
BUG=

Review URL: https://codereview.chromium.org//140253010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31976 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 16:39:22 +00:00
johnmccutchan@google.com c55a51e081 Disable profiler
Review URL: https://codereview.chromium.org//128953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31618 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 18:41:05 +00:00
hausner@google.com c571528323 Make return statements single steppable
Replace the code smashing breakpoints at function returns with a call
to a runtime stub that checks whether the debugger is single stepping.
The call to the stub is only emitted in unoptimized code.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//106053011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31435 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-02 23:31:52 +00:00
hausner@google.com 15e8f121dd Change how debugger handles source breakpoints
- Identify a source breakpoint by a script and a token position
  rather than a function object.
- When a new breakpoint is set, iterate over all compiled functions
  to see whether code breakpoints must be set.

This change fixes issues with functions that get compiled several
times, for example as implicit closures or a copies of mixin
functions or local closures of mixing functions. We did not detect
all duplicates of functions.

Eliminated recently introduced const modifiers in SourceBreakpoint
class. They tend to be in the way because several accessor methods
of SourceBreakpoint compute data lazily and modify the object as a
side effect.

Review URL: https://codereview.chromium.org//117133005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31372 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-26 20:53:58 +00:00
johnmccutchan@google.com 919dc2d6eb * Introduce ThreadInterrupter which calls a TLS set callback when thread is interrupted.
* Threads can only register and unregister themselves with ThreadInterrupter.
* Profiler is no longer involved in interrupting threads. It's just a callback and the buffer.
* Profiler operates lock free using an atomic operation to reserve sample in sample buffer.
* Linux, Mac, and Windows done.

R=asiva@google.com

Review URL: https://codereview.chromium.org//109803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31170 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-16 18:52:15 +00:00
rmacnak@google.com 5e310f4e31 Update mirror tests for removed API and other analyzer warnings.
BUG=http://dartbug.com/14695
R=gbracha@google.com

Review URL: https://codereview.chromium.org//64793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30290 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 19:55:05 +00:00
iposva@google.com 1cae21b556 - Reverting mirror changes.
Review URL: https://codereview.chromium.org//62373008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30029 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 02:07:37 +00:00
iposva@google.com a2d280501e - Reverting mirror changes.
Review URL: https://codereview.chromium.org//63563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30027 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:48:45 +00:00
rmacnak@google.com bc897425e1 Cascaded mirror removal revert.
Review URL: https://codereview.chromium.org//63363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30024 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:20:51 +00:00
rmacnak@google.com 1caa73df59 Remove implementations of mirror methods not in the API from the VM. Update tests.
R=iposva@google.com

Review URL: https://codereview.chromium.org//63063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30005 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 22:30:45 +00:00
rmacnak@google.com 07c3de9310 Mirror implementation removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.
(API was removed in r29492)

R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//23460050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29698 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:01:59 +00:00
rmacnak@google.com 0abc881d9e Mirror API removals: async invocations, mirrorSystemOf(port), Mirror.mirrors.
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//45293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29492 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:14:19 +00:00
kustermann@google.com 94ebff2225 Bugfix in test.dart, adding of specialized test outcomes for analyzer
This CL will:
 - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
   we did not report that the analyzer was missing a warning).
 - make the outcome of running the analyzer on a test be one of:
   * CompileTimeError
   * MissingCompileTimeError
   * StaticWarning
   * MissingStaticWarning
 - Make status file updates using the new Expectation markers
 - Remove support for '@static-clean':
     Previously running the analyer on a test could either result in
     'Pass' or in 'Fail'. The '@static-clean' annotation has been used
     as a (poor) mechanism to distinguish between errors and warnings.
     Having the 4 markers mentioned above means we can remove '@static-clean'
 - Remove 100 lines of rotted legacy code in our testing scripts.
 - Make a status file entry for every test that has analyzer errors or warnings

R=ricow@google.com

Review URL: https://codereview.chromium.org//46163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
floitsch@google.com 6a72655d1b Very simple version of Isolates.
R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//27215002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
iposva@google.com 6267207e64 - Account for hidden frames when concatenating throw and
catch traces.

R=asiva@google.com

Review URL: https://codereview.chromium.org//41503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29218 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:08:33 +00:00
iposva@google.com e8f2abb833 Fix build:
- Dartium is skipping some numbers when creating frames.

Review URL: https://codereview.chromium.org//38833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29140 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 01:16:10 +00:00
iposva@google.com 7fb172b783 - Don't mix the collection of Error.stackTrace with the collection of
the stack trace for try-catch.

R=asiva@google.com

Review URL: https://codereview.chromium.org//38343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29136 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:16:55 +00:00
rmacnak@google.com 879539c348 Skip redirection_type_shuffling_test on dart2js.
Review URL: https://codereview.chromium.org//29103011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28968 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:10:11 +00:00
rmacnak@google.com 7c67d66df1 Skip mirrored_compilation_error_test on dart2js and Dartium.
Review URL: https://codereview.chromium.org//33673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28951 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:00:42 +00:00
rmacnak@google.com 6a0920d2a6 isolate_mirror_local_test no longer fails the analyzer.
Review URL: https://codereview.chromium.org//33053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28948 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:38:40 +00:00
rmacnak@google.com a5fd049d73 Hide MirroredCompilationErrror behind a flag until post-1.0. Remove VM reference to MirroredUncaughtExceptionError.
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//28053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28946 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:12:49 +00:00
rmacnak@google.com 0d23dbc1e2 Make TypedefMirror a direct descendant of TypeMirror.
BUG=http://dartbug.com/11616
R=ahe@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//24005002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28862 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 16:59:55 +00:00
rmacnak@google.com 564fbb68dd Add proper API for creating private symbols wrt a library.
BUG=http://dartbug.com/13355
BUG=http://dartbug.com/12358
R=ahe@google.com, asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//24631003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:56:14 +00:00
rmacnak@google.com 6ed9f2c17f Implement constructor kinds in the VM mirrors.
BUG=http://dartbug.com/13798
R=asiva@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//26436004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28416 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:40:11 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
kustermann@google.com 22d20313b4 Implement testing support for "--compiler=none --runtime=dartium"
This is implemented without the broken unittest-based wrapping of tests.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//25514002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
ajohnsen@google.com fac6baef28 Clean up status file.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//24750003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27956 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 14:35:18 +00:00
kustermann@google.com dfbf264f40 Automatically converted general Fail status file markers to one of the more specific markers
R=johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//23494066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27876 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 12:47:03 +00:00
ajohnsen@google.com 0cc1e648e2 Re-enable VM isolate tests.
BUG=https://code.google.com/p/dart/issues/detail?id=6890
R=ricow@google.com

Review URL: https://codereview.chromium.org//24542002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27868 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 09:20:40 +00:00