dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

774 Commits

Author SHA1 Message Date
Peter von der Ahé fc2f27b52f [gardening] Undo accidental skip. 
Review-Url: https://codereview.chromium.org/2937023002 .
 2017-06-14 14:04:48 +02:00
Peter von der Ahé a14d98ecf5 [gardening] Skip flaky vm tests. 
Review-Url: https://codereview.chromium.org/2941733002 .
 2017-06-14 13:34:37 +02:00
Peter von der Ahé 3c17c44d52 Implement metadata on methods and fields. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2935993002 .
 2017-06-14 08:25:17 +02:00
Karl Klose ffa2713cfc [Gardening] Mark vm/cc/ScriptSnapshotsUpdateSubclasses as crashing on dartk 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2934033002 .
 2017-06-13 10:25:29 +02:00
Bob Nystrom e5263f0c40 Removed uses of removed negated status variables. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2935883002 .
 2017-06-12 16:04:18 -07:00
Peter von der Ahé 96e494d534 Complain about external methods with a body. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2930093002 .
 2017-06-10 10:13:04 +02:00
Ryan Macnak 3b7b05eaa9 [hot reload] Ensure we free the old class table even when there are no shape changes. 
Issue #28349

R=regis@google.com

Review-Url: https://codereview.chromium.org/2925303002 .
 2017-06-08 14:13:29 -07:00
Vyacheslav Egorov 681138e882 Gardening: Mark cc/IsolateReload_TypedefAddParameter as failing with ASAN. 
R=rmacnak@google.com
BUG=https://github.com/dart-lang/sdk/issues/28349

Review-Url: https://codereview.chromium.org/2931823002 .
 2017-06-08 14:03:43 +02:00
Peter von der Ahé f73e2ecf28 Clean up status files. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2928903002 .
 2017-06-08 13:50:30 +02:00
Vyacheslav Egorov 47b1473cbe Gardening: Mark new IsolateReload tests failing in with -c dartk. 
Also fix spelling s/IsolateREload/IsolateReload/g

TBR=rmacnak@google.com
BUG=

Review-Url: https://codereview.chromium.org/2924253003 .
 2017-06-08 10:33:40 +02:00
Martin Kustermann 31d0a74616 Update vm.status to get new vm-kernel-macos builders green 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2931573002 .
 2017-06-07 11:01:57 +02:00
Alexander Aprelev 6573c74301 Reenable vm tests with -cdartk DFE parser. 
This was accidentally disabled in 7e2d9ac85d.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2920733004 .
 2017-06-02 09:34:11 -07:00
Siva Chandra a5aaa7f5eb Update test failures after 3b9cf73. 
BUG=
TBR=aam

Review-Url: https://codereview.chromium.org/2907003002 .
 2017-05-26 22:57:24 -07:00
Bob Nystrom c296f75d10 Revert "Revert "Revert "Revert "Refactor test option parsing code."""" 
This reverts commit 02547656cc.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2904313002 .
 2017-05-26 15:04:55 -07:00
Bob Nystrom 02547656cc Revert "Revert "Revert "Refactor test option parsing code.""" 
This reverts commit 79af418430.

Review-Url: https://codereview.chromium.org/2912563002 .
 2017-05-26 14:46:04 -07:00
Bob Nystrom 79af418430 Revert "Revert "Refactor test option parsing code."" 
This reverts commit d03835783c.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2908833002 .
 2017-05-26 14:18:13 -07:00
Bob Nystrom d03835783c Revert "Refactor test option parsing code." 
This reverts commit 9c2dff8ebc.

R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2909723002 .
 2017-05-26 13:51:26 -07:00
Bob Nystrom 9c2dff8ebc Refactor test option parsing code. 
This doesn’t touch the resulting configuration map, which is what this
is leading up to, but it cleans up the specification and parsing of the
options and removes a lot of redundancy.

Behavior should be the same as it was before, except that all options
now allow both their underscore-separated and hyphen-separated names.
So this is now valid:

test.py --hot_reload --append-logs

Where before, you use to have to do --hot-reload (OK) and
--append_logs (bad, since almost all other options expect hyphens).

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2902023002 .
 2017-05-26 13:36:44 -07:00
Alexander Aprelev b44ae265f7 Update failing mac kernel test status. 
This is caused by vm switch to DFE kernel parser in https://github.com/dart-lang/sdk/commit/16c0db1022ff3294678479e60e3deee2e96dff05.

BUG=https://github.com/dart-lang/sdk/issues/29723
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2908623002 .
 2017-05-26 12:59:58 -07:00
Alexander Aprelev 1333f97b9a Mark more dartk tests as failing with vm switched to DFE parser 
TBR=siva

BUG=https://github.com/dart-lang/sdk/issues/28264

Review-Url: https://codereview.chromium.org/2901103006 .
 2017-05-24 21:54:59 -07:00
Alexander Aprelev 16c0db1022 Revert "Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser."" 
This reverts commit e0cdea811a.

Update status of vm tests, that don't work with DFE yet.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2895153005 .
 2017-05-24 20:16:48 -07:00
Zachary Anderson 7fb361907b [infra] Make gclient runhooks gn for Android on supported platforms 
Make GN run for Android configurations on supported host platforms
on a gclient runhooks. This should fix the vm-precomp-android-* bots

Review-Url: https://codereview.chromium.org/2861363002 .
 2017-05-06 23:52:26 -07:00
Zachary Anderson 1f5a55cb77 Update ASAN status for clang roll 
IsolateReload tests that were failing on x64 asan are now also failing
on ia32 asan.

related #28349

Review-Url: https://codereview.chromium.org/2869583002 .
 2017-05-06 23:05:35 -07:00
Kevin Millikin d562f7ced5 Remove definitions from Kernel canonical names. 
Before: Canonical names contained pointers to the corresponding Kernel
tree which assumed that the whole tree was in memory whenever the
canonical names were.

Now: Canonical names do not contain these pointers.  They were only
really used to perform name-based lookup in the VM's heap so the
canonical name itself is enough.

If we later find that we need to get from a canonical name to its
Kernel tree we can add an offset in the binary (for instance) to the
canonical name or in a separate mapping on the side.

BUG=
R=asgerf@google.com, jensj@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ed77783cd32d55fdad61bf9bc749030847ba9384
Review-Url: https://codereview.chromium.org/2781893004 .
 2017-03-30 09:31:31 +02:00
Vyacheslav Egorov 536c610fd2 Update status files for all test suites for -c dartk / -c dartkp configuration. 
We are going to switch to testing all testsuites instead of just limiting ourselves to

co19 language kernel service

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2780943004 .
 2017-03-29 13:18:57 +02:00
Todd Turnidge 7d6ba6bf1f Make rewind work on DBC 
Closes #27878

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2636443004 .
 2017-03-08 13:15:54 -08:00
Ryan Macnak cfe5e5f075 Include metadata in AOT to expand inline frames in stack traces and provide line numbers. 
Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2687143005 .
 2017-02-13 10:27:36 -08:00
Matthias Hausner 74da383d6f Delete Breakpoint objects, fixing memory leak 
Delete Breakpoint objects from the C heap when they are no longer needed.
Also delete inactive code breakpoint objects more aggressively.

This should fix the memory leaks reported in #28348.

General cleanup of breakpoint handling code and comments.

BUG=#28348
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2689623002 .
 2017-02-10 10:43:24 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Ben Konyi f2fd150ea0 Added new type of unit test, RAW_UNIT_TEST_CASE, which is used for tests that can be flaky if run while the VM is alive. Tests created using the RAW_UNIT_TEST_CASE macro will run after the VM has shutdown to avoid having any worker threads contaminating the test results. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2666133002 .
 2017-01-31 15:16:38 -08:00
Todd Turnidge efcdcb7709 Add Debugger_Rewind_Optimized test. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2664303002 .
 2017-01-31 13:52:23 -08:00
Todd Turnidge bbc2ac93a3 Start adding vm/cc tests for rewind functionality. 
These will make it easier to debug rewind on simdbc64.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2662333002 .
 2017-01-31 12:02:26 -08:00
Ben Konyi 1bb198ccc7 Updated status file to allow malloc hook tests to fail while they are being de-flakified. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2663873002 .
 2017-01-30 11:06:16 -08:00
Siva Annamalai 9a4d616c35 Fix status files to correctly account for asan failure in x64 target only. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2657953002 .
 2017-01-25 16:12:52 -08:00
John McCutchan a47af8ea9e Fix memory leaks in cc/Log_* tests 
Fixes #28347

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2651013002 .
 2017-01-25 13:32:28 -08:00
Zachary Anderson 82bddc3614 Fuchsia: Update vm and language status files 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2651803004 .
 2017-01-24 22:03:18 -08:00
Ben Konyi cfd27042da Fixed incorrect update to status file 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2654933002 .
 2017-01-24 14:24:10 -08:00
Ben Konyi ff5f6147bc Gardening: updated status file to deal with flaky cc/UseDartApi test randomly crashing. See issue 28499. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2651673007 .
 2017-01-24 12:33:28 -08:00
Martin Kustermann a9fbe2004d VM: Tell lsan about mmap()ed regions used for our heap 
The mmap()ed pages hold pointers to `VirtualMemory` objects. So we tell
lsan that the mmap()ed regions are roots.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2646363005 .
 2017-01-24 12:47:36 +01:00
John McCutchan dc83d0ad7a Use a better stack bound in DartEntry::InvokeFunction 
Fixes https://github.com/dart-lang/sdk/issues/28282
Fixes https://github.com/dart-lang/sdk/issues/28304

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2639673003 .
 2017-01-18 06:43:21 -08:00
Ryan Macnak 26a364f998 Support spawnUri in app snapshots. 
- Don't mark core_isolate_snapshot_buffer as a const pointer.
 - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2637193002 .
 2017-01-17 15:59:41 -08:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots." 
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
 2017-01-13 15:52:36 -08:00
Ryan Macnak cf3e91fe39 Fix leaked script in cc/EmbeddedScript. 
Fixes #28345.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2630863002 .
 2017-01-13 15:28:42 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots. 
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
 2017-01-13 15:18:27 -08:00
Ryan Macnak 89986c0b03 Fix memory leak in ServiceTestMessageHandler. 
Guard against potential double-free.

Fixes #28342

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2629413003 .
 2017-01-13 15:08:02 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots." 
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
 2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots. 
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
 2017-01-13 10:37:51 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Ryan Macnak f12527455d Fix leaks in some parsers tests and triage remaining cc tests. 
Issue #28342
Issue #28345
Issue #28347
Issue #28348
Issue #28349

R=zra@google.com

Review-Url: https://codereview.chromium.org/2627713005 .
 2017-01-11 13:12:32 -08:00
Regis Crelier f5c80237e3 Status update: profiler tests pass on windows x64 debug, but one crashes on 
mac debug x64.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2621583003 .
 2017-01-09 13:43:38 -08:00