b17e8ca9f7
[vm/tests] Speed up / filter slow vm/dart/minimal_kernel*_test
...
This test runs gen_kernel tool to compile itself with global
optimizations enabled. Such compilation is quite slow by itself, and
in various modes such as debug mode or hot-reload testing mode it takes
even more time and causes flaky timeouts on various bots.
This change replaces script being compiled with a small Dart script.
Also, the test is filtered on various slow configurations.
Fixes https://github.com/dart-lang/sdk/issues/41352
Change-Id: I45a6c7965f3ad84f75e4aa1315c9a3d00ea97cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142553
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-07 05:14:58 +00:00
a8251f820b
Skip minimal_kernel* tests on sim* architectures
...
These newly added tests use gen_kernel which is too slow if it is
running on simulated architectures.
Change-Id: Icc4cb53ddd4ac42515b4daa91d6acdd4f9259288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142450
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-06 03:34:00 +00:00
6f24f88ef9
[vm] Add --minimal-kernel option to kernel compilers
...
New option can be used instead of --aot to produce a tree-shaken
minimal .dill file which can run on the VM in JIT mode.
Can be used along with --no-link-platform and --gen-bytecode to further
decrease size of the .dill file.
Change-Id: I35e8d81263a5e223decf160d79322c06cfd27321
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140740
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2020-04-06 00:54:40 +00:00
55659b0372
[vm] Make our AOT pipeline work independent of the FLAG_precompiled_mode
...
Closes: https://github.com/dart-lang/sdk/issues/36521
Change-Id: I8f56d7bc9f3bfc7f4a6f0dcbee66f99838dde3cb
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-linux-debug-x64-try,vm-kernel-linux-release-simarm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136622
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2020-03-25 11:58:20 +00:00
b951498903
[vm/aot] Allow static methods to have unboxed args and return
...
Static methods and constructors may receive unboxed parameters.
This change adds a bitmap to the RawFunction object indicating
which parameters are unboxed and their types. Also, the stack frame
bitmap was updated to include new bits for those parameters.
The ArgumentsDescriptor object was updated to store not only the number
of arguments, but also their size, since 32-bit platforms would use two
words for each int64 and double value.
In addition, static methods that return non-nullable integers
and doubles may return these values unboxed.
Dart AOT x64:
TypedData.Uint8ClampedListViewVarBench +11.73%
DeltaBlue +9.32%
Meteor (Intel Xeon) +4.64%
Flutter release android-armv8:
velocity_tracker_bench -2.32% (less is better)
flutter_gallery_readonlydata_size +0.18%
flutter_gallery_total_size +0.13%
flutter_gallery_instructions_size +0.12%
Issue https://github.com/dart-lang/sdk/issues/33549
Change-Id: I97e310f8f30213920af2333fbdedf193d03db5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135313
Commit-Queue: Victor Agnez Lima <victoragnez@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-03-05 15:17:04 +00:00
cd7d248061
[infra] Skip dart/trigger_gc_in_native_test on TSAN bot.
...
This multitest crashes on the bot, but not locally. The bot repeatedly fails to locate the core dump for this test, but succeeds for other crashes, and keeps the bot purple.
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: I2896f20de720f187d692c48c9a3232289cf19a67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138105
Reviewed-by: Alexander Thomas <athom@google.com >
2020-03-03 19:36:05 +00:00
608604589c
[vm, gc] Fix a lock order inversion detected by TSAN.
...
If a thread acquires both a freelist lock and the pages lock, ensure it acquires the freelist lock first.
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: Iadd7c270e18052aa32d883db1ddb8e4ebd1f0c49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138041
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2020-03-03 18:30:23 +00:00
f5669caec7
[vm, gc] Skip splay_test on reload bots because it is too slow.
...
Change-Id: Id806ee37898cd2b76bbb360c27354e94b2e308dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137726
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-28 01:03:28 +00:00
ed441e48d0
Update all Slow tests to be Slow, Pass.
...
Change-Id: I610b272355b045eab80cf941210774fb12d775eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134103
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2020-02-01 00:17:42 +00:00
c359b5943a
[vm, service] Fix and enable more services tests.
...
Change-Id: I3e96b3fdcb30def43c7b87183a925bd1668fb6a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133087
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-01-24 01:59:01 +00:00
8a39cb8f66
[vm] Enable multiple entry-points on IA32.
...
Issue https://github.com/dart-lang/sdk/issues/34162
Change-Id: If3ca8448012dd1e3dc6e5f638e24202f53ccaf60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129716
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-01-07 17:05:44 +00:00
f134164332
[vm] Enable multiple entry-points on ARM64.
...
Adresses https://github.com/dart-lang/sdk/issues/34162
Change-Id: I7126f8c9b470041aaa260255293327f67d64d1bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128063
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-12-19 16:41:24 +00:00
a846098c18
[vm] Enable ELF loader to read snapshots from memory without any backing file.
...
Also build Dart_LoadELF_Fd on Linux as well to get minimal coverage for Fuchsia.
Change-Id: I4be3eeae3e4559e95413fd60a26b9e6d2edabb32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127644
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-12-10 12:26:05 +00:00
4d95ec1360
[vm] Enable multiple entry-points for unoptimized calls.
...
This also makes the entrypoints tests less sensitive to the order in which
functions are optimized and removes flaky checks.
Fixes https://github.com/dart-lang/sdk/issues/37144 .
Fixes https://github.com/dart-lang/sdk/issues/39447 .
Change-Id: I5ba23c74769ddb8415e2b635caefc798c2b70500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109704
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-11-28 13:55:34 +00:00
c5b87f2a01
[vm] Disable entire test (apparently status files can no longer disable individual multitests)
...
Change-Id: I9f7be990c28a76e124b8a54b7bcc0df76d64b9fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125406
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-11-15 16:58:48 +00:00
5f18b77d39
[vm/reload] Disable vm/dart/isolates/spawn_function_test/0 until full IG reloading is implemented
...
The test explicitly passes --enable-isolate-groups (off by-default in JIT).
It will be enabled once full hot-reload with multiple isolates in one IG is implemented.
Change-Id: I8c71a948406f6911c450161a3b5b0b0c0519b0d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125403
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-11-15 15:54:55 +00:00
ebc6340e36
[gardening] Skip bytecode_with_ast_in_aot_test on crossword-ast bot
...
Fixes https://github.com/dart-lang/sdk/issues/39199
Change-Id: I290d286d0cb2a04cf516ed1c4b5b6db03dcac1c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123887
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-11-01 17:17:12 +00:00
8a09d7ab5a
[vm/bytecode] Remove alignment of sections in bytecode
...
Previously, before switching to compact encoding of bytecode
instructions, we had to align bytecode instructions by 4.
Since that time sections of bytecode binary were aligned.
However, this alignment doesn't work well in AOT mode if dill file
contains both bytecode and AST, as other metadata (such as obfuscation
prohibitions) may precede bytecode metadata and may make the whole
bytecode binary misaligned.
This results in incorrect calculation of section offsets,
failed assertion
assert(writer.offset - start == section.offset);
and VM may fail to load bytecode binary with error
bytecode_reader.cc: 1368: error: unreachable code
In order to fix these problems, extra alignment of bytecode
sections is removed.
Change-Id: Iaa3b7c46999615aaa446781a7018db409261ead8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123686
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-10-31 21:37:44 +00:00
c885bdde1d
[vm] DBC is obsolete. Remove dead code.
...
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-27 18:18:29 +00:00
1cf7c40d32
[vm] Fix crash when AST constant references a not yet loaded bytecode class
...
Classes declared in bytecode are loaded lazily. So, in case there is
a mix of bytecode and AST kernel files, it's OK if AST constant
references a class which is not loaded yet, if that class is declared in
bytecode.
Change-Id: I6e28da7c6a97d19d88e16d6cd8abd0e9b61df388
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122847
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Aart Bik <ajcbik@google.com >
2019-10-25 19:55:09 +00:00
e62c7ae3bb
[infra] Add legacy AST mode builder to the test-matrix.json
...
This also removes the now redundant bytecode testing from the dartkb
builders.
Replace the useKernelBytecode boolean option with a more flexible
genKernelOptions string list option.
See also See also https://dart-review.googlesource.com/c/sdk/+/122321/ for the
corresponding Luci config updates.
Change-Id: Iabb207bc02637b758c42c00ae9175bd52f46559f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122320
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-25 15:11:00 +00:00
17b5ddeeb8
[SDK] Adds tests for async stacktraces.
...
Bug: https://github.com/dart-lang/sdk/issues/37668
Change-Id: Id29704d086dbae066c8b34e347b75cd374b1ce2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121986
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-24 13:38:34 +00:00
e82fedc345
[vm] Remove deprecated (and untested) ARMv5 support from the VM
...
Since we have no CQ/CI test coverage of ARMv5 and none of our customers
uses it, a breaking change request was made (see issue further down).
The breaking change has been approved and a corresponding email has been
sent out:
https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ
This CL removes any armv5 related code from our codebase.
Closes https://github.com/dart-lang/sdk/issues/36666
Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-10-23 14:44:33 +00:00
2a12a13d96
[Test] Skips emit_aot_size_info_flag_test on crossword.
...
This should cycle vm-kernel-precomp-mac-release-simarm_x64 green again.
#gardening
Change-Id: I48b12d7cd015fff75756dc2e2a28ca4f2d98fcbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122390
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-10-22 13:00:21 +00:00
6f44e99f6e
[vm/aot] Add test which passes both AOT size information flags --print-instructions-sizes-to/--write-v8-snapshot-profile-to
...
It was reported that passing both flags would sometimes crash
gen_snapshot. This test can ensure it works and continues to work.
Change-Id: Ib58685e815a628efb786a001b91e48728d4b5a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122142
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-10-21 21:19:18 +00:00
65bf2f0bcd
[VM] Fix name demangling in AOT mode.
...
Change-Id: I7e6fd25aa6073fefa0151728e30e465cf312d2cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121776
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2019-10-15 22:29:04 +00:00
fa3f88efe9
Fix AOT build breakage (new extension method names were failing as demangling is not done in AOT builds).
...
Change-Id: Ifa4432fb22934cbf451addb63c8ef2b82432e956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121651
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-10-14 22:49:22 +00:00
5fad012d02
[gardening] Skip slow vm test in hot-reload mode.
...
Change-Id: Ib3bc25f3fe7c5261daa117aa1287aea4b98c84b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121415
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2019-10-11 23:39:29 +00:00
836d9bf168
Reapply "[vm, bytecode] Fix missing dependencies in --snapshot-deps output."
...
Avoid Windows path differences. Skip for simulators (i.e., running from kernel file instead of source).
Change-Id: I7045591f026c392d92f2ec3247ed5b6e1b5e25df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120023
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-04 19:30:06 +00:00
1d5bdb2cee
Revert "[vm, bytecode] Fix missing dependencies in --snapshot-deps output."
...
This reverts commit f2e32b5e65https://dart-review.googlesource.com/c/sdk/+/120004
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
> Reviewed-by: Alexander Markov <alexmarkov@google.com >
TBR=rmacnak@google.com
Change-Id: I0848e2fc5dd4623b2e9d2913ed211cc1da5b73e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120022
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-10-04 00:21:17 +00:00
f2e32b5e65
[vm, bytecode] Fix missing dependencies in --snapshot-deps output.
...
Change-Id: Ib0bcb43f52e0a086174f508222d60b894a5855f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120004
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-10-03 22:59:02 +00:00
a9a9765eb3
[gardening] Skip dart/run_appended_aot_snapshot_test on simarm_x64
...
This test assumes `gen_snapshot` is available in the build folder where
the test gets run from. Though simarm_x64 is special in that only
test.py knows about the location of the right `gen_snapshot`.
Therefore we skip this test on simarm_x64 (which is '$builder_tag ==
crossword").
Change-Id: I677c781a970dec358f593c4504051ac515d48d0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116961
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-09-12 09:23:21 +00:00
46b58397f8
[Runtime] Adds appended blob runtime mode.
...
The Dart runtime will be able to load snapshot blobs appended at the end of
itself.
This is a step on the way to a self-contained native executable.
Tested:
$ dart2aot hello_world.dart hello_world.aot
$ <Some steps to hand-craft appended binary ..>
$ dartaotruntime_plus_hello_world.bin
Hello, world!
python tools/test.py -n dartk-linux-debug-x64 vm/dart/run_appended_aot_snapshot_test
Change-Id: I79d5500c4e2668da31cf1d27145296d17470e04c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112382
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-09-11 10:56:57 +00:00
89ad636b58
Remove the old "preview Dart 2" flags from the test runner.
...
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)
Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2019-09-05 16:59:43 +00:00
2e2d5bcca6
[vm] Make v8_snapshot_profile_writer_test less flaky and avoid user error with crossword config.
...
Fixes https://github.com/dart-lang/sdk/issues/37834
Change-Id: Ida9010a8294f2ab6e06969c671575f80c58b6697
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114850
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-08-29 12:03:43 +00:00
896c053803
Enable vm/cc tests on dartkb bots
...
Change-Id: Ibde7a25180c550b556b98ef70ed611d42f4acd97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112651
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-08-12 16:19:06 +00:00
fedd74669a
[vm/bytecode] Support multiple entry points when compiling from bytecode
...
DeltaBlueClosures +26.54%
Closes https://github.com/dart-lang/sdk/issues/36889
Issue: https://github.com/dart-lang/sdk/issues/36429
Change-Id: I8920c7985366a2c955a06013aa9f58763fcbced9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109580
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-07-20 00:05:23 +00:00
09418f4402
[vm/tests] Re-enable tests for multiple entry points, take 2.
...
Closes https://github.com/dart-lang/sdk/issues/37144
This is a re-land of 00eb034de7https://dart-review.googlesource.com/c/sdk/+/109584
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-07-19 00:21:35 +00:00
38deecec39
Revert "[vm/tests] Re-enable tests for multiple entry points"
...
This reverts commit 00eb034de7https://github.com/dart-lang/sdk/issues/37144
>
> Change-Id: I9935db44cf01dda106c9211978dca33aac7fcb16
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109551
> Reviewed-by: Ryan Macnak <rmacnak@google.com >
> Commit-Queue: Alexander Markov <alexmarkov@google.com >
TBR=rmacnak@google.com ,alexmarkov@google.com ,sjindel@google.com
Change-Id: I582c014c4e02216be1575609aa950e8afb7e0702
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109600
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-07-18 23:16:21 +00:00
00eb034de7
[vm/tests] Re-enable tests for multiple entry points
...
Closes https://github.com/dart-lang/sdk/issues/37144
Change-Id: I9935db44cf01dda106c9211978dca33aac7fcb16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109551
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-07-18 22:11:10 +00:00
2b3336b51e
[vm/compiler] Initial IL serialization implementation.
...
Adds the --serialize_flow_graphs_to flag, which takes a
filename to which to serialize all compiled functions.
This flag is only active for the AOT compiler.
Bug: https://dartbug.com/36882
Change-Id: Ib7e328ad93373168806539f0a61ec0a07506a51d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107400
Commit-Queue: Teagan Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-07-17 09:11:15 +00:00
c6bc0031f3
[vm, bytecode] Field initializer for schema changes.
...
Bug: https://github.com/dart-lang/sdk/issues/32299
Change-Id: Id6359ad36db183f4cdd091e7fd778c879e868d99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108901
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-07-15 22:58:16 +00:00
1112cc6bf5
[gardening] Skip vm/dart/transferable_test on debug win ia32 bot.
...
This is performance test and on this particular bot it's performance is
unpredictable.
Change-Id: I39465e50240f89904de7ee59de3a05966c90aa7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108980
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-07-12 20:22:29 +00:00
205b7787df
skip tests in precompiled obfuscated bot
...
Change-Id: Ie9bd64ea77fb51c6df7b704a12a514ac7d6e14d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108685
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2019-07-10 22:36:50 +00:00
8d07009931
[ VM / Gardening ] Mark disassemble_determinism_test as slow on Windows
...
Test is consistently timing out and likely just needs a little extra
time to complete on slower bots.
TBR=asiva@google.com
Change-Id: Ib4bc67bf699947164494674437ef63005cbbbd91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108440
Reviewed-by: Ben Konyi <bkonyi@google.com >
2019-07-09 15:01:58 +00:00
182a59cebb
Skip all tests that use spawnUri when running in simulator mode as it makes no sense to run the CFE on the simulator.
...
Change-Id: Ie3457e67fe4ddb3170bf4654effdc5b21dff2450
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107942
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-07-02 17:32:23 +00:00
0674955f48
[Test] Unskip vm/dart/issue_31959_31960_test on -sim* bots
...
The workload in the test was reduced, so it may be possible to run
it on sim* architectures.
Change-Id: I6eadae05081cf250f758bf0e79b3b0738ab62da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107463
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-06-27 18:19:15 +00:00
1cadf4bc58
[test] Skip vm/cc tests on opt-counter bots.
...
These tests started running with the opt-counter flags in 91c2c3537bhttps://dart-review.googlesource.com/c/sdk/+/107456
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-06-27 01:12:54 +00:00
91c2c3537b
[vm, bytecode] Plumb bytecode mode flags to VM unit tests.
...
- Make tests using eval fail instead of timing out.
- Collect allocation stats in the interpreter.
- And various EnsureDeclarationLoaded.
Change-Id: I17377216cd6dde2615b205f1b28071e12e50e252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107442
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-06-26 23:47:07 +00:00
5c1d5444d6
[vm, bytecode] Fix some source position discrepancies.
...
Fix most cases of accessing metadata; parameter annotations still missing.
Change-Id: Ie78c3d817a86a656548cdc5775f837250a710095
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106967
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-06-25 00:57:26 +00:00
Alexander Markov