dart-lang/sdk - sdk - Tonycloud git server

Author SHA1 Message Date

Author	SHA1	Message	Date
Ryan Macnak	dce0b514d4	[vm] Defer object pools and object pool entries. This defers literals, to effectively split binary size for libraries that are more data than code, such as localizations. TEST=ci Bug: https://github.com/dart-lang/sdk/issues/41974 Change-Id: I506722037cc0247b90756959e6a6f12bb5021b5c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183781 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>	2021-03-04 23:19:30 +00:00
asiva	27deca1457	Revert "[vm] Defer object pools." and "[vm] Defer object pool entries in instructions bare mode." This reverts commit `0bf8d38b3d` and commit `63d17b0ad8`. Reason for revert : Performance regression, please see https://github.com/flutter/flutter/issues/73794 TEST=(none it is a revert). Change-Id: I828734f00c55d5095f632b154d7f4ab27a184baf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181542 Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>	2021-01-28 21:13:35 +00:00
Ryan Macnak	0bf8d38b3d	[vm] Defer object pools. This is a step toward deferring literals, to effectively split binary size for libraries that are more data than code, such as localizations. Bare instructions mode still has all constants in the root snapshot because it has one global ObjectPool. dart2js+analyzer product X64 non-bare: app.so 10072728 -> 8479824 (-15.8%) app.so-2.part.so 14074512 -> 15016976 (6.69%) app.so-3.part.so 9225936 -> 9888984 (7.18%) TEST=ci Bug: https://github.com/dart-lang/sdk/issues/41974 Change-Id: If61f6156e3fc2dd539331335b3bf0458102b7c75 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168991 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Régis Crelier <regis@google.com>	2021-01-08 22:11:03 +00:00

Ryan Macnak

dce0b514d4

[vm] Defer object pools and object pool entries.

This defers literals, to effectively split binary size for libraries that are more data than code, such as localizations.

TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/41974
Change-Id: I506722037cc0247b90756959e6a6f12bb5021b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183781
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

2021-03-04 23:19:30 +00:00

asiva

27deca1457

Revert "[vm] Defer object pools." and

"[vm] Defer object pool entries in instructions bare mode."

This reverts commit 0bf8d38b3d and
             commit 63d17b0ad8.

Reason for revert : Performance regression, please see https://github.com/flutter/flutter/issues/73794

TEST=(none it is a revert).

Change-Id: I828734f00c55d5095f632b154d7f4ab27a184baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181542
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

2021-01-28 21:13:35 +00:00

Ryan Macnak

0bf8d38b3d

[vm] Defer object pools.

This is a step toward deferring literals, to effectively split binary size for libraries that are more data than code, such as localizations. Bare instructions mode still has all constants in the root snapshot because it has one global ObjectPool.

dart2js+analyzer product X64 non-bare:
app.so           10072728 ->  8479824 (-15.8%)
app.so-2.part.so 14074512 -> 15016976 (6.69%)
app.so-3.part.so  9225936 ->  9888984 (7.18%)

TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/41974
Change-Id: If61f6156e3fc2dd539331335b3bf0458102b7c75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168991
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>

2021-01-08 22:11:03 +00:00

3 Commits