dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1605 Commits

Author SHA1 Message Date
John McCutchan cbbb82cfbe Ship Observatory with non-minified sources 
This will help our users report more actionable bug reports.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2348673003 .
 2016-09-16 13:00:38 -07:00
John McCutchan d5f138e459 Fix async_generator_breakpoint_test so it awaits on isolate resume requests 
BUG=

Review URL: https://codereview.chromium.org/2344253002 .
 2016-09-16 11:24:53 -07:00
John McCutchan e2b922b4c5 Fix service test websocket error edge case 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2343183002 .
 2016-09-16 10:31:05 -07:00
John McCutchan 0d831bd5c8 Use Chain.capture instead of runZoned 
- [x] Swap all calls of runZoned to Chain.capture.

Chain.capture is a wrapper around runZoned that tracks stack traces across asynchronous gaps.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2349753002 .
 2016-09-16 09:44:06 -07:00
John McCutchan 7fca076fbb Use dartfmt on Observatory code 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2345023003 .
 2016-09-16 06:59:51 -07:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing 
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d3e356ca75be8aeff3efde5df946d746b9f8352

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: https://github.com/dart-lang/sdk/commit/6d238ba197c8bda71afe790f16f6e9adaf7abd13
 2016-09-16 15:03:18 +02:00
Ryan Macnak 47cc06ae66 Shrink AOT snapshot size and memory usage. 
- Conditionally remove fields of Code, Function and ICData that are not used in the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2326483005 .
 2016-09-15 15:06:42 -07:00
John McCutchan ce8d0653da Improve async stack traces in Observatory 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2333923007 .
 2016-09-15 13:44:51 -07:00
Ryan Macnak 57d558fa5f Observatory: Fix instance view of lists. 
Fixes #27351.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2342943002 .
 2016-09-15 13:35:18 -07:00
John McCutchan 72b79d970b Improve VM connection flow in Observatory 
- [x] Don't show "(Connected)" next to a VM we aren't connected to.
- [x] Navigate to the vm-connect page if we get an initial connection error.
- [x] Fix regression of the 'vm disconnected' notification bubble not appearing.
- [x] Use the Uris helper class instead of hard coded paths
- [x] Improve user inputted URI normalization
- [x] Ignore network errors on stream subscription requests
- [x] On first launch, attempt to connect to the default target and not the last target connected to.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2340973002 .
 2016-09-15 11:29:06 -07:00
William Hesse 6d238ba197 Revert "Use checked-in .package file for building and testing" 
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
 2016-09-15 15:46:49 +02:00
William Hesse 5d3e356ca7 Use checked-in .package file for building and testing 
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
 2016-09-15 14:50:30 +02:00
John McCutchan 87dcad607e Cleanup some Observatory errors caught by dart2js 
Not sure why the analzyer didn't notice these but dart2js (when invoked via pub serve does).

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2339303003 .
 2016-09-14 15:45:14 -07:00
Ryan Macnak cd4c9fc46b Observatory: Fix allocation profile CSV export. Fix heap snapshot in/out reference counts. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2340883002 .
 2016-09-14 15:44:28 -07:00
Carlo Bernaschina 1b4afdab2d Restored SVGs in Observatory script-inset element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2328943003 .
 2016-09-09 09:58:07 -07:00
Ryan Macnak ebc0c261a5 Minor UI tweaks. 
R=cbernaschina@google.com

Review URL: https://codereview.chromium.org/2324833005 .
 2016-09-09 09:55:50 -07:00
Carlo Bernaschina 5b838cfb01 Allow to compact header in allocation-profile 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2322643004 .
 2016-09-08 14:36:43 -07:00
Carlo Bernaschina de2cea8f57 Added missing content to nav-top-menu 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2325613003 .
 2016-09-08 10:47:40 -07:00
Carlo Bernaschina d9a886c397 Reverted change to ServiceMap 
TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/2323543002 .
 2016-09-07 15:03:00 -07:00
Carlo Bernaschina 5177c2bca9 Removed polymer & mirror from Observatory 
web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2310003004 .
 2016-09-07 14:15:27 -07:00
Carlo Bernaschina 876f49999a Converted Observatory debugger elements 
R=rmacnak@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org/2312553002 .
 2016-09-06 15:05:44 -07:00
Carlo Bernaschina cfefe97495 Converted Observatory metrics-page element 
Major restyle

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2303173002 .
 2016-09-06 09:56:16 -07:00
Carlo Bernaschina bc5a41edf8 Fixed crash of Observatory class-view element 
Fixes=https://github.com/dart-lang/sdk/issues/27222

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2308003002 .
 2016-09-02 11:12:44 -07:00
Carlo Bernaschina c38769ea9a Converted Observatory timeline-page element 
Not fully testable

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2299613004 .
 2016-09-02 10:38:40 -07:00
Carlo Bernaschina 2eab4de315 Converted Observatory logging-page element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2299893003 .
 2016-09-02 10:27:48 -07:00
Carlo Bernaschina b31829db24 Converted Observatory json-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2305693003 .
 2016-09-02 10:23:29 -07:00
Siva Annamalai 63f1261064 Update status file for issue 27225. 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2301263002 .
 2016-09-01 15:57:39 -07:00
Carlo Bernaschina 98a67efbd2 Manage null CallSite receivers in script-inset 
Fixes=https://github.com/dart-lang/sdk/issues/27222

TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/2302163002 .
 2016-09-01 15:15:31 -07:00
Carlo Bernaschina 5703296fe6 Avoid to return null in anyRef if object is not known 
Fixes=https://github.com/dart-lang/sdk/issues/27222

TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/2303073002 .
 2016-09-01 14:47:35 -07:00
Carlo Bernaschina 741d99f100 Converted Observatory code-view element 
Not fully testable

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2306483002 .
 2016-09-01 13:56:45 -07:00
Zachary Anderson 4024fe154a GN: Relativize occurrances of //dart 
The Dart root in the Dart tree is at //, not //dart.
But in the Dart tree we can refer to the root with
a relative path.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2301833003 .
 2016-09-01 13:35:44 -07:00
Carlo Bernaschina 90c50c52f2 Converted Observatory vm-view && isolate-view elements 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2304463002 .
 2016-09-01 10:46:36 -07:00
William Hesse 7bceafd11e Update all packages in third_party/pkg to latest compatible version 
Packages markdown and stack_trace are not updated, because of their high impact.
They will be updated in separate CLs.

BUG=
R=nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2297213002 .
 2016-09-01 10:12:23 +02:00
Carlo Bernaschina 1341e94321 Converted Observatory class-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2294073003 .
 2016-08-31 17:03:38 -07:00
Todd Turnidge cd8292d175 Don't return negative token positions in stack traces. 
Closes #27128

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2294883004 .
 2016-08-31 16:22:18 -07:00
Carlo Bernaschina 8561986221 Removed warnings from service tests 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2296043002 .
 2016-08-30 17:01:05 -07:00
Carlo Bernaschina 1a1224b1d3 Removed const from classes arrays in Observatory 
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2298563002 .
 2016-08-30 15:38:07 -07:00
Ryan Macnak c80b23b7ff Fix evaluating in async/sync*/async* methods. 
Fixes #27167.

R=hausner@google.com

Review URL: https://codereview.chromium.org/2291293003 .
 2016-08-30 15:16:57 -07:00
Carlo Bernaschina bf7d220741 Converted Observatory instance-view element 
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2291233002 .
 2016-08-30 14:53:24 -07:00
Carlo Bernaschina 19e9627ea0 Converted Observatory library-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2289953003 .
 2016-08-30 13:58:15 -07:00
Carlo Bernaschina 0083d2610e Converted Observatory object-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2294473002 .
 2016-08-30 13:39:12 -07:00
Carlo Bernaschina b63546ac57 Converted Observatory function-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2291823002 .
 2016-08-29 16:39:38 -07:00
Carlo Bernaschina 0a23299d65 Fixed observatory header buttons font 
Fixes=https://github.com/dart-lang/sdk/issues/27194

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2296453002 .
 2016-08-29 16:28:29 -07:00
Carlo Bernaschina 3b16691da1 Converted Observatory script-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2283263002 .
 2016-08-29 13:33:55 -07:00
Carlo Bernaschina 9a18a1b5eb Added quickExpressions support to Observatory eval-box element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2281903003 .
 2016-08-29 12:36:23 -07:00
Carlo Bernaschina a326a56eb1 Converted Observatory object-pool-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2283863003 .
 2016-08-29 11:14:18 -07:00
Carlo Bernaschina 8e7725a8b4 Converted Observatory field-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2287793002 .
 2016-08-29 10:47:05 -07:00
Carlo Bernaschina b4d833182f Avoid to updated selection on links click in cpu-profile-table 
TBR=rmacnak@google.com

Fixes=https://github.com/dart-lang/sdk/issues/27190

Review URL: https://codereview.chromium.org/2285303002 .
 2016-08-29 10:04:14 -07:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 342eb3f296 Additional status file fixes 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2283273002 .
 2016-08-26 18:29:19 -07:00