dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1605 Commits

Author SHA1 Message Date
John McCutchan 99c6a18a1b Attempt 2 -- Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

Review-Url: https://codereview.chromium.org/2810223003 .
 2017-04-12 14:02:19 -07:00
John McCutchan f0734f99b3 Detect unhandled exceptions in async functions without an awaiter 
- [x] Produce an awaiter stack trace even when there is no awaiter.
- [x] Fix fetching the saved context from Closure.call (fixes --trace_debugger_stacktrace)

Fixes #29200

Example code:

```
main(List<String> args) async {
  var f = new Foo();
  print(f.a.length);
  print('Should not get here');
}

class Foo {
  String a;
}
```

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2815863002 .
 2017-04-12 13:15:41 -07:00
Ryan Macnak 9ce48e63b2 Remove background finalization. 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2809863002 .
 2017-04-11 09:54:25 -07:00
John McCutchan 94df115e4b Revert "Fix updating packages map on reload and add a regression test" 
This reverts commit 7a2d67f3ba.

BUG=

Review-Url: https://codereview.chromium.org/2808953003 .
 2017-04-10 12:30:38 -07:00
John McCutchan bf3d374541 Dump some state when complex_reload_test fails 
BUG=

Review-Url: https://codereview.chromium.org/2814573002 .
 2017-04-10 12:13:16 -07:00
John McCutchan 7a2d67f3ba Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2797923008 .
 2017-04-10 08:59:10 -07:00
Peter von der Ahé 1e70fef1a2 Small steps towards deferred loading. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2803833003 .
 2017-04-07 12:23:35 +02:00
Dmitry Olshansky 19a352e0f5 Reland: VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator 
This allows us to bypass allocation of Context for some sync*
function such as in Iteration.tree.syncstar benchmark.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2803853004 .
 2017-04-06 17:18:40 +02:00
Peter von der Ahé 0df001cebf Implement various getters on DillMember. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2799783004 .
 2017-04-06 10:54:48 +02:00
Vyacheslav Egorov 7e1d584218 VM: [Kernel] Implement CatchBlockEntryInstr::should_restore_closure_context on all platforms. 
This was the only Kernel specific backend change - to simplify the graph builder
we allowed it to capture exception and stack trace variables. This in turn
requires CatchBlockEntryInstr to respect that this variables can be captured
and correctly update them when exception is caught.

This was implemented on X64 and ARM before. This CL expands implementation to
all other implementations including DBC.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2796283003 .
 2017-04-05 20:32:03 +02:00
Florian Loitsch cb426d5d21 Mark service/pause_on_unhandled_async_exceptions2_test as crashing. 
Review-Url: https://codereview.chromium.org/2804643002 .
 2017-04-05 14:23:29 +02:00
John McCutchan e33e09a23c Disable async debugger support until context mismatch issue is resolved. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2795303002 .
 2017-04-04 13:36:42 -07:00
Zachary Anderson 78706025da [vm service] Collect garbage before getting native allocation samples 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2795473003 .
 2017-04-03 09:12:52 -07:00
Siva Annamalai 4654381213 Move kernel related status lines from service.status to service_kernel.status 
Review-Url: https://codereview.chromium.org/2789993002 .
 2017-03-31 17:57:09 -07:00
Siva Annamalai 74229dfb1f Adjust status file to account for build breakage. 
TBR=fschneider

Review-Url: https://codereview.chromium.org/2793683002 .
 2017-03-31 14:51:45 -07:00
John McCutchan 4c4c9f2ce6 Fix test failure and add new awaiterFrames to service_dev.md 
BUG=

Review-Url: https://codereview.chromium.org/2788993002 .
 2017-03-31 13:18:07 -07:00
John McCutchan 193f26d1e1 Implement support for single stepping out of an async function. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2785243003 .
 2017-03-31 10:55:11 -07:00
Karl Klose 4b7e73fe00 [Gardening] Mark service/async_generator_breakpoint_test as slow on dartk 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2786343002 .
 2017-03-31 08:52:09 +02:00
Florian Schneider 22d5833ae4 Fix analyzer warnings in a test. 
Review-Url: https://codereview.chromium.org/2787063003 .
 2017-03-30 12:13:34 -07:00
Florian Schneider 5a3f9d9398 Fix a couple of bugs with async stack traces 
Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in ActivationFrame::ContextLevel. This is planned for a separate CL.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2786503003 .
 2017-03-30 11:02:33 -07:00
John McCutchan 8526b8cf2d Display the awaiter call stack in Observatory 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2785553005 .
 2017-03-30 10:01:39 -07:00
Lasse R.H. Nielsen ed9c76421e Mark service/async_scope_test as slow on windows+checked+debug. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2783173002 .
 2017-03-30 15:04:06 +02:00
John McCutchan 66aca8a36e Fix many warnings/errors when building Observatory 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2783933002 .
 2017-03-29 10:31:40 -07:00
John McCutchan 0e9b4123db Mark awaiter_async_stack_contents_test as failing on kernel bots 
BUG=

Review-Url: https://codereview.chromium.org/2787523002 .
 2017-03-29 08:47:14 -07:00
John McCutchan 2815f3f775 Implement debugger support for async step-out 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2777093006 .
 2017-03-29 07:44:18 -07:00
John McCutchan d8555fb5a8 Include the awaiter stack trace in the service protocol 
- [x] Include the (non-empty) awaiter stack trace in every `getStack` RPC.
- [x] Append the causal stack trace to the final frame of the awaiter stack trace.
- [x] Unit test for awaiter stack trace.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2782703002 .
 2017-03-29 06:56:50 -07:00
Jens Johansen 2ad253ed6b Mark pause_on_unhandled_async_exceptions2_test flaky on app_jit 
See https://github.com/dart-lang/sdk/issues/29178.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2774233004 .
 2017-03-28 08:59:50 +02:00
Ben Konyi 7c820f4363 Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and stack trace collection skip counts for different configurations. 
Fixed missing method referenced when MallocHooks is unsupported.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2771293003 .
 2017-03-27 13:25:26 -07:00
John McCutchan ada90ae4f2 Update the correct status file for the kernel bots 
BUG=

Review-Url: https://codereview.chromium.org/2773073004 .
 2017-03-24 14:54:30 -07:00
John McCutchan bfde95b58f Update status file for kernel bot 
BUG=

Review-Url: https://codereview.chromium.org/2775863005 .
 2017-03-24 14:49:35 -07:00
Ben Konyi 9ea672efc0 Revert "Added page to Observatory to display native memory allocation information." 
This reverts commit f30f312b48.

Revert "Fixed missing method referenced when MallocHooks is unsupported."

This reverts commit a0b9c5a178.

TBR=johnmccutchan@google.com

BUG=

Review-Url: https://codereview.chromium.org/2773073003 .
 2017-03-24 09:47:29 -07:00
Ben Konyi f30f312b48 Added page to Observatory to display native memory allocation information. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2748403002 .
 2017-03-24 09:20:25 -07:00
John McCutchan 07a257573d Debugger support for step-into async and async* functions. 
- [x] Support stepping into an async function.
- [x] Support stepping into the async generator in an await for loop.
- [x] Unit test for async function.
- [x] Unit test for async* function.

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2768103002 .
 2017-03-24 07:56:50 -07:00
Peter von der Ahé ec5d7cba1a Implement character offsets for fields and enum constants. 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2771983004 .
 2017-03-24 15:29:42 +01:00
John McCutchan e246034fca Make :embedded_observatory_archive compilable on Win for Flutter 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2769893002 .
 2017-03-23 10:19:57 -07:00
Ben Konyi c0511ad2ef Reimplemented zone memory tracking to avoid race conditions that were causing crashes in the previous implementation and made some minor name changes. 
BUG=
R=asiva@google.com, johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2762323002 .
 2017-03-23 09:03:08 -07:00
Jens Johansen dc566e137b [kernel] Fix getter, run service tests in debug mode 
Don't create getters for uninitialized static fields.
This fixes two assert hits that was hit when running service tests in debug mode via kernel. These can thus now be enabled.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2771443003 .
 2017-03-23 08:26:10 +01:00
Jacob Richman 4360e99d18 Revert "Fix observatory tests broken by running dartfmt." 
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/62be0eacfbb36bdc92a05c7c35bb4506621b6a3a
Review-Url: https://codereview.chromium.org/2767533002 .
 2017-03-21 10:07:26 -07:00
Florian Schneider ef7487a7a8 Fix two bugs with async stack traces. 
1. A crash when collecting an async stack trace with inlined frames on the stack.

2. A missing source position in an async stack trace.

Fixes #29080.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2767483002 .
 2017-03-21 09:31:11 -07:00
Jens Johansen e43feda1ed Don't run service tests via dartk in debug mode 
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2766513004 .
 2017-03-21 15:52:50 +01:00
Jens Johansen 41a8604ebf Don't run service tests via dartkp 
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2767603002 .
 2017-03-21 15:11:05 +01:00
Jens Johansen a6ea038643 [kernel] offsets on direct property get/set 
BUG=
R=ahe@google.com, kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/7577f6aaa052c9a1c309f13bf338b92bf4fb9fd0
Review-Url: https://codereview.chromium.org/2748333002 .
 2017-03-21 14:43:45 +01:00
Jens Johansen 2dbff73522 Additional service tests 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2752753002 .
 2017-03-21 14:37:01 +01:00
Jacob Richman 62be0eacfb Revert "Fix observatory tests broken by running dartfmt." 
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.

BUG=

Review-Url: https://codereview.chromium.org/2767533002 .
 2017-03-20 22:19:22 -07:00
Jacob Richman 88f8aacd5f Re-apply rolled back CL to apply dartfmt to runtime. 
Fix observatory tests broken by running dartfmt due to line and column changes.
Temporarily reverted formatting for evaluate_activation_test.dart as dartfmt doesn't yet handle multitests.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2759973004 .
 2017-03-20 21:44:59 -07:00
Ryan Macnak ea4744a06f Revert "Run dartfmt on all files under runtime." 
This reverts commit 15f393f189.

The change caused many service test failures due to changed line numbers.

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2762583003 .
 2017-03-20 13:42:55 -07:00
Jacob Richman 15f393f189 Run dartfmt on all files under runtime. 
I've omitted files where the formatter output is significantly uglier
than the original code and I'll send those files in a separate CL
with options for how to make the code look reasonable while still
taking advantage of the formatter.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2751423005 .
 2017-03-20 13:13:50 -07:00
John McCutchan 9431f65f73 Also, remove the restart test case 
BUG=

Review-Url: https://codereview.chromium.org/2759993002 .
 2017-03-20 09:10:04 -07:00
John McCutchan a4adbffb50 Remove legacy restart code 
Also fixes #29092 by threading Error objects back to the message handler.

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2759533002 .
 2017-03-20 08:47:39 -07:00
John McCutchan c92e0f5108 Disable bad_reload_test on app-jit 
BUG=

Review-Url: https://codereview.chromium.org/2757733002 .
 2017-03-16 12:59:39 -07:00