Dmitry Stefantsov
e7830a9f7b
Add a flag to Procedures indicating that it's a redirecting factory
...
Fixes #32282
Bug: http://dartbug.com/32282
Change-Id: Iee8535b053ced415e3047e990a0940d859faa86a
Reviewed-on: https://dart-review.googlesource.com/43440
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2018-02-27 10:42:07 +00:00
Alexander Aprelev
ec7029daf6
Workaround deferred library limitation.
...
Introduce no-op LoadLibrary, CheckLibraryIsLoaded into kernel_binary_flowgraph.cc
Bug: https://github.com/dart-lang/sdk/issues/32245
Change-Id: If93a4d717844dcb8a5d45d0237660ec764a6f738
Reviewed-on: https://dart-review.googlesource.com/42461
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-02-22 20:34:39 +00:00
William Hesse
62a2c75af7
Update status for simarch kernel observatory service tests.
...
Skip runtime/observatory/tests/service/pause_on_start_then_step_test
on dartk on Windows.
Move some status sections from service.status to service_kernel.status
Change some Timeout statuses to Skip, because we don't get any info
from runnning those tests.
Bug: https://github.com/dart-lang/sdk/issues/32225
Change-Id: I85c4567711657188985d52103e87de96086b8222
Reviewed-on: https://dart-review.googlesource.com/42280
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2018-02-19 17:35:31 +00:00
Jens Johansen
90f3a603cd
[gardening] kernel/windows status file updates #4
...
Change-Id: I7c938730c245f74c06e938f31ed2cdedf6db6e62
Reviewed-on: https://dart-review.googlesource.com/41180
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-14 11:10:26 +00:00
Jens Johansen
5142fcc774
[gardening] kernel/windows status file updates #3
...
Change-Id: Ia0d6625494eae9d6116b90c15994ef7f07811b42
Reviewed-on: https://dart-review.googlesource.com/40800
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 13:35:33 +00:00
Jens Johansen
f5829bb75e
[gardening] kernel/windows status file updates #2
...
Change-Id: I5ba0dd75456ec07c833f5d2e88b30e814139b37a
Reviewed-on: https://dart-review.googlesource.com/40745
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 13:08:52 +00:00
Jens Johansen
4fac2530de
[gardening] kernel/windows status file updates #1
...
Bugs #32137 and #32138 .
Change-Id: If91591170b342794120076fe6af269e8020d3796
Reviewed-on: https://dart-review.googlesource.com/40744
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-13 11:58:15 +00:00
Siva Chandra
6ff0951bdf
Remove the use of redundant flags --dfe and --kernel-binaries.
...
This change helps in confining flag manipulation to just the embedder.
When we are ready to turn all dart 2 flags to true by default, the
change can be confined to just the VM.
Change-Id: I4ac550c331b1f236a2bd9d0453b7c567eb0c05d3
Reviewed-on: https://dart-review.googlesource.com/38881
Commit-Queue: Siva Chandra <sivachandra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-02-08 20:56:22 +00:00
Mike Fairhurst
56d59dd967
Reland https://dart-review.googlesource.com/c/sdk/+/37441 with fixes
...
Change-Id: If8e2ec2ca1ac4f533dcb56b0c95d55e4a13e0598
Reviewed-on: https://dart-review.googlesource.com/39881
Reviewed-by: Paul Berry <paulberry@google.com >
2018-02-08 20:46:19 +00:00
William Hesse
be2e6c4f82
Update status for new dartk and dartkp builders
...
Change-Id: Ie5ed3cade049d1d7831440adece520dd09ad13d7
Reviewed-on: https://dart-review.googlesource.com/39985
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-02-08 16:52:56 +00:00
Peter von der Ahé
8815bbe90e
Update status files for $compiler == fasta
...
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-07 15:38:09 +00:00
Paul Berry
cca7b4419d
Replace $builder_tag == strong with $strong in status files
...
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`. Now that `$strong` is supported, it's better to
use it directly to avoid confusion.
Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-07 11:50:10 +00:00
asiva
5ac062d0ca
Fix some kernel status files for simdbc64 and simarm failures (tests that are marked as Failing seem to pass now).
...
Change-Id: Id3cacaaa2ea043d4b9e28580ba3097a99e42d362
Reviewed-on: https://dart-review.googlesource.com/39460
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-02-07 02:18:55 +00:00
Leaf Petersen
7a7e65660f
Rename ServiceObject.update to updateFromServiceMap
...
Rename a method that clashes with the new update method being added to
Map.
Change-Id: I7717e055ddd2734ee3dfc9b0d20f69c415775b28
Reviewed-on: https://dart-review.googlesource.com/39240
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-02-06 18:40:48 +00:00
William Hesse
209dac0899
Update status for dartk on sim architectures and cross-frame test.
...
BUG=dart:32039
R=athom@google.com
Change-Id: Ic62951a846c24f8a00f347afd6c6620fd56b5c13
Reviewed-on: https://dart-review.googlesource.com/39161
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2018-02-06 18:10:32 +00:00
Devon Carew
83ea11b2bb
Tweaks to the Observatory timeline landing page UI.
...
Change-Id: Ibe1fe674fc706057bc10d091c8bf0c20b31adaaf
Reviewed-on: https://dart-review.googlesource.com/38381
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-02-06 16:39:23 +00:00
Siva Chandra
71dba8a0e5
Link the platform kernel with the command line dart executable.
...
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Chandra <sivachandra@google.com >
2018-02-01 15:11:29 +00:00
Jens Johansen
29c76d7604
[kernel] Update Windows status files take #5
...
Change-Id: Ia3bc3affba3100453846678b03d2a83402187418
Reviewed-on: https://dart-review.googlesource.com/36881
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-26 08:46:23 +00:00
Jens Johansen
b2e105ac17
[kernel] Update Windows status files take #4
...
Change-Id: I76aae5cedd1be2f676ffcc794db623fb6ff26dcc
Reviewed-on: https://dart-review.googlesource.com/36760
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-01-25 12:36:32 +00:00
Jens Johansen
2f2d6b5cfb
[kernel] Update Windows status files take #3
...
Change-Id: I2012724893e7366b36ad05b6d7942e9bad58ced2
Reviewed-on: https://dart-review.googlesource.com/36600
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-01-24 13:04:39 +00:00
Jens Johansen
57a3368b7f
[kernel] Update Windows status files take #2
...
Change-Id: I41d78a6bbfb66dc0a8ce399b79890f7ed851dd39
Reviewed-on: https://dart-review.googlesource.com/36580
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-01-24 09:06:51 +00:00
Siva Annamalai
5f5bba2a74
Normalize status files.
...
Allow void as a type.
Change-Id: Ia94c50bcc2e4023008da1dad60cdbfc3465d936b
Change-Id: Ibe7d394cf92e6bb45e06770329da857bcb2c84b0
Reviewed-on: https://dart-review.googlesource.com/36127
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-01-20 23:02:08 +00:00
Ryan Macnak
2108fb25f8
[observatory] Omit VM and User tags and the trie root from profile data added to the timeline.
...
I.e., no "Dart", "Native", "Default", "Root", etc.
Change-Id: Id1a1b70934daca7f43c9657bd9fa4d3f779067a9
Reviewed-on: https://dart-review.googlesource.com/35800
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-01-19 21:39:36 +00:00
Alexander Thomas
6888aae228
[gardening] Update status files make DBC builder green again
...
Change-Id: Ie90ad628b5ac8ffc7eba2c8f707545ba0b27939b
Reviewed-on: https://dart-review.googlesource.com/34902
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-01-16 18:16:52 +00:00
Alexander Thomas
27ebef64d4
[infra] Add VM Kernel Windows x64 builders
...
Bug: https://github.com/dart-lang/sdk/issues/31707
Change-Id: Ie56f4c6f78c9b7c27fc4f587857e412db3e8f358
Reviewed-on: https://dart-review.googlesource.com/33960
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-01-16 15:39:03 +00:00
Martin Kustermann
0bc46de838
[VM] Support spawning isolates when the main isolate was spawned from a Kernel IR file
...
Issue https://github.com/dart-lang/sdk/issues/31698
Change-Id: Ifc6662a3fd56245c10f5d924f771ef85ed9b222c
Reviewed-on: https://dart-review.googlesource.com/34742
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-01-15 17:51:54 +00:00
Jens Johansen
4d5bf638c3
[kernel] Fix status files for service/bad_reload_test
...
TBR.
Change-Id: Ib6c287c41eaaa241b187b7de7bb64441b04576c6
Reviewed-on: https://dart-review.googlesource.com/34581
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-15 08:21:30 +00:00
Ryan Macnak
9cf7d6fa93
Partial static mode changes for vm-service and tests (part 4).
...
Bug: https://github.com/dart-lang/sdk/issues/31587
Bug: https://github.com/dart-lang/sdk/issues/31696
Change-Id: I2b37ad97da0520db08f43981fdbc48b094942a0e
Reviewed-on: https://dart-review.googlesource.com/34306
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-01-12 20:12:41 +00:00
Jens Johansen
d48e4e6214
[Gardening] Skip isolate_lifecycle_test on sim{arm,arm64,dmc64} in strong mode
...
It times out.
Change-Id: I12eb662c5a6c7586d6b0aabdfecd305a03d3d60d
Reviewed-on: https://dart-review.googlesource.com/34384
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-12 14:27:34 +00:00
Jens Johansen
b28efdc66b
[kernel] Allow VM to skip kInstantiation from dill file
...
A new Expression was added in bc2560069a
but C++ wasn't updated to handle it.
The crash reported in 31868 is caused by trying to skip past such an
expression, which is now possible.
Actually using that expression is still unhandled though, although thats
a separate issue.
Fixes #31868 .
Bug: 31868
Change-Id: Ife0aadb97cee398ee1925fb52f91127225253768
Reviewed-on: https://dart-review.googlesource.com/34361
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-01-12 11:50:55 +00:00
Ryan Macnak
a4f3b53fe8
Reapply "Partial static mode changes for vm-service and tests (part 3)."
...
Remove use of castTo, which is not yet available in the prebuilt SDK used to build Observatory.
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: Ia118710a2c4dca1851935d284e1a78a9c6517256
Reviewed-on: https://dart-review.googlesource.com/34022
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-01-11 01:31:17 +00:00
Alexander Thomas
2da64efb81
[infra] Update status files for new VM Kernel opt counter builder
...
Bug: https://github.com/dart-lang/sdk/issues/31838
Change-Id: I703319aebc135a7b219dc576c50f26f5feaabedf
Reviewed-on: https://dart-review.googlesource.com/33881
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-01-10 18:49:19 +00:00
Jens Johansen
37c28f8661
Revert "Reapply "Partial static mode changes for vm-service and tests (part 3).""
...
This reverts commit c9f6e8695d .
Reason for revert: Change brakes Observatory:
```
$ out/ReleaseX64/dart --observe hello.dart
Observatory listening on http://127.0.0.1:8181/
Hello, world!
vm-service: isolate(348927110) 'hello.dart:main()' has no debugger attached and is paused at exit. Connect to Observatory at http://127.0.0.1:8181/ to debug.
```
Going to the website I get
```
Unexpected exception:
NoSuchMethodError: method not found: 'castTo'
Receiver: ""
Arguments: [Instance of 'it']
StackTrace:
main.dart.js 2017:3 Object.f
main.dart.js 2203:30 Object.qn
main.dart.js 21316:11 b3.aQ
main.dart.js 20634:6 b3.c2
main.dart.js 20643:8 TZ.$1
main.dart.js 36992:29 UB.$0
main.dart.js 36982:9 Ux.nq
main.dart.js 36990:30 UC.$1
main.dart.js 36992:29 UB.$0
main.dart.js 36982:9 Ux.nq
===== asynchronous gap ===========================
main.dart.js 4840:12 Zh.e4
main.dart.js 3930:17 L.lK
main.dart.js 3932:28 L.ad
main.dart.js 20621:12 b3.dart.ba.lE
main.dart.js 20621:112 b3.dart.ba.lE
main.dart.js 20603:22 b3.cD
===== asynchronous gap ===========================
main.dart.js 4840:12 Zh.e4
main.dart.js 3930:17 L.lK
main.dart.js 3932:28 L.ad
main.dart.js 20621:12 ms.dart.ba.lE
main.dart.js 20621:112 ms.dart.ba.lE
main.dart.js 15829:10 Y4.bs
```
and Observatory is completely broken.
From https://github.com/dart-lang/sdk/issues/31397 it seems that Observatory uses an "old" sdk, i.e. we cannot use new stuff as castTo.
Original change's description:
> Reapply "Partial static mode changes for vm-service and tests (part 3)."
>
> Fix dynamic mode static warnings.
>
> Bug: https://github.com/dart-lang/sdk/issues/31587
> Change-Id: I966349f5409f911efacd11f08ffd469373bcd434
> Reviewed-on: https://dart-review.googlesource.com/33540
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
> Reviewed-by: Siva Annamalai <asiva@google.com >
TBR=rmacnak@google.com ,asiva@google.com
Change-Id: I775544cb5ab212cc836bc63181bdce31d19380b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/31587
Reviewed-on: https://dart-review.googlesource.com/33800
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-10 12:21:53 +00:00
Jens Johansen
c04d873078
Mark new service test as RuntimeError in strong mode
...
Bug:
Change-Id: I4161c937375231a501901f5dcae15b3d7ee84992
Reviewed-on: https://dart-review.googlesource.com/33722
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-10 11:29:02 +00:00
Jens Johansen
b38f5930a4
[gardening] Update status file for app_jit service test
...
Bug:
Change-Id: I8b10adaf83643bc187b03521278d993aef11a9df
Reviewed-on: https://dart-review.googlesource.com/33720
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-10 07:37:49 +00:00
Jens Johansen
11358378be
[kernel] Change offset for IndexAccessor invocations
...
Add Observatory test to check debug positions for e.g. a[0]().
Non-kernel pipeline points to '(', whereas the (old) kernel behaviour
was to point to 'a'. This fixes the kernel behaviour to also point to '('.
Bug:
Change-Id: I9cd0a2f0cdd4428cd491d02ccc63c72caf285292
Reviewed-on: https://dart-review.googlesource.com/31982
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-01-10 07:07:39 +00:00
Ryan Macnak
c9f6e8695d
Reapply "Partial static mode changes for vm-service and tests (part 3)."
...
Fix dynamic mode static warnings.
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: I966349f5409f911efacd11f08ffd469373bcd434
Reviewed-on: https://dart-review.googlesource.com/33540
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-01-10 01:28:39 +00:00
Alexander Thomas
89bd41d19a
[infra] Simplify vm-kernel configurations in test matrix
...
This also adds the missing vm-kernel opt-counter builder.
Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-01-09 20:59:49 +00:00
Ryan Macnak
e8d9d945f3
Revert "Partial static mode changes for vm-service and tests (part 3)."
...
This reverts commit 6ccd7b8ac2 .
Reason for revert: analyzer failures
Original change's description:
> Partial static mode changes for vm-service and tests (part 3).
>
> Bug: https://github.com/dart-lang/sdk/issues/31587
> Change-Id: I812fd4cd8e74875ce7ada9886035137af2fef73a
> Reviewed-on: https://dart-review.googlesource.com/33100
> Reviewed-by: Siva Annamalai <asiva@google.com >
TBR=rmacnak@google.com ,asiva@google.com
Change-Id: Ic368fc23f58e02cafbaf6ae81dbcbffc3dcced13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/31587
Reviewed-on: https://dart-review.googlesource.com/33240
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-01-09 02:37:56 +00:00
Ryan Macnak
6ccd7b8ac2
Partial static mode changes for vm-service and tests (part 3).
...
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: I812fd4cd8e74875ce7ada9886035137af2fef73a
Reviewed-on: https://dart-review.googlesource.com/33100
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-01-09 01:40:10 +00:00
Martin Kustermann
63231b8849
[Gardening] Mark service/get_cpu_profile_timeline_rpc_test flaky on simdbc64
...
Issue https://github.com/dart-lang/sdk/issues/31794
Change-Id: I8345ff0368451bb96a82f78d4f37b4d0b68870cb
Reviewed-on: https://dart-review.googlesource.com/32769
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-01-08 13:45:22 +00:00
Dmitry Stefantsov
86a1735f75
Update status files to reflect dartbug.com/31765
...
Bug:
Change-Id: Ic3246d620de637c6e47b61cb5e6a0f5d7abe72fe
Reviewed-on: https://dart-review.googlesource.com/32281
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-04 12:40:07 +00:00
Jens Johansen
4e162c5318
[kernel] Fix vm crash when trying to break on default constructor
...
Writing "break Foo" in observatory with a file including
```
class Foo { }
```
would crash them VM.
This CL introduces a test that reproduces it and fixes the issue.
Bug:
Change-Id: I24780d9204117ade19a0cb590c45aa31b7c04f7e
Reviewed-on: https://dart-review.googlesource.com/30445
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2017-12-20 13:02:12 +00:00
Ryan Macnak
9f4ffb64ef
Partial static mode changes for vm-service and tests (part 2).
...
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: Ie2605f5043b9f5d2f9156928e3cd39f74e726853
Reviewed-on: https://dart-review.googlesource.com/30681
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2017-12-20 00:45:28 +00:00
Ryan Macnak
b59923de58
Partial static mode changes for vm-service tests.
...
Bug: https://github.com/dart-lang/sdk/issues/31587
Change-Id: I9fc7d83aab68ee2b30d71f8a3a75b74fa4dde55e
Reviewed-on: https://dart-review.googlesource.com/30390
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2017-12-19 17:45:55 +00:00
Martin Kustermann
32c4480403
[VM] Fix various issues in the VM, mainly simdbc64 related
...
* Fixes kernel flow graph builder to use instantiated type argumenst
for CreateArray
* Fixes prologue builder to mask the positon of named arguments in the
arguments descriptor array
* Add a SmiBitAndTOS instruction to DBC
* Implement missing AssertSubtype DBC instruction
* Ensure we don't use field guards in DBC mode
* Remove incorrect assertions in LoadIndexedUnsafe/StoreIndexedUnsafe
* Save argdesc_ in DBC simulator when calling the runtime to optimize
a function (which can call re-entrant to Simulator via const
evalulation)
Issue https://dart-review.googlesource.com/c/sdk/+/29581
Change-Id: Ia14b657db66f90643822b6986ec7f75f746ab0d8
Reviewed-on: https://dart-review.googlesource.com/30340
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2017-12-19 14:49:52 +00:00
Martin Kustermann
d84a83344e
Update status files for simarm/simarm64/simdbc64
...
This brings the following configurations green:
tools/test.py -mrelease -cdartk -asimarm
tools/test.py -mrelease -cdartk -asimarm64
tools/test.py -mrelease -cdartk -asimdbc64
tools/test.py -mdebug -cdartk -asimdbc64
Issue https://dart-review.googlesource.com/c/sdk/+/29581
Change-Id: Ie79084bc123ace0ed59505da617ddcb30b9076c2
Reviewed-on: https://dart-review.googlesource.com/29585
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2017-12-14 15:34:15 +00:00
Martin Kustermann
cf1de7d46c
[VM] Replace hand-written assembly prologues with IR
...
As part of the prologue changes we get rid of the empty context as well.
Issue https://github.com/dart-lang/sdk/issues/31495
Change-Id: I707e23c631bcfbbad6c91c4963d0c10f7a0be625
Reviewed-on: https://dart-review.googlesource.com/25320
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2017-12-13 16:04:34 +00:00
Vyacheslav Egorov
efca9c69ab
[vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration.
...
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.
Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.
Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.
Reland of https://dart-review.googlesource.com/27820
Change-Id: I49400fae716f75425e70bf1e561b3375ba39157e
Reviewed-on: https://dart-review.googlesource.com/28565
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2017-12-12 12:19:10 +00:00
Vyacheslav Egorov
e84fa65696
Revert "[vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration."
...
This reverts commit 50865e9387 .
CQ on Mac is broken.
TBR=kustermann@google.com
Bug:
Change-Id: I41a7cab59c076dba4f25f5904725cca5bb4619c9
Reviewed-on: https://dart-review.googlesource.com/28420
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2017-12-11 21:07:43 +00:00