dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1103 Commits

Author SHA1 Message Date
John McCutchan 719794f50a Disable developer extension test 
BUG=

Review URL: https://codereview.chromium.org//1288293005 .
 2015-08-19 15:24:56 -07:00
Ryan Macnak 9162166b54 Functions are objects too! 
- Fix allInstances of non-Instances.
 - Fix loading _vmName.
 - Make refs of top-level classes (::) display something instead of empty string.
 - Fix inbound references to display C++ word offsets like retaining path.
 - Make inbound references and retaining path to display '<root>' instead of empty.
 - Make more types display heap object tools.
 - Add missing function kind for signature functions.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1300853006 .
 2015-08-19 11:18:21 -07:00
Ryan Macnak 07b6dad1f5 Automagically change the meaning of 'next' to 'async-next' when paused at an async function at await/yield. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1299083002 .
 2015-08-18 15:36:13 -07:00
Ryan Macnak 3851c8c0ed Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. 
BUG=http://dartbug.com/24039
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1284063003 .
 2015-08-13 15:50:02 -07:00
John McCutchan 10de20f230 Remove load graph from isolate 
BUG=

Review URL: https://codereview.chromium.org//1290643005 .
 2015-08-12 15:13:11 -07:00
Todd Turnidge fbe47ffa53 Minor observatory test cleanups. 
- Remove --compile-all from a couple of tests.
- Use debugger() instead of busy-waiting in a couple of tests.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1278803005 .
 2015-08-11 14:31:21 -07:00
Todd Turnidge cc981c8246 Don't use %p when generating disassembly in vm service. 
Evidentally it is platform dependent -- it seems to include the 0x
prefix on mac but not on windows.  I've switched to using %" Px "
instead.

This will fix bug 24038.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1282993002 .
 2015-08-11 11:22:55 -07:00
Todd Turnidge f9d84246db Disable code_test.dart on windows (bug 24039) 
BUG=

Review URL: https://codereview.chromium.org//1276423003 .
 2015-08-10 16:12:22 -07:00
Todd Turnidge 0230492433 Clear cruft from service.status file. 
I am using the bots to test if the windows test failures still occur.

BUG=

Review URL: https://codereview.chromium.org//1278613005 .
 2015-08-10 15:51:29 -07:00
Todd Turnidge 256b044857 Allow stepping when paused at isolate start. 
Fix tests.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1285643004 .
 2015-08-10 14:26:01 -07:00
John McCutchan e577dd8438 Remove --compile_all from all but one service test 
BUG=

Review URL: https://codereview.chromium.org//1286493004 .
 2015-08-10 14:20:05 -07:00
Todd Turnidge 64216a8cd0 Revert "Allow stepping when paused at isolate start." 
This reverts commit 319214f58b.

BUG=

Review URL: https://codereview.chromium.org//1286493003 .
 2015-08-10 10:29:31 -07:00
Todd Turnidge 319214f58b Allow stepping when paused at isolate start. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1276243004 .
 2015-08-10 09:52:55 -07:00
John McCutchan ca6deda0e4 Fix test failure on analyzer bot 
- Fix a freudian slip

Review URL: https://codereview.chromium.org//1276103004 .
 2015-08-06 16:50:36 -07:00
John McCutchan 0f13b9c931 Allow Dart code to register service protocol handlers 
- Add 'registerExtension' to dart:developer
- A service protocol handler must implement ServiceExtensionHandler
- Service extensions can report result OR error code / message

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270103002 .
 2015-08-06 16:20:56 -07:00
John McCutchan a2757141b0 Make dart:developer log more user friendly 
- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1266053003 .
 2015-08-04 07:12:39 -07:00
John McCutchan 7640cf4b85 Fix test failure 
patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001)

Review URL: https://codereview.chromium.org//1270953003 .
 2015-08-04 07:05:34 -07:00
Todd Turnidge 2eeb8ef945 Fix failing version test. 
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1267183002 .
 2015-08-03 15:12:44 -07:00
Todd Turnidge fa1d1e9faf Observatory fixes: 
- Fix bug where we incorrectly tell the user to use "anext".
- Allow debugger input box to retain focus when curly-blocks are expanded.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1265153005 .
 2015-08-03 13:16:30 -07:00
John McCutchan 390a44ccdf Make Observatory analyzer clean 
BUG=

Review URL: https://codereview.chromium.org//1267033002 .
 2015-07-31 14:57:55 -07:00
John McCutchan fc2d849cd5 Fix http requests and the crash dump RPC 
- Fix HTTP and crash dump service requests by giving them a non-null id.
- Add basic heartbeat test for _getCrashDump RPC over HTTP.
- Fix some analyzer warnings.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1266943005 .
 2015-07-31 14:38:04 -07:00
Daniel Andersson 40fc14d75a Fix incorrect expectation in allocations_test. 
The old code worked most of the time, since the Foo objects were usually not promoted to oldspace.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1269553004 .
 2015-07-31 14:34:23 -07:00
Rico Wind 93ec16c34c Nuke some whitespace in observatory 
R=johnmccutchan@google.com
BUG=

Review URL: https://codereview.chromium.org//1255273007 .
 2015-07-30 17:47:50 +02:00
Ryan Macnak 8c98455ab5 Retaining path improvements. 
- Don't answer retaining paths that go through ICData.
 - Associate edge labels with the referer instead of the referent.
 - Give edge labels for VM classes (offsets only).
 - Make is possible to distinguish closures and functions from their refs.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1246073005 .
 2015-07-28 15:56:10 -07:00
John McCutchan d3154f4247 Logging page 
- Per isolate logging page.
- Drop down to control log level threshold.
- Console area where messages are displayed.
- UI test.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1250853006 .
 2015-07-22 14:33:13 -07:00
Ryan Macnak f26050ce08 Automatically step past async state-machine switch for 'anext'. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1244983002 .
 2015-07-21 10:36:00 -07:00
John McCutchan bfd2d4ed2a Refactor dart:developer log to use named parameters 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1247803002 .
 2015-07-21 10:01:37 -07:00
John McCutchan f818f9dc0f Support piping log data over the service protocol 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241683005 .
 2015-07-21 07:54:46 -07:00
Ryan Macnak ba27c453ed Remove a source of flakiness from async_step_test. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1234783007 .
 2015-07-20 10:21:45 -07:00
Ryan Macnak 4b5d321682 Add prints to help diagnose flaky async_step_test failure. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1234203003 .
 2015-07-17 11:08:02 -07:00
Ryan Macnak 0979a7b23e Async-step, first cut. 
Also fix inclusion of internal variables from outer scopes in var descriptors.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1241673003 .
 2015-07-16 13:05:37 -07:00
Ryan Macnak c165fee611 Insert debug step check at the beginning of a function. 
BUG=http://dartbug.com/23827
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1237203002 .
 2015-07-14 15:27:44 -07:00
John McCutchan b6b3c3e93b Make observatory tests analyzer clean 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1238803002 .
 2015-07-14 13:49:08 -07:00
Todd Turnidge f544a3c3ca Fix problem when running new test in checked mode. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1237893002 .
 2015-07-14 13:43:23 -07:00
Todd Turnidge e4684c7627 Provide stdout and stderr output in the Observatory debugger. 
Implement two new streams, 'Stdout' and 'Stderr' in the service protocol.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1232193003 .
 2015-07-14 12:54:07 -07:00
John McCutchan a92a3c8af3 Expose allocation tracing over service protocol 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1231603008 .
 2015-07-14 11:41:57 -07:00
Ryan Macnak 1ef2b68e65 Deal with Javascript integer limitations in heap snapshot processing to handle 64-bit target VMs. 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1219103002 .
 2015-07-13 17:27:55 -07:00
Srdjan Mitrovic a3e1db6263 Fix --compile_all flag (--compile-all is wrong) 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1230883002 .
 2015-07-09 13:16:37 -07:00
Todd Turnidge c4dad3117a Make VM event streams look like real dart streams. 
This is a bit ugly in that vm event streams are created
asynchronously, which is not very natural with the dart libs.

Update tests accordingly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1217823009 .
 2015-07-08 14:18:59 -07:00
John McCutchan b4e416dde8 Fix analyzer error in get_ports_rpc_test.dart 
BUG=

Review URL: https://codereview.chromium.org//1196663004.
 2015-06-19 10:41:33 -07:00
John McCutchan b4c1344100 Add _getPorts rpc test 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1194893002.
 2015-06-19 09:52:37 -07:00
Ryan Macnak 723334d344 UI for setting/clearing closure-specific breakpoints. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1191133002.
 2015-06-18 14:01:19 -07:00
Ryan Macnak 392a83221f Allow setting break-on-exceptions option over the service protocol. Add command to Observatory's debugger. 
Decide whether to cache service objects based on the fixedId property.

Be more tolerant of eval scripts and functions.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1174313002.
 2015-06-15 12:05:23 -07:00
Florian Schneider 265a54411a Object pool with support for untagged entries. 
This adds meta-information to object pool entries to allow storing
untagged immediates or code addresses (ExternalLabel) directly.

This eliminates the need to generate extra code to preserve the LSB
when storing immediates as smis (x64, arm64).

BUG=

Review URL: https://codereview.chromium.org//1175523002.
 2015-06-10 11:41:22 +02:00
Ryan Macnak 304382c1b4 Add TypedData instance kinds. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1157003003.
 2015-06-08 17:30:11 -07:00
Todd Turnidge 996f012707 2nd attempt at adding streamListen/streamCancel to the service protocol. 
This time I am committing the protocol changes first and saving the
Observatory changes for a second cl.

------

We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph.

Only generate events when at least one client is listening to the
corresponding event stream.

Only send events to the clients that actually request them.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1166433008
 2015-06-04 09:57:22 -07:00
Todd Turnidge 1b59b9ea06 Service cleanups... 
- Allow for multiple breakpoints in the service protocol.
  The info isn't actually provided or used yet.
- Drop index for list elements returned by the protocol.  Flatten structure.
- Drop index for context elements.  Keep sub-structure so we
   can choose to add extra slot info later.
- Errors now have ids and kinds.
- exception and stacktrace move from @Error to Error.
- All heap Objects now include class/size.
- Changed BoundedType.type and TypeRef.type to different names.
  Turns out we already have a "type" property that conflicts.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1152753005
 2015-06-04 09:09:22 -07:00
Srdjan Mitrovic b666398745 Fix fix (again) 
BUG=

Review URL: https://codereview.chromium.org//1153413006
 2015-06-03 17:13:27 -07:00
Srdjan Mitrovic 1c18123cea Fix analyzer run on bot 
BUG=

Review URL: https://codereview.chromium.org//1162023007
 2015-06-03 16:52:20 -07:00
Regis Crelier a5669190ab Fixed breakpoint handling at return statement with inlined finally clauses. 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1170483002
 2015-06-03 15:25:42 -07:00