dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1103 Commits

Author SHA1 Message Date
Devon Carew 60a8ed5d47 Fix some observatory analysis issues. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2920603003 .
 2017-06-08 23:59:26 -07:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files. 
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
 2017-06-02 10:38:14 +02:00
Ryan Macnak 2abda1fdd7 Observatory: 
- Add M.Isolate.collectAllGarbage.
 - Add 'count' parameter to ObjectRepository.get.
 - Set hover text in heap map so it is usable when it doesn't fit on one page.

R=asiva@google.com, devoncarew@google.com

Review-Url: https://codereview.chromium.org/2914283002 .
 2017-06-01 14:26:46 -07:00
Siva Chandra ffeaa4a46d Hit breakpoints in single line closures. 
Before this change, breakpoints on lines like the following were not hit:

var singleLineClosure = (int a, int b) => return a + b;

The reason was that breakpoints were only resolved if their start token
was contained within a function. Since that is not true for closure vars
like in the above example, the breakpoints were never getting resolved.
This change avoids such a problem by resolving breakpoints if the token
range of the breakpoint overlaps the token range of a function.

Fixes #29736

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2912763005 .
 2017-06-01 11:26:06 -07:00
Siva Chandra a5aaa7f5eb Update test failures after 3b9cf73. 
BUG=
TBR=aam

Review-Url: https://codereview.chromium.org/2907003002 .
 2017-05-26 22:57:24 -07:00
Erik Corry bd6f0800fc Fix flaky test that makes assumptions about other things on the heap 
R=whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2896583002 .
 2017-05-19 16:58:35 +02:00
Ryan Macnak 03a2c24edf vm-service: Add optional 'scope' parameter to 'evaluate' and 'evaluateInFrame'. 
Closes #29535

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2872503004 .
 2017-05-18 18:02:49 -07:00
Ryan Macnak 1bf31322ad Omnibus Observatory UI fixes: 
- Globally replace InstanceRepository with ObjectRepository. In general, instances may reference non-instances, so we should not assume we'll only get instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or context.

R=aam@google.com, mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2873013004 .
 2017-05-09 17:00:34 -07:00
Ryan Macnak c301c62b1f Avoid error in Observatory about trying to load file not included in the Observatory assets. 
Related to issue #29577

R=zra@google.com

Review-Url: https://codereview.chromium.org/2870713002 .
 2017-05-08 14:00:11 -07:00
Jens Johansen 2074c40919 Add more text output to service test pause_on_start_then_step_test 
This test has timed out on the bots, but it isn't clear when exactly
it 'stops responding'.

This CL adds a few more lines of output in an attempt to make it
more clear (on any new timeout) where it stops responding.

See https://github.com/dart-lang/sdk/issues/29568 for example timeout.

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2861673008 .
 2017-05-08 08:39:33 +02:00
Karl Klose 8a9775e8ab [Gardening] Revert status file change for contexts_test on dartk after reverting 7a463a 
TBR=jensj@google.com

Closes #29513

Review-Url: https://codereview.chromium.org/2854093002 .
 2017-05-02 16:53:38 +02:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Ryan Macnak c49420ca65 [gardening] Mark service/contexts_test as failing with -cdartk. 
Issue #29513

Review-Url: https://codereview.chromium.org/2844803006 .
 2017-04-28 13:22:02 -07:00
Florian Loitsch 902bb48908 Mark get_isolate_rpc_test as flaky. 
Review-Url: https://codereview.chromium.org/2842763002 .
 2017-04-25 15:20:07 +02:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Jacob Richman b67e83eea3 Format all remaining unformatted runtime files other than multitests. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2829463003 .
 2017-04-18 15:34:03 -07:00
John McCutchan 99c6a18a1b Attempt 2 -- Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

Review-Url: https://codereview.chromium.org/2810223003 .
 2017-04-12 14:02:19 -07:00
John McCutchan f0734f99b3 Detect unhandled exceptions in async functions without an awaiter 
- [x] Produce an awaiter stack trace even when there is no awaiter.
- [x] Fix fetching the saved context from Closure.call (fixes --trace_debugger_stacktrace)

Fixes #29200

Example code:

```
main(List<String> args) async {
  var f = new Foo();
  print(f.a.length);
  print('Should not get here');
}

class Foo {
  String a;
}
```

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2815863002 .
 2017-04-12 13:15:41 -07:00
John McCutchan 94df115e4b Revert "Fix updating packages map on reload and add a regression test" 
This reverts commit 7a2d67f3ba.

BUG=

Review-Url: https://codereview.chromium.org/2808953003 .
 2017-04-10 12:30:38 -07:00
John McCutchan bf3d374541 Dump some state when complex_reload_test fails 
BUG=

Review-Url: https://codereview.chromium.org/2814573002 .
 2017-04-10 12:13:16 -07:00
John McCutchan 7a2d67f3ba Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2797923008 .
 2017-04-10 08:59:10 -07:00
Peter von der Ahé 1e70fef1a2 Small steps towards deferred loading. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2803833003 .
 2017-04-07 12:23:35 +02:00
Dmitry Olshansky 19a352e0f5 Reland: VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator 
This allows us to bypass allocation of Context for some sync*
function such as in Iteration.tree.syncstar benchmark.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2803853004 .
 2017-04-06 17:18:40 +02:00
Peter von der Ahé 0df001cebf Implement various getters on DillMember. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2799783004 .
 2017-04-06 10:54:48 +02:00
Vyacheslav Egorov 7e1d584218 VM: [Kernel] Implement CatchBlockEntryInstr::should_restore_closure_context on all platforms. 
This was the only Kernel specific backend change - to simplify the graph builder
we allowed it to capture exception and stack trace variables. This in turn
requires CatchBlockEntryInstr to respect that this variables can be captured
and correctly update them when exception is caught.

This was implemented on X64 and ARM before. This CL expands implementation to
all other implementations including DBC.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2796283003 .
 2017-04-05 20:32:03 +02:00
Florian Loitsch cb426d5d21 Mark service/pause_on_unhandled_async_exceptions2_test as crashing. 
Review-Url: https://codereview.chromium.org/2804643002 .
 2017-04-05 14:23:29 +02:00
John McCutchan e33e09a23c Disable async debugger support until context mismatch issue is resolved. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2795303002 .
 2017-04-04 13:36:42 -07:00
Zachary Anderson 78706025da [vm service] Collect garbage before getting native allocation samples 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2795473003 .
 2017-04-03 09:12:52 -07:00
Siva Annamalai 4654381213 Move kernel related status lines from service.status to service_kernel.status 
Review-Url: https://codereview.chromium.org/2789993002 .
 2017-03-31 17:57:09 -07:00
Siva Annamalai 74229dfb1f Adjust status file to account for build breakage. 
TBR=fschneider

Review-Url: https://codereview.chromium.org/2793683002 .
 2017-03-31 14:51:45 -07:00
John McCutchan 4c4c9f2ce6 Fix test failure and add new awaiterFrames to service_dev.md 
BUG=

Review-Url: https://codereview.chromium.org/2788993002 .
 2017-03-31 13:18:07 -07:00
John McCutchan 193f26d1e1 Implement support for single stepping out of an async function. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2785243003 .
 2017-03-31 10:55:11 -07:00
Karl Klose 4b7e73fe00 [Gardening] Mark service/async_generator_breakpoint_test as slow on dartk 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2786343002 .
 2017-03-31 08:52:09 +02:00
Florian Schneider 22d5833ae4 Fix analyzer warnings in a test. 
Review-Url: https://codereview.chromium.org/2787063003 .
 2017-03-30 12:13:34 -07:00
Florian Schneider 5a3f9d9398 Fix a couple of bugs with async stack traces 
Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in ActivationFrame::ContextLevel. This is planned for a separate CL.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2786503003 .
 2017-03-30 11:02:33 -07:00
Lasse R.H. Nielsen ed9c76421e Mark service/async_scope_test as slow on windows+checked+debug. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2783173002 .
 2017-03-30 15:04:06 +02:00
John McCutchan 66aca8a36e Fix many warnings/errors when building Observatory 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2783933002 .
 2017-03-29 10:31:40 -07:00
John McCutchan 0e9b4123db Mark awaiter_async_stack_contents_test as failing on kernel bots 
BUG=

Review-Url: https://codereview.chromium.org/2787523002 .
 2017-03-29 08:47:14 -07:00
John McCutchan 2815f3f775 Implement debugger support for async step-out 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2777093006 .
 2017-03-29 07:44:18 -07:00
John McCutchan d8555fb5a8 Include the awaiter stack trace in the service protocol 
- [x] Include the (non-empty) awaiter stack trace in every `getStack` RPC.
- [x] Append the causal stack trace to the final frame of the awaiter stack trace.
- [x] Unit test for awaiter stack trace.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2782703002 .
 2017-03-29 06:56:50 -07:00
Jens Johansen 2ad253ed6b Mark pause_on_unhandled_async_exceptions2_test flaky on app_jit 
See https://github.com/dart-lang/sdk/issues/29178.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2774233004 .
 2017-03-28 08:59:50 +02:00
Ben Konyi 7c820f4363 Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and stack trace collection skip counts for different configurations. 
Fixed missing method referenced when MallocHooks is unsupported.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2771293003 .
 2017-03-27 13:25:26 -07:00
John McCutchan ada90ae4f2 Update the correct status file for the kernel bots 
BUG=

Review-Url: https://codereview.chromium.org/2773073004 .
 2017-03-24 14:54:30 -07:00
John McCutchan bfde95b58f Update status file for kernel bot 
BUG=

Review-Url: https://codereview.chromium.org/2775863005 .
 2017-03-24 14:49:35 -07:00
Ben Konyi 9ea672efc0 Revert "Added page to Observatory to display native memory allocation information." 
This reverts commit f30f312b48.

Revert "Fixed missing method referenced when MallocHooks is unsupported."

This reverts commit a0b9c5a178.

TBR=johnmccutchan@google.com

BUG=

Review-Url: https://codereview.chromium.org/2773073003 .
 2017-03-24 09:47:29 -07:00
Ben Konyi f30f312b48 Added page to Observatory to display native memory allocation information. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2748403002 .
 2017-03-24 09:20:25 -07:00
John McCutchan 07a257573d Debugger support for step-into async and async* functions. 
- [x] Support stepping into an async function.
- [x] Support stepping into the async generator in an await for loop.
- [x] Unit test for async function.
- [x] Unit test for async* function.

BUG=
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2768103002 .
 2017-03-24 07:56:50 -07:00
Peter von der Ahé ec5d7cba1a Implement character offsets for fields and enum constants. 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2771983004 .
 2017-03-24 15:29:42 +01:00
Ben Konyi c0511ad2ef Reimplemented zone memory tracking to avoid race conditions that were causing crashes in the previous implementation and made some minor name changes. 
BUG=
R=asiva@google.com, johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2762323002 .
 2017-03-23 09:03:08 -07:00
Jens Johansen dc566e137b [kernel] Fix getter, run service tests in debug mode 
Don't create getters for uninitialized static fields.
This fixes two assert hits that was hit when running service tests in debug mode via kernel. These can thus now be enabled.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2771443003 .
 2017-03-23 08:26:10 +01:00