2d0a08baf9
Make reloadSources service RPC public
...
- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true, the isolate will enter the debug pause loop immediately after reloading sources and before resuming execution. This makes it possible for debugger clients to set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2411153002 .
2016-10-13 07:45:56 -07:00
48c6f19600
Respect setLibraryDebuggable
...
- [x] Mark all libraries debuggable by default
- [x] Mark all dart:_* libraries as not debuggable by default
- [x] Respect setLibraryDebuggable
- [x] Add set library debuggable test case
- [x] Do not allow dart:_* libraries to be marked debuggable
Fixes https://github.com/dart-lang/sdk/issues/27370
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2361183002 .
2016-09-23 10:45:51 -07:00
8610536da7
Misc Observatory tweaks.
...
- Fix profiler mode descriptions.
- Add count for ports and class hierarchy.
- Group 'heap snapshot' and 'heap map' together.
R=johnmccutchan@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org/2359553002 .
2016-09-20 12:44:36 -07:00
699e328105
Fix VM connect element test
...
BUG=
Review URL: https://codereview.chromium.org/2348313002 .
2016-09-19 07:33:44 -07:00
e2b922b4c5
Fix service test websocket error edge case
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2343183002 .
2016-09-16 10:31:05 -07:00
0d831bd5c8
Use Chain.capture instead of runZoned
...
- [x] Swap all calls of runZoned to Chain.capture.
Chain.capture is a wrapper around runZoned that tracks stack traces across asynchronous gaps.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2349753002 .
2016-09-16 09:44:06 -07:00
7fca076fbb
Use dartfmt on Observatory code
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2345023003 .
2016-09-16 06:59:51 -07:00
47cc06ae66
Shrink AOT snapshot size and memory usage.
...
- Conditionally remove fields of Code, Function and ICData that are not used in the AOT runtime.
- Don't include RawClosureData.context_scope_ in AOT snapshots.
- Remove parameter names not needed for method resolution.
- Remove parameter types not needed for function type tests.
- Deduplicate parameter name and parameter type lists.
- Shrink and share the initial MegamorphicCache table.
Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap 7899568 -> 5433176 (-31.2%)
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2326483005 .
2016-09-15 15:06:42 -07:00
57d558fa5f
Observatory: Fix instance view of lists.
...
Fixes #27351 .
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2342943002 .
2016-09-15 13:35:18 -07:00
72b79d970b
Improve VM connection flow in Observatory
...
- [x] Don't show "(Connected)" next to a VM we aren't connected to.
- [x] Navigate to the vm-connect page if we get an initial connection error.
- [x] Fix regression of the 'vm disconnected' notification bubble not appearing.
- [x] Use the Uris helper class instead of hard coded paths
- [x] Improve user inputted URI normalization
- [x] Ignore network errors on stream subscription requests
- [x] On first launch, attempt to connect to the default target and not the last target connected to.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2340973002 .
2016-09-15 11:29:06 -07:00
87dcad607e
Cleanup some Observatory errors caught by dart2js
...
Not sure why the analzyer didn't notice these but dart2js (when invoked via pub serve does).
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2339303003 .
2016-09-14 15:45:14 -07:00
cd4c9fc46b
Observatory: Fix allocation profile CSV export. Fix heap snapshot in/out reference counts.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2340883002 .
2016-09-14 15:44:28 -07:00
1b4afdab2d
Restored SVGs in Observatory script-inset element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2328943003 .
2016-09-09 09:58:07 -07:00
ebc0c261a5
Minor UI tweaks.
...
R=cbernaschina@google.com
Review URL: https://codereview.chromium.org/2324833005 .
2016-09-09 09:55:50 -07:00
5b838cfb01
Allow to compact header in allocation-profile
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2322643004 .
2016-09-08 14:36:43 -07:00
de2cea8f57
Added missing content to nav-top-menu
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2325613003 .
2016-09-08 10:47:40 -07:00
d9a886c397
Reverted change to ServiceMap
...
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org/2323543002 .
2016-09-07 15:03:00 -07:00
5177c2bca9
Removed polymer & mirror from Observatory
...
web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version
Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2310003004 .
2016-09-07 14:15:27 -07:00
876f49999a
Converted Observatory debugger elements
...
R=rmacnak@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org/2312553002 .
2016-09-06 15:05:44 -07:00
cfefe97495
Converted Observatory metrics-page element
...
Major restyle
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2303173002 .
2016-09-06 09:56:16 -07:00
bc5a41edf8
Fixed crash of Observatory class-view element
...
Fixes=https://github.com/dart-lang/sdk/issues/27222
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2308003002 .
2016-09-02 11:12:44 -07:00
c38769ea9a
Converted Observatory timeline-page element
...
Not fully testable
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2299613004 .
2016-09-02 10:38:40 -07:00
2eab4de315
Converted Observatory logging-page element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2299893003 .
2016-09-02 10:27:48 -07:00
b31829db24
Converted Observatory json-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2305693003 .
2016-09-02 10:23:29 -07:00
98a67efbd2
Manage null CallSite receivers in script-inset
...
Fixes=https://github.com/dart-lang/sdk/issues/27222
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org/2302163002 .
2016-09-01 15:15:31 -07:00
5703296fe6
Avoid to return null in anyRef if object is not known
...
Fixes=https://github.com/dart-lang/sdk/issues/27222
TBR=rmacnak@google.com
Review URL: https://codereview.chromium.org/2303073002 .
2016-09-01 14:47:35 -07:00
741d99f100
Converted Observatory code-view element
...
Not fully testable
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2306483002 .
2016-09-01 13:56:45 -07:00
90c50c52f2
Converted Observatory vm-view && isolate-view elements
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2304463002 .
2016-09-01 10:46:36 -07:00
1341e94321
Converted Observatory class-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2294073003 .
2016-08-31 17:03:38 -07:00
1a1224b1d3
Removed const from classes arrays in Observatory
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2298563002 .
2016-08-30 15:38:07 -07:00
bf7d220741
Converted Observatory instance-view element
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org/2291233002 .
2016-08-30 14:53:24 -07:00
19e9627ea0
Converted Observatory library-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2289953003 .
2016-08-30 13:58:15 -07:00
0083d2610e
Converted Observatory object-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2294473002 .
2016-08-30 13:39:12 -07:00
b63546ac57
Converted Observatory function-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2291823002 .
2016-08-29 16:39:38 -07:00
0a23299d65
Fixed observatory header buttons font
...
Fixes=https://github.com/dart-lang/sdk/issues/27194
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2296453002 .
2016-08-29 16:28:29 -07:00
3b16691da1
Converted Observatory script-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2283263002 .
2016-08-29 13:33:55 -07:00
9a18a1b5eb
Added quickExpressions support to Observatory eval-box element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2281903003 .
2016-08-29 12:36:23 -07:00
a326a56eb1
Converted Observatory object-pool-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2283863003 .
2016-08-29 11:14:18 -07:00
8e7725a8b4
Converted Observatory field-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2287793002 .
2016-08-29 10:47:05 -07:00
b4d833182f
Avoid to updated selection on links click in cpu-profile-table
...
TBR=rmacnak@google.com
Fixes=https://github.com/dart-lang/sdk/issues/27190
Review URL: https://codereview.chromium.org/2285303002 .
2016-08-29 10:04:14 -07:00
5e1b224ef8
Converted Observatory megamorphiccache-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2279203003 .
2016-08-26 15:22:51 -07:00
2442b3a9c3
Fixed isolate-shared-summary layout problems
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2286823002 .
2016-08-26 12:55:40 -07:00
2dbd1b2158
Converted Observatory error-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2286503002 .
2016-08-26 10:23:34 -07:00
12e8f86cf6
Converted Observatory persistent-hangles-page element
...
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2273203004 .
2016-08-26 10:15:34 -07:00
bdbd443317
Converted Observatory heap-map element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2279973002 .
2016-08-26 10:00:48 -07:00
4f96ad0440
Converted Observatory objectstore-view element
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2274013006 .
2016-08-26 09:44:24 -07:00
c39868c8a5
Converted script-inset, source-inset and eval-box elements
...
Testing postponed
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/2277543004 .
2016-08-26 09:27:56 -07:00
d644dc0661
Prevent the allInstances array from creating spurious references on future heap queries.
...
Also prevent spurious references to Fields from retaining path's work array.
Fixes #27156
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2278223002 .
2016-08-25 11:26:15 -07:00
b313b5cef9
Using HeapSnapshotClassOutbound for outbound references
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2277073002 .
2016-08-24 17:04:06 -07:00
942918347c
Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField
...
Fixes=https://github.com/dart-lang/sdk/issues/27146
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2277093002 .
2016-08-24 16:56:57 -07:00
John McCutchan