dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

678 Commits

Author SHA1 Message Date
Todd Turnidge 7ac3150ee3 Improve display of simd vector types and stack traces in Observatory. 
Associated protocol changes.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1316123004 .
 2015-08-31 10:35:01 -07:00
Todd Turnidge de300cfa0e Process service events as microtasks. 
This preserves the ordering among rpc responses and events.

Add assertions that events are processed in order.

Add a correct timestamp for Resume events when we are paused at start.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1315673007 .
 2015-08-27 12:31:06 -07:00
John McCutchan c9a4013553 More logging for pause tests 
BUG=

Review URL: https://codereview.chromium.org//1310863004 .
 2015-08-26 16:45:36 -07:00
Todd Turnidge 1587f88c2d Change how instance/list/map references are displayed when expanded. 
The goal is to not indent as deeply as we were doing before.  Stop
using tables.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1314763005 .
 2015-08-26 11:20:08 -07:00
John McCutchan d0882dd363 Remember when an isolate was paused and subtly display it in Obseravatory 
- Display paused time as tooltip over "paused" word.
- Send a timestamp with every ServiceEvent.
- Unit tests verifying that paused on start, exit, and breakpoint timestamps are stable.
- Remember the pause time in DebuggerEvent.
- Remember the pause time in MessageHandler.
- Updated service protocol documentation.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1311503004 .
 2015-08-26 10:57:59 -07:00
Todd Turnidge d6060d2ddd Don't allow variables to overwrite the frame edge. 
Make the variables demand a bit more room in general.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1307323003 .
 2015-08-25 12:52:16 -07:00
Todd Turnidge bc28a64f20 Allow script insets to scroll. 
Closes #23959

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1309223002 .
 2015-08-24 11:35:01 -07:00
Ryan Macnak 85ef528eaa Fix two typos in Observatory. 
BUG=http://dartbug.com/24181
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1311083003 .
 2015-08-24 10:02:49 -07:00
Todd Turnidge 7e8bb130f2 Add an IsolateRunnable event to the service protocol. Improve service docs. 
Closes #24140

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1293383011 .
 2015-08-21 10:25:38 -07:00
Todd Turnidge f5075eda0b Update debugger console height when window is resized. 
Closes #23985

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1305163002 .
 2015-08-21 09:57:25 -07:00
Ryan Macnak b7a8c29d92 Highlight the whole token when marking the current execution. Truncate call site annotations to one token. 
Fix display of retained size for a class's top retaining instances for non-Instances.

Fix type of Instance.pattern.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1302533003 .
 2015-08-19 13:10:09 -07:00
Ryan Macnak 9162166b54 Functions are objects too! 
- Fix allInstances of non-Instances.
 - Fix loading _vmName.
 - Make refs of top-level classes (::) display something instead of empty string.
 - Fix inbound references to display C++ word offsets like retaining path.
 - Make inbound references and retaining path to display '<root>' instead of empty.
 - Make more types display heap object tools.
 - Add missing function kind for signature functions.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1300853006 .
 2015-08-19 11:18:21 -07:00
Ryan Macnak 07b6dad1f5 Automagically change the meaning of 'next' to 'async-next' when paused at an async function at await/yield. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1299083002 .
 2015-08-18 15:36:13 -07:00
Ryan Macnak 294c6a47a4 Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls and the predefined symbols table. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//1295693002 .
 2015-08-14 10:10:34 -07:00
Ryan Macnak 3851c8c0ed Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. 
BUG=http://dartbug.com/24039
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1284063003 .
 2015-08-13 15:50:02 -07:00
John McCutchan 71d7d7a4de Fix table cpu profile to work properly with non-dart functions 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1283413002 .
 2015-08-13 09:46:44 -07:00
John McCutchan 3dd39ef37c Fix cpu profile table 
- Add back deleted call to buildFunctionCallerAndCallees
- Pass in caller count and not callee count (copy and paste bug)
- Add to isolate drop down

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1288853002 .
 2015-08-12 17:38:34 -07:00
John McCutchan cacacfa645 Hide empty CPU profile on class page 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1290023002 .
 2015-08-12 16:39:23 -07:00
John McCutchan 2ecf40450c Make function-ref only show a link for Dart functions 
BUG=

Review URL: https://codereview.chromium.org//1289803007 .
 2015-08-12 16:13:26 -07:00
John McCutchan 7af879a084 Fix time span in profiler 
BUG=

Review URL: https://codereview.chromium.org//1287033006 .
 2015-08-12 16:03:27 -07:00
John McCutchan 8e91f1a7c3 Fix heap map 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1291873002 .
 2015-08-12 15:31:17 -07:00
John McCutchan f9944c1c4c Synchronize isolate dropdown with isolate summary 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1285143004 .
 2015-08-12 15:21:06 -07:00
Ryan Macnak 82b4f03dec Fix overly-strict parameter checking of _getCallSiteData. 
Ensure padding between columns in allocation profile.

Desaturate the red used for methods with optimization issues.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1287043007 .
 2015-08-12 15:20:46 -07:00
John McCutchan 10de20f230 Remove load graph from isolate 
BUG=

Review URL: https://codereview.chromium.org//1290643005 .
 2015-08-12 15:13:11 -07:00
Ryan Macnak 919f79e044 Fix links to script + line. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1286943005 .
 2015-08-12 12:42:52 -07:00
Ryan Macnak 62dbce8555 Make declaration annotations direct links; update annotations after the library's declarations are fully loaded. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1289913002 .
 2015-08-12 12:37:11 -07:00
John McCutchan d0f216eb30 Suppress stream subscription error 
- Hides a scary exception popup in the debugger in Dartium (where stdout and stderr streams are not available).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1289923002 .
 2015-08-12 11:11:15 -07:00
Todd Turnidge cc981c8246 Don't use %p when generating disassembly in vm service. 
Evidentally it is platform dependent -- it seems to include the 0x
prefix on mac but not on windows.  I've switched to using %" Px "
instead.

This will fix bug 24038.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1282993002 .
 2015-08-11 11:22:55 -07:00
John McCutchan a8e2180b78 Fix short jump address calculation in x64 disassembler 
- Make Observatory robust to weird jump addresses.
- Use signed address offset when computing short jump target address.

R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//1273223004 .
 2015-08-11 06:17:58 -07:00
Ryan Macnak 73cfbce0bc Minor Observatory UI tweaks. 
- Display the root script on a library's page.
 - Display the root library's root script on the isolate page.
 - Display a script inset on a field's page.
 - Fix switching between singe- and multi-line evalators.
 - Display count of open ports.
 - Ensure fields are annoated with a field reference rather than a reference to an implicit getter or setter.
 - Annotate library, import, export, part, part of.

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1275173003 .
 2015-08-10 15:57:52 -07:00
Todd Turnidge 256b044857 Allow stepping when paused at isolate start. 
Fix tests.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1285643004 .
 2015-08-10 14:26:01 -07:00
John McCutchan 2306fd2fcc Don't analyze some tests that depend on bleeding edge SDK support 
BUG=

Review URL: https://codereview.chromium.org//1273373003 .
 2015-08-10 10:44:02 -07:00
Todd Turnidge 64216a8cd0 Revert "Allow stepping when paused at isolate start." 
This reverts commit 319214f58b.

BUG=

Review URL: https://codereview.chromium.org//1286493003 .
 2015-08-10 10:29:31 -07:00
Todd Turnidge 319214f58b Allow stepping when paused at isolate start. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1276243004 .
 2015-08-10 09:52:55 -07:00
Todd Turnidge a5c0dbfffe Fix the continue command. 
BUG=

Review URL: https://codereview.chromium.org//1271183004 .
 2015-08-07 13:28:11 -07:00
Todd Turnidge 5b6136fdfb Refactor the set command in Observatory debugger. 
- set with 0/1 args now can be used to query current setting value
- added completion for set command
- added up-is-down option to provide gdb-like behavior for up/down commands

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1277173004 .
 2015-08-07 13:22:21 -07:00
John McCutchan 2b2d4cf1bf Make allocation profile configurable (tags, function v. code) 
- Add sample-buffer-control and stack-trace-tree-config elements to class view to control how the allocation profile is displayed.
- Unrelated: Stop showing I/O/U next to functions in the profile.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1273323002 .
 2015-08-07 12:46:19 -07:00
Todd Turnidge 97a4ae8f94 Add hotkeys to Observatory debugger. 
Add 'cls' command to clear the console.

From 'help hotkeys':

List of hotkeys:

[TAB]        - complete a command
[Up Arrow]   - history previous
[Down Arrow] - history next

[Page Up]    - move up one frame
[Page Down]  - move down one frame

[F7]         - continue execution of the current isolate
[Ctrl ;]     - pause execution of the current isolate

[F8]         - toggle breakpoint at current location
[F9]         - next
[F10]        - step

BUG=24010
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1270283003 .
 2015-08-07 10:38:40 -07:00
Ryan Macnak e3d7903862 Add timing prints to object group to get a baseline. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1272823006 .
 2015-08-07 10:22:11 -07:00
Todd Turnidge 49a61ba3f5 Allow users to remove evaluation results. 
BUG=20555
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1275163002 .
 2015-08-06 17:08:33 -07:00
Todd Turnidge 38b9945cfd Improve display of library dependency information. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1276013002 .
 2015-08-06 12:55:33 -07:00
Todd Turnidge 227010d9dc Order the vm's isolate list by isolate start time. 
This has the effect of making isolate lists more predictable for the user.

BUG=23717
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275713002 .
 2015-08-06 10:17:07 -07:00
Todd Turnidge f73b8aa019 Resolve some input focus issues for the debugger. 
We were dropping clicks with selection type "None" on the floor, mistakenly.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1275543004 .
 2015-08-05 12:43:20 -07:00
Todd Turnidge 401075fbbf Remember when a variable has been expanded/unexpanded in the debugger. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1269083006 .
 2015-08-03 14:54:23 -07:00
Todd Turnidge fa1d1e9faf Observatory fixes: 
- Fix bug where we incorrectly tell the user to use "anext".
- Allow debugger input box to retain focus when curly-blocks are expanded.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1265153005 .
 2015-08-03 13:16:30 -07:00
John McCutchan 868109bf97 Auto scroll debugger console text only when already scrolled down 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1263853004 .
 2015-08-03 12:50:50 -07:00
John McCutchan 33831aaa6b Add log support to debugger 
- Add 'log' command to control log level.
- Manage Logging stream subscription whenever isolate changes.
- Rename _VMStreamPrinter to _ConsoleStreamPrinter.
- Pipe log events to _ConsoleStreamPrinter.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1258063005 .
 2015-08-03 12:42:59 -07:00
John McCutchan 319b274362 Stop displaying inline, optimized, and unoptimized tags next to functions in profile tree 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1269843007 .
 2015-07-31 15:04:55 -07:00
John McCutchan 390a44ccdf Make Observatory analyzer clean 
BUG=

Review URL: https://codereview.chromium.org//1267033002 .
 2015-07-31 14:57:55 -07:00
John McCutchan fc2d849cd5 Fix http requests and the crash dump RPC 
- Fix HTTP and crash dump service requests by giving them a non-null id.
- Add basic heartbeat test for _getCrashDump RPC over HTTP.
- Fix some analyzer warnings.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1266943005 .
 2015-07-31 14:38:04 -07:00