scheglov@google.com
3c4080aff2
Issue 5163. Constructor/member name conflict should be error
...
http://code.google.com/p/dart/issues/detail?id=5163
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//10969024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12660 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 21:31:09 +00:00
gram@google.com
60e02bec11
Move the addition of an onError handler to earlier (onInit instead of onStart), while still supporting its removal on onDone and reinstallation in subsequent onStarts.
...
Review URL: https://codereview.chromium.org//10959025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12658 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 21:08:01 +00:00
alanknight@google.com
ef2c2438b4
Really make the tool directory singular in intl
...
Review URL: https://codereview.chromium.org//10958006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12654 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 19:54:01 +00:00
johnniwinther@google.com
770f7eb2d6
Dartdoc supports package directory.
...
BUG=4634,5218
Review URL: https://codereview.chromium.org//10950025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12623 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 08:56:48 +00:00
gram@google.com
12633b46a6
Fixed a nasty bug in unittest, where is we have a non-async test that throws an exception, followed by an async test, the async test will not block and can end up 'passing' with no result set.
...
The problem is that when we throw the exception in the non-async test we don't break out of _nextBatch and we also add a call to _nextTestCase in _registerException. We should only do one of these; basically if the test is not async then we just stay in the _nextBatch loop; if it is async then we kick off the next test from in registerException.
Review URL: https://codereview.chromium.org//10946038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12606 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 21:28:03 +00:00
gram@google.com
bab0b240c3
Add explicit 'abstract' to abstract methods.
...
Review URL: https://codereview.chromium.org//10944039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12605 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 21:27:34 +00:00
rnystrom@google.com
a5c8f9f2da
Commit patch: https://codereview.chromium.org/10914320/
...
Thanks, Matt!
Review URL: https://codereview.chromium.org//10947044
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12603 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 21:17:49 +00:00
johnniwinther@google.com
942d0e26af
Convert dartdoc to use Args package
...
Committed on behalf of external committer.
BUG=3384
Review URL: https://codereview.chromium.org//10951024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12538 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:31:16 +00:00
efortuna@google.com
25d3eae1d6
Revert CLs by gram 12515-12526.
...
Review URL: https://codereview.chromium.org//10950020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12529 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 01:18:37 +00:00
alanknight@google.com
b9f933b920
Change intl to use new pub layout
...
Review URL: https://codereview.chromium.org//10952004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12519 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 22:18:15 +00:00
gram@google.com
99fbac3453
Issue 5152: Browser bots much more flaky after going "wrapperless"
...
Review URL: https://codereview.chromium.org//10951015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12515 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 21:43:52 +00:00
alanknight@google.com
2a96a33e66
Fix finding locale from OS on Windows
...
Review URL: https://codereview.chromium.org//10939002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12505 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 17:08:29 +00:00
bak@google.com
fd409f60a2
Reverting 12485 and 12480 just for the sake of mocking,
...
Review URL: https://codereview.chromium.org//10948005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12487 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 11:20:19 +00:00
bak@google.com
de07152be5
Fix argument test to use !? instead of ? (sigh).
...
Review URL: https://codereview.chromium.org//10948004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12485 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 10:57:59 +00:00
ager@google.com
1159462fc6
Switch from interfaces to abstract classes in dart:io.
...
Add a bunch of default argument values to the abstract classes
so they are picked up by dartdoc.
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//10938010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12484 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 10:54:37 +00:00
bak@google.com
d9c5ba5f84
- Removed comment to Frog and eliminated usage of sentinel.
...
It is not pretty BUT short of having a working reflective interface this change is an improvment.
Review URL: https://codereview.chromium.org//10944006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12480 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 10:24:33 +00:00
alanknight@google.com
989a9e3be2
Skip windows when finding browser locale from OS
...
Review URL: https://codereview.chromium.org//10928244
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12463 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 22:42:07 +00:00
alanknight@google.com
f12a2943f6
Find the system locale from the browser or OS
...
Review URL: https://codereview.chromium.org//10907266
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12461 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 22:25:48 +00:00
alanknight@google.com
5e1055ae74
Syntax error in intl pubspec.yaml
...
Review URL: https://codereview.chromium.org//10916344
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12456 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 21:07:16 +00:00
lrn@google.com
26fab5183a
Move parseInt parseDouble to int/double classes as a static method.
...
Remove math dependency from core/coreimpl in dart2js.
The existing Math.parseInt and Math.parseDouble are kept *for now*, but
simply redirect to the static methods.
They will be removed in time (when library code is ready for it).
Review URL: https://codereview.chromium.org//10913271
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12417 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 07:25:38 +00:00
efortuna@google.com
9163dfe93c
revert 1204. Will investigate when I get a chance.
...
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
gram@google.com
690e48da0d
WebDriver bindings.
...
Review URL: https://chromiumcodereview.appspot.com//10933051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12409 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 22:56:02 +00:00
rnystrom@google.com
bf1766ea63
Add missing files.
...
Review URL: https://codereview.chromium.org//10907245
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12407 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 22:44:40 +00:00
rnystrom@google.com
383488ec4f
Update unittest to new package layout.
...
Review URL: https://codereview.chromium.org//10917275
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com
659a57df3e
Revert "Make unittest follow the new package layout."
...
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.
Review URL: https://codereview.chromium.org//10911318
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com
2ba81033a6
Make unittest follow the new package layout.
...
Review URL: https://codereview.chromium.org//10918240
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
ahe@google.com
a6f34e5738
Hack to accept, but not use, colors option
...
BUG=http://dartbug.com/4996
Committed on behalf of Matthew Butler <butler.matthew@gmail.com >.
Review URL: https://codereview.chromium.org//10911311
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12384 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 13:34:02 +00:00
ager@google.com
4a2dc9f4cb
Update status files after fixes.
...
R=ngeoffray@google.com
BUG=
Review URL: https://codereview.chromium.org//10913272
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12376 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 11:21:56 +00:00
rnystrom@google.com
3c051bf78c
Disable dartdoc_test on dartium.
...
Review URL: https://codereview.chromium.org//10909222
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12360 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 01:14:21 +00:00
rnystrom@google.com
f3f22d89e9
Fail dartc dartdoc test.
...
Review URL: https://codereview.chromium.org//10905280
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12356 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 22:05:23 +00:00
rnystrom@google.com
8ee669bb71
Move dartdoc tests into dartdoc.
...
Review URL: https://codereview.chromium.org//10909214
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12352 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 21:15:39 +00:00
rnystrom@google.com
85a7fb9e55
Remove unneeded _IN_SDK stuff in dartdoc.
...
Review URL: https://codereview.chromium.org//10905276
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12350 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 21:01:59 +00:00
alanknight@google.com
2748b083f0
Add test that uses the basic example code
...
Review URL: https://codereview.chromium.org//10914272
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12349 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 19:58:16 +00:00
alanknight@google.com
88d3a194d5
dart:io usage still fails on dartc due to 5143
...
Review URL: https://codereview.chromium.org//10919269
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12346 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 18:33:56 +00:00
alanknight@google.com
282a347822
Add async initialization for Intl.message and an example
...
Review URL: https://chromiumcodereview.appspot.com//10915215
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12345 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 18:20:29 +00:00
rnystrom@google.com
a3872b3f4c
Fix dartdoc editor integration.
...
Review URL: https://codereview.chromium.org//10914267
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12343 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 17:48:30 +00:00
rnystrom@google.com
05dadf490e
Reorganize dartdoc to new package layout.
...
Review URL: https://codereview.chromium.org//10919260
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12338 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 16:49:48 +00:00
scheglov@google.com
ea65bbb961
Issue 3553. Stop treating static final variables as constants
...
http://code.google.com/p/dart/issues/detail?id=3553
http://code.google.com/p/dart/issues/detail?id=3476
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//10907215
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12336 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:49:07 +00:00
kasperl@google.com
1b994e881f
Change RegExp constructor to insist on proper named optional parameters.
...
R=bak@google.com ,lrn@google.com
BUG=
Review URL: https://codereview.chromium.org//10910253
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12329 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 14:00:32 +00:00
kasperl@google.com
997e534c28
Change Duration to take proper named optional parameters.
...
R=bak@google.com ,lrn@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10905255
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12314 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:17:31 +00:00
ahe@google.com
952ebb3a50
Enable wrapper-less browser tests on selenium.
...
Also fix bug 4631.
Review URL: https://chromiumcodereview.appspot.com//10916259
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12295 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 04:14:47 +00:00
rnystrom@google.com
8b5b96978b
Move logging to the new package layout.
...
Review URL: https://codereview.chromium.org//10908227
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12293 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 02:05:15 +00:00
rnystrom@google.com
e11b3b82fe
Make args package follow new layout.
...
Review URL: https://codereview.chromium.org//10919249
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12284 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 21:31:42 +00:00
rnystrom@google.com
f2a1253e98
Update htmlescape to new package layout.
...
Review URL: https://codereview.chromium.org//10910239
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12283 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 21:28:09 +00:00
rnystrom@google.com
1d9d8bab65
Take external patch from https://chromiumcodereview.appspot.com/10918056/ .
...
Review URL: https://codereview.chromium.org//10933052
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12278 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 19:26:49 +00:00
gram@google.com
21b7ffba73
Fix issue 4191.
...
Review URL: https://chromiumcodereview.appspot.com//10913135
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12276 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 18:30:31 +00:00
bak@google.com
919055360a
Changed interfaces to abstract classes where possible in {lib,samples,pkg}
...
Review URL: https://chromiumcodereview.appspot.com//10928139
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12255 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 10:58:25 +00:00
kasperl@google.com
55140fd125
Remove support for operator negate and replace occurrences with unary
...
operator -.
In the VM, I have disabled the operator negate support in the parser but I
have not removed the keyword because the token is used in quite a few other
places.
R=ahe@google.com ,iposva@google.com ,hausner@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10911206
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12233 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 05:29:03 +00:00
ngeoffray@google.com
d2f9fcb734
Collect getters in a FunctionSet while resolving.
...
Review URL: https://chromiumcodereview.appspot.com//10911181
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12184 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:37:28 +00:00
ahe@google.com
d1cb4358a2
Run dart2js tests unmodified in drt.
...
Review URL: https://chromiumcodereview.appspot.com//10918168
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12182 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:16:21 +00:00