dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

35087 Commits

Author SHA1 Message Date
Mayank Patke 3b4e4f6f47 [dart2js] Cache Cell-specific kernel AST nodes on CoreTypes. 
Change-Id: I82957eb405d7ab5c76ad1caf90ed510279ec8a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195540
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2021-04-16 06:34:27 +00:00
Stephen Adams 7754a868dd [dart2js] Remove static state accessors 
Change-Id: I58391845d3e28b041b7bb1746e696610d113ea7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195511
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-04-16 03:43:17 +00:00
Nate Bosch 0a5525fdb1 Drop analyzer dependency on test_api 
The only usage was to pick up `expect` which is exported through the
preferred import `package:test/test.dart`.

Change-Id: I0650901114bdc99e67e5801da636f309ff55f8da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195491
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 22:08:07 +00:00
Nicholas Shahan 8e2539d24c [ddc] Fix equality tests for Functions 
Marks `Function` as an extensible type so that DDC knows to use the
symbolized version of the equals operator.

The `Function` class at runtime already has its equals method attached
as the "symbolized" version. Consider `a == b`. When DDC knows `a` is
statically a raw `Function` and non-nullable (more likely with sound
null safety) the generated code should call the symbolized equals
member ex: `a[$_equals](b)`. Without this change the generated code
would be `a.equals(b)` and fail at runtime because the method does
not exist.

With this change co19_2/LibTest/core/Function/operator_eq_A01_t01
starts passing.

Change-Id: I80dd2abbbb04f1b7ab7e21dd14561a45f6e81459
Fixes: https://github.com/dart-lang/sdk/issues/45601
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194204
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2021-04-15 22:02:07 +00:00
Paul Berry 0ccb2771a3 Analyzer: change extent for assignability errors with named arguments 
Previously, if a type mismatch occurred on a named argument, e.g.:

    int.fromEnvironment('foo', defaultValue: 'BAD')

the error would be reported on the entire NamedExpression
(`defaultValue: 'BAD'` in this example).  Now, the error is just
reported on the expression (`'BAD'` in this example).  This makes the
analyzer behavior more self-consistent (since now assignability errors
are now consistently reported at the site of the expression that can't
be assigned).  It also makes the analyzer behavior more consistent
with the CFE.

This will make it possible, in a follow-up CL, to eliminate a lot of
the inconsistencies between analyzer and CFE in the "why not promoted"
ID tests.

Change-Id: I17db256959d730a22a5766f65d5c0736b627f244
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195489
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 21:38:37 +00:00
Danny Tuppeny 934be22ab5 [analyzer] Support package descriptions + version numbers in pubspec.yaml package completion 
Change-Id: I064689814b1f81671be870bb5c8499ebf35ab468
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 20:24:32 +00:00
Danny Tuppeny 790ceec1ab [analyzer] Support additional LSP completion trigger characters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3211.

Change-Id: Iad4db41b539990d39f641ff1dd07b174f207891b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 20:16:37 +00:00
Joshua Litt 32e3f78ba4 [js_ast] add DeferredStatement to js ast. 
Change-Id: I921eb7638039435711974d4fc40a3b9471a03f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195172
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2021-04-15 20:16:27 +00:00
Danny Tuppeny 2dcbd22e0c [analyzer] Don't send Dart's trigger/commit characters for non-Dart LSP completion registrations 
Change-Id: I703b183ebd9aedaf87dbbce664107d5bcff14367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195509
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 19:44:27 +00:00
Stephen Adams 6e48eb730c [dart2js] Remove 'operatorIsType' 
Change-Id: I223a2744c401d4b7452853917d1cb5d4474f446f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195486
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-04-15 18:32:57 +00:00
Paul Berry 1e68c47e68 Migration: make --ignore-errors affect the "rerun" button. 
Fixes #45665.

Bug: https://github.com/dart-lang/sdk/issues/45665
Change-Id: I8d238f5117fdaf8b7ffbe31dc8b1dfcb7a52a58d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195183
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 18:26:47 +00:00
Konstantin Shcheglov 4dc165f7fd Add getUnitElement2(), deprecate getUnitElement(). 
Change-Id: Ib1ed93f215356442ca9db5b8ed5fab99667e996e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 17:16:27 +00:00
Paul Berry 4e353ca98d Migration: properly assign types to collection literals. 
Fixes #45583.

Change-Id: Ic411856968ec68b5ee6dd74718d08a4e9ea9c0d3
Bug: https://github.com/dart-lang/sdk/issues/45583
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 17:15:47 +00:00
Paul Berry 3397720738 Analyzer: Add id testing for inferred variable types 
This parallels the test introduced in
https://dart-review.googlesource.com/c/sdk/+/195260, but it tests the
analyzer rather than the CFE.

Change-Id: I7751abfcad0e91bf903a5dae2136b80c6714ea35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 16:51:47 +00:00
Kallen Tu 4ac265efe5 [cfe] Universal error message for core errors for const functions. 
Change-Id: I58cbbec918adad5e75ed6a7d6b8fb4bf2dcd6c0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195380
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2021-04-15 16:42:47 +00:00
Danny Tuppeny dc28e1fee6 [analyzer] Fix unexpected completions at EOF in comments 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3281

Change-Id: Ica8160977ac682dbf4db0f0b8a64a1ec0d2d9a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195505
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 15:36:57 +00:00
Xiao Yu f560d90059 Revert "Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic" 
This reverts commit d84f359786.

Reason for revert: removed some private looking but actually vm-entrypoints used by Flutter engine https://buganizer.corp.google.com/issues/185462669

Original change's description:
> Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic
>
> Bug: https://github.com/flutter/flutter/issues/72723
> Change-Id: Ib5f809fccf1fad69add441fd40c463da8dc8be36
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192953
> Auto-Submit: Xiao Yu <xster@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

TBR=lrn@google.com,vegorov@google.com,xster@google.com

Change-Id: Ie746805ab7ef214bc4ba6f3582eb1d32672360ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/flutter/flutter/issues/72723
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195484
Reviewed-by: Xiao Yu <xster@google.com>
Commit-Queue: Xiao Yu <xster@google.com>
 2021-04-15 15:29:28 +00:00
Danny Tuppeny eb0e7199ac [analyzer] Fix a null assertion error when completing in comments 
Change-Id: I6456e951ec8cfe624efd6cbf7696c324e7a4b581
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195504
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 15:18:17 +00:00
Johnni Winther 7e6692b20c Revert "[kernel] Migrate remaining bin/lib libraries in package:..." 
Revert submission 195268

Reason for revert: Implicitly triggers running bin/* in sound null safety, revealing an unsafe use of List.length=

Reverted Changes:
I026ace4fd:[cfe] Migrate front_end libraries from wave 3-4
I9ba1f809b:[kernel] Migrate remaining bin/lib libraries in pa...

Change-Id: I3535c45d6eaf970dc5a17b6d7274cd9d6aa16ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195507
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-04-15 14:55:37 +00:00
Johnni Winther 2dbc8b18a2 Revert "[cfe] Migrate front_end libraries from wave 3-4" 
Revert submission 195268

Reason for revert: Implicitly triggers running bin/* in sound null safety, revealing an unsafe use of List.length=

Reverted Changes:
I026ace4fd:[cfe] Migrate front_end libraries from wave 3-4
I9ba1f809b:[kernel] Migrate remaining bin/lib libraries in pa...

Change-Id: I3eb8130dfd5c21ddcfc33d0efd3150712fda8a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195506
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-04-15 14:55:37 +00:00
Danny Tuppeny 1f0fe212b2 [analyzer] Migrate LSP spec tests to null-safe 
Change-Id: I988692263486d277017a057768fcae2edeca3889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195279
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 14:24:37 +00:00
Paul Berry 8af652ce3d Analyzer: update id testing for inferred type arguments to handle collection literals. 
The ID tests for inferred type arguments now include tests for
collection literals, e.g.:

    /*<dynamic>*/ [];

The analyzer ID testing code needs to be updated to handle test cases
like these.

Fixes trybot failure with
pkg/analyzer/test/id_tests/inferred_type_arguments_test.

Bug: https://github.com/dart-lang/sdk/issues/45717
Change-Id: I338814acccf3e080bbf8cf167041c52d96ba19cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195482
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 14:23:47 +00:00
Brian Wilkerson bdc6c65b32 Migrate the search support in server 
Change-Id: If9379ac44cea9ccd5cf15886d0c22624a2b66b2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 13:37:47 +00:00
Paul Berry ed9def1467 Analyzer: Add id testing for inferred type arguments 
This parallels the test introduced in
https://dart-review.googlesource.com/c/sdk/+/195020, but it tests the
analyzer rather than the CFE.

Change-Id: I5ea1b873561f159a0549acbfdf8c1e639b733435
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 12:16:17 +00:00
Paul Berry 2ee741692f Add "why not promoted" support for explicit extension overrides. 
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: Iea9300cf2cae52355bfa5a71f773c8136da2c644
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195306
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-15 12:13:27 +00:00
Johnni Winther dd2b04e41d [cfe] Migrate front_end libraries from wave 3-4 
Change-Id: I026ace4fd2563ec26439f630074eb35900839529
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195268
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-04-15 12:04:28 +00:00
Johnni Winther 9feb5330b9 [kernel] Migrate remaining bin/lib libraries in package:kernel 
Change-Id: I9ba1f809b0340b6d45471d856f2a31cff9534de8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195264
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-04-15 12:04:28 +00:00
Vyacheslav Egorov 458be23fa7 [vm_snapshot_analysis] Migrate to null-safety 
Fixes https://github.com/dart-lang/sdk/issues/45683

TEST=pkg-*-try bots

Cq-Include-Trybots: luci.dart.try:pkg-linux-release-try,pkg-mac-release-try,pkg-win-release-try
Change-Id: Ie10f313da9778d001f9c4fb618997e3b3c781dd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195263
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2021-04-15 12:03:47 +00:00
Dmitry Stefantsov 7515fe5fe7 [cfe] Avoid using flattened lists of tuples in non-simplicity checks 
Change-Id: If0e8220d3a155707cbb377c17213954dfe8e6ccf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195021
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-04-15 10:33:47 +00:00
Dmitry Stefantsov 91aecfcd5f [cfe] Use i2b at the end of function call inference 
Closes #45598.

Bug: https://github.com/dart-lang/sdk/issues/45598
Change-Id: I37430faf057e3559ad6aefaa59d83d8a14320c54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194764
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-04-15 10:33:27 +00:00
Daco Harkes 8a2b7bb5d5 [vm/ffi] Support Unions 
Closes: https://github.com/dart-lang/sdk/issues/38491

tools/test.py ffi ffi_2
TEST=tests/ffi(_2)/(.*)by_value_(*.)_test.dart

Change-Id: I6d29f7e3c3046cda4a15c9b42063c66b064787be
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,analyzer-analysis-server-linux-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-linux-debug-x64c-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194420
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2021-04-15 10:16:27 +00:00
Alexander Thomas b5c63ce757 [infra] Migrate scripts to python3 
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.

Fixes: https://github.com/dart-lang/sdk/issues/28793

TEST=Manually tested common user journeys.

Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2021-04-15 10:10:20 +00:00
Xiao Yu d84f359786 Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic 
Bug: https://github.com/flutter/flutter/issues/72723
Change-Id: Ib5f809fccf1fad69add441fd40c463da8dc8be36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192953
Auto-Submit: Xiao Yu <xster@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2021-04-15 09:25:17 +00:00
Michal Terepeta f6b257307f Make some tweaks to how we detect generated files 
I've seen occasional flakiness in our testing of this feature, but
couldn't pinpoint the reason for it. However, decreasing the frequency
how often we check for changes of the `command.log` and looking at a
larger chunk of the file seems to help (based on running th tests
multiple times).


Bug: http://b/184120864
Change-Id: Ie28a6e5aa71e7d86e0afc47906051ee1c05ed44c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194786
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Michal Terepeta <michalt@google.com>
 2021-04-15 08:14:57 +00:00
Jens Johansen a9e6de318c [CFE] Avoid AllocateContext in ConstantEvaluator.canonicalize 
putIfAbsent uses a closure and the VM allocates a context,
replacing it with ??= which doesn't should be better.

In a previous iteration it was found - with 95% confidence - a
~4ms (~10%) improvement, but for whatever reason those results
cannot currently be reproduced.

Change-Id: Id80a4eb0c0018c5827ab37b08507e70a5a5529a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194761
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2021-04-15 06:54:36 +00:00
Johnni Winther 47acb386d7 [cfe] Add id testing for inferred variable types 
* including inferred parameter/return types for local functions
* added testing for inferred type arguments on literals and bounded variables

Change-Id: I02bceef3f5a41af7794cc63769cf4959321700d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195260
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2021-04-15 05:06:56 +00:00
Stephen Adams 813019a9c5 [dart2js] Remove old-rti substitution property from namer 
Change-Id: I696220cba191b5df4ffd14abd62a718708366f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195308
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
 2021-04-15 04:46:56 +00:00
Konstantin Shcheglov 3c59708054 Make several fields of FileState non-nullable. 
With external libraries separated, we always have the fields.

R=brianwilkerson@google.com

Change-Id: I91038198921670f7739b82ed7f88abd67a2debca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195304
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 01:21:06 +00:00
Brian Wilkerson 374e35ce87 Migrate the highlight region computer 
Change-Id: I580a10014c217cec9b225b7d45c9cc72b37d8614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195303
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-04-15 01:00:26 +00:00
Brian Wilkerson 4f57626aaa Migrate the mocks used by tests and tools 
Change-Id: If5093c5ba1b53fb1d96390b0740e1337acec9958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195307
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-15 00:14:36 +00:00
Paul Berry 3186fa521e Migration: handle more complex extension method invocations. 
Fixes #45574.

Bug: https://github.com/dart-lang/sdk/issues/45574
Change-Id: Iecf7acfebc1c59e5518edec4b8c287996d80c80d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-04-14 22:56:46 +00:00
Konstantin Shcheglov c3c371b971 Remove Either2.mapAsync(), test toString(). 
We can use just `map()` with the right return type.

R=brianwilkerson@google.com

Change-Id: I9b05e75babd9019876a6194d6b49bf2b7e3982f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-04-14 21:43:06 +00:00
Brian Wilkerson a28d35ae9e Migrate ContextManager 
Change-Id: I0306c2485af0de4edf5e12e2cd3c13afdc3e8729
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-14 21:42:26 +00:00
Danny Tuppeny 1aa56ed7b1 [analyzer] Migrate LSP semantic tokens + generation script to null-safe 
Change-Id: I3d903a406808c50d995c50b8f890db8f97de8cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195276
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-14 20:08:15 +00:00
Kallen Tu c851cd31b5 [cfe] Core List properties enabled with const functions. 
Change-Id: I3bac87b7be213756fc24fbb026f663f14c390e7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195200
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2021-04-14 20:02:45 +00:00
Danny Tuppeny 7e50eedf80 [analyzer] Migrate LSP constants + ClientCapabilities to null-safe 
Change-Id: Id7d1e4dae9eb9b1a29d82244d503dfdf2a9c2524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195275
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-14 19:00:25 +00:00
Konstantin Shcheglov a505f2dc55 Replace FileState.external() with Either2<FileState?, ExternalLibrary>. (try 2) 
Global presubmit looks green.
https://test.corp.google.com/ui#id=OCL:368340336:BASE:368343419:1618375425236:9f9f89c1

Change-Id: Idaf44452f83f00102cc14579ccdd688bb7e14dbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195190
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-04-14 18:44:56 +00:00
Konstantin Shcheglov 6628a0eca5 Stop reporting StrongModeCode.TOP_LEVEL_FUNCTION_LITERAL_BLOCK 
Change-Id: I4e3aff4a16015910e1f3cb48e8dd12892e63531a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-04-14 18:38:05 +00:00
Joshua Litt 298795da23 [dart2js] Create DeferredHolderExpression to defer holder names. 
Change-Id: I5a6b2f56d0e63e8979687e16841a8696b9c6507f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194113
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2021-04-14 18:27:25 +00:00
Danny Tuppeny 7ea96c93d5 [analyzer] Migrate generated LSP code to null-safe 
Change-Id: Ibed2e796bfcfe2ad48460cf1029a9fd9034e6418
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195274
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-14 18:24:25 +00:00