d2f2f734bf
Replace findElementsByName() with FindElement.
...
Change-Id: Ia7b9d6785eb0d727c2bebee2b94fc6258b50d71c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-15 01:10:24 +00:00
f4bb16232a
[vm] Remove old version of protobuf-aware tree shaker
...
New, faster version of protobuf-aware tree shaker was introduced in
https://dart-review.googlesource.com/c/sdk/+/152100 . It has been
used in Flutter use cases for a while.
This change replaces old version of transformation with the new one in
the pkg/vm/bin/protobuf_aware_treeshaker.dart tool and removes
the old version.
TEST=existing tests in pkg/vm/test/transformations
Change-Id: I01546ae9fdc9fea3228595270c2aff04a0894e6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178281
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2021-01-15 00:54:48 +00:00
26fc05ef06
Change FlowAnalysisDebug to wrap FlowAnalysis.
...
Previously, it wrapped _FlowAnalysisImpl. I'm planning a series of
changes to allow legacy type promotion to be expressed using the same
API as flow analysis; in order to make this possible to debug using
FlowAnalysisDebug, it needs to be able to wrap any implementation of
FlowAnalysis, not just _FlowAnalysisImpl.
Change-Id: Ic1ae87c22de6d4ff1e0d5d86090726272f741c34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-01-15 00:51:58 +00:00
e620276d12
Update check for potentially constant types to include any type aliases.
...
Change-Id: I7d43e532db1d0baa6e64639f174845077631effa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-15 00:46:43 +00:00
6700437384
Update variance computing and default types for non-function type aliases.
...
Rename some resynthesize tests to make them more consistent.
Change-Id: I6701b9c409973a68b545227b840a05e1bdd237d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-15 00:43:52 +00:00
56903e6cfb
Replace findElementInUnit(), findLocalFunction(), and findLocalVariable() with FindElement.
...
Change-Id: I508b63fee81dc087489055448debb495a06eff6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-14 23:15:25 +00:00
7f95c18812
Deprecate CompilationUnitElement.functionTypeAliases
...
Change-Id: I0f13761adf3d1dfd18798d5b7549e64462be0b65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179360
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 22:38:23 +00:00
cfe510ade8
Test for search of non-function type alias.
...
Change-Id: Iab2fc3980563a321eec3cf4e843d487b7b2b399d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179320
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 21:52:13 +00:00
68025f0170
Use findNode and findElement more in DAS tests.
...
Change-Id: I949f1613d6d427ef3bddb9b4ab40b7feb012985b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 20:50:03 +00:00
c393930f59
Feature 'constant-update-2018' is always enabled.
...
Change-Id: I97b9135e2a8e3b01933bf463437220ffd8bf1d0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179160
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 19:12:13 +00:00
48503619f8
Replace AbstractSingleUnitTest.findElement with FindElement.
...
R=brianwilkerson@google.com
Change-Id: Id0a3bc6e6d33c969432337e0a7cb198ff4d6a5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 17:05:43 +00:00
b837038cf9
Update dart:async documentation and fix null-safety mistakes in the documentation.
...
Large update to `Zone` which sorely needed it.
Change-Id: I5d398e4c401ea8b17c7706e7e01ae2e22137ce77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178620
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2021-01-14 16:40:53 +00:00
0de9b16e7a
[cfe] Give a hint on erroneous super-bounded types
...
Change-Id: Ifb4caaf8995f9f139fd24b4ae6e9c071a83459ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178240
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-01-14 16:25:23 +00:00
978b838461
Revert "[VM] Adds Future.then and Future.catchError stack unwinding."
...
This reverts commit 8f2c47f24bhttp://b/177506826
Original change's description:
> [VM] Adds Future.then and Future.catchError stack unwinding.
>
> TEST=Various 'causal' tests updated below.
>
> Bug: https://github.com/dart-lang/sdk/issues/40815 , https://github.com/dart-lang/sdk/issues/37953
> Change-Id: I1420d6163ac2e3b22e0971f7b0ad516895dded70
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176662
> Commit-Queue: Clement Skau <cskau@google.com >
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
TBR=vegorov@google.com ,cskau@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/40815
Bug: https://github.com/dart-lang/sdk/issues/37953
Change-Id: I870f0202f43588f71a5d2b0f82338978b5a5dda9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178998
Reviewed-by: Michal Terepeta <michalt@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Michal Terepeta <michalt@google.com >
2021-01-14 13:56:53 +00:00
e7b15e9486
[cfe] Add more late lowering helpers
...
Adds helpers for extracting original name of a lowered late field, the
original initializer and the field used to hold the value of the lowered
field.
This helps backends to customize late field encoding while still using
the lowering provided by the cfe.
Change-Id: Ib42af539efad84a08a6e32acd29d2efaff129cd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178989
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-01-14 12:46:52 +00:00
9922491ba8
[vm/ffi] Migrate pkg/front_end tests to Allocator
...
New API landed in: https://dart-review.googlesource.com/c/sdk/+/177705
Issue: https://github.com/dart-lang/sdk/issues/44621
Issue: https://github.com/dart-lang/sdk/issues/38721
Change-Id: Id45274313edbb3842438b66b9c0917a86884c8ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178993
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2021-01-14 12:27:53 +00:00
990b03290f
[cfe] Mention update_expectations.dart in failure log
...
Change-Id: I692e6aa8571c14817831b7c6a135b2cd6ef0ed2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178991
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-01-14 12:06:59 +00:00
56de044376
[test] Use test configuration name to name generated test directories
...
The directories where generated tests and compilation output are stored
by the test runner were named based on all the relevant configuration
options. Change this so that the directory path is based on the
name of the tested configuration instead. This allows simultaneous
test runs of configurations that don't differ on relevant options.
Change-Id: Iaad8d0212cb900bc91d7472d99e266183d29a0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178986
Reviewed-by: Karl Klose <karlklose@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2021-01-14 10:12:56 +00:00
b0db6d38c0
Use single InstanceState.lazyEqualEqual()
...
R=brianwilkerson@google.com
Change-Id: I74e36c5b1a98cff0429a1cb77452f53a59cee9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 02:24:04 +00:00
353b35cc4e
Suggest only either getter or setter, but not both.
...
Otherwise we get two conflicting edits.
R=brianwilkerson@google.com
Change-Id: I57f69099f715ad3cfd342d65a6a80e2c34d812a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 01:17:55 +00:00
aaabc7537d
Use runtime type equality for type literal identity.
...
https://github.com/dart-lang/language/pull/1389/files#diff-2f9dda5244b707ca3b6d5988c6e5257d6025a99a5fa08ce0dc171c94bdc8ce0dR1256
Change-Id: Ie6b01c1ad5f5ab62ceef3e2672a2174ddaf62db8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 01:13:34 +00:00
f757851fa6
add test for over-eager add_late fix
...
Change-Id: I9cf7d6eda6b9ed50b87225e4a2558d2ca29b011b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-14 01:05:30 +00:00
e49937769f
Revert "[ CLI ] Improved consistency of -D and --define across tools and"
...
This reverts commit e83e78431fhttps://github.com/dart-lang/sdk/issues/44562
>
> TEST=Updated CLI tests and added new dart2js tests.
>
> Change-Id: I9379c7aee1eab377adb3438393d9ad79c4938cc4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178262
> Commit-Queue: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Siva Annamalai <asiva@google.com >
TBR=bkonyi@google.com ,asiva@google.com ,sigmund@google.com
Change-Id: I1c594ae7db551619cc3191ff7f832c4fc61a4171
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179081
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-01-14 01:05:29 +00:00
4a7dd03932
bulk fix for avoid_private_typedef_functions
...
Change-Id: I9775a542b58948488710156652ff8960ccbbc45b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178932
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 23:38:27 +00:00
e83e78431f
[ CLI ] Improved consistency of -D and --define across tools and
...
commands
- Added support for --define to the VM and dart2js
- Added support for -D and --define for `dart run` and `dart compile js`
Remaining improvements:
- Add support for providing multiple comma separated values for `dart
run`, `dart`, and `dart2js`
Related issue: https://github.com/dart-lang/sdk/issues/44562
TEST=Updated CLI tests and added new dart2js tests.
Change-Id: I9379c7aee1eab377adb3438393d9ad79c4938cc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178262
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2021-01-13 23:33:17 +00:00
e5d5a0f345
Don't report INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_* when null safety.
...
https://github.com/dart-lang/language/pull/1389/files#diff-2f9dda5244b707ca3b6d5988c6e5257d6025a99a5fa08ce0dc171c94bdc8ce0dR665
Change-Id: Iccc90f8f9bb877da604d5a5774a931b71a185b91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178928
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-13 21:19:04 +00:00
613ab14a9a
[ package:dds ] Disable package:test timeout for sse_smoke_test
...
Fixes https://github.com/dart-lang/sdk/issues/44474
Fixed: 44474
Change-Id: I62e6847f2e6c14deee16c3676e5e18616baa4ad4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176780
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2021-01-13 21:06:03 +00:00
f0f4f58728
[analyzer] Use generated names for extracted methods
...
Change-Id: I2aeaac092bc2222d6116c2e7172e73406bfa2260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:51:38 +00:00
65af2a0941
[analyzer] Add ExtractLocalVariable to LSP server
...
Change-Id: I997b9914d0c451e69a914c75da0f313430ba3722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:48:52 +00:00
a154a0dbdf
[analyzer] Add new contexts to declarations tracker after rebuilding due to watcher failure
...
Fixes https://github.com/dart-lang/sdk/issues/44650 .
Change-Id: Ifb59268b550e69b909c15e592cf925f40ba5f7cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:06:28 +00:00
d5ab427d16
analysis_server: Add a Convert to Null-aware Spread quick fix
...
Change-Id: I04dfb48e0257d8e14de81b927699b7eb063ea578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178924
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 17:24:48 +00:00
5d40d52fca
[vm/ffi] Add Opaque type
...
Issue: https://github.com/dart-lang/sdk/issues/44622
Issue: https://github.com/dart-lang/sdk/issues/43974
TEST=samples/ffi/sqlite/lib/src/bindings/types.dart
TEST=tests/ffi/vmspecific_static_checks_test.dart
Change-Id: Ib9e72df6a07b1bc2b72a7db66f945652814baf51
Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,analyzer-nnbd-linux-release-try,front-end-linux-release-x64-try,front-end-nnbd-linux-release-x64-try,benchmark-linux-try,dart-sdk-linux-try,pkg-linux-release-try,vm-ffi-android-release-arm-try,vm-ffi-android-release-arm64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-win-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178984
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Clement Skau <cskau@google.com >
2021-01-13 17:04:08 +00:00
4e2343c290
[vm/ffi] Introduce Allocator API
...
Introduces the Allocator API in `dart:ffi`.
This CL does not yet roll `package:ffi` to use `Allocator`, because that
breaks the checked in Dart in Fluter in g3. Instead, this coppies
`_MallocAllocator` from `package:ffi` into the ffi tests for testing.
This CL does not yet migrate off `allocate` and `free` in the SDK. That
is done in a dependent CL.
Issue: https://github.com/dart-lang/sdk/issues/44621
Issue: https://github.com/dart-lang/sdk/issues/38721
TEST=tests/ffi/allocator_test.dart
TEST=tests/ffi/calloc_test.dart
TEST=tests/ffi/vmspecific_static_checks_test.dart
Change-Id: I173e213a750b8b3f594bb8d4fc72575f2b6b91f7
Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,analyzer-nnbd-linux-release-try,front-end-linux-release-x64-try,front-end-nnbd-linux-release-x64-try,benchmark-linux-try,dart-sdk-linux-try,pkg-linux-release-try,vm-ffi-android-release-arm-try,vm-ffi-android-release-arm64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-win-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177705
Reviewed-by: Clement Skau <cskau@google.com >
2021-01-13 17:04:08 +00:00
10917ffd55
Don't promote this inside extension methods.
...
Bug: https://github.com/dart-lang/sdk/issues/44652
Change-Id: I05e5acfbff1d498fa3ad513d956510909ec7d24f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178920
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-01-13 16:48:08 +00:00
4ea0bae02a
[kernel] Tools and fixes wrt lazy loading and reachability
...
Change-Id: I191d338097b09ff2211d6d14c6013632190de629
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178980
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-01-13 14:20:28 +00:00
8f2c47f24b
[VM] Adds Future.then and Future.catchError stack unwinding.
...
TEST=Various 'causal' tests updated below.
Bug: https://github.com/dart-lang/sdk/issues/40815 , https://github.com/dart-lang/sdk/issues/37953
Change-Id: I1420d6163ac2e3b22e0971f7b0ad516895dded70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176662
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2021-01-13 08:00:14 +00:00
e776054596
[pkg/test_runner] Support 'enable-experiments' in multi-test converter
...
This change adds support for the 'enable-experiments' option to control
the experiments used in the analyzer and CFE.
It also adds support for multiple input files.
Change-Id: I15b9082e96f276249165efc66734ac9506b93ca1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178560
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2021-01-13 06:50:54 +00:00
07fa8a6589
[ddc] Add null safety mode to metadata output
...
Change-Id: Ic9c932aa1161885a9b4073ada1c17f475716950e
Fixes: https://github.com/dart-lang/sdk/issues/44601
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178161
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-01-13 01:32:54 +00:00
ef72b9fe6d
Analyzer: Look for bazel BUILD file before .packages files
...
Also move local function packageRootedHere outside of a while loop.
Change-Id: Ie900a36507934038a7bace23e6241a9c91080943
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178640
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-01-13 00:34:33 +00:00
c5e0e73df5
dart migrate: Fix rendering overlay offset issue in Firefox
...
Fixes https://github.com/dart-lang/sdk/issues/44635
Change-Id: Id6e0518b86859605c5cfacb9091f7e1ed612b71c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178724
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-01-12 23:17:33 +00:00
d13b1e82a7
[frontend_server] allow dart define to contain commas
...
package:args seems to chop off commas unless disabled. This prevents users from having
dart defines that contain commas.
Bug: https://github.com/flutter/flutter/issues/72105
Change-Id: I9900a0db0d0ad24348dd06acff7a48d3c579564f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178881
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Jonah Williams <jonahwilliams@google.com >
2021-01-12 23:09:43 +00:00
4bef6607e7
Fill and use DartType.aliasElement/aliasArguments
...
Change-Id: I71a3b7efbbe8578c47a832cb85aab6177156531f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-12 22:50:44 +00:00
6f40248275
Simplify usage of addFactor and addSubtype.
...
These test harness methods now take strings rather than Type objects,
which should make the tests easier to read (and less work to write).
Change-Id: I160bb7a7a61116e18736d414d5a549971d851c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-01-12 21:47:04 +00:00
ef8cc2c1cf
Remove LateInitializationError.
...
As per planned breaking change to let platforms decide how they and what throw for late initiaization errors,
we no longer need a public `LateInitializationError` class. It's confusing to have one if some platforms throw
something else instead.
Removes the public abstract class. The dart:_internal implementation class `LateError` no longer implements it.
This is the only implementation of the public interface, and the class which platforms either throw directly,
or through front-end lowering of the feature.
Remove mentions in tests. All tests now just expect `Error`, some platform specific tests might test the message.
TEST=rewrote tests referring to LateInitializationError.
Change-Id: I54344a67f89ce101ed770412db134e12354cdcc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174928
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2021-01-12 20:21:33 +00:00
6c33457014
[analyzer] Add support for multiline TODO comments
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3030 .
Change-Id: I97b885ee49573514560bc0452fd84793e04ee5df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-12 19:08:02 +00:00
1d35109cc1
bulk fix for prefer_is_not_operator
...
Change-Id: Ib9888b034ff4e7376d295fb15adb738451a50085
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-12 18:24:23 +00:00
87ad206da2
[dart2js] Make JS string literals more uniform
...
More runtime and boilerplate strings use double-quotes.
This is more consistent with strings from codegen.
Change-Id: I53b6852fc3e8b644a530046aa1a135faf9ae3782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178380
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2021-01-12 18:24:21 +00:00
2866e46476
UseIsNotEmpty name fix
...
Change-Id: I01b358f9f80698bfa760bb6cac6e2f00a98dccd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-12 16:15:21 +00:00
9370651773
Prepare to eliminate context arg from MigrationCliRunner.shouldBeMigrated
...
This change changes `MigrationCliRunner.shouldBeMigrated` to forward
to a transitional method `MigrationCliRunner.shouldBeMigrated2`, which
lacks the now-unused `context` argument. After this lands, internal
clients will be switched to overriding/calling `shouldBeMigrated2`
instead of `shouldBeMigrated`.
Once no clients remain that refer to `shouldBeMigrated`, the `context`
argument will be removed from it (this will be non-breaking since
`shouldBeMigrated` will at that point be unreferenced outside the
nnbd_migration package). After that, we will switch clients back to
overriding/calling `shouldBeMigrated` and eliminate
`shouldBeMigrated2`.
Change-Id: If9b476878260a5777f3346486d44c805dc361691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178761
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-01-12 16:11:21 +00:00
fe7efd5606
Update documentation in dart:core.
...
Fix null safety issues and tweak documentation where it can be improved.
Change-Id: Ia8cc20274ae151c454662bf5f137913787365a64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177960
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2021-01-12 13:06:41 +00:00
Konstantin Shcheglov