dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

74 Commits

Author SHA1 Message Date
Devon Carew 9501a15e5b [vm_service] improve doc handling; fix analysis issues; fix test expectation 
Change-Id: Ie8f48adb1b52d2e583c168165291ee510294f176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141848
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-03-31 17:26:30 +00:00
Ben Konyi a1992fec6d [ package:vm_service ] 4.0.0 release, Sentinels are now thrown, Future<dynamic> returns are now Future<Response> 
Change-Id: Ifd1bf62e3bc33bf14359802086c87b2fd19f3ba9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138561
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-03-05 18:51:29 +00:00
Ben Konyi 1f0611919d [ package:vm_service ] Non-reference types now implement their reference types. Fixed inconsistencies in protocol spec. 
Change-Id: I6529c722d595ceeb80b7eabebef0e99c59db975b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136811
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-02-21 23:44:43 +00:00
Martin Kustermann 9520235bfe [vm/async] Ensure all service tests run with both, --causal-async-stacks/--lazy-async-stacks 
Running all existing tests with/without lazy async stacks ensures that
the existing functionality for --lazy-async-stacks does not regress.

There are still a few smaller things to be done in the debugger for lazy
async stacks.

This CL also ensures:

   * The inner closure, i.e. AsyncClosure/AsyncGenClosure, is not
     inlined if FLAG_lazy_async_stacks is on.

   * Fixes a crash in dartkb mode, when the function of the Bytecode
     object is null.

   * Does a simple integration of the lazy async stacks in debugger.cc -
     to ensure a stack is returned via vm-service.

Issue https://github.com/dart-lang/sdk/issues/37668

Change-Id: Ibc1e887a457e2c456ae65d9ed5fa92434f122a32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131825
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2020-01-16 12:47:03 +00:00
Jens Johansen ca565d946f [vmservice] Make sure one can request several heap snapshots 
Also extend test to verify one can find expected instances through the
heap snapshot.

Change-Id: Ie4d83100b0702f6e0ceb7ae351b1d49d85d385a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131066
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-01-15 08:53:23 +00:00
Ben Konyi a3be4afe8d [ package:vm_service ] Added methods to allow for HttpClient.enableTimelineLogging to be set via package:vm_service 
Change-Id: Ice35290cfafbd29e4d47c75ce73030fb82d1b7dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130123
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2020-01-03 16:28:29 +00:00
Ben Konyi 1aafbb15a8 [ package:vm_service ] Added support for dart:io service extensions 
Change-Id: I77b124c66b54c428a02859a9fbdaf90c4b331998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128601
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-12-26 22:15:44 +00:00
Devon Carew 5fa4ec4564 [pkg:vm_service] misc cleanup in pkg:vm_service 
Change-Id: I74e35c4fc112b596a9141c4a9bd0d7fdd01bcf2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123102
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-30 01:38:15 +00:00
Devon Carew d867e1febf [pkg:vm_service] send responses with the id sorted first 
Change-Id: Ifc34e55f796eab363b891968a52fbef5a85e23c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123103
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-10-29 22:43:26 +00:00
Samir Jindel c885bdde1d [vm] DBC is obsolete. Remove dead code. 
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-27 18:18:29 +00:00
Alexander Aprelev 9e636b5ab4 Reland "[vm/service] Introduce IsolateGroup entity to vm service api."" 
This reverts commit f020ce5d23 with patchset 1 having original revert, rest - fixes
for calling destructors on unlinked IntrusiveDL elements and for assuming int is int64(which breaks down on simarm, ia32 bots).

Fixes https://github.com/dart-lang/sdk/issues/38926

Issue https://github.com/dart-lang/sdk/issues/36097

Change-Id: I867526c7de3786806670d1f43dbff07228f80028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121870
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-10-17 03:45:41 +00:00
Alexander Aprelev f020ce5d23 Revert "[vm/service] Introduce IsolateGroup entity to vm service api." 
This reverts commit f219e5152d as it breaks few bots.

Change-Id: I8d1d42d1ac662c2dba9ea9270c7a6cdc4f0621bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121886
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-10-16 19:45:23 +00:00
Alexander Aprelev f219e5152d [vm/service] Introduce IsolateGroup entity to vm service api. 
This is to enable vm clients to ask how much memory is consumed by isolate group.

Issue https://github.com/dart-lang/sdk/issues/36097

Change-Id: I4f1c499bf02c20b80e9802d8ad60e7ea65cfb375
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119724
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-16 18:05:06 +00:00
Ben Konyi 989289c36f [ package:vm_service ] Add 'tokenPosToLine' and 'tokenPosToColumn' to Script, improve test coverage 
This change should also reduce the number of flaky failures and fix issue where `pub run -c test` would fail for certain tests.

Change-Id: I6010346b8a916958d46985e45600ef5a4dc760c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119500
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-10-01 21:42:13 +00:00
Ben Konyi 48f7636798 [ package:vm_service ] Added HeapSnapshotGraph, a helper class which parses the responses from the HeapSnapshot event stream. 
Change-Id: I0844d5d9e61351bae64ed2b0747d86872c336339
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117922
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-09-26 21:12:05 +00:00
Ben Konyi 35748514c7 [ VM / Service ] Added additional tests for package:vm_service and fixed service bugs 
Change-Id: I3c96521a16bf0493cd0dc7ca9249487b3d9e3e64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118465
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-09-25 00:39:56 +00:00
Ben Konyi 07cd62af19 [ package:vm_service ] 2.0.0 Release: Added named parameters to VM service object constructors 
This change is considered breaking as the constructor parameters for non-optional
fields are marked as @required.

General cleanups (unnecessary 'new', single line methods) in this CL as well.

Fixes https://github.com/dart-lang/sdk/issues/38194

Change-Id: I1d6a4b3a6cca6646b6bc3ebb1fb8322060ea7c52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117211
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2019-09-16 19:28:37 +00:00
Ben Konyi 9391e15cfd [ package:vm_service ] Added support for service protocol version 3.27. 
Change-Id: I1cb3ca42821f817eaa9aed98d1aabb93e53fb0ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115079
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-09-07 05:31:37 +00:00
Ben Konyi 3f8c533fcb [ package:vm_service ] Swallow exceptions from streamCancel in service_test_common 
Change-Id: Idcc1368dc53e7356ea40c890b5c9c76c03b4f563
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114444
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-23 22:06:58 +00:00
Ben Konyi 67b2b09b97 [ package:vm_service ] Started porting Observatory tests to run with package:vm_service 
Change-Id: If7f5cf96eab91044f92992f410e852bb22fccc1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113941
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-08-23 19:27:35 +00:00
Devon Carew e2fee9c0dd [pkg:vm_service] fix an issue serializing list args 
Bug: https://github.com/dart-lang/sdk/issues/37872
Change-Id: Iba416907d62311c9eff1386ff93e2895814872d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113843
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-08-20 17:19:50 +00:00
Ben Konyi 368b3f0ab4 Reland "[ VM / Service ] Pulled in vm_service_drivers from its own repo." 
Changes from original CL:
 * Removed service_undocumented.md
 * Removed generation of wrappers for undocumented RPCs
 * Cleaned up generation code which was used for generating wrappers for undocumented RPCs
 * Removed JARs from pkg/vm_service/java/third_party

This reverts commit 477a3c4748.

Change-Id: I8d36733c8b2602e4935c3f23698d3f7c97a20187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110135
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-07-25 18:46:43 +00:00
Ryan Macnak 477a3c4748 Revert "[ VM / Service ] Pulled in vm_service_drivers from its own repo." 
This reverts commit dbeceb1d06.

Reason for revert: Exposes private VM service methods

Original change's description:
> [ VM / Service ] Pulled in vm_service_drivers from its own repo.
> 
> - Updated various paths to point to the sdk repo instead of the
>   vm_service_drivers repo.
> - Updated generate.dart to use the service.md from the SDK, not a copy.
> - Removed hidden files that are no longer needed.
> 
> Change-Id: I11b1f2e32d55f1fdaaa6eb9ce34fc318716c36f9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109120
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=devoncarew@google.com,bkonyi@google.com,rmacnak@google.com,asiva@google.com

Change-Id: I44af2074ba13dec41ffac3c25330e4603c50b06a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109895
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-07-22 20:26:22 +00:00
Ben Konyi dbeceb1d06 [ VM / Service ] Pulled in vm_service_drivers from its own repo. 
- Updated various paths to point to the sdk repo instead of the
  vm_service_drivers repo.
- Updated generate.dart to use the service.md from the SDK, not a copy.
- Removed hidden files that are no longer needed.

Change-Id: I11b1f2e32d55f1fdaaa6eb9ce34fc318716c36f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109120
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-07-22 20:06:29 +00:00