dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

11 Commits

Author SHA1 Message Date
Ben Konyi fb5ffc8275 [ package:vm_service] Output null-safe code from package:vm_service code generator 
TEST=Existing VM service tests

Change-Id: Ia3877927f8c761c8f37a37f1efe87221cc1ac2aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156980
Reviewed-by: Gary Roumanis <grouma@google.com>
 2021-01-08 21:19:38 +00:00
Ben Konyi 67a4bbb60b [ package:vm_service ] Ensure VmService.onDone doesn't complete until the provided dispose handler has finished 
Fixes https://github.com/dart-lang/sdk/issues/43940
TEST=regress_43940_test.dart

Fixed: 43940
Change-Id: I7ad57e0c35a91bf1e1e3dada6662b33b59e2d7bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176922
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2021-01-05 23:39:29 +00:00
Ben Konyi 45159b12e0 [ VM / Service ] Add isolateFlags property to Isolate JSON response 
Flags that can be set in `Dart_IsolateFlags` are now surfaced via the
Isolate JSON object returned from the service protocol. Currently only
returns boolean flags.

Related: https://github.com/dart-lang/sdk/issues/43588
Change-Id: I54a30155778de8612105eb4a5f60f8a222a086b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165403
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2020-10-01 19:18:30 +00:00
Devon Carew 8e61018d47 [pkg/vm_service] fix to analysis warnings about required arguments 
Change-Id: I752d0d09b9cee234fe9e8c06144f210eb9a5bb55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162401
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-09-10 19:10:50 +00:00
Devon Carew a99ae4d2f3 re-generate the vm_service library and add misc improvements to RPCError 
Change-Id: Ibb3de14e9b438a5ec34b865122445a6bcb83dcd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146100
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-05-04 19:25:24 +00:00
Devon Carew d867e1febf [pkg:vm_service] send responses with the id sorted first 
Change-Id: Ifc34e55f796eab363b891968a52fbef5a85e23c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123103
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-10-29 22:43:26 +00:00
Ben Konyi 07cd62af19 [ package:vm_service ] 2.0.0 Release: Added named parameters to VM service object constructors 
This change is considered breaking as the constructor parameters for non-optional
fields are marked as @required.

General cleanups (unnecessary 'new', single line methods) in this CL as well.

Fixes https://github.com/dart-lang/sdk/issues/38194

Change-Id: I1d6a4b3a6cca6646b6bc3ebb1fb8322060ea7c52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117211
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2019-09-16 19:28:37 +00:00
Devon Carew e2fee9c0dd [pkg:vm_service] fix an issue serializing list args 
Bug: https://github.com/dart-lang/sdk/issues/37872
Change-Id: Iba416907d62311c9eff1386ff93e2895814872d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113843
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2019-08-20 17:19:50 +00:00
Ben Konyi 368b3f0ab4 Reland "[ VM / Service ] Pulled in vm_service_drivers from its own repo." 
Changes from original CL:
 * Removed service_undocumented.md
 * Removed generation of wrappers for undocumented RPCs
 * Cleaned up generation code which was used for generating wrappers for undocumented RPCs
 * Removed JARs from pkg/vm_service/java/third_party

This reverts commit 477a3c4748.

Change-Id: I8d36733c8b2602e4935c3f23698d3f7c97a20187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110135
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-07-25 18:46:43 +00:00
Ryan Macnak 477a3c4748 Revert "[ VM / Service ] Pulled in vm_service_drivers from its own repo." 
This reverts commit dbeceb1d06.

Reason for revert: Exposes private VM service methods

Original change's description:
> [ VM / Service ] Pulled in vm_service_drivers from its own repo.
> 
> - Updated various paths to point to the sdk repo instead of the
>   vm_service_drivers repo.
> - Updated generate.dart to use the service.md from the SDK, not a copy.
> - Removed hidden files that are no longer needed.
> 
> Change-Id: I11b1f2e32d55f1fdaaa6eb9ce34fc318716c36f9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109120
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=devoncarew@google.com,bkonyi@google.com,rmacnak@google.com,asiva@google.com

Change-Id: I44af2074ba13dec41ffac3c25330e4603c50b06a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109895
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-07-22 20:26:22 +00:00
Ben Konyi dbeceb1d06 [ VM / Service ] Pulled in vm_service_drivers from its own repo. 
- Updated various paths to point to the sdk repo instead of the
  vm_service_drivers repo.
- Updated generate.dart to use the service.md from the SDK, not a copy.
- Removed hidden files that are no longer needed.

Change-Id: I11b1f2e32d55f1fdaaa6eb9ce34fc318716c36f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109120
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-07-22 20:06:29 +00:00