Commit Graph

8 Commits

Author SHA1 Message Date
pq a6e3008ded fix sort_directives violations
See: https://dart-review.googlesource.com/c/sdk/+/196026

TEST=Code cleanup exclusively (sorting imports); no new tests.


Change-Id: Ib07a82ff418138c542d6a83cfab9aabbb285f866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196180
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2021-04-20 22:21:28 +00:00
Ben Konyi e3c0b0d3f7 [ package:vm_service ] Null safety migration, take two
All object fields are now non-final and nullable to allow for missing
fields due to communicating with an older VM service version.

TEST=Existing tests.

Change-Id: Ibfbeefb329359e92f2e048499df7b9c806fb3220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180089
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-01-20 00:37:05 +00:00
Ben Konyi fb5ffc8275 [ package:vm_service] Output null-safe code from package:vm_service code generator
TEST=Existing VM service tests

Change-Id: Ia3877927f8c761c8f37a37f1efe87221cc1ac2aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156980
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-01-08 21:19:38 +00:00
Devon Carew 9501a15e5b [vm_service] improve doc handling; fix analysis issues; fix test expectation
Change-Id: Ie8f48adb1b52d2e583c168165291ee510294f176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141848
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-03-31 17:26:30 +00:00
Ben Konyi a1992fec6d [ package:vm_service ] 4.0.0 release, Sentinels are now thrown, Future<dynamic> returns are now Future<Response>
Change-Id: Ifd1bf62e3bc33bf14359802086c87b2fd19f3ba9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138561
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-03-05 18:51:29 +00:00
Ben Konyi 989289c36f [ package:vm_service ] Add 'tokenPosToLine' and 'tokenPosToColumn' to Script, improve test coverage
This change should also reduce the number of flaky failures and fix issue where `pub run -c test` would fail for certain tests.

Change-Id: I6010346b8a916958d46985e45600ef5a4dc760c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119500
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-10-01 21:42:13 +00:00
Ben Konyi 3f8c533fcb [ package:vm_service ] Swallow exceptions from streamCancel in service_test_common
Change-Id: Idcc1368dc53e7356ea40c890b5c9c76c03b4f563
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114444
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-08-23 22:06:58 +00:00
Ben Konyi 67b2b09b97 [ package:vm_service ] Started porting Observatory tests to run with package:vm_service
Change-Id: If7f5cf96eab91044f92992f410e852bb22fccc1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113941
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-08-23 19:27:35 +00:00