dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

9 Commits

Author SHA1 Message Date
Robert Nystrom 8b21a49f61 Turn on the "isEmpty" and "isNotEmpty" lints and fix violations. 
Change-Id: Ia6d957ebcc2b19f8043fa58f0c6e2202b2c1104f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160982
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2020-08-31 18:33:48 +00:00
Robert Nystrom 98e781f632 Enable two more lints with only a few violations. 
Change-Id: Ibd72d53740b06370b12ae4dd7e4a3f471de09978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160983
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2020-08-30 18:36:15 +00:00
Robert Nystrom cb2cbb7074 Enable "omit_local_variable_types" lint in test_runner and fix violations. 
Also turned a couple of "final" locals to "var" to be consistent with others.
Removed a no-longer valid analysis option.

Change-Id: I741989b20199ba8f1e86e464e1cf994137332fad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128500
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-12-17 19:48:54 +00:00
Robert Nystrom f9f005cdb9 Tool to automatically update expectations in static error tests. 
Change-Id: Ie1faacd66448efe209b35dfd66fded622e59812a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110766
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-07-30 01:23:22 +00:00
Robert Nystrom 375adbfbe0 Enable "comment_references" lint and fix violations. 
Change-Id: If3759e3c0f49b17eae5a8c7f3d3446c5fb23a9bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108966
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-07-12 23:53:13 +00:00
Robert Nystrom 0104a62595 Enable "prefer final fields" lint and fix violations. 
I also removed a field that did nothing useful, fixed a couple of types,
and removed some unnecessary getters.

Change-Id: I95af91850f5971a22046db4a7d746bc0a43a643c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108700
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-07-10 22:04:07 +00:00
Robert Nystrom eceef5e809 Fix unneeded braces in interpolation and enable lint for it. 
Change-Id: I1a4dbe4ca8b21778c10e63bc153017647f2ba04a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108681
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-07-10 21:31:08 +00:00
Robert Nystrom 81b677cd80 Turn on a bunch of linter rules for the test_runner. 
I pulled this list from the build package and turned on the ones that
only had a handful of violations. Left the others that I eventually want
to enable commented out.

Change-Id: I09ec037982e29d3682bc0eaa6af28adfad91b941
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108563
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-07-10 17:53:48 +00:00
Robert Nystrom 8828acae82 Add an analysis_options.yaml file for test_runner. 
I didn't realize they were being gitignored across the entire SDK repo.
I'm not sure why they are ignored at all, but based on the linked bug,
I think it's only a top-level analysis_options.yaml file that would
cause problems?

This change to the .gitignore file prohibits that case while still
allowing analysis_options.yaml files in subdirectories.

I very strongly want to have an options file for test_runner to ensure
that everyone on the team keeps it "no-implicit-cast" clean.

Change-Id: I9ceac507b08a063e71e2fe39501161723651e6b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106840
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-06-20 18:58:51 +00:00