Commit Graph

6 Commits

Author SHA1 Message Date
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Morten Krogh-Jespersen 404bb2b15e Re-enabling linter and normalizer tests.
All status files from the tests/ and runtime/tests directories has been copied
to a local directory, to make sure, that the unit test does not break when junk
is added to status files.

The linter has been updated with a check for duplicate entries in status files,
which is why the normalizer unit tests failed in the first place.

Bug:
Change-Id: Ifebd2bfd9011373bfe9a613de5c365ff99535ca4
Reviewed-on: https://dart-review.googlesource.com/25380
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
2017-12-04 09:03:44 +00:00
Morten Krogh-Jespersen 64930b3abd Removing linter and normalize unit tests.
TBR: sortie@
Bug:
Change-Id: Ie34d137607ca04ca0408fe85af74e516a11af10e
Reviewed-on: https://dart-review.googlesource.com/25340
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-12-01 10:11:28 +00:00
Morten Krogh-Jespersen 39c399ca98 Add normalizer to normalize status files.
The test in this CL will test if the transformation of a status file produce an
equivalent status file. It does this by checking the number of entries and
making sure to find ONE entry in the produced status file.

As an invariant it needs that no duplicate entries exists in sections.

Bug:
Change-Id: I6aec3b20ef1bca89d6a7cf72d85487a95c3d1f0a
Reviewed-on: https://dart-review.googlesource.com/21341
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-01 09:10:51 +00:00
Morten Krogh-Jespersen ad8152a276 Add check for duplicate section headers to linter.
Bug:
Change-Id: Iec49d6dd34ca592189a577f21d78bfd3946963e0
Reviewed-on: https://dart-review.googlesource.com/19920
Reviewed-by: William Hesse <whesse@google.com>
2017-11-10 15:23:19 +00:00
Morten Krogh-Jespersen 14ae756623 Linting for status files.
This both works as a tester for correct canonicalization of status files and can
be used later to check if changes to status files follow the guide lines.

It checks that:
- Comments only exists before a section or after a test path entry.
- That there are no disjunctions in headers.
- That variables and clauses are correctly ordered in section headers.
- That paths are alphabetically ordered in sections.
- That sections are lexicographically ordered with respect to negation.

Bug:
Change-Id: I0f5e2cc16f20bb48ee53a9a55a22aaab710e32ff
Reviewed-on: https://dart-review.googlesource.com/17786
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-09 01:48:03 +00:00