Commit Graph

7 Commits

Author SHA1 Message Date
Karl Klose e4a1085b45 [infra] status file clean up tool: add flag to also remove non-essential expectations in lines with comments
Deleted comments are collected and printed or written to a spearate file (when using -w).

Adds an option -i to resolve the status of issue using a log file of issue status changes.

Change-Id: I3939ef949cb32738755065ec74af238d12f71e55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114847
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-09-04 08:57:53 +00:00
Karl Klose 966b7de1ff [infra] status file clean up tool: also remove sections with comments
Change-Id: I9027ed4c937b4c06bfc30221bd42de307de8d1fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113683
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-19 12:01:41 +00:00
Karl Klose 2a8480e5a2 [infra] Add script to remove non essential status file entries
Change-Id: Iafdde22eaa305b9a5550540f939db31aac04d46b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113181
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-19 06:38:55 +00:00
Kevin Moore 94abf948c4 pkg:status_file misc cleanup
Clarify in the pubspec that it's not published
Cleaned up hints/lints in source files

Change-Id: Ifbf59ab0fb219dcdf5de99eced0a0129e6e191cb
Reviewed-on: https://dart-review.googlesource.com/61909
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-06-22 16:42:27 +00:00
Morten Krogh-Jespersen 39c399ca98 Add normalizer to normalize status files.
The test in this CL will test if the transformation of a status file produce an
equivalent status file. It does this by checking the number of entries and
making sure to find ONE entry in the produced status file.

As an invariant it needs that no duplicate entries exists in sections.

Bug:
Change-Id: I6aec3b20ef1bca89d6a7cf72d85487a95c3d1f0a
Reviewed-on: https://dart-review.googlesource.com/21341
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-01 09:10:51 +00:00
Morten Krogh-Jespersen 14ae756623 Linting for status files.
This both works as a tester for correct canonicalization of status files and can
be used later to check if changes to status files follow the guide lines.

It checks that:
- Comments only exists before a section or after a test path entry.
- That there are no disjunctions in headers.
- That variables and clauses are correctly ordered in section headers.
- That paths are alphabetically ordered in sections.
- That sections are lexicographically ordered with respect to negation.

Bug:
Change-Id: I0f5e2cc16f20bb48ee53a9a55a22aaab710e32ff
Reviewed-on: https://dart-review.googlesource.com/17786
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-09 01:48:03 +00:00
Bob Nystrom b9795ffabb A minimal status file formatter and canonicalizer.
For the migration script, I need a (less hacky) way of programmatically
modifying a status file. As a step along that path, I need the ability
to write a status file to disc given a StatusFile object.

With that, it was a small step to write a little "formatter" that turns
a status file into its canonical representation.

It removes unneeded parentheses in expressions, normalizes expectation
case, and normalizes whitespace. Seems useful.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2988383002 .
2017-08-03 13:37:30 -07:00