William Hesse
4a39a9b9fe
[infra] Disallow spaces in test configuration names
...
Change-Id: Ibd96e414d9a8c76a36b4fc8360ceca3560f1dd91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181404
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2021-01-29 14:55:56 +00:00
Karl Klose
1ad255e8b9
[pkg/smith] Check that each configuration is tested on at most one builder
...
Change-Id: I9233fa6f75dae727bc3a6951ca35792967610db0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148064
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Karl Klose <karlklose@google.com >
2020-05-14 10:40:41 +00:00
Karl Klose
bb14279237
[infra] pkg/smith: custom test runner steps are test steps
...
Change-Id: I6517475d1db1cad707fb0d096e2689ea265f6a9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133522
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-26 13:44:08 +00:00
Samir Jindel
1fbc71da0f
Re-land "[vm] AOT blobs snapshots are obsolete. Remove dead code."
...
Original change is in Patchset 1. I erroneously assumed DART_PRECOMPILER
was only used AOT compilation (it is also used for JIT snapshots).
Change-Id: I77f6c463db7f2b482c9b098f353dc28f0676ea0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135900
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2020-02-17 11:12:15 +00:00
Siva Annamalai
edd64e6d5c
Revert "[vm] AOT blobs snapshots are obsolete. Remove dead code."
...
This reverts commit bcc0900e6a .
Reason for revert: This CL is breaking the Fuchsia Flutter build see https://github.com/flutter/engine/pull/16604/checks?check_run_id=445155807
Original change's description:
> [vm] AOT blobs snapshots are obsolete. Remove dead code.
>
> Change-Id: I35cf4befbe66b92197dcd659172f90be3de30f8e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134840
> Commit-Queue: Samir Jindel <sjindel@google.com >
> Reviewed-by: Ryan Macnak <rmacnak@google.com >
TBR=rmacnak@google.com ,sjindel@google.com
Change-Id: I9dd32a71bf43907f59ed766b98bf453bab99ea3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135881
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2020-02-14 06:40:31 +00:00
Samir Jindel
bcc0900e6a
[vm] AOT blobs snapshots are obsolete. Remove dead code.
...
Change-Id: I35cf4befbe66b92197dcd659172f90be3de30f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134840
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2020-02-13 14:16:49 +00:00
Karl Klose
3ab2112b06
[infra] Add support for branches to pkg/smith
...
Change-Id: Id2562a7dd2a4180aef7d7623ac937d7abae8ff74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133237
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-01-31 06:37:41 +00:00
Karl Klose
23fa59f8b6
[infra] Add support for builders to pkg/smith
...
Change-Id: I21b970aaa61331b25687891f325621165f7861ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128160
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-01-27 08:13:25 +00:00
Ryan Macnak
3678a3bd42
[build] Use separate out directories for each sanitizer.
...
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: Ie0aeaff758234220c2f0267b462d14f4c076bdf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127821
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-12-11 18:12:47 +00:00
Robert Nystrom
aab88791b8
Change experiment flag name in test runner and test config.
...
Use "enable-experiment" to be consistent with other tools.
Change-Id: If9598f667517443a4f61ef91955ff57a477f0a5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121681
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2019-10-14 23:24:58 +00:00
Robert Nystrom
3f7805a90e
Make the NNBD command-line options less, uh, half-baked.
...
- Better name than "optedIn".
- Actually hook up the command-line option to the configuration.
- Add tests, which would have caught the previous mistake.
- Don't allow comma-separated values for "--progress" and "--nnbd".
- Remove unused dead "--strong" option.
Change-Id: I57d7cb0d81af50d662dcf3f7f4c9ca1f2b102f2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116544
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2019-09-10 22:39:19 +00:00
Robert Nystrom
981be87206
Add configuration options and flags for controlling NNBD mode.
...
This data is parsed by configurations and allowed as command-line
options to the test runner, but isn't currently plumbed through to any
of the tools. That's the next step.
Change-Id: I7931a11502a1c460e28b2a4a13d8722d8ad6974d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115767
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2019-09-06 01:17:07 +00:00
Robert Nystrom
89ad636b58
Remove the old "preview Dart 2" flags from the test runner.
...
Dart 2 shipped a year ago, so we're pretty well past a "preview". :)
Change-Id: I6c5d21ae4181e4228cc1fc49b6344cdb8fc43794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115544
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2019-09-05 16:59:43 +00:00
Robert Nystrom
7cfedd9a6f
Run dartfmt --fix on pkg/smith.
...
Change-Id: I423489b851638f6d50fe365433863fd6bc91bb14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115501
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2019-09-04 22:55:56 +00:00
Sigmund Cherem
888596af88
Add support for a production dart2js mode in test.dart
...
Change-Id: Ia828cb46106f044313e579f1c4b23ec92c6a2d44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96862
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2019-03-14 23:59:28 +00:00
Sigmund Cherem
1b5f7c1047
Remove unnecessary flags for dart2js from test.dart
...
Change-Id: I751688fba97d605de69164068fe2377d80087127
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96861
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2019-03-14 22:01:13 +00:00
William Hesse
a533753bec
Remove --fast-startup flag support from testing scripts and status files
...
Change-Id: Icfb4aa228c0f13bf9fce25aeb7bacbf1e38497ee
Reviewed-on: https://dart-review.googlesource.com/c/89582
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-01-16 11:32:44 +00:00
Alexander Thomas
ba10df6611
[infra] Switch pkg bots to Dart 2
...
* Update named configs for unit tests to Dart 2.
* Bump json_rpc_2 in front_end package.
* Use named configurations in unit tests.
* Fix typing issues.
Change-Id: Id3b393a0d2abe92c8eaec10fa8057fb35d18a4c6
Reviewed-on: https://dart-review.googlesource.com/67341
Reviewed-by: Jens Johansen <jensj@google.com >
2018-08-13 07:04:06 +00:00
William Hesse
be7022f6d9
Remove named configuration template expansion code from test.py.
...
Named configuration templates are expanded by the recipe before being
passed to test.py.
Change-Id: I164df7acf0a0aff76f050b871101590efae51954
Reviewed-on: https://dart-review.googlesource.com/69300
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2018-08-10 13:12:49 +00:00
William Hesse
e0f6fdfff1
Refactor testing:TestConfiguration to use smith:Configuration by inclusion.
...
Change-Id: I5c116ad082a24c25a07b9ceb6aaf8c9cbe3f11e3
Reviewed-on: https://dart-review.googlesource.com/68361
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-08-06 16:19:08 +00:00
Bob Nystrom
a4c7cf388f
First stab at a parsing library for named configurations.
...
Change-Id: I1a2660914715d529b0233645b109b13c2fa9171a
Reviewed-on: https://dart-review.googlesource.com/61121
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-06-26 22:17:08 +00:00