Commit Graph

1458 Commits

Author SHA1 Message Date
Peter von der Ahé 06040f73f2 Skip hot_reload_e2e_test on Windows.
Change-Id: I7a379c2520be98d447a6c4e12875b74c5af29518
Reviewed-on: https://dart-review.googlesource.com/34720
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-16 06:29:57 +00:00
Peter von der Ahé 2cc21f515e Remove original and minimal IKG
Change-Id: Id845a025ae9823fd3e53aaac7b5a95aa9e2ad767
Reviewed-on: https://dart-review.googlesource.com/34380
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-01-15 15:02:20 +00:00
Alexander Thomas 813be084dd [infra] Normalize pkg.status
Change-Id: I656880ceb89bfe3e5588d035d2c1a452580c2e95
Reviewed-on: https://dart-review.googlesource.com/34104
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-11 14:33:48 +00:00
Alexander Thomas db99248e77 [infra] Normalize comments in pkg.status
Change-Id: Ia90ecd801c4d63c434c3b3fa220f59ff8c054e08
Reviewed-on: https://dart-review.googlesource.com/33886
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-11 12:13:15 +00:00
Aske Simon Christensen 9bdcc40f69 Rename PhysicalFileSystem to StandardFileSystem.
Preparation for data URI support. For clarity, this is just a rename.

Change-Id: Ibbd8da05d1a7106b5ec7c0ea9c1e13a95a89d1bd
Reviewed-on: https://dart-review.googlesource.com/33460
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-11 11:23:25 +00:00
Jens Johansen 5e5550422f [kernel] Remove unnecessary "skip" of perf_test
Issue 28698 updated 3 status file entries. 2 entries are now gone,
and the last one doesn't seem to be current anymore.
This CL removes the remaining - unnecessary - entry.

Bug:
Change-Id: I38c8339e83c00d4be33ce84abc1c12f0b5ebe181
Reviewed-on: https://dart-review.googlesource.com/32771
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-01-11 08:17:47 +00:00
Vijay Menon 3a4a0fae4f test.py support for tests under pkg/dev_compiler
Change-Id: Ic68359907d3c58bbebe7e368a6e4ad24017c6504
Reviewed-on: https://dart-review.googlesource.com/33620
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-01-10 23:31:18 +00:00
Konstantin Shcheglov 2ba489c65a Fix resynthesize tests for Windows.
Fixes #31832

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/31832
Change-Id: Ie0b1dd9742415fe9cf97b3d3843eeaf3af878308
Reviewed-on: https://dart-review.googlesource.com/33982
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-01-10 20:24:39 +00:00
Dmitry Stefantsov 613c248a6d Skip resynthesize_kernel_test for now, until the timeout issue is solved
TBR=athom@google.com,jensj@google.com

Bug: http://dartbug.com/31832
Change-Id: I675be8bd7432f598d80ac79126f53ddfad318e42
Reviewed-on: https://dart-review.googlesource.com/33740
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-01-10 08:30:18 +00:00
Alexander Thomas 89bd41d19a [infra] Simplify vm-kernel configurations in test matrix
This also adds the missing vm-kernel opt-counter builder.

Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-01-09 20:59:49 +00:00
Alexander Thomas c637a34a5a [gardening] Mark timing out test as "Slow"
TBR=whesse@google.com

Change-Id: I080c700e6c7e76aad0a70419e21021d92c295f3f
Reviewed-on: https://dart-review.googlesource.com/33464
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-01-09 20:26:58 +00:00
Jens Johansen 426d94785d [gardening] Mark timing out tests as slow
It seems that f99d3628d1
(CL https://dart-review.googlesource.com/33144)
caused these 5 tests to time out on the pkg builder as well as the try
bots.
Locally the tests take ~40 seconds, so giving it a bit more time (i.e.
marking them as slow) seems likely to turn things green again.

Bug:
Change-Id: I90526b1d7060309d8f1cf902bd9d52c71927f1ed
Reviewed-on: https://dart-review.googlesource.com/33340
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-01-09 12:57:28 +00:00
Jens Johansen 923386490a [pkg/kernel] Remove status entries for non-existing tests
Bug:
Change-Id: I07e51f6fe958f6c37761a97002bab2fe15251a3d
Reviewed-on: https://dart-review.googlesource.com/32241
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2018-01-05 07:50:33 +00:00
Jenny Messerly 0b4d7a7d7b address #30245 for DDC codegen_test
Change-Id: I34bfc4a4c3a47dfc8352fcd3ccbd0e3fce63a5d1
Reviewed-on: https://dart-review.googlesource.com/32501
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
2018-01-05 01:03:37 +00:00
Florian Loitsch c0e4c30adb Mark minimal_incremental_kernel_generator_test as slow.
Change-Id: I3f32dc82c146071ff14ba3345f4ba733b46bc56d
Reviewed-on: https://dart-review.googlesource.com/30220
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-12-18 13:54:55 +00:00
Devon Carew 3ac5200e3a Add --preview-dart-2 integration tests for the search domain.
Bug:
Change-Id: Ib062b45936463c2e3564195bc3ffd69e031ddf17
Reviewed-on: https://dart-review.googlesource.com/27464
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-09 04:57:26 +00:00
Devon Carew e38c1a98e4 Add --preview-dart-2 integration tests for the edit domain.
Bug:
Change-Id: Ie63cd20cad7d27cb380db1cdefd7a5d4f7254a2a
Reviewed-on: https://dart-review.googlesource.com/27461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2017-12-08 04:26:10 +00:00
Martin Kustermann d82cdcc66e [Gardening] Mark analyzer/test/src/dart/analysis/driver_kernel_test as Slow
Change-Id: I690971ee5acc072e2ab51c26dfe538e860277641
Reviewed-on: https://dart-review.googlesource.com/26181
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2017-12-05 10:04:31 +00:00
Martin Kustermann d354a28cb2 [kernel] Add kernel2kernel constant evaluation, binary format as well as vm support
The introduced "constants" transformation can evaluate constant expressions.  The
original use-sites of constant expressions are replaced by a new [ConstantExpression]
node, which points to a subclass of a new [Constant] class hierarchy.  Constant
[Field]s and [VariableDeclarations]s will be removed, since all use-sites are
re-written.

The [Constant] class hierarchy is, similarly to the [DartType] class hierarchy, not
part of the AST tree (also has no parent pointer).  The constants form a
DAG (directed acyclic graph).

There is no canonicalization requirement of the [Constant] objects referenced by the
AST (via [ConstantExpression]).  Although it is beneficial to canonicalize them during
construction, since it reduces time spent in operator==/hashCode.

This CL furthermore adds support for a constant table in the binary format.  Similarly
to [String]s, we canonicalize the constants before writing the table to the binary.
The constant table entries in the binary are written in a post-order way, to ensure
easy construction on the backend side.

The text format will be augmented with a "constants { ... }" section at the end,
which lists the constants in the same order as in the binary format.

The transformation can be used by those backends who choose to do so.  It is not
enabled by default atm.  It should therefore not affect analyzer, fasta or other
components.

Change-Id: I57cd9624fedcf537ab6870db76246149647bed21
Reviewed-on: https://dart-review.googlesource.com/14382
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2017-11-16 11:08:02 +00:00
Peter von der Ahé 8bc6f7761f Add strong version of compile_platform_test.
Change-Id: I18795293ca353a265b76f472ba2b567ab2b1ebbf
Reviewed-on: https://dart-review.googlesource.com/18540
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2017-11-03 13:17:39 +00:00
Brian Wilkerson c0f81029a3 Extract error translation and re-enable completeness test
Change-Id: Ic78139f46a56f5b37d5569af712071ee8ae5fed9
Reviewed-on: https://dart-review.googlesource.com/18148
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-11-02 16:34:09 +00:00
Paul Berry 08b0120186 Begin reporting "invalid assignment" errors.
Change-Id: I1e47acd662032c63e56cb2349b2f349e9825b990
Reviewed-on: https://dart-review.googlesource.com/17680
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-11-01 16:28:35 +00:00
Florian Loitsch d2d8d35080 Mark checker test as slow.
Change-Id: I43825a55d9fe0c3dc6b1e3a02d14d20678e6260c
Reviewed-on: https://dart-review.googlesource.com/16440
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-10-25 08:20:18 +00:00
Peter von der Ahé fc2c2f251e front_end/tool/incremental_perf_test is slow
Change-Id: I61414ff273ea3a5d39043598287bd89988f4625d
Reviewed-on: https://dart-review.googlesource.com/14440
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2017-10-17 12:23:10 +00:00
Peter von der Ahé b96ac4520a Update most clients to use computePlatformBinariesLocation.
Change-Id: I6e6960c471b2fab3f0cd8a672da05d7699217410
Reviewed-on: https://dart-review.googlesource.com/12291
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-17 10:48:40 +00:00
Vyacheslav Egorov ac2cd68708 Skip pkg/kernel/test/metadata_test on pkg bots.
This test needs platform.dill and can't run from SDK currently.

(Use correct path in the status file: without pkg/)

Bug:
Change-Id: I4e6e9ed2f713d51a68fe9f3caa59f65b6c0aaf04
Reviewed-on: https://dart-review.googlesource.com/11064
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-10-04 16:45:07 +00:00
Vyacheslav Egorov 7890aeef81 Skip pkg/kernel/test/metadata_test on pkg bots.
This test needs platform.dill and can't run from SDK currently.

Bug: https://github.com/dart-lang/sdk/issues/28629
Change-Id: I7c3f1a20b74c9d09982e70dec07322cd9a454ca4
Reviewed-on: https://dart-review.googlesource.com/11063
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-10-04 16:41:38 +00:00
Sigmund Cherem d96b29378a Delete use of rasta and dartk from perf.dart scripts.
Change-Id: Id8cd7f01c68dbcb6f814ef51627a2f4b377f6819
Reviewed-on: https://dart-review.googlesource.com/9790
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-10-03 23:12:21 +00:00
Konstantin Shcheglov 1018d6038c Mark hint_code_kernel_test as Slow, Pass.
R=brianwilkerson@google.com

Bug:
Change-Id: Idaa96e6e75d4dfc40378705f8ebc98d12a466444
Reviewed-on: https://dart-review.googlesource.com/10580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-03 16:25:33 +00:00
Peter von der Ahé cefe4d5d65 Move compile_platform_test.dart to tool directory.
This also reverts "Move command_line.dart and most of compile_platform.dart into lib/"

This reverts commit 1916dc75e6.

Change-Id: I2598514c6bb62eec392bd00f20b15aac72b6fa42
Reviewed-on: https://dart-review.googlesource.com/9600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2017-10-02 16:23:56 +00:00
Konstantin Shcheglov b5fc2de3bf Keep sources for libraries of the current cycle.
This should fix the issue 30917 flakiness.

The reason why the tests were failing is that the code in the tests
was not quite correct Dart code, so Fasta generated a synthetic
`#errors` top-level variable with fileUri == null. We should skip
this field because it is not a part of any unit, because its fileUri
is not the fileUri of any unit.

But we lose fileUri for a Node if Program.uriToSource does not
include this URI. So, if we clear uriToSource in KernelDriver, we
lose all the file URIs. So, now we keep sources for the cycle files.

The reason for flakiness is because of the same race condition
between analyzing AnalysisDriver.addFile() and getResult(). If
we process getResult() before, we don't have to read the library
kernel file, we just create in first time, and fileUri(s) are
valid.

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30917
Change-Id: Ie559cf2a8a778ebf4a9e297f5cb13d30a98b5a3c
Reviewed-on: https://dart-review.googlesource.com/9744
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-29 18:38:52 +00:00
William Hesse 392b89fb99 Update status of analyzer strong_mode_kernel unittest on Windows.
Info in issue #30917
Bug: https://github.com/dart-lang/sdk/issues/30917
Change-Id: I13ba60350d0031a1f2b08cd22438e814c751bd1c
Reviewed-on: https://dart-review.googlesource.com/9621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-09-29 16:24:33 +00:00
Peter von der Ahé ed34e41d0e Update status for slow front_end/tool/incremental_perf_test.
Change-Id: Ie16775c322f29d1f715b85a263571ea47b6150fb
Reviewed-on: https://dart-review.googlesource.com/9560
Reviewed-by: Peter von der Ahé <ahe@google.com>
2017-09-29 12:08:50 +00:00
Sigmund Cherem 655d60f2c5 Add incremental_perf: a script to measure performance of the incremental kernel
generator.

The script takes an input program Uri, and a file describing edits, and it mocks
applying the edits in multiple iterations.

incremental_perf_test illustrates how this can be used to do incremental
compiles of the dart2js source code.

Change-Id: I3518996a0faac34de8c6cef2f63468f4788b3c06
Reviewed-on: https://dart-review.googlesource.com/6026
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-09-29 05:17:41 +00:00
Dmitry Stefantsov 9df589eeae Mark pkg/analyzer_plugin/test/plugin/folding_mixin_test as Slow
The bot had several timeouts during the day.  It may be similar to what
was fixed in
https://github.com/dart-lang/sdk/commit/5263d17f7480ff0648fa319ba1a8ed62d5116111
Change-Id: Ife4a1e6d2b40992d260ae03287d844ee9cceb79b
Reviewed-on: https://dart-review.googlesource.com/8600
Reviewed-by: Karl Klose <karlklose@google.com>
2017-09-26 13:32:26 +00:00
Johnni Winther c0c63bf16e Fix handling of function type parameters
Closes #30826

Change-Id: I804bff2a204aa210ba59f691c5d680d8a53aadeb
Reviewed-on: https://dart-review.googlesource.com/7553
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-09-26 08:23:34 +00:00
Konstantin Shcheglov 5263d17f74 Make more *_kernel_test Slow, Pass.
R=brianwilkerson@google.com

Bug:
Change-Id: I306a311096093312faf817f2daded105821bd5ca
Reviewed-on: https://dart-review.googlesource.com/8241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-25 20:00:51 +00:00
Konstantin Shcheglov f575c099b0 Run all *_driver tests also with Kernel. (attempt #2)
With previous changes that fix finding dart:core on Windows and
flakyness of reporting import errors, I'd like to reland this CL.

Attempt #1: https://dart-review.googlesource.com/c/sdk/+/7624

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: If5ab2c5ebe2204df6643ee42cbee5b49fb2d8c31
Reviewed-on: https://dart-review.googlesource.com/7961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-24 18:27:27 +00:00
Konstantin Shcheglov 8e94406288 Remove DirectoryBasedSourceContainer and its test.
This is the only test from pkg/analyzer/test/test_all.dart suite
that fails on my Windows machine. Given that the class has not been
used for ages, it is easier to remove it.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/21772
Change-Id: I110825f44915dde354af22e73e2d376231c08b0d
Reviewed-on: https://dart-review.googlesource.com/7943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-23 16:41:24 +00:00
Konstantin Shcheglov 3b632329f7 Fix source_factory_test to pass on Windows. (attempt #2)
Attempt #1 was: https://dart-review.googlesource.com/c/sdk/+/7843

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: Id5cb82883d25e5b51b8304cd152497535d7db48a
Reviewed-on: https://dart-review.googlesource.com/7940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-23 00:19:09 +00:00
Konstantin Shcheglov e929620072 Revert "Fix source_factory_test to pass on Windows."
This reverts commit 11d2dfb915.

Reason for revert: There is still one failing test.
See https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/builds/7264/steps/analyzer%20unit%20tests/logs/stdio

Original change's description:
> Fix source_factory_test to pass on Windows.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/26828
> Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
> Reviewed-on: https://dart-review.googlesource.com/7843
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I4f4e2f9a0c34fed26726a1d48ab1068ca8b6e16b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/26828
Reviewed-on: https://dart-review.googlesource.com/7920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-22 22:25:18 +00:00
Konstantin Shcheglov 11d2dfb915 Fix source_factory_test to pass on Windows.
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
Reviewed-on: https://dart-review.googlesource.com/7843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-22 20:56:58 +00:00
William Hesse 2274739c3c Revert addition of kernel tests to analyzer unit tests
These tests have flaky failures on the buildbots and commit queue.
Revert "Run all *_driver tests also with Kernel."

This reverts commit d2f887e37b.

Revert "Adjusted status for analyzer/test/generated/strong_mode_kernel_test"

This reverts commit 055654e96d.

Revert "Made status for strong_mode_kernel_test broader (flaky)."

This reverts commit 824c3f56cc.

Bug:
Change-Id: I341762671efc31f168df2f5806653d9548bd43ae
Reviewed-on: https://dart-review.googlesource.com/7708
Reviewed-by: William Hesse <whesse@google.com>
2017-09-22 11:37:21 +00:00
Erik Ernst 824c3f56cc Made status for strong_mode_kernel_test broader (flaky).
Change-Id: Ia5ee7c6a06b34959760aef6771d608ad4431ffeb
Reviewed-on: https://dart-review.googlesource.com/7705
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-22 10:06:22 +00:00
Erik Ernst 055654e96d Adjusted status for analyzer/test/generated/strong_mode_kernel_test
See https://github.com/dart-lang/sdk/issues/30863 for further
information.

Change-Id: I54adc4956db294e00c019366a83af082c029aae4
Reviewed-on: https://dart-review.googlesource.com/7704
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-22 09:20:09 +00:00
Konstantin Shcheglov d2f887e37b Run all *_driver tests also with Kernel.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I92a0f5f2192c20276b166a9211ab1064bc6f2b82
Reviewed-on: https://dart-review.googlesource.com/7624
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-21 22:44:39 +00:00
Alexander Thomas 55f98fef95 Change status for flaky tests
Bug:
Change-Id: I2544efc246ce285222aa569990f23106dcee4d09
Reviewed-on: https://dart-review.googlesource.com/7557
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2017-09-21 20:46:18 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones.
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2017-09-20 15:46:06 +00:00
Johnni Winther 6976262fa1 [gardening] Skip analyzer/test/generated/non_error_resolver_kernel_test
Change-Id: Ia175864e0bfa19c86d56d5135a6197a9917bedff
Reviewed-on: https://dart-review.googlesource.com/6861
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-09-19 10:34:25 +00:00
Konstantin Shcheglov 44c43773c9 Attempt to fix Windows bots for non_error_resolver_kernel_test.
TBR

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I2b764c7a5bf020f0983c1e9abb226091c888571b
Reviewed-on: https://dart-review.googlesource.com/6768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-09-19 01:36:34 +00:00