dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1123 Commits

Author SHA1 Message Date
Sam Rawlins ba82e5cc5d Migrator: Update non-nullable Details click region 
Fixes https://github.com/dart-lang/sdk/issues/41851

Screenshot (5% darker than surrounding bg): https://screenshot.googleplex.com/pzOBBoOC5MV.png

Alternatives:
10% darker than surrounding bg: https://screenshot.googleplex.com/6CpRZKegTNH.png
10% lighter than surrounding bg: https://screenshot.googleplex.com/m5tTsrwmrxx.png
info icon: https://screenshot.googleplex.com/Awwc8U9i0fo.png
rectangle: https://screenshot.googleplex.com/1vrKRyXUx1g.png
struck thru question: https://screenshot.googleplex.com/43st7uupEpo.png

I tried many different tweaks and a lot of things looked very bad:

* subscript _i_
* superscript _i_
* bang

I think the main problem with the previous look was that the background
of the rectangle was exactly the color of the other text, so it really
looked like there might be a masked character, as Devon pointed out.
This CL fixes that aspect, changing the background to be a grey,
slightly darker than the other gray background.

Reference:

* UTF question marks: https://unicode-search.net/unicode-namesearch.pl?term=QUESTION
* UTF boxen: https://www.fileformat.info/info/unicode/block/geometric_shapes/list.htm
* UTF

Change-Id: I8378376eabaf849488fddb150780dbb256779a00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147942
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-13 23:39:23 +00:00
Mike Fairhurst fc391eb620 [nnbd_migration] Add hint actions to stack trace info 
Still not rendered by the front end or handled by the server, but now
sent over to the front end via json encode/decode.

Change-Id: I3f93dc78d9981bf08fddf03bcf484a0fc324b66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147809
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Mike Fairhurst 547b72d55b [nnbd_migration] Create a simple node mapper, part of instrumentation 
Change-Id: Ia7b3f60ea6e5ce8518e62013e4deb0d315426f86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147802
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Mike Fairhurst c18db7c8dd [nnbd_migration] Build hint actions in node builder. 
Change-Id: I36428e72170d07f0f234aab0290365ca47f5b08a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147801
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Mike Fairhurst 424c2ad5a7 [nnbd_migration] Add model for hint actions stored on nullability nodes. 
In the future this could change to simply be a `Set<HintActionKind>`, so
that the `AtomicEdit`s can be calculated lazily. However, for the first
pass, they are calculated eagerly. This model lets us do that.

Change-Id: I07108ae0876d5e0efe7b35559cedb4cbd1c13605
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147624
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Mike Fairhurst b33496bbbd [nnbd_migration] Add header to edit links section 
This is to differentiate it from the edit links that appear inside the
stack trace in later CLs for #41077.

Change-Id: I018518cb16ef09a4959895bb4becd10cbabbea23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147622
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Konstantin Shcheglov 123f92f239 Remove unused extension in NavigationTreeRendererTest. 
Change-Id: Ieeac05bac86f06cb8fbd21169574e5b53fa3988d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147941
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-13 21:08:56 +00:00
Paul Berry fabceab5ee Migration: remove changedPaths tracking. 
See comments in
https://dart-review.googlesource.com/c/sdk/+/147043/1/pkg/nnbd_migration/lib/migration_cli.dart#484
for why this is unnecessary.

Change-Id: I046835d73eb581aecd8d65b1e3248d07daf34f17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147702
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-13 20:42:56 +00:00
Sam Rawlins ae5eb469dc Fix trace for unnamed constructors; remove stack frame icon 
Bug: https://github.com/dart-lang/sdk/issues/41851
Change-Id: Ib3a4b76f094c2c4ce55e8617138ab6403b9d80f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147825
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 18:12:02 +00:00
Paul Berry 83a2b2e51d Migration: exclude "never" node from "why not nullable" traces 
Change-Id: I7b1e22b439dc32b5272e13c947f86e640ffc366b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147050
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-12 17:50:39 +00:00
Paul Berry 94997823c0 Migration: verify that the preview server doesn't leak information from outside the project 
Change-Id: Ic49f02ab58bff367ac55c4807feecb54a28aa0f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147045
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Paul Berry 9e087df222 Migration: fix rerunning migration tool after adding/removing files 
Change-Id: I33e7ab428902efa44c7569fefc9f9c7436cae740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147044
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Paul Berry 383e75e5de Migration: add rerun support to new CLI 
Change-Id: If4e2854f0326ef0ef2d03a83a647a3d3bb092d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147043
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Sam Rawlins af99babc6c Migrator: Only print text about --apply-changes conditionally 
Fixes https://github.com/dart-lang/sdk/issues/40881

Change-Id: I4671e29f05ca9495419681a1f3fcb9d1718acbf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147334
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-12 13:57:09 +00:00
Sam Rawlins c6db98667a Migrator: Add a progress bar; fixes #41187 
The progress bar fills the width of the user's terminal, and computes
progress strictly based on files and phases, not weighing any file or
phase as greater than another.

Change-Id: Ic9840b3b66789512e0973160b3e0f069b714a4f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147421
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-05-12 01:22:11 +00:00
Paul Berry 9019699520 Migration: reorganize code in source_edit_diff_formatter.dart 
Based on suggestions from
https://dart-review.googlesource.com/c/sdk/+/146442.  Specifically,
the `_Output` class hierarchy has been moved to a new file so that the
classes in it are together, and the remaining classes (in the
DiffStyle hierarchy) are together in source_edit_diff_formatter.dart.
This required making a bunch of things public, so I split `DiffStyle`
into an interface and and impl class to make it easier to see which
method is intended to be used (DiffStyle.formatDiff).  Also, moved the
logic that was previously in _Output._processEdits to
DiffStyleImpl.formatDiff.

Change-Id: Iad448f16233e6752e7b20d1e0cee4eb5c033f498
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146821
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-08 12:48:54 +00:00
Paul Berry 6ef6d3ca89 Migration: sort declarations in instrumentation.dart. 
Change-Id: I8c4c38300de959a38d00d6b3fad8f490060c1018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146982
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-08 12:40:49 +00:00
Paul Berry f48e7e9f8a Migration: assign better quality node targets in NodeBuilder. 
This should help ensure that descriptions of nullabilities that show
up in the stack trace refer to parts of the program the user is
familiar with, rather than simply saying "explicit type".

Change-Id: If53198cc45077a664e44859c7c0770ec9831c765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146964
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-08 12:40:49 +00:00
Konstantin Shcheglov 7161036eb7 Fix avoid_unused_constructor_parameters in analyzer. 
Bug: https://github.com/dart-lang/sdk/issues/41797
Change-Id: I6fb201b549a599b12d022abd6108d3418966c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-08 04:44:58 +00:00
Paul Berry ce62ad2e8b Migration: test "add hint" functionality, and fix a path problem on Windows 
Change-Id: I6373a20ef3e3e74c77c4a1b9108317996256b831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146820
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-07 16:24:58 +00:00
Paul Berry 8636312883 Migration: turn off removeViaComments by default. 
This was the original behavior, and it persists in some tests because
it's more trouble than it's worth to rewrite them.  But it's not the
behavior we want to ship to users.

Change-Id: Ibf1df628f62b01e934d05336bfe43a5a61268f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147042
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-07 16:21:48 +00:00
Sam Rawlins 1279bbf0f1 Migrator: Always remove @ from @required 
Commenting out the @ (producing `/* @*/ required`) does no one good. It
does not help weak-mode or strong-mode testing.

Fixes https://github.com/dart-lang/sdk/issues/41181

Change-Id: I9de2775e2a17bacdd30cbfb34dc095cf2b5c603f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147040
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-07 14:47:07 +00:00
Sam Rawlins 6630f39690 Migrator: Fix null-check hint after a cast 
Fixes https://github.com/dart-lang/sdk/issues/41400

Change-Id: Iba8ee6c63ea4613904b7eb11b688d14b33ba29dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146825
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 21:43:21 +00:00
Sam Rawlins c958fa4fb9 Migrator: Fix nullable casts which are immediately null-checked. 
Fixes https://github.com/dart-lang/sdk/issues/41397

Change-Id: I7e64cbb475b6387ad10a2895e67311edac3aa7d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146824
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 21:33:29 +00:00
Sam Rawlins 7477ab0b93 Migrator: add two failing tests for #41788 
The expectation in test_expression_bang_hint_in_as_wrapped looks weird,
but without  https://github.com/dart-lang/sdk/issues/41397 fixed, this
is the expectation I have; if the migrator starts producing that output,
then #41788 is being fixed. If #41397 is being fixed, the dev can change
the expectation in this test.

Change-Id: I0cfc0c5da8cd12ea12ae74b1909155a0b9a2b043
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146822
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 16:32:22 +00:00
Paul Berry 097c3aab2c Migration: add a repro for issue #41409. 
Bug: https://github.com/dart-lang/sdk/issues/41409
Change-Id: I1029767745414c472bbe0b6efc7ee1ea6c0ac51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146685
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-06 12:59:52 +00:00
Konstantin Shcheglov 9b3f9db65a Switch InheritanceManager3 to computing ClassElement interfaces. 
Change-Id: Id9148d1bf3fc369eeabe2b1acc7507c20986a3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 03:09:03 +00:00
Mike Fairhurst ba6725d547 [nnbd_migration] Fix #41338, top code reference in details now a link 
Change-Id: If93956ef4065582bee9afdff783358870e18e16c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146701
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-05 21:47:13 +00:00
Paul Berry 965dd4d6d8 Migration CLI: validate that package to migrate exists and is not a file 
Change-Id: I4b7c189e29c141a5bbd7738542d7dbf398e567d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146523
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:25:33 +00:00
Paul Berry e5efe2be29 Migration CLI: normalize input path and make it absolute 
Change-Id: Ie88dae881f62b3513df9f799ca1abd4c7e831641
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146500
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:25:33 +00:00
Paul Berry c644e4c001 Migration: remove unnecessary TODO comment about supporting --debug in new CLI. 
In the dartfix-based implementation, the only significant effect of
supplying `--debug` was to enable the analysis server's
instrumentation log.  Since we don't have an analysis server layer in
the new CLI, there's no need for this command line option right now.

If we decide we need a `--debug` flag later we can always add it.

Change-Id: Ib729c5793044456ef460cfa7f823c48f5af9e898
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146445
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:25:33 +00:00
Paul Berry 399805bfdc Migration: upgrade to cli_util 0.1.4, which supports Ansi.reversed. 
We no longer need a clumsy workaround using an extension method.

Change-Id: If443cbe7138f59e66cce0ca613940b67307b637e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146502
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 20:19:23 +00:00
Paul Berry 1ac898a2c5 Migration: add the ability to output a text diff to the CLI. 
The previous implementation of the tool (based on dartfix) used
diffing code that was pretty deeply tied into dartfix, and didn't
produce good quality output for migration, so I've replaced it with a
new implementation.

Change-Id: Id3679435bf59c73145eacb6eaee1b6ce16dd61f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146442
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:19:23 +00:00
Sam Rawlins 57ff9b73f9 Migrator: Support nullable function-typed parameters 
Feature includes:
* function-typed formal parameters
* function-typed field formal parameters
* overridding parameters
* nullability hints
* adding `required`
* optional parameters

Fixes https://github.com/dart-lang/sdk/issues/39832

Change-Id: I1d9b1a50a9a6a77651fe6179b66c8301c8ab9408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146029
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-05 20:03:07 +00:00
Mike Fairhurst 44ad40afa5 [nnbd_migration] Add a trace entry for nodes with no known nullability. 
Change-Id: Ic73563fb5c7dffd03685c87a5ba2eaf591513934
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145660
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 19:39:47 +00:00
Paul Berry 8061d2d6cc Migration: add support for a machine-readable summary of migration results. 
Change-Id: Id41bc9869448dd4ed63286cab814bf7687baaaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146620
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 17:35:22 +00:00
Paul Berry c27da7da14 Migration: clarify titles for bug reporting links. 
If an external customer reports an issue with the migration tool using
the links we provide, they won't have the necessary github privileges
to apply labels to the issue, so we want to make sure the default bug
title clarifies that this is a customer-reported issue with NNBD
migration.

Change-Id: I55bf8c16062b1b9e8c25415addc99dd1c378b724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146621
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 17:27:17 +00:00
Sam Rawlins 9c94f08410 Migrator: Fix 'Report a Problem' link 
Fixes https://github.com/dart-lang/sdk/issues/41485

Change-Id: I514cc299f7a821f8cd8d623a8d9702e694178379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146461
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 04:04:03 +00:00
Paul Berry 11e5a05a70 Migration: when removing dead code, remove unnecessay ??=s 
Fixes #38676.

Change-Id: Icc24c6f070d7f3e8a74fc9494aef3e4c2583fac4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146320
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-05 02:18:13 +00:00
Paul Berry 13b3d67278 Migration: test interactions between type promotion and new compound assignment diagnostics 
Change-Id: I31d0389872640a54c962976754e65c3e2aeb2f1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 02:18:13 +00:00
Paul Berry eb3a42b789 Migration: test interactions between null-shorting and new compound assignment diagnostics 
Change-Id: Ia46aaf380fad1c65b59fff214217658cfcaee973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146000
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-04 23:02:17 +00:00
Paul Berry b71d09542c Migration: extend compound assignment diagnostics to ++ and --. 
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Iab5097359d8de7aa9411f51ee0ec6212c3adb678
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145920
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-04 23:02:17 +00:00
Paul Berry 2846ec88b3 Migration: test that new compound assignment checks respect potential nullability 
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: I344a9c9ea1e79af864c239dbcc924f78e798a8aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-01 22:54:25 +00:00
Paul Berry bf56b2ca2c Migration: produce diagnostic information for assignments. 
We produce a diagnostic under the following conditions:

- For compound assignments, if the type read from the LHS is nullable
  (this is illegal after NNBD, and requires user intervention to fix).

- For compound assignments, if the type returned from the combiner is
  not assignable to the LHS (this was required prior to NNBD, but it
  is a stricter condition after migration, both because the LHS might
  have a non-nullable type, and because implicit downcasts are not
  allowed).

- For null-aware assignments, if the type read from the LHS is
  non-nullable (this indicates that once strong mode is enabled, the
  assignment will be dead code).

Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Icb242ba36437e38364ada069880831eb05e3a513
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145664
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-01 22:54:25 +00:00
Paul Berry f0e428eb73 Migration: encode and decode paths properly on Windows. 
Fixes #41678.

Bug: https://github.com/dart-lang/sdk/issues/41678
Change-Id: I532f65eb99a9ad7ce2542bffa0aa2d5a680d28c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145880
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-01 17:53:13 +00:00
Paul Berry 31c8b587b1 Migration: introduce NodeChange.toString() method. 
This should make it easier to debug failures in FixBuilder unit tests.

Change-Id: I785e939648f10753ae9ac1e18530248c728a7157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145564
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-30 21:52:32 +00:00
Paul Berry ff53bd8d4a Migration: make sure new CLI detects when run with an old SDK 
Change-Id: I7b279788e34d3d2e86df58ff4ef7c86b58e154e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145644
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-30 21:50:12 +00:00
Paul Berry c33f4ad9fc Migration: support changing pubspec in new CLI 
Change-Id: I2e091a4ef8999f1fe649c7b9e69798e9959b635a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145643
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-04-30 21:50:12 +00:00
Paul Berry 28952641d5 Sort declarations in fix_aggregator.dart 
Change-Id: I19c8370fc38fbebc104dca3b6108db10660c5b9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145620
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-30 21:07:22 +00:00
Konstantin Shcheglov cf3a034210 Implement promotion via initialization in flow analysis. 
Change-Id: I10a5f6bfeb5a05dd144db5212c9f31796f5a2385
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145502
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-30 16:26:27 +00:00