dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

788 Commits

Author SHA1 Message Date
Mike Fairhurst b21ee57ccd [nnbd_migration] Support remove hint action in stack traces 
Change-Id: I2878fde38b233747d8cf9e3e8666b5768f3125fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148187
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-19 16:34:20 +00:00
Mike Fairhurst a8ab569f5c [nnbd_migration] Support deletions in UnitInfo.handleInsertion 
Change `handleInsertion` to use a `SourceEdit` instead, and update
`PreviewSite` to use it, but otherwise do not change `PreviewSite`. That
can be tested later when we have new `HintAction`s that allow us to
exercise this new code.

Change-Id: Idd6d782e003d4d643abb5770daa9055685f2e76a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148186
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-19 16:34:20 +00:00
Mike Fairhurst fdc19bc8f1 [nnbd_migration] Support replace/delete in offset mappers. 
Change-Id: Ieef27cff8c9d03537b8f80e5d436eec524abac7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148220
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-19 16:34:20 +00:00
Mike Fairhurst 40d048ac29 [nnbd_migration] Fix hint action windows test. 
Previous windows-incompatible implementation of hint action mapped the
path unnecessarily. The path for the new hint action comes from the AST
node and not a web URL and therefore should not be (and cannot be)
mapped for it to work on windows.

In the process of fixing this on cli_test, I missed this place where an
extra map was added in the preview_site test code which causes the test
to fail on windows.

Change-Id: If8d175379f0cb9fe864ab1f588af514a17b4758b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148229
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-15 19:15:43 +00:00
Paul Berry 166d083389 Migration: remove directory lib/api_for_analysis_server. 
This existed solely to have a centralized location for the analysis
server's dependencies on nnbd_migration.  Now that nnbd_migration
doesn't depend on the analysis server, there's no need for it anymore.

Change-Id: I24b231337b1f724840b4533afef1672241b0af4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148181
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-05-15 17:12:02 +00:00
Paul Berry c38742cdbc Migration: remove references from analysis_server to nnbd_migration. 
Change-Id: I90b562b8b3e82b770f197d7ef2c4e10ac9f99100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148160
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-15 16:49:32 +00:00
Mike Fairhurst f6d1c93a70 [nnbd_migration] Handle new stack trace add hint action 
Change-Id: I94e11938214413955e066f5e1b00c412ee6d78f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147814
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-14 22:51:45 +00:00
Paul Berry 898f28d51a Migration: do not parse args in new CLI handler. 
This is a step toward integrating the new migration CLI with dartdev.
It's necessary because dartdev handles arg parsing.

Change-Id: Ie50a69c434fd4d8873616e72b8274545cf0277d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148007
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-14 18:03:21 +00:00
Sam Rawlins a432ca0f8c Migrator: Improve adding explicit types to parameters and variable declarations 
While working on #38453, I encountered these issues.

Change-Id: I6abbfca19d9f6de771181e7f5515681cbbc39a4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148080
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-14 17:32:01 +00:00
Mike Fairhurst 95e11bc2d3 [nnbd_migration] Fix #41894, corrupt offset mapper on edit links. 
Fixed: 41894
Change-Id: Ice7b436baa57c473f8cdcab02580b8e531372d7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148026
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-14 17:22:01 +00:00
Mike Fairhurst fc391eb620 [nnbd_migration] Add hint actions to stack trace info 
Still not rendered by the front end or handled by the server, but now
sent over to the front end via json encode/decode.

Change-Id: I3f93dc78d9981bf08fddf03bcf484a0fc324b66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147809
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Mike Fairhurst c18db7c8dd [nnbd_migration] Build hint actions in node builder. 
Change-Id: I36428e72170d07f0f234aab0290365ca47f5b08a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147801
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 22:31:03 +00:00
Konstantin Shcheglov 123f92f239 Remove unused extension in NavigationTreeRendererTest. 
Change-Id: Ieeac05bac86f06cb8fbd21169574e5b53fa3988d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147941
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-13 21:08:56 +00:00
Paul Berry fabceab5ee Migration: remove changedPaths tracking. 
See comments in
https://dart-review.googlesource.com/c/sdk/+/147043/1/pkg/nnbd_migration/lib/migration_cli.dart#484
for why this is unnecessary.

Change-Id: I046835d73eb581aecd8d65b1e3248d07daf34f17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147702
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-13 20:42:56 +00:00
Sam Rawlins ae5eb469dc Fix trace for unnamed constructors; remove stack frame icon 
Bug: https://github.com/dart-lang/sdk/issues/41851
Change-Id: Ib3a4b76f094c2c4ce55e8617138ab6403b9d80f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147825
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-05-13 18:12:02 +00:00
Paul Berry 83a2b2e51d Migration: exclude "never" node from "why not nullable" traces 
Change-Id: I7b1e22b439dc32b5272e13c947f86e640ffc366b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147050
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-12 17:50:39 +00:00
Paul Berry 94997823c0 Migration: verify that the preview server doesn't leak information from outside the project 
Change-Id: Ic49f02ab58bff367ac55c4807feecb54a28aa0f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147045
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Paul Berry 9e087df222 Migration: fix rerunning migration tool after adding/removing files 
Change-Id: I33e7ab428902efa44c7569fefc9f9c7436cae740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147044
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Paul Berry 383e75e5de Migration: add rerun support to new CLI 
Change-Id: If4e2854f0326ef0ef2d03a83a647a3d3bb092d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147043
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-12 16:33:59 +00:00
Paul Berry f48e7e9f8a Migration: assign better quality node targets in NodeBuilder. 
This should help ensure that descriptions of nullabilities that show
up in the stack trace refer to parts of the program the user is
familiar with, rather than simply saying "explicit type".

Change-Id: If53198cc45077a664e44859c7c0770ec9831c765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146964
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-08 12:40:49 +00:00
Konstantin Shcheglov 7161036eb7 Fix avoid_unused_constructor_parameters in analyzer. 
Bug: https://github.com/dart-lang/sdk/issues/41797
Change-Id: I6fb201b549a599b12d022abd6108d3418966c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147221
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-08 04:44:58 +00:00
Paul Berry ce62ad2e8b Migration: test "add hint" functionality, and fix a path problem on Windows 
Change-Id: I6373a20ef3e3e74c77c4a1b9108317996256b831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146820
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-07 16:24:58 +00:00
Sam Rawlins 1279bbf0f1 Migrator: Always remove @ from @required 
Commenting out the @ (producing `/* @*/ required`) does no one good. It
does not help weak-mode or strong-mode testing.

Fixes https://github.com/dart-lang/sdk/issues/41181

Change-Id: I9de2775e2a17bacdd30cbfb34dc095cf2b5c603f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147040
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-07 14:47:07 +00:00
Sam Rawlins 6630f39690 Migrator: Fix null-check hint after a cast 
Fixes https://github.com/dart-lang/sdk/issues/41400

Change-Id: Iba8ee6c63ea4613904b7eb11b688d14b33ba29dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146825
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 21:43:21 +00:00
Sam Rawlins c958fa4fb9 Migrator: Fix nullable casts which are immediately null-checked. 
Fixes https://github.com/dart-lang/sdk/issues/41397

Change-Id: I7e64cbb475b6387ad10a2895e67311edac3aa7d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146824
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 21:33:29 +00:00
Sam Rawlins 7477ab0b93 Migrator: add two failing tests for #41788 
The expectation in test_expression_bang_hint_in_as_wrapped looks weird,
but without  https://github.com/dart-lang/sdk/issues/41397 fixed, this
is the expectation I have; if the migrator starts producing that output,
then #41788 is being fixed. If #41397 is being fixed, the dev can change
the expectation in this test.

Change-Id: I0cfc0c5da8cd12ea12ae74b1909155a0b9a2b043
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146822
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-06 16:32:22 +00:00
Paul Berry 097c3aab2c Migration: add a repro for issue #41409. 
Bug: https://github.com/dart-lang/sdk/issues/41409
Change-Id: I1029767745414c472bbe0b6efc7ee1ea6c0ac51e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146685
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-06 12:59:52 +00:00
Paul Berry 965dd4d6d8 Migration CLI: validate that package to migrate exists and is not a file 
Change-Id: I4b7c189e29c141a5bbd7738542d7dbf398e567d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146523
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:25:33 +00:00
Paul Berry e5efe2be29 Migration CLI: normalize input path and make it absolute 
Change-Id: Ie88dae881f62b3513df9f799ca1abd4c7e831641
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146500
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:25:33 +00:00
Paul Berry 1ac898a2c5 Migration: add the ability to output a text diff to the CLI. 
The previous implementation of the tool (based on dartfix) used
diffing code that was pretty deeply tied into dartfix, and didn't
produce good quality output for migration, so I've replaced it with a
new implementation.

Change-Id: Id3679435bf59c73145eacb6eaee1b6ce16dd61f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146442
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 20:19:23 +00:00
Sam Rawlins 57ff9b73f9 Migrator: Support nullable function-typed parameters 
Feature includes:
* function-typed formal parameters
* function-typed field formal parameters
* overridding parameters
* nullability hints
* adding `required`
* optional parameters

Fixes https://github.com/dart-lang/sdk/issues/39832

Change-Id: I1d9b1a50a9a6a77651fe6179b66c8301c8ab9408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146029
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-05-05 20:03:07 +00:00
Mike Fairhurst 44ad40afa5 [nnbd_migration] Add a trace entry for nodes with no known nullability. 
Change-Id: Ic73563fb5c7dffd03685c87a5ba2eaf591513934
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145660
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-05 19:39:47 +00:00
Paul Berry 8061d2d6cc Migration: add support for a machine-readable summary of migration results. 
Change-Id: Id41bc9869448dd4ed63286cab814bf7687baaaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146620
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 17:35:22 +00:00
Paul Berry 11e5a05a70 Migration: when removing dead code, remove unnecessay ??=s 
Fixes #38676.

Change-Id: Icc24c6f070d7f3e8a74fc9494aef3e4c2583fac4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146320
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-05 02:18:13 +00:00
Paul Berry 13b3d67278 Migration: test interactions between type promotion and new compound assignment diagnostics 
Change-Id: I31d0389872640a54c962976754e65c3e2aeb2f1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-05 02:18:13 +00:00
Paul Berry eb3a42b789 Migration: test interactions between null-shorting and new compound assignment diagnostics 
Change-Id: Ia46aaf380fad1c65b59fff214217658cfcaee973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146000
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-04 23:02:17 +00:00
Paul Berry b71d09542c Migration: extend compound assignment diagnostics to ++ and --. 
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Iab5097359d8de7aa9411f51ee0ec6212c3adb678
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145920
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-05-04 23:02:17 +00:00
Paul Berry 2846ec88b3 Migration: test that new compound assignment checks respect potential nullability 
Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: I344a9c9ea1e79af864c239dbcc924f78e798a8aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-01 22:54:25 +00:00
Paul Berry bf56b2ca2c Migration: produce diagnostic information for assignments. 
We produce a diagnostic under the following conditions:

- For compound assignments, if the type read from the LHS is nullable
  (this is illegal after NNBD, and requires user intervention to fix).

- For compound assignments, if the type returned from the combiner is
  not assignable to the LHS (this was required prior to NNBD, but it
  is a stricter condition after migration, both because the LHS might
  have a non-nullable type, and because implicit downcasts are not
  allowed).

- For null-aware assignments, if the type read from the LHS is
  non-nullable (this indicates that once strong mode is enabled, the
  assignment will be dead code).

Bug: https://github.com/dart-lang/sdk/issues/38676
Change-Id: Icb242ba36437e38364ada069880831eb05e3a513
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145664
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-05-01 22:54:25 +00:00
Paul Berry f0e428eb73 Migration: encode and decode paths properly on Windows. 
Fixes #41678.

Bug: https://github.com/dart-lang/sdk/issues/41678
Change-Id: I532f65eb99a9ad7ce2542bffa0aa2d5a680d28c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145880
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-01 17:53:13 +00:00
Paul Berry ff53bd8d4a Migration: make sure new CLI detects when run with an old SDK 
Change-Id: I7b279788e34d3d2e86df58ff4ef7c86b58e154e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145644
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-30 21:50:12 +00:00
Paul Berry c33f4ad9fc Migration: support changing pubspec in new CLI 
Change-Id: I2e091a4ef8999f1fe649c7b9e69798e9959b635a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145643
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-04-30 21:50:12 +00:00
Paul Berry a144fedbba Migration: add support for --ignore-errors to new CLI 
Change-Id: I467c3ecfc7e8a7f52a1ba2be887ac2a677d5545c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145543
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-30 16:23:37 +00:00
Paul Berry 136ad8353b In migration CLI tests, verify that preview server only starts when expected 
Change-Id: I81555fe4c520761ab14dc1535ad4a9918e226965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145540
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-30 16:23:37 +00:00
Sam Rawlins 5ab3f3506f migrator: quiver's checkNotNull implies non-null intent 
Fixes https://github.com/dart-lang/sdk/issues/39315

Change-Id: I136975064c6aadf9b8548afe9b5928d4ee6775a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145569
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-30 16:15:32 +00:00
Sam Rawlins 5506769402 Count variables checked with ArgumentError.checkNotNull as not null 
Fixes https://github.com/dart-lang/sdk/issues/39644

Change-Id: I552e87e7c57dd2c5a012b76d9c73c24fefb19785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145025
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-29 22:35:18 +00:00
Sam Rawlins 61755dea19 Migrator: Infer late for test variables 
Fixes https://github.com/dart-lang/sdk/issues/38291

This change also involves moving the "package" where test sources are
written and analyzed; It used to be /home/test (or /project in some
places); and a pubspec.yaml was written (or a .packages file) which
specified the package's name was "test". However, this conflicts with
adding an entry for a mock copy of the actual _test_ package. A
.packages file cannot have two entries for a package named "test", so
the package where all test sources are written is changed to "tests"
(located at /home/tests).

Change-Id: I462b88a814931dc2d4f1e72d07e3daf64768a399
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144994
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-29 22:09:28 +00:00
Paul Berry 4d1ca6316f Migration: fix mock SDK path for testing CLI on windows. 
Bug: https://github.com/dart-lang/sdk/issues/41678
Change-Id: I191699a5b9f39445be1bccad5e1e44d6b568d486
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145441
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-29 19:11:54 +00:00
Paul Berry c6f94c3224 Migrtaion: add a hook to allow the preview server to be shut down in unit tests. 
Without this, it's possible for a unit test failure to result in a
preview server remaining open, which can prevent test execution from
terminating.

Change-Id: I8a11056da5bea003dfa46e3871a241e8f5ce8cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145440
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-29 19:11:54 +00:00
Paul Berry 6c1f8a0fb6 Split migration_cli_test.dart into Windows and Posix tests. 
Since the tests use a MemoryResourceProvider we can run both kinds of
tests on both platforms.  That should make it easier to track down and
fix issues occurring under Windows (see
https://github.com/dart-lang/sdk/issues/40381).

Change-Id: Ie058f8c08923a3ef4ea12c5f28219e48aa17c28d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145026
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-29 16:20:44 +00:00