dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

59 Commits

Author SHA1 Message Date
Sam Rawlins afbb8f9063 Meta: introduce @internal annotation 
Fixes https://github.com/dart-lang/sdk/issues/28066

Change-Id: I200173e48bfbffa8460d6273c274d210b3be8606
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164244
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-09-24 00:25:29 +00:00
pq eb30e43940 specify targets for @doNotStore 
Change-Id: I22546585fb189e4536e16a38488ce2e8b3b7fe52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160740
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-29 01:11:03 +00:00
Brian Wilkerson 896f874b9f An initial definition of the Target annotation 
Change-Id: I6980da1e869c57b15a8bd068fef17f33d6a884ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-07-17 19:01:17 +00:00
Brian Wilkerson 73e9554779 Update meta to correspond to the published 1.2.2 
Change-Id: I9dcbd9237d25948eb62e3ba68403436c64c70845
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153822
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-09 17:38:32 +00:00
Tess Strickland 06cb010247 Revert "Add unawaited to package:meta" 
This reverts commit 0d44449aaa.

Reason for revert: Breaks Flutter HHH and the Dart->Flutter roll.

Original change's description:
> Add unawaited to package:meta
> 
> Change-Id: I09df4989591327bd4d148e73a5887b900902576c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jake Macdonald <jakemac@google.com>

TBR=brianwilkerson@google.com,jakemac@google.com

Change-Id: I71f491bccc37508a24b7f6f9d051ed914bafeccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153351
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2020-07-07 08:14:51 +00:00
Brian Wilkerson 0d44449aaa Add unawaited to package:meta 
Change-Id: I09df4989591327bd4d148e73a5887b900902576c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-06 21:57:52 +00:00
pq 37ba50cd0c Add @doNotStore. 
See: https://github.com/dart-lang/sdk/issues/41941

As per the conversation there, I opted not to handle the formal parameter case.

(My thinking being we could add it as a refinement.)

Change-Id: Ia91c525c8ea4ce26d9debe3f52af9a3018e50d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152540
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:27:52 +00:00
pq 2d7235c14d typos 
Change-Id: Idbbd0ad4d6097f7c1c5a70de5f3fa4c2d13ff2c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-02 23:09:17 +00:00
pq a688de0371 Add deprecated member messages 
Change-Id: I8efa2244b3f03a1af44eca93ed4441a255c6cb68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129923
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 15:41:26 +00:00
pq 6a8ab6a858 Remove unnecessary const modifiers 
Change-Id: I2187b009abc150d8e361d00c673099ec7b4147f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-02 00:48:55 +00:00
pq 5812bf4688 remove “implements” condition 
Change-Id: I21f571e0490bcfd43ed84f84fb08f8b6659c836d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-24 18:19:22 +00:00
pq d43cd7e909 + @nonVirtual 
See: https://github.com/dart-lang/sdk/issues/34378

Change-Id: Ie61b8bddaef01cdbf47da9a8ca6915cbd86b21a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122701
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-23 22:43:47 +00:00
Sam Rawlins e9dcb9f45d fix typo in factory; add mixin text for protected 
Change-Id: Idab2890de1f128105a02d94a7512e4a22eba7023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116050
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-09 14:11:47 +00:00
Sam Rawlins 35c011c030 Update meta docs to consider mixins and static extensions 
* Update optionalTypeArgs to consider mixins and static extensions
* Update visibleForOverriding to consider mixins
* Update visibleForTesting to consider private declarations, and
  declarations on unnamed mixins

Bug: https://github.com/dart-lang/sdk/issues/38105
Change-Id: I50b87e0fafd7960abc945b240788b1a640f78621
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115067
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-04 04:01:47 +00:00
Vijay Menon 23dae9cca3 Make package:meta NNBD agnostic 
Minor changes to pass analysis with --experiment=non-nullable on.

Change-Id: I17cafbc4f3a127fb755412883b889e5454387819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114400
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-08-23 19:23:41 +00:00
Sam Rawlins af97015781 Fix markdown and Dart links in meta package 
Right now they're dead. https://pub.dev/documentation/meta/latest/meta/meta-library.html

Change-Id: Iecc12075e56eb4caf115c34fdfb04d9b164ebe2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-02 21:08:59 +00:00
Jonas Termansen 7d6a3e0058 Fix http links to pub which has https. 
Change-Id: I3b712014fb0744b890df426e941907760bd92780
Reviewed-on: https://dart-review.googlesource.com/c/88452
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2019-01-07 11:37:19 +00:00
Sam Rawlins 359217d30d Correct doc comment for sealed 
As per discussion at https://github.com/dart-lang/sdk/issues/34232

Bug: https://github.com/dart-lang/sdk/issues/34232
Change-Id: Ib0a7207a43167b5e69973fc3abffa197e0bdafe5
Reviewed-on: https://dart-review.googlesource.com/c/88289
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-03 21:21:20 +00:00
Sam Rawlins 31fa815dca Remove sealed ability on mixin 
Change-Id: I69f59dfaa18d77fcd53f82b71a79c567102a9b66
Reviewed-on: https://dart-review.googlesource.com/c/88200
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-03 01:51:35 +00:00
Brian Wilkerson e58e3fbb55 Deprecate the "virtual" annotation 
Change-Id: I3fa88a70f36c769be3649ea7d40d280e6cf6b633
Reviewed-on: https://dart-review.googlesource.com/c/84443
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-14 20:12:37 +00:00
Stephen Adams ded73cdd08 Revert "[dart2js] Simplify noInline / tryInline annotations" 
This reverts commit 8bae3a1cfd.

There are versioning issues that need to be addressed.

TBR=kevmoo@google.com

Change-Id: Ia82e94f127523db650e4df03af1179ef94463bee
Reviewed-on: https://dart-review.googlesource.com/76564
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-09-25 22:11:42 +00:00
Stephen Adams 8bae3a1cfd [dart2js] Simplify noInline / tryInline annotations 
Use @pragma for dart2js.noInline / dart2js.tryInline

Change-Id: Id7932ad7f85b91e4c1e427bb88e782ede81d5926
Reviewed-on: https://dart-review.googlesource.com/76341
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-09-25 19:08:14 +00:00
Sam Rawlins dfce7e26a4 Use uppercase example class names in meta 
Change-Id: I21f4ff480648cd0e2e3f732fd56ec6e3564d93fc
Reviewed-on: https://dart-review.googlesource.com/71230
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-08-23 00:33:55 +00:00
Sam Rawlins 76ae676a23 Fix meta CHANGELOG and doc comment after feedback 
Bug: https://github.com/dart-lang/sdk/issues/27372
Change-Id: If532ad81e833589642b696b5ef0c291ccaac1e3e
Reviewed-on: https://dart-review.googlesource.com/71121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-08-22 15:22:58 +00:00
Sam Rawlins 537a6f1411 Introduce @sealed annotation 
This annotation will act as an easy way for users to experiment with a language
feature under consideration, called "sealed classes."

Bug: https://github.com/dart-lang/sdk/issues/27372
Change-Id: Ieb8bc70edaf8c11c41f0f47c01951e8311736c1f
Reviewed-on: https://dart-review.googlesource.com/69601
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-08-22 04:03:22 +00:00
Konstantin Shcheglov f64ba0cadd Add @isTest and @isTestGroup to package:meta 
R=devoncarew@google.com, paulberry@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2055
Change-Id: I78083783a3e05171746253101b3b10bbdcc8ef99
Reviewed-on: https://dart-review.googlesource.com/53480
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-03 04:39:04 +00:00
Brian Wilkerson 7ed0bccca8 Add a README file to the meta package 
Change-Id: Id8e9587a0a0f3573dcc713c9244c11d0d142a494
Reviewed-on: https://dart-review.googlesource.com/30140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-17 21:53:17 +00:00
Stephen Adams 4babd94282 Update dart2js.noInline docs 
Change-Id: Id6870b405d2a379c221a3fc493adc547c84c450b
Reviewed-on: https://dart-review.googlesource.com/18506
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2017-11-03 19:04:20 +00:00
Stephen Adams b3a93f44eb Add dart2js noInline and tryInline annotations to package:meta 
There will be a follow-up change to remove NoInline from package:expect.

Change-Id: I6dc33241ea6d8b6a8994da6a8ec5295dab30f4da
Reviewed-on: https://dart-review.googlesource.com/17043
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-27 21:21:13 +00:00
Konstantin Shcheglov 6869702dae Deprecate @checked in package:meta, use covariant instead. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I024d15a804a394efbb3a982d6205f30d7385b89e
Reviewed-on: https://dart-review.googlesource.com/9781
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-30 01:25:15 +00:00
Sam Rawlins c6d6a69a78 Add an alwaysThrows annotation to indicate that a function always throws. 
BUG=https://github.com/dart-lang/sdk/issues/17999
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2170643003 .
 2017-06-13 12:42:25 -07:00
Brian Wilkerson 8d340ee8c6 Add an experimental annotation 
R=matanl@google.com

Review-Url: https://codereview.chromium.org/2789843003 .
 2017-03-31 10:54:24 -07:00
Brian Wilkerson 37890f995f Add a new annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2420653002 .
 2016-11-09 14:19:27 -08:00
Brian Wilkerson f61a3eacc4 Add the @immutable annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2476673004 .
 2016-11-07 09:49:45 -08:00
John Messerly 865e808f15 support @virtual fields, fix #27384 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2352433002 .
 2016-09-19 09:45:24 -07:00
John Messerly 05e945d1c0 follow up for #25578, add @checked to package:meta 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2334413002 .
 2016-09-13 17:26:24 -07:00
Konstantin Shcheglov 5ade4b47f9 Add @visibleForTesting annotation to meta. 
R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/2231993002 .
 2016-08-10 13:23:32 -07:00
pq 1ec53e449c Update @factory to allow for statics and nulls. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2087953003 .
 2016-06-21 15:33:07 -07:00
pq bfd06cbd77 Extend @protected to include implemented interfaces. 
Fixes: https://github.com/dart-lang/linter/issues/252.
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2031053002 .
 2016-06-02 16:13:03 -07:00
pq da4f9c0b7f Fixed docs for meta. 
BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/1902483003 .
 2016-04-18 14:29:45 -07:00
pq 1cbf0a4313 Annotation for @optionalTypeArgs (linter#196). 
See: https://github.com/dart-lang/linter/issues/196

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1879853002 .
 2016-04-11 16:56:32 -07:00
Brian Wilkerson e0f7b4f314 Add an optional parameter to the Required annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1770653002 .
 2016-03-07 07:08:07 -08:00
Brian Wilkerson eadf713dfd Add the @literal annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1747943002 .
 2016-03-01 07:57:26 -08:00
Brian Wilkerson 55df03925a Clarify the semantics of the @required annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1744273002 .
 2016-03-01 07:56:36 -08:00
Brian Wilkerson f4f8f05d97 Add @factory annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1735313005 .
 2016-02-26 14:48:22 -08:00
Brian Wilkerson a614bcef5f Define the mustCallSuper annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1740763003 .
 2016-02-25 14:33:34 -08:00
Brian Wilkerson 33250f8ff5 Add the @required annotation 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1728273003 .
 2016-02-25 08:47:36 -08:00
Brian Wilkerson 7d8b260b60 Define protected to apply to fields 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1719353002 .
 2016-02-24 13:55:38 -08:00
Brian Wilkerson 8df095e6e0 Add the @protected annotation 
R=ianh@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org/1706993002 .
 2016-02-18 07:51:27 -08:00
pq 6a242d046a Add pkg/meta (#25741). 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1705803002 .
 2016-02-17 09:44:24 -08:00