dart-lang/sdk - sdk - Tonycloud git server

dart-lang/sdk

Fork 0

Commit Graph

Author	SHA1	Message	Date
Nate Bosch	ec160b74dc	Start cleaning up docs in package:js - Remove some unnecessary details in the README. The SDK constraint duplicates the pubspec, the dependencies section duplicates automatic info on the pub site, and the contributing section duplicates generate Dart/SDK contributing information. The issue link is still useful since it fills in a template, but we should update it to include a label by default. - Use "JavaScript" consistently in docs. - Rephrase some doc comments for clarity. - Drop `new` from examples. - Use consistent single quotes in examples. - Always show the `@JS()` annotation on `library` in examples. - Move the note about factory constructors for anonymous classes to the annotation from the README. - Bump the mimimum SDK to`2.0.0` since there isn't utility in claiming support for older SDKs. There are stale docs remaining in the `varargs.dart` library that should be handled separately by deleting that library. Change-Id: Ida51d2ec3fd31210b55dc91042a0ac1cf77210b8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107450 Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com>	2019-06-27 21:36:54 +00:00
Jacob Richman	96ca5db7e5	Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js. BUG= R=alanknight@google.com, sra@google.com Review URL: https://codereview.chromium.org/2150313003 .	2016-07-25 09:59:01 -07:00

Author

SHA1

Message

Date

Nate Bosch

ec160b74dc

Start cleaning up docs in package:js

- Remove some unnecessary details in the README. The SDK constraint
  duplicates the pubspec, the dependencies section duplicates automatic
  info on the pub site, and the contributing section duplicates generate
  Dart/SDK contributing information. The issue link is still useful
  since it fills in a template, but we should update it to include a
  label by default.
- Use "JavaScript" consistently in docs.
- Rephrase some doc comments for clarity.
- Drop `new` from examples.
- Use consistent single quotes in examples.
- Always show the `@JS()` annotation on `library` in examples.
- Move the note about factory constructors for anonymous classes to the
  annotation from the README.
- Bump the mimimum SDK to`2.0.0` since there isn't utility in claiming
  support for older SDKs.

There are stale docs remaining in the `varargs.dart` library that should
be handled separately by deleting that library.

Change-Id: Ida51d2ec3fd31210b55dc91042a0ac1cf77210b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107450
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>

2019-06-27 21:36:54 +00:00

Jacob Richman

96ca5db7e5

Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js.

BUG=
R=alanknight@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2150313003 .

2016-07-25 09:59:01 -07:00

2 Commits