d75a49a44f
[CFE] Ignore abstract methods when looking for operator '=='.
...
Fixes https://github.com/dart-lang/sdk/issues/36515
Change-Id: I7e6717b8cde7341c482e5eeb52c2ab4fe8fdcb9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98842
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-08 11:11:08 +00:00
6dc9c8d127
[CFE] JS: Treat integer valued double constants as integers.
...
This fixes the problem with two-pass constant evaluation (with
intervening serialization) where an integer created by the first
pass would look like a double to the second pass.
Fixes https://github.com/dart-lang/sdk/issues/36477
Change-Id: I5040c3a2dac780c17a28b29df3dd65b6b9b3379b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98676
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-04-05 15:56:04 +00:00
44799241fa
Revert "set empty environment defines to CompilerOptions"
...
This reverts commit 3d6e29d251https://dart-review.googlesource.com/c/sdk/+/98697
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2019-04-05 14:57:14 +00:00
3d6e29d251
set empty environment defines to CompilerOptions
...
Bug: https://github.com/dart-lang/sdk/issues/36476
Change-Id: I5fac7372026acbb9ef1d9514e6518088ee18dcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98702
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2019-04-04 20:38:18 +00:00
896f1c4bb9
CFE tests for issue 36400
...
Change-Id: I05139ce86177fe32cae857e410f759d365dc7bde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98503
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-04 15:48:30 +00:00
313e0f5410
[CFE] Check if set element or map key overrides operator '=='.
...
Fixes https://github.com/dart-lang/sdk/issues/36444
Change-Id: I38b485ca538c65072e2ec3386e30c5ce49671fe4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98666
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-04 14:39:50 +00:00
e58a8fade5
Fix typos in the diagnostic messages
...
Change-Id: I65a11e52933c37a63cb9d0a14b1961a20e16271f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-04 13:47:40 +00:00
a069ddda21
[CFE] Produce InstanceCreation from unevaluated constructor invocation.
...
Thread assert enable flag through in dart2js to make the dart2js cfe
constant evaluation unit test properly pass the flag.
Fixes https://github.com/dart-lang/sdk/issues/36454
Change-Id: Ie4ac86ce96feda1548120fed54ece9ca03387496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98570
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-04 12:22:50 +00:00
2f77af1c6f
Fold identical(double.nan, double.nan) => false in dart2js.
...
Change-Id: Idc6b064e330af71bbc8525a48874d332d84f404a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98607
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-04-03 21:14:31 +00:00
fe2d66006d
improve type-before-factory error message
...
Address comment in https://dart-review.googlesource.com/c/sdk/+/98449
Change-Id: I38e7cf04e2061dbd6c9b37cca713e8420a1e021d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98520
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-03 16:30:18 +00:00
9f3e9f37a0
[cfe] Make checks on individual leaves of collection element sub-trees
...
Closes #36456 .
Bug: http://dartbug.com/36456
Change-Id: Ic604fecbabe78eede44cedb2251a68b71f608c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98567
Auto-Submit: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-04-03 13:54:03 +00:00
54783db99c
[cfe] Ensure that await for elements are marked async
...
When converting an await for map entry to an element, ensure that the
element is properly marked async. This fixes failures on dart2js and
DDK.
Change-Id: I7566bc57728f1d734bb8932f15ea7a9e9487d39e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98565
Auto-Submit: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-04-03 12:54:33 +00:00
dbb6bf0237
[cfe] Ensure that async for map entries are marked
...
When disambiguating between maps and sets, ensure that `await for`
loops are marked as asynchronous. Otherwise, there will be a spurious
type error because we have a Stream and would expect an Iterable.
Change-Id: Ie97eaf74ff7a9e4dfb262ab0447f4322d04701aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98467
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Auto-Submit: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-03 10:27:22 +00:00
e1e5bb59c9
[cfe] Check that the condition in if-elements is a bool
...
Change-Id: If089fa603d586169ca2a368ba7fbf7fffc7ec8d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98484
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-03 09:17:24 +00:00
c5f1614bcc
[fasta] Don't use invalidCollectionElement when ui-as-code is enabled
...
Closes #36413 .
Bug: http://dartbug.com/36413
Change-Id: Ie9f0b82bab63c802fddb4c5642d374d7cc43455e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98466
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-03 09:17:24 +00:00
335a854696
Implement JavaScript semantics for frontend constant folding.
...
Change-Id: I8232d0f5875d8471d8110582c44fc9d9b8a735f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98240
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-02 22:37:46 +00:00
8fee2596e5
Remove some unused front_end dependencies
...
There are no imports to these packages.
Change-Id: I51c194cd48b7fb594070616524f817267ae11d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
2019-04-02 16:55:29 +00:00
725c070632
report error on type reference before factory keyword
...
This updates the parser to report an error if there is a type reference
preceding the factory keyword.
Fix https://github.com/dart-lang/sdk/issues/36400
Change-Id: Iba04f68bba8d260444d55168322d67a600feba53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-02 15:39:29 +00:00
14fd3b7d6a
Report errors on invalid constants in == and !=
...
Invocation of == and != is only constant on receivers of types bool, int, double, and String or null operands. This is now handled correctly in constant evaluation. The case for method invocation of `a != b` is removed since it is parsed as `!(a == b)`.
Change-Id: I65d8ddf2716f319f61fc0609803a5237f4aba644
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98349
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-02 13:54:28 +00:00
4a1b153fe1
[cfe] Enable type promotion in if-elements of literal collections
...
Closes #36396 .
Bug: http://dartbug.com/36396
Change-Id: I223267cdee1aca38d69354e4f97df7dcc76e9553
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98461
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-02 13:33:19 +00:00
45bd79c119
[cfe] Fix inference on variable declarations in for-elements
...
Closes #36395 , closes #36393 .
Bug: http://dartbug.com/36395
Change-Id: Ifd35ce2e1a646b484b7fcc83d9fb1a0f9d3ae978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98333
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-02 13:33:19 +00:00
71a3649a5a
[cfe] Assume invocations are dead if they aren't reached by type inference
...
Closes #36356
Bug: http://dartbug.com/36356
Change-Id: I8fdc50877ada3eaa608bd8b02d53dc975af4efd8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98355
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-02 13:08:09 +00:00
d320f42542
[CFE] Remove redundant null checks in constant evaluator.
...
The evaluate method now never returns null, so checks for null of
return values are redundant, and the "try" in the name of the
evaluation functions is not appropriate.
Change-Id: I32960164ba73fb706eef5a5a617df7d47e24a074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98357
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-04-02 12:11:58 +00:00
8ce2d7a4e1
[CFE] Better error messages on errors with user definable operators
...
Fixes #36383
Change-Id: I24fd51bdb3ead75973009fe515819f9c8354e1b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98332
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-04-02 10:46:18 +00:00
c71888d537
[cfe] Async translation of block expressions
...
Translate block expressions in the VM's async translation. Closes
https://github.com/dart-lang/sdk/issues/36277
Change-Id: I606b155bfe1364e948d18043c167a272007411e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98339
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-04-02 10:00:53 +00:00
87de68341f
[CFE] Disallow property access on instance constants.
...
Change-Id: I06b87332774790ae0c650810541bb6828101c3ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98335
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-04-01 15:51:34 +00:00
1a3e8dda3b
Handle nested unevaluated constants in constant evaluator
...
The constant evaluator assumed that any ConstantExpression met during evaluation of a sub expression was not an unevaluated constant. This do occur, for instance when a field is initialized to an unevaluated constant. With the change, unevaluated constants met during evaluation are themselves evaluated.
This change also fixed handling of assert initializers in unevaluated constants.
Change-Id: Id9e676f40bc829c4d234f34a74ef0ca5c4c6ec48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98348
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-04-01 14:29:32 +00:00
277f65ec93
[CFE] Permit evaluating a const variable more than once.
...
This happens for instance in language_2/const_qq_test.
Change-Id: Ibad3f578f765cf2dccbf1e6c50ef0ff7187f5f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98334
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-04-01 13:44:13 +00:00
a88b653e03
[CFE] Bubble out InvalidExpression from unevaluated constants.
...
This allows backends that do not understand unevaluated constants,
such as the VM, to properly throw when encountering static errors
inside constant expressions.
Change-Id: Ida0f213cacbc66aea9bb1db2ddbd3fb4b8405eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98352
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-04-01 13:11:47 +00:00
05dd851566
Test late CFE constant evaluation.
...
Tests that dart2js can handle evaluation of unevaluated constants from CFE, including handling of potential compile-time errors found during evaluation.
The CL fixes a bug in the constant evaluator where it created map literals that were not marked as constant as needed.
Change-Id: I7df77a3c68e52392a143478b3567d19e09ebe6bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98347
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-04-01 13:05:52 +00:00
e0a2651ce0
[cfe] Fix downcasts added during set/map disambiguation
...
Change-Id: I79d559c756994424eb395ecc8f12f84c1bf1e257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98327
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-29 17:18:55 +00:00
f21d521d0e
[cfe] Fix pre-inference set/map disambiguation
...
Closes #36377
Bug: http://dartbug.com/36377
Change-Id: I0a486f467bdc999e6188fb3206f4eed1d8ffb67a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98341
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-29 17:18:55 +00:00
6b19aa821b
[cfe] Do type checks on spreads during inference
...
Change-Id: I9eb72681a5a019ff7f7e030cf5f500144293bd4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98180
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-29 17:18:55 +00:00
1a5ed8247f
[fasta] Fix typos and copy-paste errors in a test case
...
Change-Id: I5d65f4ec44cb358767b1a8902d862dba1be1bb6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98019
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-03-29 17:18:55 +00:00
584affcffa
[cfe] Add initial support for 'for' and for-in elements in maps
...
Change-Id: I9fade4b8ac193f4d9a4df33c71447c0cb5fc3590
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98015
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-29 17:18:55 +00:00
fa7e0c7531
[cfe] Add element type checks in spreads
...
Closes #36348
Bug: http://dartbug.com/36348
Change-Id: I2952e4430409bc84a97e611b43cf8885a5f5a6f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98003
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-29 17:18:55 +00:00
fb58826aa3
[CFE] Compensate for lowering and desugaring in spread.
...
This fixes a problem where a set or map in a spread would not be
properly recognized by the constant evaluator when compiling for a
VM target.
Fixes https://github.com/dart-lang/sdk/issues/36387
Change-Id: I01efc932994c143fa5a5a2fbacda21fe9206e3e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98330
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-29 16:59:06 +00:00
4fe2f6f349
Add more tests to the incremental compiler
...
Add a test that reproduces a error we had in flutter code when
for instance 51da94da76https://dart-review.googlesource.com/c/sdk/+/98340
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-03-29 12:20:12 +00:00
b7f69e24a2
dartdevc and bazel worker can use incremental compiler
...
This allows dartdevc and the bazel worker to user
the incremental compiler with kernel.
Use --reuse-compiler-result --use-incremental-compiler to run in this mode.
Change-Id: I9189ce5f1a51320d9d96e071f8c95c80fe6fca84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95386
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2019-03-29 12:07:42 +00:00
f0027dfea3
[CFE] JS number semantics for constant subtype checks.
...
Change-Id: I7c12ec41ac6bab6318f4ff52201bdf333a6b81e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98141
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-03-28 15:00:58 +00:00
018fd36557
[CFE] Handle spread and if in const map literals.
...
Change-Id: I5250a115c1c98849a695e1d159532a49605c7caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98014
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-28 15:00:58 +00:00
b5be157e09
[CFE] Handle spread and if in const set literals.
...
Change-Id: I7db79282c1caafb2f8f07cd676e4bbe0941cd264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98009
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-28 15:00:58 +00:00
0b57b67ecb
[CFE] Move const set desugaring to constant evaluator.
...
To properly recognize control-flow constructs in sets, the constant
evaluator needs to get un-desugared set literals. This commit skips the
desugaring of const set literals if the constant evaluator is enabled
and adds a similar desugaring in the constant evaluator.
Doing the desugaring in the constant evaluator (which can be called
independently of Fasta) necessitates that dart:collection is indexed
in CoreTypes. We can remove this indexing again when the VM gains
native support for set constants.
Change-Id: Ibddafdcb182e4471012801745b51b529805b7b9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98008
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-28 15:00:58 +00:00
102b1fa39e
[CFE] Handle spread and if in const list literals.
...
Change-Id: I534dcd2e02d8d70b83b55a4890fb1a6e1bf6170d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97307
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-28 15:00:58 +00:00
665d2d0003
[CFE] Leave const collections to the constant evaluator.
...
Change-Id: Ib828bfa7f5695657e9e5ca67f7a9c3868a2a8fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97936
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-03-28 15:00:58 +00:00
a977273262
Re-allow the incremental compiler to load modules
...
This reverts commit 4d43abdd9f2f3026ccfabaa5495499b3ea220430 and adds a
fix.
Change-Id: Id80186aba02dd80171aac3843d63aa4f42c5ca17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98017
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-03-28 12:53:01 +00:00
7b33a8fdc4
[cfe] Fix type inference in map literals with spreads
...
Closes #36223
Bug: http://dartbug.com/36223
Change-Id: Id274361628f5b769609ca9c9513e48dbfaa42374
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97963
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-03-28 12:30:41 +00:00
864b22d3ce
[cfe] Add inference and type checks to if-elements in maps
...
Change-Id: I3cacaee173320dd52bead6688fac24e4e4a01f0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97962
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-03-28 12:30:41 +00:00
b978fdd142
Move experimental flag defaults to CFE
...
Change-Id: I9f1890f349fb19bbd792af071adc14ad4e50c364
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98010
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-28 10:19:51 +00:00
3e4a1de6e9
Use dart:foo-patch import uri for patches; remove VM workaround for sdk uris
...
Closes #32087 .
Change-Id: I93a757125bf29bc283bf6536fa5e53a4f9334891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97311
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2019-03-28 10:00:51 +00:00
Aske Simon Christensen