Leaf Petersen
5e9be81d5e
Make all CastErrors be TypeErrors.
...
This makes CastError implement TypeError, and changes all test
expectations to look for TypeError. A followup CL will deprecate
CastError.
Bug: https://github.com/dart-lang/language/issues/787
Bug: https://github.com/dart-lang/sdk/issues/34097
Change-Id: I7102c6260901317572d2df08c4be9c4c48197688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138670
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-11 23:31:06 +00:00
Jens Johansen
e6a1e70960
[CFE] Error in outline and recover from type parameter in static field in class
...
Change-Id: I7127a6acd85c3133912d70abb28285989aeeae61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138809
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-11 07:48:49 +00:00
Sigmund Cherem
bff20985ce
[cfe] remove whitelist of opt-out packages
...
Closes https://github.com/dart-lang/sdk/issues/40775
Change-Id: Ib713494edf34046bbf7de43811659863fbc5884e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138901
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-03-11 03:19:59 +00:00
Konstantin Shcheglov
9a0c09ecb2
Track definitely unassigned variables.
...
Change-Id: Id610a133912605f9af63222f25408942420cbf1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138881
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-10 18:35:40 +00:00
Jens Johansen
7ac22948e5
[CFE] More error for type variable in static contexts
...
Bug: 40918
Change-Id: Ibd7efa6618ea732a42bfb0042d5e9ef9bc8c0d8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138803
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-10 13:26:30 +00:00
Konstantin Shcheglov
24c8021f03
Replace initialize() with declare().
...
Fixes https://github.com/dart-lang/sdk/issues/38791
Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-09 18:24:51 +00:00
Dmitry Stefantsov
029c8f1cee
[cfe] Use Supertype instead of InterfaceType in ClassHierarchyBuilder
...
Change-Id: I1a11ce32237480c0eddf50a7a86cd56b89116e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138801
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-09 12:57:17 +00:00
Jens Johansen
e8c58a7a3d
[CFE] Add ability to compare CompilerOptions
...
This is (intended to be) a small step towards removing the batch compiler.
Change-Id: I201c56b6d33420f91d2f4b989682670cd8d6a387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138508
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-09 09:11:57 +00:00
Jens Johansen
40507e7b13
[CFE] Tool for fasta -v statistics
...
Change-Id: I0f492b294dec96f871e6d9cdd997594fe3d1b410
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138507
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-09 09:06:07 +00:00
Nate Bosch
d3c0d59706
Disallow non-external generative JS constructors
...
Towards #40434
Towards #38875
Fixes #33834
- Add a shared error message for a non-external constructor.
- Check for non-external non-factory constructors constructors in the JS interop
checks.
- Remove commented out code in Dart2JS that used to handle this check.
- Clean up skipped tests due to the missing static error. The status in
`legacy_status_dart2js.csv` has no behavior impact but is removed for
completeness.
- Add `external` to a few test cases.
- Remove unused dart2js error message.
- Add `annotating` to hardcoded spelling list.
- Ignore missing example for web specific error message.
- Switch some dart2js error expectations to GENERIC since the message is no
longer defined with other dart2js errors.
Non-external synthetic constructors are ignored for now. An upcoming change will
automatically convert these to external.
Change-Id: I3b4a042392826c528689d81c4255f5369a0a7a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138043
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-06 17:06:39 +00:00
Clement Skau
b681bfd8d2
[VM] Fixes bad reuse/typing of temps in async transform invocations.
...
For a method invocation temps might get allocated for both the receiver
and argument(s) so that:
A().foo(await null)
becomes:
Future<void> tmp0
...
tmp0 = A() // <- Type mismatch.
yield ...
tmp0 = tmp0.foo(:result) // <- Correct type.
This happens because the liveness analysis finds that the (previously
dynamic) temps can be reused.
Unfortunately 121988 added typing information to these temps, which
means they can't be simply reused in all cases.
This fix makes the temps dynamic again (by removing the type) but adds
unsafecasts to all VariableGets to propagate the know type.
Bug: https://github.com/flutter/flutter/issues/51828
Change-Id: I89c82763e0d4f8b102bb55dec3b694d017345517
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138500
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-03-06 12:20:45 +00:00
Jens Johansen
c1ed25dcf0
[CFE] Remove BulkCompiler
...
Change-Id: I4f88f47c18646e9cc9db2190c5861862f3c9a74c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138293
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-06 11:12:54 +00:00
Sigmund Cherem
a410f5bde1
[dart2js] rename null-safety flag and plumb through CFE
...
The new flag name follows the changes in https://github.com/dart-lang/language/pull/779 , the change also is converging on not having each tool infer a default on the input, but rely on build systems to provide the appropriate flag instead.
Fixes https://github.com/dart-lang/sdk/issues/39979
Change-Id: I39c143b7985dbfe6dab5dfd9a7347a7a4420479b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138569
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2020-03-06 02:22:41 +00:00
Konstantin Shcheglov
0649115b06
Rename VoidWithTypeParameters to VoidWithTypeArguments.
...
Change-Id: I5df6a49f0b27b6edfe2ce0f677d5f898900d8384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-05 17:31:34 +00:00
Jens Johansen
6b4c4faf28
[CFE] Combine 'inputSummaries' and 'linkedDependencies'
...
The two fields are already treated the same, so having two is just
confusing.
Change-Id: I649db2a77bced62429dfd94ab300673cf886e367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138291
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-05 12:38:34 +00:00
Jens Johansen
3c4089da96
[VM] Enable expression compilation when loaded from dill
...
Whenever the VM sends a request to evaluate an expression, it sends over
the list of alive dills (in order) and a sequence number (number of
reloads).
This can then either be
a) ignored if there's already a compiler around that has compiled
everything itself (e.g. if launched from source with observatory
enabled).
b) used to find out that we need to create a new compiler especially
for expression compilation. Either because we don't have any old
compiler or because a reload or GC changed the data available.
c) used to find out that the compiler we created previously is still in
a good state.
Tests for expression compilation has been added, and with the "framework"
added it should be easy to add new ones.
This CL leaves a few things to possibly be improved later:
* It doesn't support if one tries to do a mixed mode, where one
starts from source and reloads from dill. The compiler will not be
updated and the expression compilation will work on a old view of the
world.
* If - in any of the reloads - the main entry point changes library,
the initialization might not work correctly.
Fixes #34736 .
Change-Id: Icae009c581e69b810ee19d2a5e2d0a803fd9f7c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135683
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2020-03-05 07:56:23 +00:00
Régis Crelier
90484c2edb
[VM/nnbd] Check consistency of non-nullable compiled mode of loaded libraries.
...
Change-Id: If924e47fb782eb77ec0aa1cc003f0b6edb76411b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137847
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-03-04 21:16:46 +00:00
Jens Johansen
a8c7757589
[CFE] Don't hard-code uncertain version numbers in messages or tests
...
Instead don't mention them (until they are certain), and make them
certain in tests, by setting a specific version (2.9999 in this case).
Change-Id: I1a375b4908c9d06f0241a6cda0746172d6b46c15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138285
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-04 14:35:05 +00:00
Jens Johansen
4e2a1a1b0f
[CFE/kernel] Generate dart files with versions in them from tools/experimental_features.yaml
...
Use the version from tools/experimental_features.yaml as the current
language version (as specified in kernel).
Use the "enabledIn" from tools/experimental_features.yaml to write out
the major and minor version for enabling features. This replaces the
hard-coding of when nnbd is enabled (in front-end).
Change-Id: I5b5dd7c2bb0c1a412ef1e660dfbe61e227193e1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138284
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-04 14:15:05 +00:00
Jens Johansen
f828f00b59
[parser] Error recovery of type parameters on void
...
Fixes #39958 .
Change-Id: I851bef762776f4b68f0fcb645d634019b8b32e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-04 14:02:35 +00:00
Dmitry Stefantsov
eca9aabedc
[cfe] Enable NNBD support in VM for NNBD unit tests
...
Change-Id: I8ab19dcf5e5b94b2192f13ecbce917dfa8c0fb40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138281
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-04 12:53:05 +00:00
Jens Johansen
70b4ffae4b
[kernel] Delete limited_ast_to_binary.dart
...
Change-Id: I11277942cd8bb9f3f3b875233934ec0281c0369b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138085
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-04 11:45:55 +00:00
Jens Johansen
12df258354
[kernel] Small cleanup of binary printer
...
Change-Id: I3d5f6d145811e24fa4cb2936fb8fedf1c00d86b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138084
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-04 11:43:35 +00:00
Dmitry Stefantsov
0738b6701d
[cfe] Allow nullable right-hand side in typedefs
...
Closes #40714
Bug: https://github.com/dart-lang/sdk/issues/40714
Change-Id: I4d9b4a9c1439415a8b16f5ac18046aacb56585de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138087
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-04 10:22:18 +00:00
Johnni Winther
3d5fb65c06
[cfe] Handle implicit extension method call in argument replacement
...
Closes #40816
Change-Id: I1d7e0c479e03e2b40010551ebeb977e12cdf250c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138082
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-04 07:26:13 +00:00
Paul Berry
d0826bdbd5
Add current-version field to tools/experimental_features.yaml.
...
Previously, each top level key/value pair in the file represented a
feature, so in order to make room for the new field, these were all
moved under a "features:" header.
Code generators have been updated to produce the same result as they
did before; in future CLs I'll update them to generate code based on
the new field.
Change-Id: Ia2266dd0d92796f15460127742eb2b56f64438e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-03 19:25:44 +00:00
Sam Rawlins
19dc177a82
Missed one expectation change in parser recovery test
...
Change-Id: I3592dfa6c2ed0f704a34975d35d02a4073830834
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-03 18:39:44 +00:00
Sam Rawlins
e7e45599cb
Improve error recovery of misplaced await or yield
...
Bug: #32967
Change-Id: I9f8e2ae434ea79470949e7931bcb80c542c54f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138042
Reviewed-by: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-03 14:58:21 +00:00
Johnni Winther
c1ff1cbaae
[cfe] Merge clone with existing procedure in mixin transformation
...
This ensure that any existing references to the original procedure
will correctly refer to the cloned procedure after transformation.
Change-Id: I08f561f11e88d717041009e6a9bd9bb6e8054d88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137976
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-03 13:52:11 +00:00
Karl Klose
c31ca2bd1b
[infra] Increase timeout on front-end unit test suites
...
Change-Id: Ic4dad914f0ef8744d0e31913dae25ffa0a71634d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137972
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Karl Klose <karlklose@google.com >
2020-03-03 12:44:55 +00:00
Johnni Winther
101588f0f4
[cfe] Implement legacy top merge functionality
...
+ fix getter/setter type inference
Change-Id: I9a4bed2b6a53131cbc9946bac0a01a4b15a63a91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137922
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-03 12:19:09 +00:00
Dmitry Stefantsov
c07d5d84b8
[cfe] Allow uninitialized non-nullable late fields
...
Change-Id: If0d1450c317b488e3299cfa031ab1a3d6953a7ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137787
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-03 09:50:27 +00:00
Jens Johansen
47d462e8b1
[parser] Better handling of nullable types vs conditional expressions
...
Fixes #40834
Change-Id: I2fdad5a383c1873b1dd782b70e2f1e3ab8664b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137960
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-03 09:49:57 +00:00
Jens Johansen
771a1fdaeb
[CFE] Allow enabling internal experiments via environment
...
Change-Id: Icec66e1087ccd99abd7513a612479b2bdae989f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137963
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-03 08:18:37 +00:00
Sam Rawlins
e687b62ffe
Improve recovery on yield not-in generator; Improves #32967
...
Fix is inspired by very similar recover for `await` in synchronous
function, like `looksLikeAwaitExpression` and `endInvalidAwaitExpression`.
Change-Id: I50bf0c1e73c31551b94de29d78fd3d449c30fd20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136920
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-03-02 17:29:22 +00:00
Johnni Winther
5800997ed7
[cfe] Correctly merge nnbd signatures
...
Change-Id: I33e55f6ba4c2822c790667a06e0456410696ca04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137920
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-02 12:15:50 +00:00
Jens Johansen
3969356f1a
[parser] Parse bangs before type parameters correctly
...
Change-Id: Ie05e57d12cdbdeac037785ef6b94497c77d264ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137789
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-02 11:21:40 +00:00
Jens Johansen
399c68e884
[parser] Parse chained calls with type arguments correctly
...
Change-Id: Ifaecd7f74c4e2d3d332fc759f5e2ae55de47b8a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137784
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-02 10:28:47 +00:00
Johnni Winther
2fd685727a
[cfe] Remove stray debug print
...
Change-Id: Iabf75ddb949e7ccab6539fdcb6629eb0a2dc6fcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137794
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-02 09:33:33 +00:00
Jens Johansen
1b7b0bcc95
[parser] Allow covariant late final variables when it doesn't have an initializer
...
Bug: #40805
Change-Id: I94db171493ccb57f294928a3e2cec60740a09e91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137796
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-02 08:32:43 +00:00
Jens Johansen
1b534d04a8
[CFE] Change parser test output slightly
...
Special handling of beginBinaryExpression/endBinaryExpression as they
don't always comes in pairs.
Change-Id: I74323dd45615fbb340acc1c5144b0ba94ea19f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137783
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-02 08:22:03 +00:00
Johnni Winther
56763db04b
[cfe] Support NoneTarget in expectation testing
...
Change-Id: Iff7fbc581eaf875cf9a09f4b994dff7bcf70cd3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137795
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-28 14:45:31 +00:00
Johnni Winther
dda5bcee00
[cfe] Handle invalid uri in opt-out work-around
...
Change-Id: Id5e8ee4578d6ff245e1345500e58ee3f800130ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137782
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-28 11:47:51 +00:00
Jens Johansen
566973afc0
[CFE] Add leak test that attempts to find leaks in the incremental compiler
...
Change-Id: I24ae2030af0721de665b183e2997f2cdd167fa42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137580
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-02-28 08:06:24 +00:00
Alexander Markov
88be7d1cae
[cfe] Fix hasImplicitSetter for late final fields
...
Unlike other final fields, late final fields without initializers have a
corresponding implicit setter. Previously, front-end was setting
Field.hasImplicitSetter to false for late final fields.
As a result, ClassHierarchy.getDispatchTarget was not returning such
field as a dispatch target for a setter invocation and TFA was inferring
incorrect types for late final fields (as if all setters for late
final fields disappeared).
Change-Id: I8f55f7ec8afa38e8cc3f54f85bd66c0381ae6318
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137701
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
2020-02-28 07:59:44 +00:00
Robert Nystrom
4b7ba5a72f
Add a script to generate a package_config.json for the SDK.
...
Also include the generated output.
Change-Id: Ic2818f544972c737f69913122e366ea48375e950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135795
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-27 17:52:23 +00:00
Johnni Winther
51bc38f26c
[cfe] Fix uri in nnbd error
...
+ add support for configurations in messages tests
Closes #40789
Change-Id: I00b241df0e090a4736974e12598085d902ae9c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137560
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-27 11:38:07 +00:00
Jens Johansen
991b522353
[CFE] Remove space from test filename
...
Change-Id: I0314708d14c24282c10b5ca545a30569f9a29025
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137540
Reviewed-by: Jens Johansen <jensj@google.com >
2020-02-27 10:15:33 +00:00
Devon Carew
9eeecae3e4
address a few static analysis nits
...
Change-Id: I461c71550e320ed9f520169bcdbd4083f58b3db3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137323
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-26 20:04:51 +00:00
Konstantin Shcheglov
5940821f4e
Issue 37487. Add CompilationUnit.languageVersion override.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/136802
Reverted: https://dart-review.googlesource.com/c/sdk/+/136851
Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: Ida3bf049840e7bda32ecdd54309ea0b141aa6800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137201
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-26 18:08:07 +00:00