dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6018 Commits

Author SHA1 Message Date
Joshua Litt 05ca544f15 [dart2js] Move tests/compiler/dart2js_extra to tests/dart2js_2. 
Change-Id: Iaa0ca2b4f2d1b15f79ddca37834d3ed2497bc068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149242
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-06-03 15:15:30 +00:00
Jens Johansen 1b5197e55f [parser] Update parser tests for using keywords as methods/fields/typedefs 
The previous tests only tested out reserved keywords (here updated to all
keywords) and forgot about typedefs altogether (added here).

Change-Id: Ibb98ef5e3342077343484640c9ebf6bc239164dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149597
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-06-03 10:12:29 +00:00
Johnni Winther 01c09391f3 [cfe] Add regress test for issue39666 
This underlying issue has been fixed.

Closes #39666

Change-Id: Ic407107fd99b1fe9f72651c16e3631a769709b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149593
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-03 08:21:59 +00:00
Johnni Winther 23d70f6f23 Reland: [cfe] Embed and use allowed experiments in CFE 
This CL embeds the sdk_nnbd/lib/_internal/allowed_experiments.json
into the CFE and uses this to allow experiments enabled on a
per library basis. The file is embedded through generated code to
avoid reliance on access to the file itself.

A presubmit check is also added to ensure that the json file and
the generated code are in sync.

This work is in preparation for https://github.com/dart-lang/sdk/issues/41538

This was reverted in https://dart-review.googlesource.com/c/sdk/+/149620
because flutter wasn't prepared for auto-enabling nnbd in dart:* libraries.
This has now been fixed in https://github.com/flutter/engine/pull/18714

Closes #42162

Change-Id: I686ed6feaef8ee066b426068fe2a0f5080bf1713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149588
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-03 08:15:49 +00:00
Johnni Winther aec6a3529e Revert "[cfe] Embed and use allowed experiments in CFE" 
This reverts commit a936f3019e as it broke
flutter hhh fuchsia build: https://ci.chromium.org/p/dart/builders/ci.sandbox/flutter-engine-linux/10876

Change-Id: I0a83e5edf8d53fc648a4f548529e456a5e6bcfc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149620
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-02 08:48:51 +00:00
Johnni Winther 665c58aa1a [cfe] Disallow void in await expression 
Closes #41602

Change-Id: I29b8880e3fdb769b2acdf2c82a9ced038d7b0d94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149287
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-02 08:20:31 +00:00
Johnni Winther f90391a12d [cfe] Add regression test for issue 41435 
The failure seems to have been fixed elsewhere.

Closes #41435

Change-Id: Iab3c0b3ff8dda2d498c854f35d5fea01f46ca899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149284
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-06-02 08:20:31 +00:00
Alexander Markov dd6dc29c21 [vm/nnbd] Prepare to migrate runtime/tests/vm/dart to NNBD 
This change mechanically copies

  runtime/tests/vm/dart -> runtime/tests/vm/dart_2

in preparation for the migration of runtime/tests/vm/dart to NNBD.

Corresponding statuses in vm.status are duplicated.

Added vm_nnbd builder tag for NNBD bots.
vm/dart/* tests are allowed to run only on vm_nnbd builders.
vm/dart_2/* tests are allowed to run only on non-vm_nnbd builders.

Issue: https://github.com/dart-lang/sdk/issues/41314

Change-Id: I079da92da17960605f37c1c0e28e48362b236739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149485
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-06-01 17:57:27 +00:00
Johnni Winther a936f3019e [cfe] Embed and use allowed experiments in CFE 
This CL embeds the sdk_nnbd/lib/_internal/allowed_experiments.json
into the CFE and uses this to allow experiments enabled on a
per library basis. The file is embedded through generated code to
avoid reliance on access to the file itself.

A presubmit check is also added to ensure that the json file and
the generated code are in sync.

This work is in preparation for https://github.com/dart-lang/sdk/issues/41538


Change-Id: Ic03c0fc69684d124c685f2fe6e80423a7e751530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149064
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-30 09:47:02 +00:00
Johnni Winther 3a021a6545 [cfe] Remove EvaluationMode.legacy 
This is no longer valid. Since the SDK is agnostic we should default to weak mode.

Change-Id: Ia9fbf911e7ebb595c93a71afe3bb8de7495cebba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149065
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-30 09:47:02 +00:00
Aske Simon Christensen 1ad89b85a2 [gardening] Read nnbdMode parameter instead of field on null options. 
Fixes crash introduced by https://github.com/dart-lang/sdk/commit/72e559929f7c6db5f38a9b2ad52df67aec624dfc.

Change-Id: Ie9e3cdbcd282a840dcd028661fa93e49d207d38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149421
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-29 09:12:09 +00:00
Nicholas Shahan 72e559929f [ddc] Add --sound-null-safety flag and pass to CFE 
https://dart-review.googlesource.com/c/sdk/+/149080 is required to
get errors if you try use weak .dill files when passing the
--sound-null-safety flag.

Added a new build target to copy the sound SDK outline .dill to
dart-sdk/lib/_internal. This is only part of dartdevc_test right
now. We will decide in the future if we are going to include this
in the released SDK or if we will have the build systems create
them as needed. For now in testing scenarios it appears to be part
of the SDK.

Change-Id: I3b31a894841f59b437658104e7ee9443ee67db93
Fixes: https://github.com/dart-lang/sdk/issues/41694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146962
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-29 01:16:18 +00:00
Joshua Litt 20faaa5d94 [dart2js] Move dart2js unit tests to pkg/compiler/test. 
Change-Id: Ib18f554c1076f27a3f7c0df5a36410da41a1f467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148784
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-05-28 18:51:11 +00:00
Nicholas Shahan 2cc4d7ca2f [cfe] Set and check null safety mode in .dill 
Validates that the .dill files provided for dependencies and the SDK
support sound null safety when compiling for strong mode.

Change-Id: Id1f7547a6bc473b901bfce62145cc918353c8ea4
Issue: https://github.com/dart-lang/sdk/issues/41694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149080
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-05-27 16:27:50 +00:00
Mayank Patke d1546cac87 [dart2js] Make diagnostic message arguments strongly typed. 
We were passing arguments as just a `Map` and forcing the Message to
handle the String conversion, but the caller is much better equipped to
do it and prevents the dynamic typing.

Change-Id: Icc4ab91edf233b81a64aa3b03462b541349fa751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149048
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-05-27 05:28:03 +00:00
Mayank Patke 46dc9fb9a7 [dart2js] Set NNBD mode based on entry point. 
Tested with https://github.com/dart-lang/null_safety_sample_package/.

Change-Id: Icecbee11da44eb9eb9cb3eb36f905f4a7126996b
Bug: https://github.com/dart-lang/sdk/issues/41208
Fixes: https://github.com/dart-lang/sdk/issues/41208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148580
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-05-26 22:08:52 +00:00
Johnni Winther 0e6c8683e3 [cfe] Set #isSet field after late field in lowering 
Closes #41922

Change-Id: I403ca031898c72f3edc0ca9c7434466c3510c53d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148800
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-26 10:48:25 +00:00
Dmitry Stefantsov 142d09fed7 [cfe] Provide better context in verifier's diagnostics 
Change-Id: I599eb100acab431fc5630305951120dfe98e79b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148763
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-26 10:02:05 +00:00
Jens Johansen 4dcf24ac7f [CFE] Use BlockExpression for encoding cascades 
Change-Id: I9c56cbed9880716af804c80c6ca34578ae6765a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148528
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-05-26 09:07:25 +00:00
Jens Johansen 1dd99d3a39 [CFE] Feedback for tool to add comments to method calls 
I overlooked the comments in
https://dart-review.googlesource.com/c/sdk/+/147541
This CL incorporates the comments.

Change-Id: If8b8ca1c1931379b6a4de416e97a30ee3298f1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148536
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-26 08:47:00 +00:00
Jens Johansen 53ac4d53f2 [CFE] Set compilation mode if no main found 
Change-Id: I2c3121e54f6c12b7ecdd8784851ca0611ff0b9d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148401
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-20 10:29:42 +00:00
Johnni Winther 3dbb64a507 [cfe] Handle == on Never 
Change-Id: I9519c20f249ba038b29c05b65e8741f80705d664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147081
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-20 10:25:02 +00:00
Jens Johansen 17ff769f0a [CFE] Add tool to add comments to method calls 
e.g. foo(null) => foo(/* argumentName = */ null)

for readability.

Change-Id: Ic6eef4c522e30eaf6a6f71d6d6e24820adb9400e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147541
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-05-20 09:46:52 +00:00
Jens Johansen e3650e5ea5 [CFE] Reproduction of different interface target when from dill 
Change-Id: I6ee248fd5d5b18a2c9f4e854cbcce8d89f373b94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148524
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-20 08:02:04 +00:00
Dmitry Stefantsov 54fa4252a4 [cfe] Treat types containing InvalidType as invalid in assignability 
Change-Id: I591e2d7eb729bb90dd7efdbf06397c34f0e96256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148241
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-19 14:34:30 +00:00
Johnni Winther 585d664d35 [cfe] Add annotations on synthesized getters/setters 
This moves late lowered annotations from the field declaration to the
synthesized getters and setters, and adds annotations to the synthesized
setter for external fields.

Change-Id: I50e6cb9e155877a2be4d92ea2d9c9dc7796fef8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148521
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-19 11:18:30 +00:00
Johnni Winther 6708394f03 [cfe] Add predicates to detect late lowered fields. 
Needed for https://github.com/dart-lang/sdk/issues/41892

Change-Id: I049e76655cf62a5558c18319e80ab9702c7a3c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148321
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-19 08:55:20 +00:00
Johnni Winther 6336e8e2d3 [cfe] Use legacy subtyping in weak mode constant evaluation. 
+ add checks for agnostic subtyping differences

Closes #41657

Change-Id: I1e6b558edbfcb1ca282e0e4c788c6a7a7db6bfd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148126
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-19 08:55:20 +00:00
Alexander Markov cbb5305f78 [vm/nnbd] Optimize type casts 
Add a kernel transformation which removes redundant casts and reduces
some casts to null checks. This transformation assumes that type
system is sound and subtyping relation is transitive. So in NNBD weak
mode this transformation is always correct. In NNBD strong mode
this transformation is correct only if opted-out libraries are not
allowed.

The following patterns are handled:
If S <: T (this includes S <: T? in weak mode)
  S x; x as T => x
If S <: T? in strong mode
  S x; x as T => (x == null) ? x as T : x

This kernel transformation is not specific to the VM and can be reused
by other back-ends such as dart2js and DDC.

Fixes https://github.com/dart-lang/sdk/issues/40892
Issue https://github.com/dart-lang/sdk/issues/40893

Change-Id: I466ba96d763d5358011c768400c5225fa7bf5e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139314
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-05-19 02:35:12 +00:00
Johnni Winther c10b41a4e2 [kernel] Add DartType.toTypeText and Constant.toConstantText 
These are used to provide a testable textual representation
of types and constants that do not rely upon Node.toString.

Change-Id: Iff77ebb44e8299b262f4f263666b2e1d4dd5794b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147909
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-18 11:48:20 +00:00
Alexander Markov 2d57c1f86e [vm/aot/tfa] Handle @pragma('vm:entry-point') on redirecting factory constructors in TFA 
Issue: https://github.com/flutter/flutter/issues/57213
Change-Id: Iad12f77b8c17a40a865e19d5fbd4a8915be6a184
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148203
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-05-15 16:42:12 +00:00
Jacob MacDonald 667e6f96ae add --verbose support to Kernel worker 
Change-Id: Ibe4b21980c30b57629bf59520563c5952636127e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148145
Commit-Queue: Jake Macdonald <jakemac@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-15 15:18:52 +00:00
Jens Johansen aa1e71e5f9 [CFE] Clear _delayedMemberChecks in class hierarchy builder 
This could lead to some memory leak if the experimental invalidation was
enabled.

Change-Id: Idaf4fb5967e89a38eb78baf38ab34aac7c364c3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148131
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-05-15 10:40:55 +00:00
Dmitry Stefantsov e53e5f2475 [cfe] Separate nullability and declared nullability 
For some types it makes sense to distinguish between nullability as a
property of including null and the declared nullability, such as for
type-parameter types and FutureOr types.  This CL introduces the
separation between the two concepts.  The plan is to use that when
implementing FutureOrType.

Bug: https://github.com/dart-lang/sdk/issues/40123
Change-Id: I90b45bea768e89c213d021d360a481d38377c682
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147903
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-15 07:38:05 +00:00
Johnni Winther 383a8ea857 [cfe] Initial support for external fields. 
Change-Id: Iccee87f40df395c928dc1a9dc81ddad8813a5000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147906
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-14 18:34:06 +00:00
Johnni Winther 1661e0e03d [cfe] Handle covariant late fields in lowering 
Change-Id: I2bbac50e7b544e5180e74ded8e657a09bf6430da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147901
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-14 18:34:06 +00:00
Johnni Winther 46963a3422 [cfe] Change implicit catch type to Object 
Closes #41520

Change-Id: Iff07ac2b7187b042e2c702462c0c3269208f27ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148062
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-14 18:26:01 +00:00
Johnni Winther 00353040b9 [CFE] Error when strong mode mixed with non-opted-in 
Change-Id: Ibff34fe071a6d10ce29c30e1d008d4a5ce6690a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140868
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-14 17:10:51 +00:00
Paul Berry 3ca37fb66e Re-apply some recent parser fixes. 
My recent revert (275b922ee8) mistakenly
reverted too much (I incorrectly attributed the angular failure to
1f9b5c1996 when it was actually due to
96df1f9e6c).  Reapply the commits that
are ok.

This re-applies commit 1f9b5c1996.
This re-applies commit c40b24da48.

Change-Id: I4d64b1511b92d87197a5e939903a31e01f0b2e70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-13 16:00:01 +00:00
Paul Berry 275b922ee8 Revert recent parser fixes 
Commit 1f9b5c1996 causes tests to fail
in angular when rolled into internal sources; the other two commits
need to be reverted as well to avoid merge conflicts.

This reverts commit 1f9b5c1996.
This reverts commit c40b24da48.
This reverts commit 96df1f9e6c.

Change-Id: Ic4e55181ef60e825ce4409a9a9528ecbf19c39c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-12 22:02:09 +00:00
Dmitry Stefantsov 3b93b85aef [cfe] Update inference for redirecting factory constructors 
Closes #34714.

Bug: https://github.com/dart-lang/sdk/issues/34714
Change-Id: Ia1f6845d2ae623ecba01fd5e60dcaed975471f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147181
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-12 14:03:49 +00:00
Johnni Winther d5650235a2 [cfe] Handle ProblemBuilder in binary expression 
Closes #41787

Change-Id: I81fcf0aee975b58b3b44d0de94054ae87bdd265d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147140
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-12 11:44:19 +00:00
Jens Johansen 96df1f9e6c [parser] Add ErrorToken for ignored (unmatched) end parenthesis, brackets etc 
Change-Id: Idb57295700988d71321743af9782134b02562311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146240
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-11 14:46:47 +00:00
Jens Johansen 64714f2596 [CFE] Include _fe_analyzer_shared in tests 
Change-Id: I6d2ab3465a0aa2488cbe7b9a2f1909ab6c615d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147082
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-11 13:13:21 +00:00
Johnni Winther f4f0ba4b36 [cfe] Update id-tests post unfork 
These were for some reason not updated by the update_all script on the
first run.

Change-Id: I49dc1f5524c120947a971356548755325c63e8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147360
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-08 17:25:41 +00:00
asiva ce5d18b0f0 [CFE] - Update exectations of CFE unit tests to account for NNBD unfork 
These updated expectations were generated by running the script
pkg/front_end/tool/update_all.dart

Change-Id: I6b8f7c5e50160da96e90c44fa888bd9b072efd06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147321
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2020-05-07 23:16:21 +00:00
Dmitry Stefantsov 7cbd5f6f78 [cfe] Add round-trip serialization support for loop nodes 
The following nodes are supported now:
* ForStatement
* ForInStatement
* WhileStatement
* DoStatement

Change-Id: I42d43b949da80a631887996fac4b6a6f4c2a8c79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147100
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-07 17:21:38 +00:00
Jens Johansen c40b24da48 [parser] Show errors from 'handleErrorToken' in parser suite tests 
Change-Id: I3528136b6c220f0fe72d9d7b2aa591737c4c7096
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146225
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-07 11:23:48 +00:00
Dmitry Stefantsov e86e4d6183 [cfe] Add round-trip serialization support for more statement nodes 
The support is added for the follwing statements:
* YieldStatement
* Block
* VariableDeclaration (as a statement)
* IfStatement
* EmptyStatement

+ improve diagnostics in related unit tests

Change-Id: Ib738227c6e8c1963aeaee52630953e07cef4b093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146800
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-07 10:07:37 +00:00
Jens Johansen 1f9b5c1996 [parser] Recovery of unbalanced parenthesis, brackets etc. 
Bug: https://github.com/dart-lang/sdk/issues/41000

Change-Id: I8d1d8ff5d3f832f9b6b5e5880b59a485a7ff9b96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146224
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-07 10:04:08 +00:00