Commit Graph

6018 Commits

Author SHA1 Message Date
Peter von der Ahé 695ebae97a Complain about bad operator parameters.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2782843002 .
2017-03-29 13:12:41 +02:00
Peter von der Ahé a62c5631bf Use message.yaml in parser.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2778213002 .
2017-03-29 11:02:23 +02:00
Peter von der Ahé 2aa0e1976d Improve semantics of parts.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2781623003 .
2017-03-29 10:48:52 +02:00
Peter von der Ahé a49bc60120 Handle complicated imports.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2780543002 .
2017-03-29 10:44:22 +02:00
Peter von der Ahé 2de7a24238 Handle complicated exports.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2776153002 .
2017-03-29 10:42:35 +02:00
Peter von der Ahé a6ba01e8aa Throw AbstractClassInstantiationError on abstract classes.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2781493002 .
2017-03-29 10:38:15 +02:00
Peter von der Ahé a91ebba200 Complain about assignments to parenthesized expressions.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2780483002 .
2017-03-29 10:28:05 +02:00
Peter von der Ahé e1a25e35ca Rename BuilderAccessor to FastaAccessor.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2777893002 .
2017-03-29 10:24:29 +02:00
Peter von der Ahé 0b4706ce30 Make catch variables final.
Fixes https://github.com/dart-lang/sdk/issues/28410.

R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2775163003 .
2017-03-29 10:20:07 +02:00
Peter von der Ahé f979dad474 Complain about uninitialized const fields.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2774933002 .
2017-03-29 10:12:41 +02:00
Asger Feldthaus f396d919ae Remove some additional code that depended on the old type propagation.
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2781473004 .
2017-03-28 13:51:21 +02:00
James Robinson 2b70abd2e3 Fix computation of relative paths in depsfile when cross-compiling
Relative paths in a depsfile are interpreted by ninja relative to the
current working directory which in a GN build is the root of the build
directory ($root_build_dir in GN terms). When doing a
cross-compilation, this is different from the root of the output
directory ($root_out_dir in GN terms) for all builds other than the
target. This fixes the computation of depsfile entries so that they are
always relative to the current working directory.

Concretely, this means incremental builds in Fuchsia do not always
rerun the patch_sdk step for the host, shaving 12+ seconds off of no-op
builds.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2776323002 .
2017-03-27 20:28:04 -07:00
Peter von der Ahé 02573b3caa Remove Fasta's copy of accessors.dart.
R=asgerf@google.com, jensj@google.com

Review-Url: https://codereview.chromium.org/2777883002 .
2017-03-27 14:04:43 +02:00
Dan Rubel 0fa52686f3 fix missing digit error translation
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2772513006 .
2017-03-25 22:33:59 -04:00
Dan Rubel 05300ea2df change "deferred" keyword isPseudo --> isBuiltIn
Fix https://github.com/dart-lang/sdk/issues/29069

R=ahe@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2769253002 .
2017-03-25 21:20:11 -04:00
Konstantin Shcheglov 713847a71b Parse LabeledStatement and SwitchStatement with Fasta.
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2776743002 .
2017-03-24 11:49:47 -07:00
Dan Rubel 186c6f23bd fasta scanner recovery and error code translation improvements
* cleanup defaultRecoveryStrategy next/previous and eof

* add SymbolToken.eof() constructor to ensure that EOF tokens
  are correctly self referencing

* add fasta.scanString method to match scan method

* add fasta.ScannerResult.hasErrors field
  so that scan and scanString callers can quickly check for errors

* new scanner replacement test
  which scans using fasta then asserts as if it were from analyzer

* improve SymbolToken.toString() for EOF
* update analyzer test :: fasta scanner considers "<" to be an opener
* extract and move translateErrorToken into front_end
* address comments in https://codereview.chromium.org/2763833002

R=ahe@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2767083002 .
2017-03-24 11:40:22 -04:00
Paul Berry 415c868589 Introduce a shadow hierarchy and factory class for use by fasta's BodyBuilder.
In the long run, this shadow hierarchy is intended to be used both for
kernel and analyzer ASTS; this should allow a single BodyBuilder class
to build either a kernel or an analyzer AST depending on which factory
it's connected to.

For now we only have a kernel shadow hierarchy, and it's incomplete,
so the code is not yet used.  I intend to follow up with CLs that
complete the implementation and hook it up to BodyBuilder.

R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2769723004 .
2017-03-24 08:25:59 -07:00
Peter von der Ahé ec5d7cba1a Implement character offsets for fields and enum constants.
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2771983004 .
2017-03-24 15:29:42 +01:00
Peter von der Ahé 0c17ebba9f Report errors on non-final fields in const classes.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2775633004 .
2017-03-24 15:10:31 +01:00
Peter von der Ahé 91e290b610 Allow identical as a compile-time constant.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2770243002 .
2017-03-24 14:42:59 +01:00
Peter von der Ahé 62b39e746a Report compile-time error on invalid constructors.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2777533002 .
2017-03-24 14:11:32 +01:00
Konstantin Shcheglov 9b6c63a39d Parse YieldStatement with Fasta.
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2769133004 .
2017-03-23 17:32:26 -07:00
Karl Klose cf2ef53b28 Share operator names
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2756443004 .
2017-03-23 18:23:30 +01:00
Peter von der Ahé d41b344896 Allow literal symbols as constant expressions.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2769063003 .
2017-03-23 17:42:48 +01:00
Peter von der Ahé 89bcf728f9 Clean up use of identifier context.
R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2769813007 .
2017-03-23 16:08:32 +01:00
Peter von der Ahé ee591a87d2 Fix warnings in dart2js and analyzer caused by Fasta.
Review-Url: https://codereview.chromium.org/2766323005 .
2017-03-23 15:39:03 +01:00
Peter von der Ahé 2eca8c58c3 Various errors on constant expressions.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2765283002 .
2017-03-23 13:40:25 +01:00
Peter von der Ahé 9d439605a8 Run dartfmt on generated file.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2769663002 .
2017-03-23 13:09:16 +01:00
Peter von der Ahé 0afdf6b44a Report error on only-try block.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2765253002 .
2017-03-23 13:02:41 +01:00
Peter von der Ahé 347bfbc4b8 Add kernel-service subcommand to fasta script.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2770623003 .
2017-03-23 12:56:47 +01:00
Peter von der Ahé f12acc02a3 Move throwNoSuchMethodError to BodyBuilder.
R=karlklose@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2764303002 .
2017-03-23 12:49:42 +01:00
Peter von der Ahé 0087af4e3c Report compile-time errors on cyclic hierarchies.
R=karlklose@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2767633004 .
2017-03-23 12:41:04 +01:00
Peter von der Ahé bfb82582f5 Only display 'nits' in verbose mode.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2770683005 .
2017-03-23 12:34:32 +01:00
Peter von der Ahé 7e8639eebf Setup type and modifiers of local variables on creation.
R=karlklose@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2769113004 .
2017-03-23 12:19:36 +01:00
Konstantin Shcheglov 77c29fb006 Parse SuperConstructorInvocation with Fasta.
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2771583002 .
2017-03-22 13:21:24 -07:00
Karl Klose 4d3719f54e Change code to determine ANSI support on Windows
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2765223002 .
2017-03-22 13:20:46 +01:00
Peter von der Ahé 2562ed28cb Generate methods for reporting problems.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2754383002 .
2017-03-22 12:30:51 +01:00
Peter von der Ahé 002d5c7150 Update messages.yaml with asynchronous messages.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2754793004 .
2017-03-22 12:27:38 +01:00
Peter von der Ahé a6e0ecb30a Diagnostic messages.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2756923002 .
2017-03-22 12:23:14 +01:00
Peter von der Ahé 17621ed6ff Tweak message.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2754343002 .
2017-03-22 12:22:11 +01:00
Peter von der Ahé ccf7597fb5 Rename analyzer options file.
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2756243002 .
2017-03-22 12:19:26 +01:00
Peter von der Ahé 3de706a0ec Update parser documentation.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2756953002 .
2017-03-22 12:17:41 +01:00
Peter von der Ahé 84f1547975 Add constantExpressionRequired to BodyBuilder.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2769613002 .
2017-03-22 12:14:24 +01:00
Peter von der Ahé 819b226598 Add begin events for const and new expressions.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2767543003 .
2017-03-22 12:06:23 +01:00
Peter von der Ahé e37d55d111 Switch to IdentifierContext.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2762283002 .
2017-03-22 11:50:07 +01:00
Peter von der Ahé 6f422b93fc Improve handling of complicated getters and setters.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2765943002 .
2017-03-22 10:49:03 +01:00
Peter von der Ahé d50bfcde53 Implement dynamic and void as types exported by core library.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2761173004 .
2017-03-22 10:25:08 +01:00
Peter von der Ahé c9d9b4d295 Implement fullNameForErrors on all Builders.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2767653002 .
2017-03-22 09:52:52 +01:00
Peter von der Ahé 983a47293c Fix IdentifierContext for primary expressions. Also pass IdentifierContext to handleThisExpression and handleSuperExpression.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2768523002 .
2017-03-22 09:39:29 +01:00