Commit Graph

30 Commits

Author SHA1 Message Date
Jens Johansen 1c3468a646 [kernel] Remove Library.isExternal
Change-Id: I6638b915c1189838e7081069a0075e4ecd9ee9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125600
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-12-02 09:24:42 +00:00
Dan Rubel 4a27605fdc generate kernel experimental flags
Change-Id: I9430d95c012b752bc4ca0530d79252b8b032a26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104841
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
2019-06-06 14:03:29 +00:00
asiva 98dddc9daa [tests] Ensure that --enable-asserts is used whereever checked was used previously
Change-Id: Ia88c03a8dd36237f3c819a3a892f8f17ecf7f00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97604
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2019-03-22 19:51:41 +00:00
asiva 1bab46b06f [vm] Remove support for '-c', '--checked' flags and '--enable-checked-mode'
1. Remove support for the following flags '-c', '--checked' and '--enable-checked-mode'
2. Cleanup some of the tests and test scripts where these options were being passed.

https://github.com/dart-lang/sdk/issues/34660

Change-Id: I4d8aa0d14bd054cfba08d78a411a0df4fc829df1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97550
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2019-03-22 17:08:56 +00:00
Peter von der Ahé f200c37553 Enable extra VM options in fasta script
Change-Id: Ib7f68bee7155dcf4ad49d6b17bea6eb071f31f8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96646
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2019-03-13 06:46:21 +00:00
Peter von der Ahé fe39691269 Don't use --no-preview-dart-2
Fixes https://github.com/dart-lang/sdk/issues/34548

Change-Id: Ia6b4a3cdc4b6c39e0aa0fb649940b2bd126a619e
Reviewed-on: https://dart-review.googlesource.com/76120
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2018-09-24 09:20:01 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-06-18 22:31:32 +00:00
Siva Chandra 6ff0951bdf Remove the use of redundant flags --dfe and --kernel-binaries.
This change helps in confining flag manipulation to just the embedder.
When we are ready to turn all dart 2 flags to true by default, the
change can be confined to just the VM.

Change-Id: I4ac550c331b1f236a2bd9d0453b7c567eb0c05d3
Reviewed-on: https://dart-review.googlesource.com/38881
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-08 20:56:22 +00:00
Peter von der Ahé e7ac35dfc9 Make the fasta tool use Platform.resolvedExecutable when tested.
Change-Id: Ie83cd4692898c1b6e585ed5d47fc55be4d60c272
Reviewed-on: https://dart-review.googlesource.com/35162
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2018-01-17 10:26:08 +00:00
Alexander Markov 58ffdbf5fc [VM] Move kernel service to pkg/vm, populate pkg/vm with necessary files
* kernel-service.dart is moved to pkg/vm/bin and renamed to
  kernel_service.dart

* LICENSE, pubspec.yaml and analysis_options.yaml added to pkg/vm.

* Kernel isolate name is corrected to be independent of URI passed
  in --dfe VM option.

Change-Id: I5b7b860297314e240e557af80913e7ac3e6324ad
Reviewed-on: https://dart-review.googlesource.com/21260
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-17 17:45:03 +00:00
Peter von der Ahé 16aa720d27 Remove compiling platform.dill from patch_sdk.dart
This separates compiling platform.dill files from the patch_sdk.dart
script. The motivation for that is that I'm working on reading patch
files directly from Fasta, so we can completely remove the build step
for generating patched_sdk and dart2js_patched_sdk.

Short-term this should allow Paul to add a strong-mode version of
platform.dill without causing to many conflicts with my work on
patches.

Change-Id: I1150845b2986348d4fffe27092701d8a9b57ea54
Reviewed-on: https://dart-review.googlesource.com/11506
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-06 15:34:37 +00:00
Paul Berry a8afd3ab16 Remove reified_dart.dart, batch_consistency.dart, and dartk.dart.
These files all have to do with the old "dartk" front end, which is no
longer used.

Change-Id: I67041bf0a3a8a9213153123d9f79ac1632cc4d24
Reviewed-on: https://dart-review.googlesource.com/7101
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-09-20 15:33:16 +00:00
Peter von der Ahé a5bcf58b06 Move tools to tool folder.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3003743002 .
2017-08-29 14:30:51 +02:00
Sigmund Cherem 92481e9b34 Add dump-partial tool.
This script lets you dump as text a partial .dill file generated by the
incremental generator. To do so, it requires that you pass in other .dill files
that are needed (in order).

In the context of a hot-reload test, you should be able to run this as follows:

pkg/front_end/tool/fasta dump-ir newProgram.dill fullProgram.dill platform.dill

BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2985113002 .
2017-07-26 15:19:42 -07:00
Peter von der Ahé f1b7a97744 Move testing.json and status files to more natural locations.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2957623002 .
2017-06-23 14:27:53 +02:00
Siva Chandra 7087085505 Fix frontend tests after bac83e0973
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2943173002 .
2017-06-16 14:05:08 -07:00
Peter von der Ahé 9eb265439f Ensure DART_CONFIGURATION is exported and don't run code in checked mode.
R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2903593002 .
2017-05-24 11:20:45 +02:00
Peter von der Ahé e6a7a38022 Support being called as absolute path.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2896033002 .
2017-05-24 11:07:53 +02:00
Peter von der Ahé de7edcde74 Fix crash with generalized function types in type tests.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2899693003 .
2017-05-22 14:53:46 +02:00
Peter von der Ahé 347bfbc4b8 Add kernel-service subcommand to fasta script.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2770623003 .
2017-03-23 12:56:47 +01:00
Peter von der Ahé 2562ed28cb Generate methods for reporting problems.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2754383002 .
2017-03-22 12:30:51 +01:00
Peter von der Ahé 0526f5b150 Add testing subcommand to fasta tool.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2757303002 .
2017-03-20 17:55:00 +01:00
Peter von der Ahé 9514a2c231 Shell script to ease running fasta tools.
Fixes https://github.com/dart-lang/sdk/issues/29000

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2740323002 .
2017-03-10 17:19:08 +01:00
Peter von der Ahé d1bdc9596d Improve detection of compile-time errors.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2739213004 .
2017-03-10 14:14:49 +01:00
danrubel 516646735d cleanup and improve A/B fasta test harness
* Update harness to show 99.9% best and worst case

* Moved compile summary functionality
  from pkg/front_end/tool/fasta/compile.dart
  into pkg/front_end/lib/src/fasta/outline.dart

* Modified outline.dart to output a JSON summary
  containing elapse execution times if -Dsummary=true

* Moved all statistical calculations into abcompile.dart

* Adjusted pkg/front_end/tool/fasta/abcompile.dart so that
  --verbose is not needed to capture numbers and progress

* Updated the A/B summary section to paste more easily
  into Google Sheets

* Address comments in
  https://codereview.chromium.org/2734863003/

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2739963002 .
2017-03-09 14:07:43 -05:00
danrubel dd3ab83eee add previous token field
This adds fasta Token.previous and sets that field to point
to the previous token in the fasta token stream.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2739583002 .
2017-03-07 13:03:52 -05:00
danrubel c354e26fb6 A/B fasta performance measurement harness
Tweak and reapply https://codereview.chromium.org/2731703003/

Review-Url: https://codereview.chromium.org/2734863003 .
2017-03-06 14:30:47 -05:00
danrubel 8552edb9b3 Revert "A/B fasta performance measurement harness"
This reverts commit 82685eacbf.

Review-Url: https://codereview.chromium.org/2733033002 .
2017-03-06 10:59:51 -05:00
danrubel 82685eacbf A/B fasta performance measurement harness
Given two separate Dart SDK repo clones, A and B,
this pkg/front_end/tool/fasta/abcompile.dart harness
alternately runs

<A>/pkg/front_end/tool/fasta/compile.dart
then
<B>/pkg/front_end/tool/fasta/compile.dart

so that a performance comparison can be made of the difference
between fasta in A vs B.
For example, from the <A> root directory:

xcodebuild/ReleaseX64/dart
  -DbRoot=/path/to/2nd/dart/sdk/repo
  -Diterations=15
  pkg/front_end/tool/fasta/abcompile.dart
  --compile-sdk=xcodebuild/ReleaseX64/patched_sdk/
  pkg/compiler/lib/src/dart2js.dart
  --verbose

The output contains the raw data along with a summary
of the average difference, and is formatted in a way
that can be easily pasted into Google Sheets
for further analysis.

Future improvements to this include:

* Add JSON output to pkg/front_end/tool/fasta/compile.dart
  so that abcompile.dart is not text scraping the numbers

* Adjust pkg/front_end/tool/fasta/compile.dart so that --verbose
  is not needed to capture the needed numbers and progress

* tweak the A/B summary section to paste more easily
  into Google Sheets

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2731703003 .
2017-03-06 10:09:45 -05:00
Peter von der Ahé 88a92f805a Move all main methods to tool/.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722223006 .
2017-03-02 14:41:06 +01:00