dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1972 Commits

Author SHA1 Message Date
Johnni Winther 462a448ac8 [cfe] Integrate definite assignment, nullability and type promotion analysis 
Currently not handled: null-aware and break/continue

Change-Id: I61b3ef92c974a2e98a010e091ba81cbefa0f6069
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124127
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-06 12:28:52 +00:00
Johnni Winther d635bdd49c [cfe] Move variance tests to general/ 
Change-Id: I1d2c48cf96f18a63563a01fe418e3e331061299f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124129
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-11-05 15:02:31 +00:00
Johnni Winther 523e9ffa88 [cfe] Add EqualsExpression, BinaryExpression, UnaryExpression and ParenthesizedExpression 
Change-Id: Ida185b192c329f21979f6d5fbf39aa17ef1b9c0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123409
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-11-02 12:33:44 +00:00
Régis Crelier df678dbec0 [VM/nnbd] Introduce type Never in VM and bytecode. 
Introduce enum NNBDMode for subtype test checking mode.

Change-Id: Id9c39ee8c975c664ac58e313b7dd05e6e219dfc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123557
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-11-01 00:43:59 +00:00
Dmitry Stefantsov 2897bebdef [cfe] Resolve serialization mismatch due to variance computation 
Change-Id: Id38c63f5bd659f21423d802fd6180aa04465712c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123406
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-31 10:15:29 +00:00
Johnni Winther 3ccdb01fc9 [cfe] Handle extensions exported through multiple libraries 
Closes #39160

Change-Id: I605b1a95ddab822848b33244b3130ebf16b69842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123523
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-30 11:59:44 +00:00
Johnni Winther ee9ec9c3e0 [cfe] Report error on builtin identifier as extension name 
Closes #38094

Change-Id: I029f8f30ee0c15ec9f1adf7419f83c4e76ca3ae1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123521
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-30 10:02:55 +00:00
Jens Johansen ea3cb7317a [CFE] Fix unescapeString crash 
unescapeString would for instance crash if it got the string '"'
(without the quotes) (i.e. the single ascii character 0x22).

Fixes #39035

Change-Id: I0b6baba975b3e8a9279699027fde4b15cde4a5ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123249
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-29 09:38:46 +00:00
Johnni Winther eb04e0922b [cfe] Refactor CompoundPropertySet and add CompoundExtensionSet 
Change-Id: Id6dda215cae88dc35943f34be4f210d148eace00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122642
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-28 14:08:42 +00:00
Johnni Winther bb02531b7e [cfe] Move creation of error nodes to inferrer 
During top-level inference we cannot emit errors. With this change
the inferrer controls whether to create and report an error or to create
a revisitable node.

Change-Id: Ia7821c6d2628fdae0897f3cd6108ef12d2f096df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122782
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-28 14:08:42 +00:00
Jens Johansen a14bf89eb9 [CFE] Move old dill files to CIPD 
Remove from git, add to CIPD, DEPS and gclient sync.

Change-Id: Ib215f51a53108c56c2b129de3fdb156814a31a88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123245
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-28 14:07:18 +00:00
Dmitry Stefantsov 9910fa8454 [cfe] Implement the first part of NNBD-aware isSubtypeOf 
This CL is a squashing of the following smaller CLs:

* https://dart-review.googlesource.com/c/sdk/+/120669/
* https://dart-review.googlesource.com/c/sdk/+/120670/
* https://dart-review.googlesource.com/c/sdk/+/121331/
* https://dart-review.googlesource.com/c/sdk/+/121381/
* https://dart-review.googlesource.com/c/sdk/+/121383/
* https://dart-review.googlesource.com/c/sdk/+/121620/
* https://dart-review.googlesource.com/c/sdk/+/121707/
* https://dart-review.googlesource.com/c/sdk/+/122144/
* https://dart-review.googlesource.com/c/sdk/+/122360/
* https://dart-review.googlesource.com/c/sdk/+/122381/
* https://dart-review.googlesource.com/c/sdk/+/122783/
* https://dart-review.googlesource.com/c/sdk/+/122787/

Change-Id: I9d850f531f0fce07055ff9b5cd39abb605752005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122868
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-25 16:37:39 +00:00
Jens Johansen 2d0cdbdd12 [CFE/Incremental compiler] Don't crash on parts with invalid scheme 
Before this CL a part like "part ' package:foo/bar.dart';" would crash
the incremental compiler because the part specifies a scheme that is
invalid.

Change-Id: I567df0a68ff8709e4ca95d24e6dabc4d959c95fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122862
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-25 09:27:24 +00:00
Jens Johansen 87fa4e49d7 [CFE] Fix of an UTF8 BOM in input file possibly causing a crash 
Fixes: #39091
Change-Id: I963d22a49efebbed16b9645d2249c0887c35d780
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122789
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-25 07:07:54 +00:00
Johnni Winther 1bc9fba660 [cfe] Allow this access in late field initializers 
Change-Id: Ia2139e3e87a4b141b5e0df41541bab5f74acd5dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122760
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-24 18:11:17 +00:00
Johnni Winther 18d43babd1 [cfe] Avoid crash for missing object access targets in toplevel inference 
We cannot emit errors during toplevel inference.

Change-Id: I2add33892ddf20c27ff53038a3be2b02c34029e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122761
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-24 10:51:49 +00:00
Johnni Winther 2727fd9b3c [cfe] Add helper for creating property set 
The use of the helper removed the creation some unneeded temporary
variables in extension access which is reflected in the expectation
changes.

Change-Id: Ice6afcb223b7740c2555a076c3ddae9a9d4f092d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122394
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-23 12:23:53 +00:00
Johnni Winther 857502b1d2 [cfe] Add helpers for creating index set/get operations 
Change-Id: I0125d31ed5fb43baeb76b3346a4251703c5f8b4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122383
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-23 12:23:53 +00:00
Jens Johansen 18fa7485ad [kernel] Read ContinueSwitchStatements in nested FunctionNodes correctly 
Closes #39040

Change-Id: I8ae9a89cfd750dddbf0a994e93d9b2aa2d46490c
Fixed: 39040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122386
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-23 08:34:27 +00:00
Kallen Tu 4601bd7bff Modified supertype check error message to be more descriptive. 
Change-Id: I3068bf195eb9a746d25ac62007eaeac0296d3087
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121463
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-10-22 16:59:16 +00:00
Jens Johansen 0449905e2d [CFE] Add a serialization-and-unserialization step to strong test 
Change-Id: Icb6275e9eaec0bbdd890719d780a0218fa660fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122384
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-22 13:40:01 +00:00
Johnni Winther e76f6d49e4 [cfe] Implement null-shorting for most expressions 
Binary operations and parenthesized expression are shorted which they
shouldn't be. Also, so complex expressions, like compound assignment,
are not handled because they need to be encoded in a more high-level
internal expression to support choosing the receiver based on shorting.

Change-Id: I0bdeabdc21da7d80f533ea0880662bfb11341c6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121856
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-22 10:04:54 +00:00
Johnni Winther b1b4f6b7e4 [cfe] Allow assignment to late final fields/variables 
Change-Id: I0264904fe6f24f4021cef3d6576b54e11fe0a4d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122143
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-21 12:38:51 +00:00
Johnni Winther f1ac6959ab [cfe] Handle mixed if map entries 
Closes #38874

Change-Id: I0122ccb9bc91d349c030955332da338830a137c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121987
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-21 12:38:11 +00:00
Jens Johansen 3d67e7d6a7 [CFE] Don't try to infer fields not in the output program 
Fixes assertion error because it cannot properly infer 'this' for field
not inserted in the ast.

Fixes #38961.

Bug: 38961
Change-Id: I4230fc2d8c47eb84ad2627651f4d7ca2787e5f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122141
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 10:44:28 +00:00
Jens Johansen c1599932f9 [CFE] Fix crash when serializing: "Type parameter #lib1::B::X is not indexed" 
Fixes #38944

Bug: 38944
Change-Id: I26bdd06f86c0c0ac0089d34255bcb3ef824affcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 09:40:38 +00:00
Jens Johansen 0c47a8529c [CFE] Fix "Type 'void' not found." bug 
Fixes #38943

Bug: 38943
Change-Id: I6086f5f46a67b37a04b21d0053fc7903a83df523
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122000
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 06:36:25 +00:00
Johnni Winther c6cb89c622 [cfe] Replace child nodes in parent nodes on post-traversal 
Replace child nodes in parent nodes on post-traversal instead of using
TreeNode.replaceChild and TreeNode.replaceWith

Change-Id: I2f6f908dce0cd38f1d9a68d4183810e2e0cdca71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121622
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-17 12:56:49 +00:00
Johnni Winther 9b3c7f64d8 [cfe] Represent Cascade expressions directly 
This is needed to perform lowering during inference.

Some missing expectation files were added as part of the update.

Change-Id: Ifc834617621e8d60518e840dc61f0386fb8d3b92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121423
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-17 12:56:49 +00:00
Jens Johansen 95991df628 [CFE] Fix crash with duplicate field and constructor initialization 
Fixes #38938

Bug: 38938
Change-Id: Icee8187c2237289640cf7bfa763c8e614c5f1cb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121858
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-17 10:47:53 +00:00
Johnni Winther 9f1b0fe102 [cfe] Handle explicit extension operator calls 
Closes #38895

Change-Id: If8dd84dcd888dc1462f4598aacf0a2da141e2918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121855
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-17 09:39:14 +00:00
Johnni Winther dee702264b [cfe] Handle named arguments on extensions methods correctly 
Closes #38915

Change-Id: Ie11a2508605fb3591347bc1f4cd68de846829328
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121852
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-16 14:38:23 +00:00
Jens Johansen 504c45fe2b [CFE] Don't cleanup moved parts in uriToSource 
After 41d13f0ffe a part that was moved
from a now unreferenced library to another (used) library would still
have it's sources removed from uriToSource.
It shouldn't, and this CL fixes that.

Change-Id: I6a97572d2274198203dcdf35cbbbec7cb667697f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121844
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-16 13:31:03 +00:00
Aske Simon Christensen f3294f7083 [cfe] Ignore context when de-duplicating error messages 
Change-Id: I44b00ca5277f69fdaa05bb71a5409ea9dabac601
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121061
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-16 13:02:23 +00:00
Dmitry Stefantsov 23e8f2bcfa [cfe] Verify that Null is always nullable 
Closes #38360.

Bug: http://dartbug.com/38360
Change-Id: I073a63bc968f1955a3c23bb8ed42e07b5955568a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120668
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-16 11:25:02 +00:00
Aske Simon Christensen e000482852 [cfe] Better marker length when pointing to a constructor 
Change-Id: Ib962babb98e1fbc96231477eac70db0cb366d479
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121300
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-16 09:47:03 +00:00
Aske Simon Christensen dd140495e7 [cfe] Position on != 
Fixes https://github.com/dart-lang/sdk/issues/35220

Change-Id: I9a9f62b5ba8934dfc8e1162d248146b19e449cb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121380
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-16 09:38:23 +00:00
Johnni Winther 42dcdf903c [cfe] Handle promoted type variables in getStaticType 
Change-Id: I05a748ec800c7c18a52f8444ad030208ea14d268
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121325
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-11 19:04:48 +00:00
Johnni Winther cd86dbbdeb [cfe] Replace UnknownType in typedef types 
Closes #38812

Change-Id: I74f71d023d68123aa1ef4a7e5579be6948a295b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121303
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-11 12:47:56 +00:00
Johnni Winther 72bae7be70 [cfe] Handle all bounds checks on extension methods. 
Closes #38755

Change-Id: I3d5449950ecb3268436a3033ae16bac590a1e4b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120790
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-09 19:50:02 +00:00
Jens Johansen 41d13f0ffe [CFE] Cleanup unused parts in uriToSource 
Change-Id: Ie26fb25a0394999df1c681296ef96a90d51d8c13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120789
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-09 13:28:12 +00:00
Jens Johansen f09edd1d32 [CFE] Add incremental serializer 
Add an incremental serializer that can be used to avoid re-serializing
the same thing again and again.
It does this by grouping libraries into Components / bundles,
serializing them individually and using the concatenated dill feature to
output the wanted data --- just potentially faster if we had the data
in cache.

Note that the serialized output might contain *more* than the input given
if we cached the wanted data into a bigger bundle.
The output will always be "closed" though, i.e. if the stuff that is
included that is too much added a new dependency, that dependency will be
included as well.
This should generally make it safe, although one can imagine situations
where it could pull in lots of dependencies that it wouldn't otherwise
have.

It is being driven by the incremental compiler which makes sure to
invalidate the cache when the data changes.

Except for situations where the libraries are changed externally after
being serialized, but before being serialized again, where one then wants
the updated library serialized, the feature should be safe.

Change-Id: I2a504abe6dbb68434c3b04abff13480ef72a6a6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120786
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-09 13:28:12 +00:00
Aske Simon Christensen d1124c3b2b [CFE] Fail at runtime when a const constructor redirects to a non-const 
If a const constructor redirects to a non-const constructor, report a
compile-time error (no change here).

At runtime, a const instantiation will result in an invalid expression,
whereas a non-const (explicit or implicit new) instantiation will
work normally.

Closes https://github.com/dart-lang/sdk/issues/23622

Change-Id: Ief0e9c62fb8de34203df49fd862f20aba41a3cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120042
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-09 10:18:37 +00:00
Jens Johansen 05f56ef160 [kernel] Fix printing of additional exports 
Change-Id: I65ee82646555cd31eccad33e3a125f0ef2af3a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120784
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-09 10:10:33 +00:00
Jens Johansen e7a128ecc2 [CFE] Refactor incremental compiler test(s) 
Change-Id: I538d5bb5f50af2409d0c99e8ab15b803b9e10fc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120783
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-09 10:10:32 +00:00
Johnni Winther a85054d12e [cfe] Handle parser recovery in extension declarations 
Closes #38600
Closes #38712

Change-Id: I875c55c49253066263bfe1c9cbe97debd1e81648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120583
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-08 20:24:38 +00:00
Aske Simon Christensen f25c72f25f [cfe] Fix position and redundancy in redirecting constructor error 
Closes https://github.com/dart-lang/sdk/issues/35294

Change-Id: Ic712c84b62d421eb6e02d2e9c13829c3cc419eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120120
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-08 14:16:51 +00:00
Johnni Winther 4856917f63 [cfe] Handle extension getter/setter conflicts 
Closes #38713

Change-Id: I07a1a07f842c88f95ddecbe1a9d4e0a7da232c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120586
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-08 14:03:31 +00:00
Johnni Winther f4a72bfc64 [cfe] Don't crash on access to extension fields 
Closes #38745

Change-Id: I8ab361d3663e22f1d21869ac787069ba8f73fa9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120646
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-08 10:26:17 +00:00
Johnni Winther 9276d50fdc [cfe] Remove Severity.errorLegacyWarning 
Change-Id: I1cc7a34af307b9edee4c92e43e8607a450cf471d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120585
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-08 09:16:47 +00:00