dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1972 Commits

Author SHA1 Message Date
Jens Johansen 2ad66bbffe [CFE] Set correct async markers in outline phase 
Change-Id: I4ac1fe1f4195dea2c20b8e55963b7e7dffc2d289
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152330
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-06-25 10:29:28 +00:00
Alexander Markov e2921461e3 [CFE] Fix static type of temporary variable in null-aware spreads 
Fixes https://github.com/dart-lang/sdk/issues/42423

Change-Id: If01cefca5cd85c37fb3f886e7caf27cbfd26f367
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152422
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-06-24 21:48:33 +00:00
Dmitry Stefantsov 8e0b0d5fa0 [cfe] Add NNBD-aware constraint gathering and solving 
Closes #41105
Closes #41106
Closes #41447

Bug: http://dartbug.com/41105
Bug: http://dartbug.com/41106
Bug: http://dartbug.com/41447
Change-Id: I041c4a861fa580a9a9da77416308300206f4774e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151393
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-24 14:35:01 +00:00
Jens Johansen b41471670e [CFE] Use experiment flag 'alternative-invalidation-strategy' 
Change-Id: Ib7358793c8413aa0a67134e3a00fe1a6c8c4bbb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150342
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-24 08:35:54 +00:00
Johnni Winther cc5df58bd2 [cfe] Refactor return type checking in preparation for nnbd spec change 
Change-Id: Ie73726b59b23be4c5e35b207ec72732c8be7dada
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150982
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-22 11:33:35 +00:00
Johnni Winther 7517a0903b [cfe] Mark late setters as isGenericCovariantImpl 
Closes #42407

Change-Id: Icbca37955f0e2c67ac44dd912516048d33ccac39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151842
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-06-20 06:57:29 +00:00
Johnni Winther bcace93c4f [cfe] Add test for issue 42407 
Change-Id: Idf4362be94d42f36afa4e7a471e412a8f3b00c0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151821
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-19 14:50:05 +00:00
Johnni Winther be96c24560 [cfe] Only check required named parameters in opt-in overrides 
Closes #42387

Change-Id: I60a0c7b47f2f8c71d67f79a854648b96a301ba45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151740
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-19 07:19:05 +00:00
Johnni Winther 87f74cbba9 [cfe] Check optional non-nullable parameters in constructors 
Closes #42203
Closes #42362
Closes #42352

Change-Id: Ida8a41252ec524ba5c2eaa697fa61e3514897bef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151500
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-18 18:07:06 +00:00
Johnni Winther f591ad7d88 [cfe] Only perform legacy-to-non-nullable conversion on inferred types 
The exempts types for synthesized variables to avoid emitting a warning
on `o?.foo` when `o` is a legacy type.

Closes #42276
Closes #42003

Change-Id: Ideaf099e25c0d50a35a2e704a29aacceb22142b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151516
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-18 18:06:46 +00:00
Johnni Winther 4d8d05d1b7 [cfe] Add regression test for issue 41952 
Closes #41952

Change-Id: Ic605c505f55725b87964204d450bae863049467e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151397
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-18 17:51:07 +00:00
Leaf Petersen d44457f79d [Core Libraries] Eliminate the fork in the core libraries. 
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.

Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-06-16 23:37:36 +00:00
Johnni Winther 261e283a0a [cfe] Handle explicit type parameter type nullability in bounds 
Closes #42143

Change-Id: I05f181889481c48b183cef135f96dbf510ca788d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151381
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-16 12:28:04 +00:00
Johnni Winther f369194255 [cfe] Add test for extension on Never 
Closes #42180

Change-Id: I690d3419d94bfc593f77f0cea75274cb20182ba2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151229
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-16 08:10:24 +00:00
Johnni Winther 9b4b9ae3a7 [cfe] Fix expectations after adding of FutureOrType 
Change-Id: Ia4a6e18062ad215b0db5b44ee447ad615c28690e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151231
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-15 16:15:05 +00:00
Johnni Winther 28606d040b [cfe] Recompute type parameter type nullability after substitution 
Closes #41697

Change-Id: Ib4977aa3f8d97defa7884036a0f561d6ecb4c3ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149587
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-06-15 13:24:26 +00:00
Dmitry Stefantsov 929d5e4a98 [cfe,ddc,dart2js,vm] Add FutureOrType 
This CL is the sum of the following 5 CLs:
* https://dart-review.googlesource.com/c/sdk/+/149297/
* https://dart-review.googlesource.com/c/sdk/+/149299/
* https://dart-review.googlesource.com/c/sdk/+/149320/
* https://dart-review.googlesource.com/c/sdk/+/149321/
* https://dart-review.googlesource.com/c/sdk/+/149323/

The reason for landing the 5 CLs as one CL is to prevent potential
troubles with bisecting over the branch because the change is fully
functional only with all 5 CLs.

Closes #40123.

Bug: https://github.com/dart-lang/sdk/issues/40123
Change-Id: Ice52250a98acfe455b1d7fa5bb0624c115ca5dac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150934
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-15 12:18:46 +00:00
Mayank Patke f043f9e5f6 Don't legacy-erase type literals. 
Change-Id: Ic924a4ddf27801e0d09952cd0da222cfda4f8b73
Bug: https://github.com/dart-lang/sdk/issues/42262
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150821
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-11 13:28:49 +00:00
Jens Johansen 978342b7b1 [CFE] Fix redirecting factory constructor usage in expression compilation 
Fixes: #41976
Change-Id: I71d393e6503d7ad3ea3c433dda783ffb02f5e280
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150020
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-06-04 08:46:11 +00:00
Jens Johansen acb552d056 [CFE] Make incremental tests output expect files for expression compilations 
Also add reproduction for issue #41976.

Change-Id: I65c55ce0b7ef65e28903b924945e148a1a2285d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149844
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-06-04 07:12:47 +00:00
Johnni Winther 01c09391f3 [cfe] Add regress test for issue39666 
This underlying issue has been fixed.

Closes #39666

Change-Id: Ic407107fd99b1fe9f72651c16e3631a769709b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149593
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-03 08:21:59 +00:00
Johnni Winther 23d70f6f23 Reland: [cfe] Embed and use allowed experiments in CFE 
This CL embeds the sdk_nnbd/lib/_internal/allowed_experiments.json
into the CFE and uses this to allow experiments enabled on a
per library basis. The file is embedded through generated code to
avoid reliance on access to the file itself.

A presubmit check is also added to ensure that the json file and
the generated code are in sync.

This work is in preparation for https://github.com/dart-lang/sdk/issues/41538

This was reverted in https://dart-review.googlesource.com/c/sdk/+/149620
because flutter wasn't prepared for auto-enabling nnbd in dart:* libraries.
This has now been fixed in https://github.com/flutter/engine/pull/18714

Closes #42162

Change-Id: I686ed6feaef8ee066b426068fe2a0f5080bf1713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149588
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-03 08:15:49 +00:00
Johnni Winther 665c58aa1a [cfe] Disallow void in await expression 
Closes #41602

Change-Id: I29b8880e3fdb769b2acdf2c82a9ced038d7b0d94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149287
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-06-02 08:20:31 +00:00
Johnni Winther f90391a12d [cfe] Add regression test for issue 41435 
The failure seems to have been fixed elsewhere.

Closes #41435

Change-Id: Iab3c0b3ff8dda2d498c854f35d5fea01f46ca899
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149284
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-06-02 08:20:31 +00:00
Johnni Winther 0e6c8683e3 [cfe] Set #isSet field after late field in lowering 
Closes #41922

Change-Id: I403ca031898c72f3edc0ca9c7434466c3510c53d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148800
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-26 10:48:25 +00:00
Jens Johansen 4dcf24ac7f [CFE] Use BlockExpression for encoding cascades 
Change-Id: I9c56cbed9880716af804c80c6ca34578ae6765a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148528
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-05-26 09:07:25 +00:00
Johnni Winther 3dbb64a507 [cfe] Handle == on Never 
Change-Id: I9519c20f249ba038b29c05b65e8741f80705d664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147081
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-20 10:25:02 +00:00
Jens Johansen e3650e5ea5 [CFE] Reproduction of different interface target when from dill 
Change-Id: I6ee248fd5d5b18a2c9f4e854cbcce8d89f373b94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148524
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-20 08:02:04 +00:00
Johnni Winther 585d664d35 [cfe] Add annotations on synthesized getters/setters 
This moves late lowered annotations from the field declaration to the
synthesized getters and setters, and adds annotations to the synthesized
setter for external fields.

Change-Id: I50e6cb9e155877a2be4d92ea2d9c9dc7796fef8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148521
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-19 11:18:30 +00:00
Johnni Winther 6336e8e2d3 [cfe] Use legacy subtyping in weak mode constant evaluation. 
+ add checks for agnostic subtyping differences

Closes #41657

Change-Id: I1e6b558edbfcb1ca282e0e4c788c6a7a7db6bfd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148126
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-19 08:55:20 +00:00
Alexander Markov cbb5305f78 [vm/nnbd] Optimize type casts 
Add a kernel transformation which removes redundant casts and reduces
some casts to null checks. This transformation assumes that type
system is sound and subtyping relation is transitive. So in NNBD weak
mode this transformation is always correct. In NNBD strong mode
this transformation is correct only if opted-out libraries are not
allowed.

The following patterns are handled:
If S <: T (this includes S <: T? in weak mode)
  S x; x as T => x
If S <: T? in strong mode
  S x; x as T => (x == null) ? x as T : x

This kernel transformation is not specific to the VM and can be reused
by other back-ends such as dart2js and DDC.

Fixes https://github.com/dart-lang/sdk/issues/40892
Issue https://github.com/dart-lang/sdk/issues/40893

Change-Id: I466ba96d763d5358011c768400c5225fa7bf5e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139314
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-05-19 02:35:12 +00:00
Johnni Winther c10b41a4e2 [kernel] Add DartType.toTypeText and Constant.toConstantText 
These are used to provide a testable textual representation
of types and constants that do not rely upon Node.toString.

Change-Id: Iff77ebb44e8299b262f4f263666b2e1d4dd5794b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147909
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-18 11:48:20 +00:00
Johnni Winther 383a8ea857 [cfe] Initial support for external fields. 
Change-Id: Iccee87f40df395c928dc1a9dc81ddad8813a5000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147906
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-14 18:34:06 +00:00
Johnni Winther 1661e0e03d [cfe] Handle covariant late fields in lowering 
Change-Id: I2bbac50e7b544e5180e74ded8e657a09bf6430da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147901
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-14 18:34:06 +00:00
Johnni Winther 46963a3422 [cfe] Change implicit catch type to Object 
Closes #41520

Change-Id: Iff07ac2b7187b042e2c702462c0c3269208f27ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148062
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-14 18:26:01 +00:00
Johnni Winther 00353040b9 [CFE] Error when strong mode mixed with non-opted-in 
Change-Id: Ibff34fe071a6d10ce29c30e1d008d4a5ce6690a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140868
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-05-14 17:10:51 +00:00
Paul Berry 275b922ee8 Revert recent parser fixes 
Commit 1f9b5c1996 causes tests to fail
in angular when rolled into internal sources; the other two commits
need to be reverted as well to avoid merge conflicts.

This reverts commit 1f9b5c1996.
This reverts commit c40b24da48.
This reverts commit 96df1f9e6c.

Change-Id: Ic4e55181ef60e825ce4409a9a9528ecbf19c39c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-12 22:02:09 +00:00
Dmitry Stefantsov 3b93b85aef [cfe] Update inference for redirecting factory constructors 
Closes #34714.

Bug: https://github.com/dart-lang/sdk/issues/34714
Change-Id: Ia1f6845d2ae623ecba01fd5e60dcaed975471f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147181
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-12 14:03:49 +00:00
Johnni Winther d5650235a2 [cfe] Handle ProblemBuilder in binary expression 
Closes #41787

Change-Id: I81fcf0aee975b58b3b44d0de94054ae87bdd265d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147140
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-12 11:44:19 +00:00
Jens Johansen 96df1f9e6c [parser] Add ErrorToken for ignored (unmatched) end parenthesis, brackets etc 
Change-Id: Idb57295700988d71321743af9782134b02562311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146240
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-05-11 14:46:47 +00:00
asiva ce5d18b0f0 [CFE] - Update exectations of CFE unit tests to account for NNBD unfork 
These updated expectations were generated by running the script
pkg/front_end/tool/update_all.dart

Change-Id: I6b8f7c5e50160da96e90c44fa888bd9b072efd06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147321
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2020-05-07 23:16:21 +00:00
Erik Ernst b0837b9aeb Corrected non-function type alias diagnostics 
Errors involving superinterfaces in class declarations will now mention
both the type alias and the unaliased type, e.g., in cases like
`class A extends T {}` where `typedef T = void;`.

Change-Id: I5bb575b98329e8338560d1ee5dc18e71da9711e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146720
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-05-07 09:00:57 +00:00
Jens Johansen 4264cba086 [CFE/kernel] Reproduction for crashes 
Change-Id: I1f6e0a3dd08c9bfd3875b0835a5b9241b78e2602
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146805
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-05-07 07:30:48 +00:00
Clement Skau 2359f4dc68 [VM] Reworked: Remove unnecessary Closure.clone() from sync*. 
Removes the Closure.clone() in sync* by adding an additional closure
around the rewritten sync* function body.

This is a re-worked version of the now reverted:
- https://dart-review.googlesource.com/c/sdk/+/136190
- https://dart-review.googlesource.com/c/sdk/+/144948

This CL includes changes from both the above CLs, in addition to:
- A new 'ShadowRewriter' transformer to do deep rewriting of
  shadowed parameters.
  Previous versions only rewrote the immediate sync* function, missing
  references in nested rewritten functions.

Note: This CL is re-landing largely unchanged since the roll-blocking
issues suspected to be caused by this was later attributed to a
different set of changes.
I have independently re-run all failing external tests to verify
them passing for this CL.

Bug: https://github.com/dart-lang/sdk/issues/37753
Change-Id: Id1670a93961180e8558d7c7eca65fe7e9115f07b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145402
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2020-05-05 12:04:03 +00:00
Johnni Winther 59e54abb0e [cfe] Handle callable type variables. 
Change-Id: Ibd963206bb81fef16f3cb410fc352e636b0596e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146580
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-05 10:02:03 +00:00
Johnni Winther 3788a59c6c [cfe] Remove ObjectAccessTargetKind.unresolved 
Change-Id: I39fd278531038829ea28a870b6333918e4a6bf38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146261
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-05-05 09:00:23 +00:00
Jens Johansen e1cfc95c02 [CFE] Add missing '()' to nnbd/override_checks 
Change-Id: I7a62dbb21a9c3bc59550f2daff59a1a62cc3588f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144580
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-05 07:45:13 +00:00
Johnni Winther 645f3acca7 [cfe] Update greatest closure of ? to Object? 
Closes #41386

Change-Id: I1a5a4cdc35cef37c7a8ba6a6aecb99457789bcdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144940
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-05-04 08:14:43 +00:00
Johnni Winther a9b81e18d9 [cfe] Handle dynamic return in async 
Closes #41437

Change-Id: I493b516f0b72fc1da097b92bd75150aea8e60ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145042
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-30 12:39:04 +00:00
Jens Johansen c08bcbb25e [CFE] Enable textual outline sorting in test suite 
Change-Id: Iccf35b9cb3dce96487ca9ba688394e3b05be2e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145401
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-04-30 08:25:17 +00:00