dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

350 Commits

Author SHA1 Message Date
Johnni Winther 3ccdb01fc9 [cfe] Handle extensions exported through multiple libraries 
Closes #39160

Change-Id: I605b1a95ddab822848b33244b3130ebf16b69842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123523
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-30 11:59:44 +00:00
Johnni Winther ee9ec9c3e0 [cfe] Report error on builtin identifier as extension name 
Closes #38094

Change-Id: I029f8f30ee0c15ec9f1adf7419f83c4e76ca3ae1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123521
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-30 10:02:55 +00:00
Jens Johansen ea3cb7317a [CFE] Fix unescapeString crash 
unescapeString would for instance crash if it got the string '"'
(without the quotes) (i.e. the single ascii character 0x22).

Fixes #39035

Change-Id: I0b6baba975b3e8a9279699027fde4b15cde4a5ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123249
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-29 09:38:46 +00:00
Johnni Winther eb04e0922b [cfe] Refactor CompoundPropertySet and add CompoundExtensionSet 
Change-Id: Id6dda215cae88dc35943f34be4f210d148eace00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122642
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-28 14:08:42 +00:00
Johnni Winther bb02531b7e [cfe] Move creation of error nodes to inferrer 
During top-level inference we cannot emit errors. With this change
the inferrer controls whether to create and report an error or to create
a revisitable node.

Change-Id: Ia7821c6d2628fdae0897f3cd6108ef12d2f096df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122782
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-28 14:08:42 +00:00
Dmitry Stefantsov 9910fa8454 [cfe] Implement the first part of NNBD-aware isSubtypeOf 
This CL is a squashing of the following smaller CLs:

* https://dart-review.googlesource.com/c/sdk/+/120669/
* https://dart-review.googlesource.com/c/sdk/+/120670/
* https://dart-review.googlesource.com/c/sdk/+/121331/
* https://dart-review.googlesource.com/c/sdk/+/121381/
* https://dart-review.googlesource.com/c/sdk/+/121383/
* https://dart-review.googlesource.com/c/sdk/+/121620/
* https://dart-review.googlesource.com/c/sdk/+/121707/
* https://dart-review.googlesource.com/c/sdk/+/122144/
* https://dart-review.googlesource.com/c/sdk/+/122360/
* https://dart-review.googlesource.com/c/sdk/+/122381/
* https://dart-review.googlesource.com/c/sdk/+/122783/
* https://dart-review.googlesource.com/c/sdk/+/122787/

Change-Id: I9d850f531f0fce07055ff9b5cd39abb605752005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122868
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-25 16:37:39 +00:00
Jens Johansen 87fa4e49d7 [CFE] Fix of an UTF8 BOM in input file possibly causing a crash 
Fixes: #39091
Change-Id: I963d22a49efebbed16b9645d2249c0887c35d780
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122789
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-25 07:07:54 +00:00
Johnni Winther 18d43babd1 [cfe] Avoid crash for missing object access targets in toplevel inference 
We cannot emit errors during toplevel inference.

Change-Id: I2add33892ddf20c27ff53038a3be2b02c34029e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122761
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-24 10:51:49 +00:00
Jens Johansen 18fa7485ad [kernel] Read ContinueSwitchStatements in nested FunctionNodes correctly 
Closes #39040

Change-Id: I8ae9a89cfd750dddbf0a994e93d9b2aa2d46490c
Fixed: 39040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122386
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-23 08:34:27 +00:00
Jens Johansen 0449905e2d [CFE] Add a serialization-and-unserialization step to strong test 
Change-Id: Icb6275e9eaec0bbdd890719d780a0218fa660fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122384
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-22 13:40:01 +00:00
Johnni Winther e76f6d49e4 [cfe] Implement null-shorting for most expressions 
Binary operations and parenthesized expression are shorted which they
shouldn't be. Also, so complex expressions, like compound assignment,
are not handled because they need to be encoded in a more high-level
internal expression to support choosing the receiver based on shorting.

Change-Id: I0bdeabdc21da7d80f533ea0880662bfb11341c6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121856
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-22 10:04:54 +00:00
Johnni Winther b1b4f6b7e4 [cfe] Allow assignment to late final fields/variables 
Change-Id: I0264904fe6f24f4021cef3d6576b54e11fe0a4d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122143
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-10-21 12:38:51 +00:00
Johnni Winther f1ac6959ab [cfe] Handle mixed if map entries 
Closes #38874

Change-Id: I0122ccb9bc91d349c030955332da338830a137c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121987
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-21 12:38:11 +00:00
Jens Johansen 3d67e7d6a7 [CFE] Don't try to infer fields not in the output program 
Fixes assertion error because it cannot properly infer 'this' for field
not inserted in the ast.

Fixes #38961.

Bug: 38961
Change-Id: I4230fc2d8c47eb84ad2627651f4d7ca2787e5f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122141
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 10:44:28 +00:00
Jens Johansen c1599932f9 [CFE] Fix crash when serializing: "Type parameter #lib1::B::X is not indexed" 
Fixes #38944

Bug: 38944
Change-Id: I26bdd06f86c0c0ac0089d34255bcb3ef824affcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 09:40:38 +00:00
Jens Johansen 0c47a8529c [CFE] Fix "Type 'void' not found." bug 
Fixes #38943

Bug: 38943
Change-Id: I6086f5f46a67b37a04b21d0053fc7903a83df523
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122000
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-18 06:36:25 +00:00
Johnni Winther c6cb89c622 [cfe] Replace child nodes in parent nodes on post-traversal 
Replace child nodes in parent nodes on post-traversal instead of using
TreeNode.replaceChild and TreeNode.replaceWith

Change-Id: I2f6f908dce0cd38f1d9a68d4183810e2e0cdca71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121622
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-17 12:56:49 +00:00
Johnni Winther 9b3c7f64d8 [cfe] Represent Cascade expressions directly 
This is needed to perform lowering during inference.

Some missing expectation files were added as part of the update.

Change-Id: Ifc834617621e8d60518e840dc61f0386fb8d3b92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121423
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-17 12:56:49 +00:00
Jens Johansen 95991df628 [CFE] Fix crash with duplicate field and constructor initialization 
Fixes #38938

Bug: 38938
Change-Id: Icee8187c2237289640cf7bfa763c8e614c5f1cb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121858
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-10-17 10:47:53 +00:00
Johnni Winther dee702264b [cfe] Handle named arguments on extensions methods correctly 
Closes #38915

Change-Id: Ie11a2508605fb3591347bc1f4cd68de846829328
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121852
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-16 14:38:23 +00:00
Dmitry Stefantsov 23e8f2bcfa [cfe] Verify that Null is always nullable 
Closes #38360.

Bug: http://dartbug.com/38360
Change-Id: I073a63bc968f1955a3c23bb8ed42e07b5955568a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120668
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-16 11:25:02 +00:00
Aske Simon Christensen e000482852 [cfe] Better marker length when pointing to a constructor 
Change-Id: Ib962babb98e1fbc96231477eac70db0cb366d479
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121300
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-16 09:47:03 +00:00
Aske Simon Christensen dd140495e7 [cfe] Position on != 
Fixes https://github.com/dart-lang/sdk/issues/35220

Change-Id: I9a9f62b5ba8934dfc8e1162d248146b19e449cb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121380
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-10-16 09:38:23 +00:00
Johnni Winther 42dcdf903c [cfe] Handle promoted type variables in getStaticType 
Change-Id: I05a748ec800c7c18a52f8444ad030208ea14d268
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121325
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-11 19:04:48 +00:00
Johnni Winther cd86dbbdeb [cfe] Replace UnknownType in typedef types 
Closes #38812

Change-Id: I74f71d023d68123aa1ef4a7e5579be6948a295b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121303
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-11 12:47:56 +00:00
Johnni Winther 72bae7be70 [cfe] Handle all bounds checks on extension methods. 
Closes #38755

Change-Id: I3d5449950ecb3268436a3033ae16bac590a1e4b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120790
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-09 19:50:02 +00:00
Aske Simon Christensen d1124c3b2b [CFE] Fail at runtime when a const constructor redirects to a non-const 
If a const constructor redirects to a non-const constructor, report a
compile-time error (no change here).

At runtime, a const instantiation will result in an invalid expression,
whereas a non-const (explicit or implicit new) instantiation will
work normally.

Closes https://github.com/dart-lang/sdk/issues/23622

Change-Id: Ief0e9c62fb8de34203df49fd862f20aba41a3cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120042
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-09 10:18:37 +00:00
Johnni Winther a85054d12e [cfe] Handle parser recovery in extension declarations 
Closes #38600
Closes #38712

Change-Id: I875c55c49253066263bfe1c9cbe97debd1e81648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120583
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-08 20:24:38 +00:00
Johnni Winther 4856917f63 [cfe] Handle extension getter/setter conflicts 
Closes #38713

Change-Id: I07a1a07f842c88f95ddecbe1a9d4e0a7da232c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120586
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-10-08 14:03:31 +00:00
Johnni Winther f4a72bfc64 [cfe] Don't crash on access to extension fields 
Closes #38745

Change-Id: I8ab361d3663e22f1d21869ac787069ba8f73fa9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120646
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-08 10:26:17 +00:00
Johnni Winther bc8b12e43b [cfe] Handle privacy in extension lookup 
Closes #38750

Change-Id: Ieb5af03859a51ee034b3c2731eadf7591a4cc83c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120641
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-08 08:07:09 +00:00
Johnni Winther 0ef041d8f2 [cfe] Avoid crash on explicit extension access of static members 
Change-Id: Ia9df90138be93cb9aa2a3111fdc2127fdc3f6cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119334
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-01 07:34:20 +00:00
Aske Simon Christensen 0a5f736c68 [cfe] Fix missing comma between type parameters in function types 
Change-Id: I90f7d1665a93414ed89799b3f564fdb7d2114e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119324
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 13:44:59 +00:00
Johnni Winther f1d6282fa3 [cfe] Report error on extension members that conflict with Object members 
Closes #38561

Change-Id: I9c26879662502e1f56203f87d1cd7a21036dcb2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119325
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-30 13:21:49 +00:00
Dmitry Stefantsov b682235c4c [cfe] Preserve the nullability of LHS of intersection types 
Change-Id: I2e91338d4172c1288ceb58c566d9d3e3e465a0b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 12:53:19 +00:00
Dmitry Stefantsov 7d75eb1fd9 [cfe] Account for nullability in type substitution on DartTypes 
Bug: http://dartbug.com/37689
Change-Id: I5c37f0e13da956285300288cffc58263e67ac302
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 12:52:29 +00:00
Johnni Winther e52542b421 [cfe] Handle generic return types 
Returns types on generic methods in generic extension that contained
type variables declared on the generic method were not substituted,
leaving these as unindexed type parameters during serialization.

Change-Id: I4f53005318ba2be014bfe6e92f4f6c93288f2a4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118995
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 10:58:05 +00:00
Aske Simon Christensen 4b9557e5e3 [cfe] Check valid return type of local async functions. 
Fixes https://github.com/dart-lang/sdk/issues/37681

Change-Id: I24e53f92ab9c812591a1317673082c4a40c2d00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119142
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 08:48:08 +00:00
Kallen Tu 327bc451f8 Added variance support in listeners to ast. 
Pass variance data to field in TypeParameter through the listeners.
ast_to_text will print variances for classes and mixins if specified.

Avoids serialization/deserialization (impl in future CL).

Change-Id: I298537604823710f0d30001f4cb5f1e81530959f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118464
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-26 18:11:10 +00:00
Johnni Winther 6ff8d2199d [cfe] Don't crash on constructors in extensions 
Change-Id: I11cdb9699101f384c2734c3551b4eefdfda6eccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118980
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-26 12:32:25 +00:00
Johnni Winther 53564db036 [cfe] Handle implicit extension call() 
Change-Id: Ib0aa04b7b00c54c21932040bd8912d95c138f62e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118960
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-26 10:36:51 +00:00
Johnni Winther ee7aae43c0 [cfe] Handle explicit extension index access 
+ avoid implicit extension for [] or []= when the other is defined on
the receiver.

Change-Id: I99c76a66bfb4f72c396097b2f347aad9f0a42f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118940
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-26 10:36:51 +00:00
Johnni Winther 0bf6b6ae64 [cfe] Handle instantiation of extension tear-offs and check bounds on extension method invocation 
Change-Id: I212f95c897889a28934910c2c21c64bea6c6a64c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118585
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-26 08:41:38 +00:00
Johnni Winther b03d472e4c [cfe] Handle default values on extension methods 
Closes #38541

Change-Id: I078800cc98b5444c2c7f6f87b2d89bcf764bfc23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118582
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-25 08:45:27 +00:00
Dmitry Stefantsov 12f6cbb7b1 [cfe] Thread nullability modifiers for TypeParameterTypes from source 
Closes #38218, #38221.

Bug: http://dartbug.com/38218
Change-Id: I4689b0b192b71790c8fc5ffba6ccb807f289f771
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118580
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-25 08:15:47 +00:00
Johnni Winther 7b9bcd08b4 [cfe] Correctly substitute function types from extension on-clauses 
Change-Id: Icf6bf59544d2c14cc153cdf77b675554d319b6b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118541
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-25 07:30:17 +00:00
Jens Johansen cc7baf9bf5 [CFE] Fix of crash etc in error messages wrt formal parameters 
With something like
x2() {
  y(z, {z}) {}
}

in a part, we create an error on the 2nd 'z'.
That error message gets the file uri of the body builder which is correct.
The context gets (for the 1st 'z') gets the file uri of the
FormalParameterBuilder which in turn got it from the "parent" which is the
library which is the "main library", i.e. not the "part library".

This causes - in the face of parts - one of two things:
1) It will point into the wrong file and the error message will be bad.
2) It tries to point into the wrong file, but the wrong file is not big
   enough, and we thus get a crash.

This CL fixes it so the FormalParameterBuilder has the right uri.

Fixes https://github.com/dart-lang/sdk/issues/38523.

Bug: 38523
Change-Id: I303dbec2934ae930b8f2f2c9f63a4aa00db3a89c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118448
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-24 11:50:09 +00:00
Jens Johansen 98d94e7efc [CFE] Reproduction of crash etc in error messages wrt formal parameters 
Reproduction of dartbug.com/38523

Bug: 38523
Change-Id: Iffc30a622685c0c8d7a0daf0b84c910072c8146f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118446
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-09-24 11:43:28 +00:00
Johnni Winther 175fc6edff [cfe] Use original name in extension method errors. 
Previously the errors were reported using the synthesized name, like
`Extension|method` instead of `method`.

+ Report errors on invalid uses of explicit extension application as
an expression or lvalue.

Change-Id: I6d85430be4ab3966ee94131b37aa365265c07eac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118383
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-24 07:55:45 +00:00
Johnni Winther b7ad248209 [cfe] Handle annotations on extension members 
Closes #38439

Change-Id: I3c995ba5ca3058530318b14e46d275ce6ccc8778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118381
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-09-24 07:55:45 +00:00