Commit Graph

2 Commits

Author SHA1 Message Date
Daco Harkes a7fa63493f [cfe] Give external field generated setters parameter names
The setters generated from external fields used not have a name.
This broke the assumptions in the VM when making stack traces.

Separated out from https://dart-review.googlesource.com/c/sdk/+/140290.

Issue: https://github.com/dart-lang/sdk/issues/43533

Change-Id: I1816557eff891eaa7c531db1f4239159c66c325c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164093
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2020-09-23 22:42:09 +00:00
Johnni Winther 92f4eb58c8 [cfe] Support abstract fields
Only positive implementation, no error states are checked yet.

Change-Id: Iad79da1dd7e8be9229ee9d47c5301d39ebc3debc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154003
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-07-16 10:13:23 +00:00