Jens Johansen
69412b2da7
Avoid file io in incremental_load_from_dill_test
...
Attempt to avoid failure on Windows.
Change-Id: Ib86d36e377e655dc85f5a3e2da219e911fa3fa3c
Reviewed-on: https://dart-review.googlesource.com/37761
Reviewed-by: Jens Johansen <jensj@google.com >
2018-02-02 07:53:55 +00:00
Siva Chandra
71dba8a0e5
Link the platform kernel with the command line dart executable.
...
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Chandra <sivachandra@google.com >
2018-02-01 15:11:29 +00:00
Jens Johansen
c3b992dcd8
[fasta] incremental compiler can initialize from dill
...
As requested in #31691 the incremental compiler should be able to
initialize its state from a previously generated dill file.
This CL introduces that functionally.
It is tested, but actual usage (e.g. proper invalidation of old files)
should live outside of the front-end (i.e. it's the callers responsibility).
One option would be for the caller to load the dill file and use the
included sources to invalidate changed files.
On my machine a from-scratch compile of dart2js takes ~5 seconds,
one initialized from such an output and with a single file invalidated
(though it actually hasn't changed) it takes ~1 second and the resulting
dill file is bit-perfect compared to the from-scratch compiled one.
Closes #31691 .
Change-Id: I07f5efca5f2684d73f6c252f2dbc2ad04e9b5cd0
Reviewed-on: https://dart-review.googlesource.com/37260
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2018-02-01 14:57:07 +00:00
Paul Berry
e978cd6062
Encapsulate the handling of forwarding stub target references.
...
As discussed in https://dart-review.googlesource.com/c/sdk/+/34261 .
Change-Id: I2af5021ad9738f6bc47bb11d2a1133f303d3ace9
Reviewed-on: https://dart-review.googlesource.com/36481
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
2018-01-30 11:49:38 +00:00
Mike Fairhurst
dcb7ad3a10
Create a single CL to get CFE void-compliant
...
This is to incrementally land https://dart-review.googlesource.com/c/sdk/+/35805 .
This FE code uses 'void' values where they are not allowed
Change-Id: I2c10766dbf0367a1f6db6f29db2f6f2005165f83
Reviewed-on: https://dart-review.googlesource.com/36800
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-01-26 17:46:55 +00:00
Zachary Anderson
9c40a7e662
Reland: [dart:cli] Adds waitFor(Future)
...
This is a reland of https://dart-review.googlesource.com/#/c/sdk/+/28920/
with the following changes:
- It creates a new library dart:cli
- waitFor(Future) goes in dart:cli instead of dart:io
- Removes a flaky test, and adds a missing precompiler entrypoint
- Adds waitFor(Future)
- Improves doc comments
fixes #31102
Change-Id: I04d2c46fd0afac049dd4fd1353905dc20da18f90
Reviewed-on: https://dart-review.googlesource.com/29449
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Natalie Weizenbaum <nweiz@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-01-18 16:38:54 +00:00
Peter von der Ahé
4d1adf42d3
Deprecate IncrementalClassHierarchy
...
See https://github.com/dart-lang/sdk/issues/31842
Change-Id: I019909831a91a4e06138dc3a6bf32f766bca1ae6
Reviewed-on: https://dart-review.googlesource.com/34880
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-17 13:30:17 +00:00
Peter von der Ahé
e7ac35dfc9
Make the fasta tool use Platform.resolvedExecutable when tested.
...
Change-Id: Ie83cd4692898c1b6e585ed5d47fc55be4d60c272
Reviewed-on: https://dart-review.googlesource.com/35162
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-01-17 10:26:08 +00:00
Peter von der Ahé
beda5c3e62
This CL supposedly broke the analyzer, but that isn't true. It broke a single front_end test, and if that was causing you trouble, you could have marked it as failing.
...
Revert "Revert "Don't skip front-end tests""
This reverts commit b4556e646e .
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Don't skip front-end tests"
>
> This reverts commit 62d2255719 .
>
> Reason for revert: Broke analyzer bots
>
> Original change's description:
> > Don't skip front-end tests
> >
> > Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
> > Reviewed-on: https://dart-review.googlesource.com/34621
> > Reviewed-by: Jens Johansen <jensj@google.com >
>
> TBR=ahe@google.com ,jensj@google.com
>
> Change-Id: I6519e0c551dd79d3bd98345925c2db888e892123
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/35020
> Reviewed-by: Paul Berry <paulberry@google.com >
> Commit-Queue: Paul Berry <paulberry@google.com >
TBR=paulberry@google.com ,ahe@google.com ,jensj@google.com
Change-Id: I7ff6fd587912fd8a2aba113eb7c765c7b16c5eda
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/35120
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-01-17 06:03:59 +00:00
Paul Berry
b4556e646e
Revert "Don't skip front-end tests"
...
This reverts commit 62d2255719 .
Reason for revert: Broke analyzer bots
Original change's description:
> Don't skip front-end tests
>
> Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
> Reviewed-on: https://dart-review.googlesource.com/34621
> Reviewed-by: Jens Johansen <jensj@google.com >
TBR=ahe@google.com ,jensj@google.com
Change-Id: I6519e0c551dd79d3bd98345925c2db888e892123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/35020
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-01-16 22:44:33 +00:00
Peter von der Ahé
1bca76d012
Convert Platform.resolvedExecutable to URI correctly
...
Change-Id: I583b98277b1c62328885c775fcb712823c9ff405
Reviewed-on: https://dart-review.googlesource.com/34860
Reviewed-by: Alexander Thomas <athom@google.com >
2018-01-16 14:24:52 +00:00
Peter von der Ahé
62d2255719
Don't skip front-end tests
...
Change-Id: Ibbd0d63e8c23d045a898e52185fe55e5c53dd6b3
Reviewed-on: https://dart-review.googlesource.com/34621
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-16 12:00:28 +00:00
Peter von der Ahé
1b8953f256
Prevent async cross talk
...
Change-Id: I678cfa16a26e0f2bbda4480b0b21a53750346429
Reviewed-on: https://dart-review.googlesource.com/34664
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-16 11:33:01 +00:00
Peter von der Ahé
e6683f0638
Don't crash when the delta is empty
...
Change-Id: I322261faad1431b7b597094048a9f904d70c33ff
Reviewed-on: https://dart-review.googlesource.com/34740
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-16 09:57:33 +00:00
Peter von der Ahé
2cc21f515e
Remove original and minimal IKG
...
Change-Id: Id845a025ae9823fd3e53aaac7b5a95aa9e2ad767
Reviewed-on: https://dart-review.googlesource.com/34380
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-01-15 15:02:20 +00:00
Konstantin Shcheglov
f79596c0ff
Switch from ForwardingStub to Procedure.forwardingStubInterfaceTarget.
...
Fixes #31519
R=paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/31519
Change-Id: I0e9634ba6a1413a758ff3376c69d530d4215b512
Reviewed-on: https://dart-review.googlesource.com/34261
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-01-12 17:54:30 +00:00
Aske Simon Christensen
4553cdeeb6
Support data URIs in StandardFileSystem.
...
Closes https://github.com/dart-lang/sdk/issues/31594
Change-Id: I8dad1429d91cc5934b37cb0be60d1e4039293b71
Reviewed-on: https://dart-review.googlesource.com/33461
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-01-11 11:23:36 +00:00
Aske Simon Christensen
9bdcc40f69
Rename PhysicalFileSystem to StandardFileSystem.
...
Preparation for data URI support. For clarity, this is just a rename.
Change-Id: Ibbd8da05d1a7106b5ec7c0ea9c1e13a95a89d1bd
Reviewed-on: https://dart-review.googlesource.com/33460
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-01-11 11:23:25 +00:00
Dmitry Stefantsov
d16eeb5eb8
Use --reify-generic-functions when running strong-mode tests with fasta
...
Change-Id: Ie16f8a8339c5b646d714e7656df4fceb5ff2a500
Reviewed-on: https://dart-review.googlesource.com/32601
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-01-05 16:15:48 +00:00
Dmitry Stefantsov
1f3b493dcc
Add simple instantiate-to-bounds algorithm to the common front-end
...
Bug:
Change-Id: I65097b037f4b02f0a161c9c183844a3dc3339c77
Reviewed-on: https://dart-review.googlesource.com/29880
Reviewed-by: Paul Berry <paulberry@google.com >
2018-01-04 11:31:08 +00:00
Konstantin Shcheglov
f57a0511a4
Apply import prefixes in type annotations.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I185b9860aac8650856c8c13b6784b63f3fe2f379
Reviewed-on: https://dart-review.googlesource.com/32000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-02 22:34:04 +00:00
Sigmund Cherem
4dfa6a4b9c
Add flag to truncate summaries.
...
Also remove "trimDependencies".
For context: see issue #31704 (https://github.com/dart-lang/sdk/issues/31704 )
Change-Id: Iedce40fac9ed974850b41145e531d08aeccee87b
Reviewed-on: https://dart-review.googlesource.com/30963
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-12-21 20:00:21 +00:00
Peter von der Ahé
d1543b3986
Don't include .dill artifacts in delta program
...
Change-Id: Ibbcb490cdaca57c600bcf4b9783d889644e8af00
Reviewed-on: https://dart-review.googlesource.com/30822
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-20 15:58:02 +00:00
Peter von der Ahé
ac068b3cb4
Use options.input if entryPoint is null
...
Change-Id: Ia7ce42d2caa025b0e1a31872f23bd0364d6cf5f7
Reviewed-on: https://dart-review.googlesource.com/30820
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-20 12:49:28 +00:00
Peter von der Ahé
2eab494036
Don't add dynamic to a reused dart:core library.
...
Change-Id: I6e4b5bef9e6cd244b7dd59d1be676e47358ec9b8
Reviewed-on: https://dart-review.googlesource.com/30453
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-20 11:05:55 +00:00
Peter von der Ahé
3b6e403f1b
Support compiling the SDK from source
...
Change-Id: Ib5df97ef143c2cf98fc3d92a81d0f6b2f4cb1224
Reviewed-on: https://dart-review.googlesource.com/30452
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-20 09:37:55 +00:00
Brian Wilkerson
032cc33fd5
Rename parseAsyncModifier to parseAsyncModifierOpt
...
Change-Id: I1cc4ad97566bcaeebf16be65ba1e8972a526daef
Reviewed-on: https://dart-review.googlesource.com/30468
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-19 20:22:54 +00:00
Mike Fairhurst
a9fe991cc5
First pass at plumbing fasta errors through to the analyzer. Hopefully this is
...
all satisfactory infrastructurally, organizationally, performance wise.
This does not handle summarizing errors so that we can produce them for existing
dill files, and some other places where special analysis is performed like on
the standard libs.
The CompilationMessage object is less rich than the Message object that other
code is using, see \#31644. However, workarounds included.
Bug:
Change-Id: I5b436b0de6051877801c1d128f43a9656df1b549
Reviewed-on: https://dart-review.googlesource.com/29400
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-15 00:49:55 +00:00
Konstantin Shcheglov
92bf47e7e4
When vm_platform_strong.dill is loaded, and an SDK library is requested, we don't need cycles.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I0bd39b5bd8fa414a59b27b21e1a63196ec8a4300
Reviewed-on: https://dart-review.googlesource.com/29620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-14 21:10:49 +00:00
Konstantin Shcheglov
353e0bdefc
Apply resolution to formals in AstBuilder tests.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I28a045d1e8640a2a447fae6e9f35bfb6db76790a
Reviewed-on: https://dart-review.googlesource.com/28542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-12 17:42:51 +00:00
Peter von der Ahé
ce655bc2ff
Print the URI, not t.dart
...
Change-Id: I03b28f60622f34f19d2e5ce6428e6d696f505331
Reviewed-on: https://dart-review.googlesource.com/28600
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-12 12:22:37 +00:00
Peter von der Ahé
690b8865f5
Compute dependencies instead of strong components
...
Change-Id: I1d20ffc26951669391eaa2a67c02932a264d5eb1
Reviewed-on: https://dart-review.googlesource.com/28305
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-12 12:22:37 +00:00
Peter von der Ahé
cac6551376
Always clear StringToken canonicalizer after running Fasta
...
Change-Id: If994a644c2089e3e9cb57232baceb6b622106d19
Reviewed-on: https://dart-review.googlesource.com/28282
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-12 12:22:37 +00:00
Peter von der Ahé
affb2c9321
Use existing tests of DependencyWalker
...
Change-Id: If870792d24757d020c5724ab79e8972be4bd679b
Reviewed-on: https://dart-review.googlesource.com/27722
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-12 12:22:37 +00:00
Peter von der Ahé
31b512faa2
Implement reusing libraries not affected by invalidated URIs
...
Change-Id: I2fbb6daaa8fe6ca5b136c639194ec49ae31c385f
Reviewed-on: https://dart-review.googlesource.com/27721
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2017-12-12 11:26:10 +00:00
Konstantin Shcheglov
5c580dbe21
Remember explicit static get/assign Class and offset.
...
Revert merging ResolutionApplier with ValidatingResolutionApplier.
Bug:
Change-Id: Ie55ebdcb5d63be26720156a28a68f2727ebc96d3
Reviewed-on: https://dart-review.googlesource.com/28380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 21:46:13 +00:00
Brian Wilkerson
fcfdb8a4d5
Replace TokenStreamRewriter.insertToken with insertTokenAfter
...
Change-Id: I110099eaf0db7f4b09a8225ffaf674e132ce3d43
Reviewed-on: https://dart-review.googlesource.com/28260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-12-11 21:24:53 +00:00
Paul Berry
1c6e907fc8
Report errors when type inference fails due to inconsistent overrides.
...
I will have a follow-up CL to cover type inference failures due to
circularities.
Change-Id: I8c9af501c150d4707ad06e6bbcdc3cabdfbf9207
Reviewed-on: https://dart-review.googlesource.com/28180
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2017-12-11 17:02:45 +00:00
Paul Berry
3e329b7996
Ensure that forwarding stubs do not forward to other forwarding stubs.
...
Fixes #31580
Change-Id: I3b58eedd4036ae42148fdcec74df6c79ed0efd26
Reviewed-on: https://dart-review.googlesource.com/27860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-12-08 19:02:34 +00:00
Paul Berry
9a59be4777
Store the interface target of a forwarding stub.
...
This is a temporary measure to allow the analyzer team to make
progress until #31519 is fixed.
Change-Id: I056505ed0308c5b2ea3e3664a8943549c3c8548c
Reviewed-on: https://dart-review.googlesource.com/27460
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-12-08 16:48:41 +00:00
Peter von der Ahé
3b1f8d4df3
Implement option for requesting all IKG variants
...
Change-Id: Iabeb890cc898b508e6b8cc217a7006feee92c2aa
Reviewed-on: https://dart-review.googlesource.com/27240
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2017-12-08 09:04:24 +00:00
Peter von der Ahé
5bd939bb59
Implement Dijkstra's path-based strong component algorithm
...
Change-Id: I2d8e395231861b8c7e760b929b53e7e5053fed8b
Reviewed-on: https://dart-review.googlesource.com/27222
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2017-12-08 08:26:12 +00:00
Peter von der Ahé
723053f214
Incremental compiler that holds Fasta right
...
Change-Id: I240c7d5ef250014b5688e7f379e7299809148880
Reviewed-on: https://dart-review.googlesource.com/27162
Reviewed-by: Jens Johansen <jensj@google.com >
2017-12-07 14:25:56 +00:00
Peter von der Ahé
e66e6d9dec
Compile all edits.
...
Change-Id: I534ce73bf63c0185aa7add2381a8fa418d10bfa8
Reviewed-on: https://dart-review.googlesource.com/27161
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2017-12-07 13:56:45 +00:00
Peter von der Ahé
7d8c3ab494
Revert my previous changes to IKG API
...
Also, clean up incremental_test.dart a bit.
Change-Id: I4215760b7352f981f21852c160c10b6ac2f89664
Reviewed-on: https://dart-review.googlesource.com/27160
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2017-12-07 13:03:56 +00:00
Konstantin Shcheglov
94907f1aea
Apply resolution to FunctionExpression.
...
Bug:
Change-Id: Iaa8c4b31800fdb9d5a4613417a6076c3af683c6a
Reviewed-on: https://dart-review.googlesource.com/26721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-06 20:41:40 +00:00
Jens Johansen
078f25acf9
[CFE/dart2js] Create dart2js-specific CFE entry point
...
This CL creates the initial dart2js-specific CFE entry point.
It is currently mostly a matter of copying the dart2js code for running the
front-end into the front-end, although it also applies a workaround for
making batch-mode faster.
Running the same dart2js with kernel tests as on the bots locally I get
this:
* Before: [09:11 | 100% | +10507 | - 0]
* Now [04:46 | 100% | +10507 | - 0]
Change-Id: I68f147fd7aadb0281807b4688b9f6fdc5aa24c28
Reviewed-on: https://dart-review.googlesource.com/25300
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-12-06 08:24:28 +00:00
Brian Wilkerson
d522e93a56
Convert replaceToken to accept the token before the token to be replaced
...
Change-Id: Ibcb730cb500f35352a88394d3ec49e27f23e6cdd
Reviewed-on: https://dart-review.googlesource.com/26340
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-05 18:22:02 +00:00
Konstantin Shcheglov
6bb1d1a93e
Set AdjacentStrings type to String.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I5a2fa448a2e38946bb9310e4240fbe996efb3adc
Reviewed-on: https://dart-review.googlesource.com/26140
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-05 16:20:52 +00:00
Konstantin Shcheglov
ca4b1fcdc3
Use offsets to distinguish StaticGet and PropertyGet for Analyzer's PrefixedIdentifier.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I458facf24099d25a1a0d3632acf1ee562930cec5
Reviewed-on: https://dart-review.googlesource.com/26080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-12-05 01:49:34 +00:00