dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

204 Commits

Author SHA1 Message Date
Peter von der Ahé 9137fe26ac Remove deprecated_problems.dart 
Change-Id: I5f6cad8077b9faaf2164dd0f3f1f5d54c59ed0b7
Reviewed-on: https://dart-review.googlesource.com/c/78203
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-16 08:02:49 +00:00
Peter von der Ahé ed7be67cab Remove CompilerOptions.onProblem 
Change-Id: Ie143024ff13725f3a0db83d8fc95eecc189af905
Reviewed-on: https://dart-review.googlesource.com/c/78202
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-16 08:02:49 +00:00
Peter von der Ahé d4fac1684c Remove CompilerOptions.reportMessages 
Change-Id: I6b3e2f44ef89ba6a234fab97e08f56a69247d13f
Reviewed-on: https://dart-review.googlesource.com/c/77081
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-16 05:50:05 +00:00
Peter von der Ahé 54ef78b7c5 Remove non-strong vm dill files from SDK 
Change-Id: Ia9337ec090333902ea8fc2492f2ffdac1bcff2d1
Reviewed-on: https://dart-review.googlesource.com/c/79520
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-12 12:42:57 +00:00
Peter von der Ahé 244e6c7ffc Infer package URIs 
Closes https://github.com/dart-lang/sdk/issues/33076

Change-Id: I73db84eadaf3ba723c2f1323f9b883077a4df9df
Reviewed-on: https://dart-review.googlesource.com/c/78246
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-11 17:41:50 +00:00
Peter von der Ahé 8c872e0e3a Remove TargetFlags.strongMode 
Change-Id: Ibf8661e5444d16666c54f1d81c626893b000521a
Reviewed-on: https://dart-review.googlesource.com/c/78986
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:11:41 +00:00
Peter von der Ahé ee97806084 Replace strongMode with legacyMode in CompilerOptions 
Also, remove --strong and --strong-mode flags (use --legacy-mode
flag to enable legacy mode).

Change-Id: I577ab5f755a2bee88f0f4d63915a6e852e792f06
Reviewed-on: https://dart-review.googlesource.com/c/79000
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:04:26 +00:00
Daniel Hillerström 71eaf3209b Fix broken 'fasta testing sdk'. 
This CL fixes some bugs and regressions in the 'fasta testing sdk' tool:

  * Plugs the excessive memory leak in suite.dart (thanks to jensj
    for helping tracking it down)
  * Fixes the signature of MultitestTransformer.bind such that it no
    longer causes a type error to happen at runtime.
  * Removes the code that disallows test name "none".
  * Updates the exclude list in testing.json

Change-Id: Ie850139c2228550c9847883d4fdaed839a052200
Reviewed-on: https://dart-review.googlesource.com/76840
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
 2018-09-27 13:08:47 +00:00
Peter von der Ahé 3831da8743 Include all problems in expectations 
Change-Id: Ib9426243ae851bdf529f11d0d9b47c75679972fa
Reviewed-on: https://dart-review.googlesource.com/74760
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-19 08:34:43 +00:00
Peter von der Ahé 6fe272314d Tweak parameters of ProcessedOptions 
Change-Id: Id7aa47d9119da3ab21a1130253b4735c160a2459
Reviewed-on: https://dart-review.googlesource.com/74740
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-19 08:13:45 +00:00
Peter von der Ahé 65f56bba66 Clean up imports 
Change-Id: Ia6feab43ef4d932b07a47419bc01eacf8a6b59a6
Reviewed-on: https://dart-review.googlesource.com/74722
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-13 10:10:46 +00:00
Vyacheslav Egorov aa8145a03d [vm/kernel] Add a transformation that annotates invocations with receiver type. 
Currently we only annotate those call-sites that would result
in generic covariant checks performed on the callee side.

Bug: https://github.com/dart-lang/sdk/issues/31798
Change-Id: Ifcf60032036575f615015d716276484a7c1236b3
Reviewed-on: https://dart-review.googlesource.com/69580
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-08-16 12:30:56 +00:00
Vyacheslav Egorov bde6bbca96 [kernel] Move VmTarget and FlutterTarget to package:vm 
Similar to how dart2js keeps its own target in package compiler.

This allows VmTarget to use package vm specific transformations and metadata.

Change-Id: I41dd2ae241b828224fb2c9a51e6ad5073b6fdea8
Reviewed-on: https://dart-review.googlesource.com/69160
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-08-10 12:55:57 +00:00
Peter von der Ahé 1c6ae7742c Remove deprecated_toMessage 
Change-Id: I8d55dd3f4800e503dc04715aed459287d2573f6d
Reviewed-on: https://dart-review.googlesource.com/63140
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-07-02 13:38:43 +00:00
Peter von der Ahé 032925c4ff Remove obsolete features 
Remove tree-shaker as we're not using it, and it creates problems
when the SDK changes.

Remove scopes from AstBuilder as we will be phasing out AstBuilder
in favor of using BodyBuilder and the Forest API.

Change-Id: I51950c5d8bfb0493587336325f9da8f5bf8ecea6
Reviewed-on: https://dart-review.googlesource.com/57261
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-31 07:24:54 +00:00
Kevin Millikin 2d46ebd6a5 Fix Dart 2 runtime errors in the front end 
Fix all the Dart 2 runtime errors revealed by compiling dart2js, the
front end itself, the front end tests.

Change-Id: Ic6e6dd9f85db845b6a351ebbcfea9a6045843fc2
Reviewed-on: https://dart-review.googlesource.com/56322
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-24 10:14:20 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code. 
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-16 16:11:57 +00:00
danrubel 072bd1c88e Remove KernelLibraryBuilder proxies 
Change-Id: Ib2326bc4700e5063c2885664389a5310d672fbea
Reviewed-on: https://dart-review.googlesource.com/50780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-04-11 18:12:36 +00:00
Peter von der Ahé e5c84938f2 Update names derived from Program 
Change-Id: Ifdb072506fef909ccf5ad2e5270b1976ae61e3cc
Reviewed-on: https://dart-review.googlesource.com/31143
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-16 09:33:07 +00:00
Peter von der Ahé 4f2bdff90b Rename Program to Component 
Change-Id: I1a3cc03fba9783807fa637a9d42fdbad68ee7686
Reviewed-on: https://dart-review.googlesource.com/31040
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-15 12:22:23 +00:00
Samir Jindel 4289a9967b Check expected outputs of transforms. 
Change-Id: I56ff4d4391b7a22d709dc60b696646895928e34c
Reviewed-on: https://dart-review.googlesource.com/46100
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-03-15 12:11:13 +00:00
Martin Kustermann 846d18414c Use platform.dill for more fasta tests, skip shaker test 
Issue https://github.com/dart-lang/sdk/issues/32530
Issue https://github.com/dart-lang/sdk/issues/32531

Change-Id: Ie31a9e4d82fb942e48aa9a9c89c45eefb132702f
Reviewed-on: https://dart-review.googlesource.com/46520
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-14 16:27:37 +00:00
Kevin Millikin be30b62e3d Remove the Kernel type inference listener 
We have decided to move to a different API for Fasta/Analyzer
integration, one that doesn't involve compiling to Kernel or observing
type inference.  The listener API will become broken, so let's just
remove it before that happens.

We lose the ability to trace type inference so let's restore that
ability next.  The analyzer's resolution storer is not used, but that
code has been left.  The resolution applier will no longer work
without the resolution storer, so those tests have been disabled.

Change-Id: If9ac5aba2d5de7788d8a65f7fa8410599e636d21
Reviewed-on: https://dart-review.googlesource.com/42400
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-02-21 16:28:07 +00:00
Dan Rubel e1e7ab1c3d Fasta parser cleanup 
This separates and cleans up externally called fasta parser methods
such as parseTopLevelMember and parseMember from internal callers.

* Split external and internal calls to parseTopLevelMember
    so that external callers use parseTopLevelMember
    and internal callers use parseTopLevelMemberImpl.

* Rename the externally called parseMember --> parseClassMember
    and the internally called parseClassMember --> parseClassMemberImpl

* Revise the insertSyntheticIdentifier method and cleanup some
    exiting recovery code to use it.

Change-Id: Ic66ddcbbe761937bb917c679590fc7de2fdd0396
Reviewed-on: https://dart-review.googlesource.com/39080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-02-06 16:34:43 +00:00
Siva Chandra 71dba8a0e5 Link the platform kernel with the command line dart executable. 
Change-Id: Ib376a259e2e9ff9b487820c041d6795f8f7192d1
Reviewed-on: https://dart-review.googlesource.com/37420
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
 2018-02-01 15:11:29 +00:00
Peter von der Ahé 4d1adf42d3 Deprecate IncrementalClassHierarchy 
See https://github.com/dart-lang/sdk/issues/31842

Change-Id: I019909831a91a4e06138dc3a6bf32f766bca1ae6
Reviewed-on: https://dart-review.googlesource.com/34880
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-17 13:30:17 +00:00
Peter von der Ahé 1bca76d012 Convert Platform.resolvedExecutable to URI correctly 
Change-Id: I583b98277b1c62328885c775fcb712823c9ff405
Reviewed-on: https://dart-review.googlesource.com/34860
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-01-16 14:24:52 +00:00
Aske Simon Christensen 9bdcc40f69 Rename PhysicalFileSystem to StandardFileSystem. 
Preparation for data URI support. For clarity, this is just a rename.

Change-Id: Ibbd8da05d1a7106b5ec7c0ea9c1e13a95a89d1bd
Reviewed-on: https://dart-review.googlesource.com/33460
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-11 11:23:25 +00:00
Dmitry Stefantsov d16eeb5eb8 Use --reify-generic-functions when running strong-mode tests with fasta 
Change-Id: Ie16f8a8339c5b646d714e7656df4fceb5ff2a500
Reviewed-on: https://dart-review.googlesource.com/32601
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-01-05 16:15:48 +00:00
Konstantin Shcheglov f57a0511a4 Apply import prefixes in type annotations. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I185b9860aac8650856c8c13b6784b63f3fe2f379
Reviewed-on: https://dart-review.googlesource.com/32000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-01-02 22:34:04 +00:00
Brian Wilkerson 032cc33fd5 Rename parseAsyncModifier to parseAsyncModifierOpt 
Change-Id: I1cc4ad97566bcaeebf16be65ba1e8972a526daef
Reviewed-on: https://dart-review.googlesource.com/30468
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-19 20:22:54 +00:00
Konstantin Shcheglov 353e0bdefc Apply resolution to formals in AstBuilder tests. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I28a045d1e8640a2a447fae6e9f35bfb6db76790a
Reviewed-on: https://dart-review.googlesource.com/28542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-12 17:42:51 +00:00
Konstantin Shcheglov 5c580dbe21 Remember explicit static get/assign Class and offset. 
Revert merging ResolutionApplier with ValidatingResolutionApplier.

Bug:
Change-Id: Ie55ebdcb5d63be26720156a28a68f2727ebc96d3
Reviewed-on: https://dart-review.googlesource.com/28380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-11 21:46:13 +00:00
Konstantin Shcheglov 94907f1aea Apply resolution to FunctionExpression. 
Bug:
Change-Id: Iaa8c4b31800fdb9d5a4613417a6076c3af683c6a
Reviewed-on: https://dart-review.googlesource.com/26721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-06 20:41:40 +00:00
Konstantin Shcheglov 6bb1d1a93e Set AdjacentStrings type to String. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I5a2fa448a2e38946bb9310e4240fbe996efb3adc
Reviewed-on: https://dart-review.googlesource.com/26140
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-05 16:20:52 +00:00
Konstantin Shcheglov ca4b1fcdc3 Use offsets to distinguish StaticGet and PropertyGet for Analyzer's PrefixedIdentifier. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I458facf24099d25a1a0d3632acf1ee562930cec5
Reviewed-on: https://dart-review.googlesource.com/26080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-12-05 01:49:34 +00:00
Peter von der Ahé e14726a3f4 Use absolute URIs instead of relative paths 
We change the type of FileUriNode.fileUri from String to Uri, which in principle
doesn't change the binary format. However, we did notice that LibraryParts
weren't serialized as specified in binary.md, so we also fixed that.

Since fileUris are stored as strings in a separate table, Uri.parse is only called
once per unique URI.

Fasta only uses relativizeUri when printing diagnostics, and URIs stored in
expectation files (golden files) are relativized using String.replaceAll.

Change-Id: Ib2dc1b80c03a0cdaf84e48b8b3ba73b16bdf8a40
Reviewed-on: https://dart-review.googlesource.com/25421
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-12-04 11:34:24 +00:00
Konstantin Shcheglov 21277a4df8 Apply resolution to 'this' and 'super'. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I905ea53aa1c39d789824e8c7061135a41b8f8cac
Reviewed-on: https://dart-review.googlesource.com/25663
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-03 00:13:42 +00:00
Konstantin Shcheglov e16df981c9 When applying types, treat UndefinedType as having required number of UndefinedType arguments. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Id2428967928a823cb55dcc4348b994af5c6674bf
Reviewed-on: https://dart-review.googlesource.com/25502
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-01 19:10:17 +00:00
Konstantin Shcheglov 22f5ce415d Translate types during ResolutionApplier. 
This allows us update enclosing ExecutableElement as we enter/exit
local functions, and successfully translate references to type
parameters.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I184123212b816740a586beee98796c28beadf6b2
Reviewed-on: https://dart-review.googlesource.com/25220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-12-01 16:58:47 +00:00
Jens Johansen 22d0696d91 [CFE] Move front-end API under src/ 
This CL deprecates the front-end API and moves it into src/api_prototype.

For now all usages have been updated to point to the new location,
but they should be updated to use custom-client invocations instead (e.g.
one specific way for DDC, another for dart2js etc.)

Bug:
Change-Id: I9b4f41f6ebf55d42510fd35240d942d1dc7292d6
Reviewed-on: https://dart-review.googlesource.com/24822
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-12-01 08:42:16 +00:00
Brian Wilkerson 20c9565b3d Recover from a missing function body 
Change-Id: Ie9091f856fdff2e2fceaa34cd29ce787f092b6e0
Reviewed-on: https://dart-review.googlesource.com/24160
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-28 19:11:44 +00:00
Konstantin Shcheglov ad7bc62921 Store and apply elements for SimpleIdentifier. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ie5f7a5b963dab8a731b9c60ae3a9440ef09b68f0
Reviewed-on: https://dart-review.googlesource.com/22902
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 17:36:39 +00:00
Brian Wilkerson 96ba131d30 Enhance ResolutionApplier to allow elements to be applied 
Change-Id: I7006000bb72592866edd641b8b614fe73c8f18c2
Reviewed-on: https://dart-review.googlesource.com/22820
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 00:02:57 +00:00
Peter von der Ahé a689397a36 Revert "Implement support for generic comment syntax in Fasta." 
This reverts commit f1959d6cd4.

Reason for revert: insufficient approval.

Original change's description:
> Implement support for generic comment syntax in Fasta.
> 
> Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
> Reviewed-on: https://dart-review.googlesource.com/21223
> Commit-Queue: Paul Berry <paulberry@google.com>
> Reviewed-by: Dan Rubel <danrubel@google.com>

TBR=paulberry@google.com,danrubel@google.com,sigmund@google.com

Change-Id: I047e4e87913002c6bd77e455599189349c123146
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/22460
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-21 10:08:39 +00:00
Paul Berry f1959d6cd4 Implement support for generic comment syntax in Fasta. 
Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
Reviewed-on: https://dart-review.googlesource.com/21223
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-20 22:01:27 +00:00
Brian Wilkerson 8556269166 Convert some of the methods used to parse function bodies 
Change-Id: Ia8addbbc057768dac83695d7c8e2a7de98c86ebb
Reviewed-on: https://dart-review.googlesource.com/21482
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 20:37:12 +00:00
Brian Wilkerson 9f730ecbc8 Return the last consumed token from seven methods 
Change-Id: I53ad977e3c68ea9ed583fd89cc798ab75b9d0b0f
Reviewed-on: https://dart-review.googlesource.com/20120
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-10 16:55:08 +00:00
Brian Wilkerson cebb86e3ce Convert some methods used to parse formal parameters 
Change-Id: I1d6542f069a2818ea7253997a4d5c0944e12ce6f
Reviewed-on: https://dart-review.googlesource.com/19420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-08 23:21:41 +00:00
Brian Wilkerson 0a66494841 Convert parseTopLevelMember and parseClassMember 
Change-Id: Iab8109a48866e12c2a3a11c62fc7e340b0b8862e
Reviewed-on: https://dart-review.googlesource.com/19022
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-07 21:29:41 +00:00