6 Commits

Author	SHA1	Message	Date
Jens Johansen	5b76fc2172	[parser] Better recovery of methods/fields called 'const', 'final', 'var' or 'void' ... Change-Id: I370089a6de8c585a60785fe069de5da869ae23f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145820 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>	2020-05-06 11:56:24 +00:00
Jens Johansen	3969356f1a	[parser] Parse bangs before type parameters correctly ... Change-Id: Ie05e57d12cdbdeac037785ef6b94497c77d264ae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137789 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>	2020-03-02 11:21:40 +00:00
Jens Johansen	3660b9ecc7	[parser] New syntax for null aware index (2nd try) ... This reverts commit bc4893a3b3. The previous attempt failed because when we check if something is a conditional expression we used a rewriter that didn't actually rewrite. This further down the line (still checking if we can parse the expression) results in errors occurring (that wouldn't have occurred if the rewrite had happened) and the conclusion was thus that it wasn't a conditional expression and we parsed it as a null-aware index operator (which gave errors because it wasn't). This 2nd try solves it by having a rewriter that actually rewrites, but then allows to undo the rewrites after we're done parsing. Change-Id: Ide3c0d6a870d4dc18b6d9475b0227d93c733dc7f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136624 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>	2020-02-26 13:31:52 +00:00
Jens Johansen	bc4893a3b3	Revert "[parser] New syntax for null aware index" ... This reverts commit cf4e044e07. Reason for revert: Breaks internal customer. Original change's description: > [parser] New syntax for null aware index > > Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903 > Commit-Queue: Jens Johansen <jensj@google.com> > Reviewed-by: Johnni Winther <johnniwinther@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> TBR=brianwilkerson@google.com,jensj@google.com,johnniwinther@google.com Change-Id: Ic0ff607c944e489f29bda7da37afd63c62d368eb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136600 Reviewed-by: Jens Johansen <jensj@google.com> Commit-Queue: Jens Johansen <jensj@google.com>	2020-02-20 14:11:08 +00:00
Jens Johansen	cf4e044e07	[parser] New syntax for null aware index ... Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>	2020-02-20 12:33:28 +00:00
Johnni Winther	f521734ce7	[cfe] Handle setter import conflicts ... Fixes the underlying problem for the crash reported in https://github.com/flutter/flutter/issues/46823 Change-Id: I392c7bae3679cae52b694f3bd08b0b700ee9c56f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128540 Reviewed-by: Jens Johansen <jensj@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>	2019-12-16 12:02:47 +00:00